coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60566 ) Change subject: soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I42076d361045c224b99e111e34de7539420b8a52 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60566 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/apollolake/acpi/gpiolib.asl 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index eb46df5..89f647e 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -60,8 +60,7 @@ Store (0, Local1) Or( Or (ShiftLeft (Arg0, 16), CONFIG_PCR_BASE_ADDRESS), Local1, Local1) - Or(PAD_CFG_BASE + Multiply (Arg1, Multiply ( - GPIO_NUM_PAD_CFG_REGS, 4)), Local1, Local1) + Or(PAD_CFG_BASE + Arg1 * GPIO_NUM_PAD_CFG_REGS * 4, Local1, Local1) Return (Local1) } @@ -69,7 +68,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Local1 = HOSTSW_OWN_REG_0 + Multiply (Divide (Arg0, 32), 4) + Local1 = HOSTSW_OWN_REG_0 + Divide (Arg0, 32) * 4 Return (Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42076d361045c224b99e111e34de7539420b8a52 Gerrit-Change-Number: 60566 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60565 ) Change subject: soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I6dc9f57773754e89df4b4ffd088a4693af0452e3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60565 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index 3249954..265bcfb 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -92,7 +92,7 @@ } Store (PCRB (Local0), Local2) Local2 += PAD_CFG_BASE - Return (Local2 + Multiply (Local1, 16)) + Return (Local2 + Local1 * 16) } /* diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index 9122e65..f60fd56 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -92,5 +92,5 @@ } Store (PCRB (Local0), Local2) Local2 += PAD_CFG_BASE - Return (Local2 + Multiply (Local1, 16)) + Return (Local2 + Local1 * 16) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dc9f57773754e89df4b4ffd088a4693af0452e3 Gerrit-Change-Number: 60565 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60564 ) Change subject: drivers/intel/gma/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: Idd77fa995e1edab86c509a88a1ba16d636c60b30 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60564 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index c168d63..564f182 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -53,7 +53,7 @@ /* Always keep BCLP up to date, even if driver is not ready. It requires a full 8-bit brightness value. 255 = 100% */ - Store (Divide (Multiply (Arg0, 255), 100), Local1) + Store (Divide (Arg0 * 255, 100), Local1) If (LGreater(Local1, 255)) { Store (255, Local1) } @@ -105,7 +105,7 @@ Method (XBCM, 1, NotSerialized) { - Store (DRCL (Multiply (Arg0, BCLM), 100), BCLV) + Store (DRCL (Arg0 * BCLM, 100), BCLV) } /* Find value closest to BCLV in BRIG (which must be ordered) */ @@ -117,7 +117,7 @@ Return (Zero) } /* Local0: current percentage */ - Store (DRCL (Multiply (BCLV, 100), BCLM), Local0) + Store (DRCL (BCLV * 100, BCLM), Local0) /* Local1: loop index (selectable values start at 2 in BRIG) */ Store (2, Local1) -- To view, visit https://review.coreboot.org/c/coreboot/+/60564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd77fa995e1edab86c509a88a1ba16d636c60b30 Gerrit-Change-Number: 60564 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/apple/acpi: Replace Index() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60563 ) Change subject: ec/apple/acpi: Replace Index() with ASL 2.0 syntax ...................................................................... ec/apple/acpi: Replace Index() with ASL 2.0 syntax Replace `Index (FOO, 0)` with `FOO[0]`. Change-Id: I7b73e490e0a88a3693d7eaaf0fa37d0ea75b2529 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60563 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/apple/acpi/battery.asl 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/apple/acpi/battery.asl b/src/ec/apple/acpi/battery.asl index 291451f..6d4ab57 100644 --- a/src/ec/apple/acpi/battery.asl +++ b/src/ec/apple/acpi/battery.asl @@ -91,13 +91,13 @@ Method(_BIF, 0, NotSerialized) { - Index(BATS, 0x01) = ^^SBRW(0x0B, 0x18) * 10 - Index(BATS, 0x02) = ^^SBRW(0x0B, 0x10) * 10 + BATS[1] = ^^SBRW(0x0B, 0x18) * 10 + BATS[2] = ^^SBRW(0x0B, 0x10) * 10 - Index(BATS, 0x04) = ^^SBRW(0x0B, 0x19) - Index(BATS, 0x09) = ^^SBRB(0x0B, 0x21) - Index(BATS, 0x0B) = ^^SBRB(0x0B, 0x22) - Index(BATS, 0x0C) = ^^SBRB(0x0B, 0x20) + BATS[4] = ^^SBRW(0x0B, 0x19) + BATS[9] = ^^SBRB(0x0B, 0x21) + BATS[11] = ^^SBRB(0x0B, 0x22) + BATS[12] = ^^SBRB(0x0B, 0x20) Return(BATS) } @@ -124,7 +124,7 @@ } Local1 = ^^SBRW(0x0B, 0x09) - Index(BATI, 0x03) = Local1 + BATI[3] = Local1 Local0 = ^^SBRW(0x0B, 0x0A) /* Sign-extend Local0. */ @@ -136,16 +136,16 @@ } Local0 *= Local1 - Index(BATI, 1) = Local0 / 1000 - Index(BATI, 2) = ^^SBRW(0x0B, 0x0F) * 10 + BATI[1] = Local0 / 1000 + BATI[2] = ^^SBRW(0x0B, 0x0F) * 10 If (HPAC) { If (!(^^SBRW(0x0B, 0x16) & 0x40)) { - Index(BATI, 0) = 2 + BATI[0] = 2 } Else { - Index(BATI, 0) = 0 + BATI[0] = 0 } } Else { - Index(BATI, 0) = 1 + BATI[0] = 1 } Return(BATI) -- To view, visit https://review.coreboot.org/c/coreboot/+/60563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b73e490e0a88a3693d7eaaf0fa37d0ea75b2529 Gerrit-Change-Number: 60563 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Index() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60562 ) Change subject: arch/x86/acpi: Replace Index() with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace Index() with ASL 2.0 syntax Replace `Index (FOO, 0)` with `FOO[0]`. Change-Id: Ief0f855a449d67542d6b1b56a2b76919c4cb8e2c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60562 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/x86/acpi/globutil.asl 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index 25feaea..3a7144d 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -41,8 +41,8 @@ Store(MIN(Local5, Local6), Local7) While(LLess(Local4, Local7)) { - Store(Derefof(Index(Local0, Local4)), Local2) - Store(Derefof(Index(Local1, Local4)), Local3) + Store(Derefof(Local0[Local4]), Local2) + Store(Derefof(Local1[Local4]), Local3) if (LGreater(Local2, Local3)) { Return(One) } else { @@ -78,8 +78,8 @@ Store(SLEN(Arg1), Local3) While(LLess(Local2, Local3)) { - if (LNotEqual(Derefof(Index(Local0, Local2)), - Derefof(Index(Local1, Local2)))) { + if (LNotEqual(Derefof(Local0[Local2]), + Derefof(Local1[Local2]))) { Return(0) } Increment(Local2) -- To view, visit https://review.coreboot.org/c/coreboot/+/60562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief0f855a449d67542d6b1b56a2b76919c4cb8e2c Gerrit-Change-Number: 60562 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Index() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60561 ) Change subject: ec/starlabs/merlin/acpi: Replace Index() with ASL 2.0 syntax ...................................................................... ec/starlabs/merlin/acpi: Replace Index() with ASL 2.0 syntax Replace `Index (FOO, 0)` with `FOO[0]`. Change-Id: I88cb974ed808b602a9398c9c3e363cb145420528 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60561 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/starlabs/merlin/acpi/hid.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/starlabs/merlin/acpi/hid.asl b/src/ec/starlabs/merlin/acpi/hid.asl index 1d2b226..5449807 100644 --- a/src/ec/starlabs/merlin/acpi/hid.asl +++ b/src/ec/starlabs/merlin/acpi/hid.asl @@ -303,7 +303,7 @@ // Case (0x03) { - HDSM (DeRefOf(Index(Arg3, 0x00))) + HDSM (DeRefOf(Arg3[0])) } // // Function 4, HDEM. HID Driver Event Method. @@ -332,7 +332,7 @@ // Case (0x06) { - BTNE (DeRefOf(Index(Arg3, 0x00))) + BTNE (DeRefOf(Arg3[0])) } // // Function 7 HEBC. Button implemented state. -- To view, visit https://review.coreboot.org/c/coreboot/+/60561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88cb974ed808b602a9398c9c3e363cb145420528 Gerrit-Change-Number: 60561 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Replace Index() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60560 ) Change subject: mb/google/kahlee/acpi: Replace Index() with ASL 2.0 syntax ...................................................................... mb/google/kahlee/acpi: Replace Index() with ASL 2.0 syntax Replace `Index (FOO, 0)` with `FOO[0]`. Change-Id: I81a2d63db3e3575acd91ea99e1490701889b896f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60560 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl index d151e1d..7aaf478 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl @@ -30,8 +30,8 @@ /* Clear wake status structure. */ Store (0, PEWD) - Store (0, Index(WKST,0)) - Store (0, Index(WKST,1)) + Store (0, WKST[0]) + Store (0, WKST[1]) Store (7, UPWS) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81a2d63db3e3575acd91ea99e1490701889b896f Gerrit-Change-Number: 60560 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
by Angel Pons (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 ) Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/60402/comment/4cad9c19_1d759f71 PS6, Line 12: if (phase == AFTER_PCI_ENUM && CONFIG(SKIP_FSP_NOTIFY_PHASE_AFTER_PCI_ENUM)) : return false; : else if (phase == READY_TO_BOOT && CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT)) : return false; : else if (phase == END_OF_FIRMWARE && CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE)) : return false; : else : return true; Idea: Use a switch statement? switch (phase) { case AFTER_PCI_ENUM: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_AFTER_PCI_ENUM); case READY_TO_BOOT: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT); case END_OF_FIRMWARE: return !CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE); default: return true; } https://review.coreboot.org/c/coreboot/+/60402/comment/28f7aaf5_fac8f1fe PS6, Line 41: timestamp_add_now(TS_FSP_BEFORE_ENUMERATE); : post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); Maybe we could have a struct to store the per-phase information. I'll try to do something. -- To view, visit https://review.coreboot.org/c/coreboot/+/60402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64 Gerrit-Change-Number: 60402 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 13:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Implement HECI notify
by Angel Pons (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Arthur Heymans, Felix Singer, Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Implement HECI notify ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/60405/comment/7dc267f9_0632c406 PS7, Line 279: HeciEnabled > CB:47195 drops HeciEnabled from CNL looks like. Ah, the HECI device can be enabled and initialised in coreboot, but hidden before booting an OS. So, if I understand correctly, there are multiple cases: 1. HECI device disabled: I think this happens when CSE is in an abnormal state (e.g. because of some error or because it has been disabled). This situation should be detected at runtime and dealt with accordingly. 2. HECI device enabled, and left visible: This is the simplest thing to do when the CSE is running normally, but I'm not sure if there are any drawbacks. I know Windows Device Manager shows a "yellow bang" for the HECI device when its drivers aren't installed, but it's not a serious problem. 3. HECI device enabled, but hidden before booting an OS: I think this is to avoid the Windows Device Manager "yellow bang" thing when the drivers aren't installed, and I think it also saves a bit of power by keeping the HECI device in D0i3. Other than that, I'm not sure if there are any other reasons to do this. Case 1 would be handled as part of the CSE error handling flows, so we don't need to worry about it in this commit. Cases 2 and 3 are with CSE running normally. This makes me wonder: are there any reasons to prefer case 2 over case 3, or viceversa? If so, which ones? If there's no (mainboard-specific) reason for a particular mainboard to require either case 2 or case 3, I was thinking of having a user-configurable Kconfig option to control hiding the HECI device. This still allows mainboards to override the default setting, and also allows non-mainboard code to do so. For instance, if Chrome OS needs case 3, one would only need to override the default once with `if CHROMEOS` or similar. Thoughts? -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 13:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi: Remove unused <acpi/acpi.h>
by HAOUAS Elyes (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60635 ) Change subject: src/acpi: Remove unused <acpi/acpi.h> ...................................................................... src/acpi: Remove unused <acpi/acpi.h> Change-Id: I1684e6386da9db0ff41e78078f7d72c1fb4a499e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/acpi/acpigen_ps2_keybd.c M src/acpi/acpigen_usb.c M src/acpi/sata.c 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/60635/1 diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index c65790d..a3ea4ef 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpigen_ps2_keybd.h> #include <console/console.h> diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 2868fee..e32dfc4 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpi_pld.h> #include <acpi/acpigen.h> diff --git a/src/acpi/sata.c b/src/acpi/sata.c index 04676a6..282d366 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpi_sata.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1684e6386da9db0ff41e78078f7d72c1fb4a499e Gerrit-Change-Number: 60635 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022