Attention is currently required from: Felix Singer, Elyes HAOUAS, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60622 )
Change subject: soc/intel/common: Remove unnecessary new lines throughout the crashlog.c
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60622/comment/d9326ae0_d4330927
PS1, Line 7: soc/intel/common: Remove unnecessary new lines throughout the crashlog.c
How about:
soc/intel/common/blk/crashlog: Drop some new lines
Remove unnecessary new lines in crashlog code.
Also, happy new year! 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/60622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0920f563d6fdf9414eab86796cedcac83173dba3
Gerrit-Change-Number: 60622
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Elyes HAOUAS
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 01 Jan 2022 11:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60540 )
Change subject: util: Allow overriding install options
......................................................................
Patch Set 1:
(1 comment)
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/60540/comment/0d0219af_c393b501
PS1, Line 8: PREFIX ?= /usr/local
Actually that is a GNU extension, and not really needed [1], as it can be overridden by:
make PREFIX=/usr
or
PREFIX=/usr make -e
[1]: https://lists.suckless.org/dev/2112/index.html#msg34568
--
To view, visit https://review.coreboot.org/c/coreboot/+/60540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c
Gerrit-Change-Number: 60540
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Sat, 01 Jan 2022 09:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment