coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6714 discussions

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace LAnd() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60574 ) Change subject: mb/aopen/dxplplusu/acpi: Replace LAnd() with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace LAnd() with ASL 2.0 syntax Replace `LAnd (a, b)` with `a && b`. Change-Id: Ifbd7b282061b27cda9d5d4c17e2ade9459e72c24 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60574 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/aopen/dxplplusu/acpi/i82801db.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl index 20400c3..9b16070 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/i82801db.asl @@ -113,7 +113,7 @@ CreateByteField (MSBF, \_SB_.PCI0.ICH0.PMIO._LEN, IOAL) Store (PBAR, Local0) - If ( Land(Local0, 0x01) ) + If (Local0 && 1) { And (Local0, 0xFFFE, Local0) Store (Local0, IOA1) @@ -128,7 +128,7 @@ CreateByteField (MSBF, \_SB_.PCI0.ICH0.GPIO._LEN, IOSL) Store (GBAR, Local0) - If ( Land(Local0, 0x01) ) { + If (Local0 && 1) { And (Local0, 0xFFFE, Local0) Store (Local0, IOS1) Store (Local0, IOS2) -- To view, visit https://review.coreboot.org/c/coreboot/+/60574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbd7b282061b27cda9d5d4c17e2ade9459e72c24 Gerrit-Change-Number: 60574 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: superio/winbond/w83627hf/acpi: Replace LAnd() with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60573 ) Change subject: superio/winbond/w83627hf/acpi: Replace LAnd() with ASL 2.0 syntax ...................................................................... superio/winbond/w83627hf/acpi: Replace LAnd() with ASL 2.0 syntax Replace `LAnd (a, b)` with `a && b`. Change-Id: I66aedbab79d6b0d8e727d19b86458789a09889a8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60573 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/superio/winbond/w83627hf/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 5db7ca8..f53872e 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -1166,7 +1166,7 @@ { Store (0x00, Local0) ENTER_CONFIG_MODE (5) - If (LAnd(ACTR, IRQ1) ) { + If (ACTR && IRQ1) { Store (0x0F, Local0) } ElseIf (Lor(LOr (IO1H, IO1L), LOr (IO2H, IO2L))) -- To view, visit https://review.coreboot.org/c/coreboot/+/60573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66aedbab79d6b0d8e727d19b86458789a09889a8 Gerrit-Change-Number: 60573 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Divide(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60571 ) Change subject: drivers/intel/gma/acpi: Replace Divide(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Divide(a,b) with ASL 2.0 syntax Replace `Divide (a, b)` with `a / b`. Change-Id: Icfae760441560e1aa51383d04a3898412ba1be04 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60571 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 564f182..e273b22 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -53,7 +53,7 @@ /* Always keep BCLP up to date, even if driver is not ready. It requires a full 8-bit brightness value. 255 = 100% */ - Store (Divide (Arg0 * 255, 100), Local1) + Store (Arg0 * 255 / 100, Local1) If (LGreater(Local1, 255)) { Store (255, Local1) } @@ -100,7 +100,7 @@ /* Divide round closest */ Method (DRCL, 2) { - Return (Divide (Arg0 + Divide (Arg1, 2), Arg1)) + Return ((Arg0 + Arg1 / 2) / Arg1) } Method (XBCM, 1, NotSerialized) -- To view, visit https://review.coreboot.org/c/coreboot/+/60571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icfae760441560e1aa51383d04a3898412ba1be04 Gerrit-Change-Number: 60571 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/kontron/it8516e/acpi: Replace Divide(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60570 ) Change subject: ec/kontron/it8516e/acpi: Replace Divide(a,b) with ASL 2.0 syntax ...................................................................... ec/kontron/it8516e/acpi: Replace Divide(a,b) with ASL 2.0 syntax Replace `Divide (a, b)` with `a / b`. Change-Id: Ic705dce7303b6bcd1c679a1ae7c81e0809fefa5b Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60570 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/kontron/it8516e/acpi/pm_channels.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/kontron/it8516e/acpi/pm_channels.asl b/src/ec/kontron/it8516e/acpi/pm_channels.asl index b130026..0ac0467 100644 --- a/src/ec/kontron/it8516e/acpi/pm_channels.asl +++ b/src/ec/kontron/it8516e/acpi/pm_channels.asl @@ -91,7 +91,7 @@ Release (EC_MUTEX) Or (ShiftLeft (Local1, 8), Local0, Local0) - Store (Divide (Local0 * 10, 64), Local0) /* Convert to 10th °C */ + Store (Local0 * 10 / 64, Local0) /* Convert to 10th °C */ Return (Local0 + 2732) /* Return as 10th Kelvin */ } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic705dce7303b6bcd1c679a1ae7c81e0809fefa5b Gerrit-Change-Number: 60570 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Divide(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60569 ) Change subject: soc/intel/apollolake/acpi: Replace Divide(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Divide(a,b) with ASL 2.0 syntax Replace `Divide (a, b)` with `a / b`. Change-Id: Ifb377f0abb50a736aa3aa53a11d45bee65488c4c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60569 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/apollolake/acpi/gpiolib.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index 89f647e..31599f2 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -68,7 +68,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Local1 = HOSTSW_OWN_REG_0 + Divide (Arg0, 32) * 4 + Local1 = HOSTSW_OWN_REG_0 + Arg0 / 32 * 4 Return (Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb377f0abb50a736aa3aa53a11d45bee65488c4c Gerrit-Change-Number: 60569 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60572 ) Change subject: ec/google/chromeec/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I75c68c733b192a8e86643f5a5f3451d010e69023 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60572 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 663cc25..3416633 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -78,11 +78,11 @@ Store (Local0, Arg1[1]) // Design Capacity of Warning - Divide (Multiply (Local0, DWRN), 100, , Local2) + Divide (Local0 * DWRN, 100, , Local2) Store (Local2, Arg1[5]) // Design Capacity of Low - Divide (Multiply (Local0, DLOW), 100, , Local2) + Divide (Local0 * DLOW, 100, , Local2) Store (Local2, Arg1[6]) // Get battery info from mainboard @@ -118,11 +118,11 @@ Store (Local0, Arg1[2]) // Design Capacity of Warning - Divide (Multiply (Local0, DWRN), 100, , Local2) + Divide (Local0 * DWRN, 100, , Local2) Store (Local2, Arg1[6]) // Design Capacity of Low - Divide (Multiply (Local0, DLOW), 100, , Local2) + Divide (Local0 * DLOW, 100, , Local2) Store (Local2, Arg1[7]) // Cycle Count -- To view, visit https://review.coreboot.org/c/coreboot/+/60572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75c68c733b192a8e86643f5a5f3451d010e69023 Gerrit-Change-Number: 60572 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/kontron/it8516e/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60568 ) Change subject: ec/kontron/it8516e/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... ec/kontron/it8516e/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: Iabddeb97c045ee211011ffe5cd947321a5fafaab Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60568 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/kontron/it8516e/acpi/pm_channels.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/kontron/it8516e/acpi/pm_channels.asl b/src/ec/kontron/it8516e/acpi/pm_channels.asl index 9217406..b130026 100644 --- a/src/ec/kontron/it8516e/acpi/pm_channels.asl +++ b/src/ec/kontron/it8516e/acpi/pm_channels.asl @@ -91,7 +91,7 @@ Release (EC_MUTEX) Or (ShiftLeft (Local1, 8), Local0, Local0) - Store (Divide (Multiply (Local0, 10), 64), Local0) /* Convert to 10th °C */ + Store (Divide (Local0 * 10, 64), Local0) /* Convert to 10th °C */ Return (Local0 + 2732) /* Return as 10th Kelvin */ } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabddeb97c045ee211011ffe5cd947321a5fafaab Gerrit-Change-Number: 60568 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/roda/rk9/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60567 ) Change subject: mb/roda/rk9/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... mb/roda/rk9/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I8697f62cf5627ace8c4eac0caec7962171bb3541 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60567 Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/roda/rk9/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/roda/rk9/acpi/thermal.asl b/src/mainboard/roda/rk9/acpi/thermal.asl index 709c912..9bf50d9 100644 --- a/src/mainboard/roda/rk9/acpi/thermal.asl +++ b/src/mainboard/roda/rk9/acpi/thermal.asl @@ -6,7 +6,7 @@ { /* degree Celsius to deci-Kelvin (ACPI temperature unit) */ Method(C2dK, 1) { - Local0 = 2732 + Multiply (Arg0, 10) + Local0 = 2732 + Arg0 * 10 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60567 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8697f62cf5627ace8c4eac0caec7962171bb3541 Gerrit-Change-Number: 60567 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60566 ) Change subject: soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I42076d361045c224b99e111e34de7539420b8a52 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60566 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/apollolake/acpi/gpiolib.asl 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index eb46df5..89f647e 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -60,8 +60,7 @@ Store (0, Local1) Or( Or (ShiftLeft (Arg0, 16), CONFIG_PCR_BASE_ADDRESS), Local1, Local1) - Or(PAD_CFG_BASE + Multiply (Arg1, Multiply ( - GPIO_NUM_PAD_CFG_REGS, 4)), Local1, Local1) + Or(PAD_CFG_BASE + Arg1 * GPIO_NUM_PAD_CFG_REGS * 4, Local1, Local1) Return (Local1) } @@ -69,7 +68,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Local1 = HOSTSW_OWN_REG_0 + Multiply (Divide (Arg0, 32), 4) + Local1 = HOSTSW_OWN_REG_0 + Divide (Arg0, 32) * 4 Return (Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42076d361045c224b99e111e34de7539420b8a52 Gerrit-Change-Number: 60566 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60565 ) Change subject: soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax Replace `Multiply (a, b)` with `a * b`. Change-Id: I6dc9f57773754e89df4b4ffd088a4693af0452e3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60565 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index 3249954..265bcfb 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -92,7 +92,7 @@ } Store (PCRB (Local0), Local2) Local2 += PAD_CFG_BASE - Return (Local2 + Multiply (Local1, 16)) + Return (Local2 + Local1 * 16) } /* diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index 9122e65..f60fd56 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -92,5 +92,5 @@ } Store (PCRB (Local0), Local2) Local2 += PAD_CFG_BASE - Return (Local2 + Multiply (Local1, 16)) + Return (Local2 + Local1 * 16) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dc9f57773754e89df4b4ffd088a4693af0452e3 Gerrit-Change-Number: 60565 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022