coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/cyan: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60362 ) Change subject: mb/google/cyan: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/cyan: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Ifcdfd9fff197391ca0da083e7f6151c2dffe3374 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60362 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/Kconfig.name 2 files changed, 33 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 4de5a61..c303266 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -19,6 +19,39 @@ select SYSTEM_TYPE_LAPTOP select USE_GOOGLE_FSP +config BOARD_GOOGLE_BANON + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_CELES + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_CYAN + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_EDGAR + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_KEFKA + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_REKS + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_RELM + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_SETZER + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_TERRA + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_ULTIMA + select BOARD_GOOGLE_BASEBOARD_CYAN + +config BOARD_GOOGLE_WIZPIG + select BOARD_GOOGLE_BASEBOARD_CYAN + if BOARD_GOOGLE_BASEBOARD_CYAN config VBOOT diff --git a/src/mainboard/google/cyan/Kconfig.name b/src/mainboard/google/cyan/Kconfig.name index 1ab8ed4..19adc08 100644 --- a/src/mainboard/google/cyan/Kconfig.name +++ b/src/mainboard/google/cyan/Kconfig.name @@ -2,44 +2,33 @@ config BOARD_GOOGLE_BANON bool "-> Banon (Acer Chromebook 15 (CB3-532))" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_CELES bool "-> Celes (Samsung Chromebook 3)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_CYAN bool "-> Cyan (Acer Chromebook R11 (C738T))" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_EDGAR bool "-> Edgar (Acer Chromebook 14 (CB3-431))" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_KEFKA bool "-> Kefka (Dell Chromebook 11 3180/3189)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_REKS bool "-> Reks (Lenovo N22/N42 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_RELM bool "-> Relm" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_SETZER bool "-> Setzer (HP Chromebook 11 G5)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_TERRA bool "-> Terra (ASUS Chromebook C202SA/C300SA/C301SA)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_ULTIMA bool "-> Ultima (Lenovo Yoga 11e G3)" - select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_WIZPIG bool "-> Wizpig" - select BOARD_GOOGLE_BASEBOARD_CYAN 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdfd9fff197391ca0da083e7f6151c2dffe3374 Gerrit-Change-Number: 60362 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/auron: Select board-specific options per board
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60360 ) Change subject: mb/google/auron: Select board-specific options per board ...................................................................... mb/google/auron: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I5c437ee2d62415f9048a24ad4a517fc33eec3cf1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60360 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/auron/Kconfig 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 10e08ae..640cf13 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -7,7 +7,6 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE - select HAVE_SPD_IN_CBFS if !BOARD_GOOGLE_BUDDY select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_CHROMEOS @@ -15,25 +14,34 @@ select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_BROADWELL - select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_BUDDY config BOARD_GOOGLE_AURON_PAINE select BOARD_GOOGLE_BASEBOARD_AURON + select HAVE_SPD_IN_CBFS + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_AURON_YUNA select BOARD_GOOGLE_BASEBOARD_AURON + select HAVE_SPD_IN_CBFS + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_BUDDY select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_GANDOF select BOARD_GOOGLE_BASEBOARD_AURON + select HAVE_SPD_IN_CBFS + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_LULU select BOARD_GOOGLE_BASEBOARD_AURON + select HAVE_SPD_IN_CBFS + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SAMUS select BOARD_GOOGLE_BASEBOARD_AURON + select HAVE_SPD_IN_CBFS + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_AURON -- To view, visit https://review.coreboot.org/c/coreboot/+/60360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c437ee2d62415f9048a24ad4a517fc33eec3cf1 Gerrit-Change-Number: 60360 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/auron: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60359 ) Change subject: mb/google/auron: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/auron: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Ic9e001721baa7b7df89204eed03375e872c93e28 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60359 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/Kconfig.name 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 82addfd..10e08ae 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -17,6 +17,24 @@ select SOC_INTEL_BROADWELL select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_BUDDY +config BOARD_GOOGLE_AURON_PAINE + select BOARD_GOOGLE_BASEBOARD_AURON + +config BOARD_GOOGLE_AURON_YUNA + select BOARD_GOOGLE_BASEBOARD_AURON + +config BOARD_GOOGLE_BUDDY + select BOARD_GOOGLE_BASEBOARD_AURON + +config BOARD_GOOGLE_GANDOF + select BOARD_GOOGLE_BASEBOARD_AURON + +config BOARD_GOOGLE_LULU + select BOARD_GOOGLE_BASEBOARD_AURON + +config BOARD_GOOGLE_SAMUS + select BOARD_GOOGLE_BASEBOARD_AURON + if BOARD_GOOGLE_BASEBOARD_AURON config VBOOT diff --git a/src/mainboard/google/auron/Kconfig.name b/src/mainboard/google/auron/Kconfig.name index 19fd4d7..4ac0368 100644 --- a/src/mainboard/google/auron/Kconfig.name +++ b/src/mainboard/google/auron/Kconfig.name @@ -2,24 +2,18 @@ config BOARD_GOOGLE_AURON_PAINE bool "-> Auron_Paine (Acer C740 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_AURON_YUNA bool "-> Auron_Yuna (Acer Chromebook 15 (C910/CB5-531))" - select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_BUDDY bool "-> Buddy (Acer Chromebase 24)" - select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_GANDOF bool "-> Gandof (Toshiba Chromebook 2 (2015))" - select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_LULU bool "-> Lulu (Dell Chromebook 13 7310)" - select BOARD_GOOGLE_BASEBOARD_AURON config BOARD_GOOGLE_SAMUS bool "-> Samus (Google Chromebook Pixel (2015))" - select BOARD_GOOGLE_BASEBOARD_AURON 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e001721baa7b7df89204eed03375e872c93e28 Gerrit-Change-Number: 60359 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/beltino: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60357 ) Change subject: mb/google/beltino: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/beltino: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Id1bbe7d68d9eace3f54e9decbd02f8b2b50d6867 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60357 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/beltino/Kconfig M src/mainboard/google/beltino/Kconfig.name 2 files changed, 15 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 2843777..74caad2 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -14,6 +14,21 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_ITE_IT8772F +config BOARD_GOOGLE_MCCLOUD + select BOARD_GOOGLE_BASEBOARD_BELTINO + +config BOARD_GOOGLE_MONROE + select BOARD_GOOGLE_BASEBOARD_BELTINO + +config BOARD_GOOGLE_PANTHER + select BOARD_GOOGLE_BASEBOARD_BELTINO + +config BOARD_GOOGLE_TRICKY + select BOARD_GOOGLE_BASEBOARD_BELTINO + +config BOARD_GOOGLE_ZAKO + select BOARD_GOOGLE_BASEBOARD_BELTINO + if BOARD_GOOGLE_BASEBOARD_BELTINO config VBOOT diff --git a/src/mainboard/google/beltino/Kconfig.name b/src/mainboard/google/beltino/Kconfig.name index f75f428..6c3913d 100644 --- a/src/mainboard/google/beltino/Kconfig.name +++ b/src/mainboard/google/beltino/Kconfig.name @@ -2,20 +2,15 @@ config BOARD_GOOGLE_MCCLOUD bool "-> Mccloud (Acer Chromebox CXI)" - select BOARD_GOOGLE_BASEBOARD_BELTINO config BOARD_GOOGLE_MONROE bool "-> Monroe (LG Chromebase 22CV241 & 22CB25S)" - select BOARD_GOOGLE_BASEBOARD_BELTINO config BOARD_GOOGLE_PANTHER bool "-> Panther (ASUS Chromebox CN60)" - select BOARD_GOOGLE_BASEBOARD_BELTINO config BOARD_GOOGLE_TRICKY bool "-> Tricky (Dell Chromebox 3010)" - select BOARD_GOOGLE_BASEBOARD_BELTINO config BOARD_GOOGLE_ZAKO bool "-> Zako (HP Chromebox G1)" - select BOARD_GOOGLE_BASEBOARD_BELTINO 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1bbe7d68d9eace3f54e9decbd02f8b2b50d6867 Gerrit-Change-Number: 60357 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60355 ) Change subject: mb/google/jecht: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/jecht: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Ieb6626aeb2023ac27eac8a515cc0e561607f9f62 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60355 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/jecht/Kconfig M src/mainboard/google/jecht/Kconfig.name 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index db5a4a1..836cbdf 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -12,6 +12,18 @@ select SOC_INTEL_BROADWELL select SUPERIO_ITE_IT8772F +config BOARD_GOOGLE_GUADO + select BOARD_GOOGLE_BASEBOARD_JECHT + +config BOARD_GOOGLE_JECHT + select BOARD_GOOGLE_BASEBOARD_JECHT + +config BOARD_GOOGLE_RIKKU + select BOARD_GOOGLE_BASEBOARD_JECHT + +config BOARD_GOOGLE_TIDUS + select BOARD_GOOGLE_BASEBOARD_JECHT + if BOARD_GOOGLE_BASEBOARD_JECHT config VBOOT diff --git a/src/mainboard/google/jecht/Kconfig.name b/src/mainboard/google/jecht/Kconfig.name index b241ca4..d28e5a1 100644 --- a/src/mainboard/google/jecht/Kconfig.name +++ b/src/mainboard/google/jecht/Kconfig.name @@ -2,16 +2,12 @@ config BOARD_GOOGLE_GUADO bool "-> Guado (ASUS Chromebox CN62)" - select BOARD_GOOGLE_BASEBOARD_JECHT config BOARD_GOOGLE_JECHT bool "-> Jecht" - select BOARD_GOOGLE_BASEBOARD_JECHT config BOARD_GOOGLE_RIKKU bool "-> Rikku (Acer Chromebox CXI2)" - select BOARD_GOOGLE_BASEBOARD_JECHT config BOARD_GOOGLE_TIDUS bool "-> Tidus (Lenovo ThinkCentre Chromebox)" - select BOARD_GOOGLE_BASEBOARD_JECHT 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb6626aeb2023ac27eac8a515cc0e561607f9f62 Gerrit-Change-Number: 60355 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/slippy: Select board-specific options per board
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60353 ) Change subject: mb/google/slippy: Select board-specific options per board ...................................................................... mb/google/slippy: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I1cfea0491f707052db2fbcee078e2c27c5a306c5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60353 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/slippy/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 12d0c26..0148093 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -1,7 +1,6 @@ config BOARD_GOOGLE_BASEBOARD_SLIPPY def_bool n select BOARD_ROMSIZE_KB_8192 - select DRIVERS_I2C_RTD2132 if BOARD_GOOGLE_LEON select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC select HAVE_ACPI_RESUME @@ -24,6 +23,7 @@ config BOARD_GOOGLE_LEON select BOARD_GOOGLE_BASEBOARD_SLIPPY + select DRIVERS_I2C_RTD2132 config BOARD_GOOGLE_PEPPY select BOARD_GOOGLE_BASEBOARD_SLIPPY 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cfea0491f707052db2fbcee078e2c27c5a306c5 Gerrit-Change-Number: 60353 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/slippy: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60352 ) Change subject: mb/google/slippy: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/slippy: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I677770168caa95d95fd7d32cadc15ffae8455e8c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60352 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/Kconfig.name 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 866038c..12d0c26 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -19,6 +19,18 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SYSTEM_TYPE_LAPTOP +config BOARD_GOOGLE_FALCO + select BOARD_GOOGLE_BASEBOARD_SLIPPY + +config BOARD_GOOGLE_LEON + select BOARD_GOOGLE_BASEBOARD_SLIPPY + +config BOARD_GOOGLE_PEPPY + select BOARD_GOOGLE_BASEBOARD_SLIPPY + +config BOARD_GOOGLE_WOLF + select BOARD_GOOGLE_BASEBOARD_SLIPPY + if BOARD_GOOGLE_BASEBOARD_SLIPPY config VBOOT diff --git a/src/mainboard/google/slippy/Kconfig.name b/src/mainboard/google/slippy/Kconfig.name index e81d056..3e0f81e 100644 --- a/src/mainboard/google/slippy/Kconfig.name +++ b/src/mainboard/google/slippy/Kconfig.name @@ -2,16 +2,12 @@ config BOARD_GOOGLE_FALCO bool "-> Falco (HP Chromebook 14)" - select BOARD_GOOGLE_BASEBOARD_SLIPPY config BOARD_GOOGLE_LEON bool "-> Leon (Toshiba Chromebook)" - select BOARD_GOOGLE_BASEBOARD_SLIPPY config BOARD_GOOGLE_PEPPY bool "-> Peppy (Acer C720/C720P Chromebook)" - select BOARD_GOOGLE_BASEBOARD_SLIPPY config BOARD_GOOGLE_WOLF bool "-> Wolf (Dell Chromebook 11)" - select BOARD_GOOGLE_BASEBOARD_SLIPPY 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I677770168caa95d95fd7d32cadc15ffae8455e8c Gerrit-Change-Number: 60352 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/rambi: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60363 ) Change subject: mb/google/rambi: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/rambi: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Ibd78e1c42d6184127277c1b5dea66150027444fe Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60363 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/Kconfig.name 2 files changed, 48 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 69fb843..5bd268a 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -16,6 +16,54 @@ select SOC_INTEL_BAYTRAIL select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO +config BOARD_GOOGLE_BANJO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_CANDY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_CLAPPER + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_ENGUARDE + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_GLIMMER + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_GNAWTY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_HELI + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_KIP + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_NINJA + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_ORCO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_QUAWKS + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SQUAWKS + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_RAMBI + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SUMO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SWANKY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_WINKY + select BOARD_GOOGLE_BASEBOARD_RAMBI + if BOARD_GOOGLE_BASEBOARD_RAMBI config VBOOT diff --git a/src/mainboard/google/rambi/Kconfig.name b/src/mainboard/google/rambi/Kconfig.name index fe26faa..bae223e 100644 --- a/src/mainboard/google/rambi/Kconfig.name +++ b/src/mainboard/google/rambi/Kconfig.name @@ -2,64 +2,48 @@ config BOARD_GOOGLE_BANJO bool "-> Banjo (Acer Chromebook 15 (CB3-531))" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_CANDY bool "-> Candy (Dell Chromebook 11 3120)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_CLAPPER bool "-> Clapper (Lenovo N20 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_ENGUARDE bool "-> Enguarde" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_GLIMMER bool "-> Glimmer (Lenovo ThinkPad 11e Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_GNAWTY bool "-> Gnawty (Acer Chromebook 11 (CB3-111/131,C730/C730E/C735))" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_HELI bool "-> Heli (Haier Chromebook G2)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_KIP bool "-> Kip (HP Chromebook 11 G3 / G4 / G4 EE)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_NINJA bool "-> Ninja (AOpen Chromebox Commercial)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_ORCO bool "-> Orco (Lenovo 100S Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_QUAWKS bool "-> Quawks (ASUS Chromebook C300)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SQUAWKS bool "-> Squawks (ASUS Chromebook C200)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_RAMBI bool "-> Rambi" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SUMO bool "-> Sumo (AOpen Chromebase Commercial)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SWANKY bool "-> Swanky (Toshiba Chromebook 2)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_WINKY bool "-> Winky (Samsung Chromebook 2 (XE500C12))" - select BOARD_GOOGLE_BASEBOARD_RAMBI 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd78e1c42d6184127277c1b5dea66150027444fe Gerrit-Change-Number: 60363 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/notify.c: Group per-phase data
by Subrata Banik (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Angel Pons, Andrey Petrov, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60639 ) Change subject: drivers/intel/fsp2_0/notify.c: Group per-phase data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Sounds good. […] perfect, will rebase accordingly. -- To view, visit https://review.coreboot.org/c/coreboot/+/60639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4ab3d87edfcd5426ce35c168cbb780ade87290e Gerrit-Change-Number: 60639 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 17:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/notify.c: Group per-phase data
by Angel Pons (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60639 ) Change subject: drivers/intel/fsp2_0/notify.c: Group per-phase data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I liked it, thanks for addressing super quickly, next I will rebase CB:60402 to add a new structure […] Sounds good. I'd store `skip` instead of `allowed` so that notify phases that can't be skipped don't need to set `.allowed = true,`. This is also in line with the Kconfig options containing `SKIP` in their names. -- To view, visit https://review.coreboot.org/c/coreboot/+/60639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4ab3d87edfcd5426ce35c168cbb780ade87290e Gerrit-Change-Number: 60639 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 17:49:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022