coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: console: Create helper function to get max console log level
by Nico Huber (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, EricR Lai. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 ) Change subject: console: Create helper function to get max console log level ...................................................................... Patch Set 3: (1 comment) File src/console/init.c: https://review.coreboot.org/c/coreboot/+/60470/comment/85f4770f_d8eb785f PS2, Line 55: return get_log_level(); > Thanks, will wait for Nico's reply on this thought. My initial thought was to have a function that complements the existing console_log_level() function. But exporting get_log_level() works too, I wouldn't mind. -- To view, visit https://review.coreboot.org/c/coreboot/+/60470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397 Gerrit-Change-Number: 60470 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 19:56:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake/fsp_params.c: Use `is_dev_enabled()`
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60026 ) Change subject: soc/intel/tigerlake/fsp_params.c: Use `is_dev_enabled()` ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e79f637bedec0bdca1312291328b2385bd027a7 Gerrit-Change-Number: 60026 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 19:49:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: pci_device.c: Don't guard `pci_dev_disable_bus_master()`
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60599 ) Change subject: pci_device.c: Don't guard `pci_dev_disable_bus_master()` ...................................................................... pci_device.c: Don't guard `pci_dev_disable_bus_master()` The `pci_dev_disable_bus_master()` function doesn't need to be guarded with `CONFIG(PC80_SYSTEM)`, so move it out of the guard. Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60599 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M src/device/pci_device.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 1075ef7..a61fbd6 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1472,6 +1472,11 @@ pci_scan_bus(link, PCI_DEVFN(0, 0), 0xff); } +void pci_dev_disable_bus_master(const struct device *dev) +{ + pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); +} + /** * Take an INT_PIN number (0, 1 - 4) and convert * it to a string ("NO PIN", "PIN A" - "PIN D") @@ -1665,9 +1670,4 @@ i8259_configure_irq_trigger(irq, IRQ_LEVEL_TRIGGERED); } } - -void pci_dev_disable_bus_master(const struct device *dev) -{ - pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); -} #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Gerrit-Change-Number: 60599 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/volteer: Select board-specific options per board
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60370 ) Change subject: mb/google/volteer: Select board-specific options per board ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/volteer/Kconfig: https://review.coreboot.org/c/coreboot/+/60370/comment/0082b9d4_3a29b4d3 PS3, Line 30: select MAINBOARD_HAS_CHROMEOS > I wonder if this would work: […] Yes, that works. Probably that makes sense here. -- To view, visit https://review.coreboot.org/c/coreboot/+/60370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c5305a764b7a362f9f381580a1cd2c20a8f2e9d Gerrit-Change-Number: 60370 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 19:12:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/{adl,ehl,tgl}: Rename spi_protection_mode to mfg_mode
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60407 ) Change subject: soc/intel/{adl,ehl,tgl}: Rename spi_protection_mode to mfg_mode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d00f72ce7b3951120778733066c351986ccf343 Gerrit-Change-Number: 60407 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 18:11:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/pi/agesawrapper.c: Include <string.h>
by HAOUAS Elyes (Code Review) 01 Jan '22

01 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60641 ) Change subject: soc/amd/common/pi/agesawrapper.c: Include <string.h> ...................................................................... soc/amd/common/pi/agesawrapper.c: Include <string.h> "memcpy" needs <string.h> Change-Id: I5b7b3a94acbb7e4f9614fcf3f06d68e6ac72f4f1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/common/pi/agesawrapper.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/60641/1 diff --git a/src/soc/amd/common/pi/agesawrapper.c b/src/soc/amd/common/pi/agesawrapper.c index ca576ba..5083c8a 100644 --- a/src/soc/amd/common/pi/agesawrapper.c +++ b/src/soc/amd/common/pi/agesawrapper.c @@ -11,6 +11,7 @@ #include <soc/pci_devs.h> #include <soc/northbridge.h> #include <soc/cpu.h> +#include <tring.h> void __weak SetMemParams(AMD_POST_PARAMS *PostParams) {} void __weak OemPostParams(AMD_POST_PARAMS *PostParams) {} -- To view, visit https://review.coreboot.org/c/coreboot/+/60641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b7b3a94acbb7e4f9614fcf3f06d68e6ac72f4f1 Gerrit-Change-Number: 60641 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/rambi: Select board-specific options per board
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60364 ) Change subject: mb/google/rambi: Select board-specific options per board ...................................................................... mb/google/rambi: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I20d79d4b42908314dbf7021a67b92e5fd2b79556 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60364 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/rambi/Kconfig 1 file changed, 29 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 5bd268a..d513672 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -9,60 +9,87 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_SPD_IN_CBFS - select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_BAYTRAIL - select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO config BOARD_GOOGLE_BANJO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_CANDY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_CLAPPER select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_ENGUARDE select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_GLIMMER select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_GNAWTY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_HELI select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_KIP select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_NINJA select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_ORCO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_QUAWKS select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SQUAWKS select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_RAMBI select BOARD_GOOGLE_BASEBOARD_RAMBI + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SUMO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_SWANKY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_WINKY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_RAMBI 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20d79d4b42908314dbf7021a67b92e5fd2b79556 Gerrit-Change-Number: 60364 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/volteer: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60369 ) Change subject: mb/google/volteer: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/volteer: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I72c0e0c3968cb2e92b35381691762148f4c270e4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60369 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name 2 files changed, 83 insertions(+), 45 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 8a605ca..ced8d9d 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -35,6 +35,89 @@ select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_TIGERLAKE +config BOARD_GOOGLE_DELBIN + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GENESYSLOGIC_GL9755 + +config BOARD_GOOGLE_ELDRID + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_HALVOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_LINDAR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_GENERIC_BAYHUB_LV2 + select DRIVERS_I2C_RT1011 + select INTEL_CAR_NEM + +config BOARD_GOOGLE_MALEFOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_TERRADOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_TODOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_TRONDO + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_VOLTEER + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOLTEER2 + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOLTEER2_TI50 + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOXEL + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_ELEMI + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_VOEMA + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_DROBIT + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_COPANO + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_COLLIS + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_VOLET + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_CHRONICLER + select BOARD_GOOGLE_BASEBOARD_VOLTEER + if BOARD_GOOGLE_BASEBOARD_VOLTEER config CHROMEOS diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index be82d32..d868e52 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -2,103 +2,58 @@ config BOARD_GOOGLE_DELBIN bool "-> Delbin (ASUS Chromebook Flip CX5)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVERS_GENESYSLOGIC_GL9755 config BOARD_GOOGLE_ELDRID bool "-> Eldrid" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_HALVOR bool "-> Halvor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_LINDAR bool "-> Lindar" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_GENERIC_BAYHUB_LV2 - select DRIVERS_I2C_RT1011 - select INTEL_CAR_NEM config BOARD_GOOGLE_MALEFOR bool "-> Malefor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_TERRADOR bool "-> Terrador" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_TODOR bool "-> Todor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_TRONDO bool "-> Trondo" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_VOLTEER bool "-> Volteer" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOLTEER2 bool "-> Volteer2" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVER_I2C_TPM_ACPI - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA # Reworked Volteer2 prototype, Haven chip replaced with Dauntless demo board config BOARD_GOOGLE_VOLTEER2_TI50 bool "-> Volteer2_Ti50" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVER_I2C_TPM_ACPI - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOXEL bool "-> Voxel (Acer Chromebook Spin 713 (CP713-3W))" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_ELEMI bool "-> Elemi (HP Pro c640 G2 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_VOEMA bool "-> Voema" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_DROBIT bool "-> Drobit (ASUS Chromebook CX9400)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COPANO bool "-> Copano (ASUS Chromebook Flip CX5400)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COLLIS bool "-> Collis" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_VOLET bool "-> Volet" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_CHRONICLER bool "-> Chronicler" - select BOARD_GOOGLE_BASEBOARD_VOLTEER 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72c0e0c3968cb2e92b35381691762148f4c270e4 Gerrit-Change-Number: 60369 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/deltaur: Select board-specific options per board
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60367 ) Change subject: mb/google/deltaur: Select board-specific options per board ...................................................................... mb/google/deltaur: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I71f22100fe56a8b88321d220f98ac03887ce6bd7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60367 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 45e8258..8a5cf3c 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -14,13 +14,13 @@ select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_EC_REGION - select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_DELTAN select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_TIGERLAKE select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_DELTAN select BOARD_GOOGLE_BASEBOARD_DELTAUR + select MAINBOARD_USES_IFD_GBE_REGION config BOARD_GOOGLE_DELTAUR select BOARD_GOOGLE_BASEBOARD_DELTAUR 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71f22100fe56a8b88321d220f98ac03887ce6bd7 Gerrit-Change-Number: 60367 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/deltaur: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60366 ) Change subject: mb/google/deltaur: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/deltaur: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I9b523ebee2d2af8585736588306ca687dfe16003 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60366 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/Kconfig.name 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index e1874e3..45e8258 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -19,6 +19,12 @@ select SOC_INTEL_TIGERLAKE select SYSTEM_TYPE_LAPTOP +config BOARD_GOOGLE_DELTAN + select BOARD_GOOGLE_BASEBOARD_DELTAUR + +config BOARD_GOOGLE_DELTAUR + select BOARD_GOOGLE_BASEBOARD_DELTAUR + if BOARD_GOOGLE_BASEBOARD_DELTAUR config CHROMEOS diff --git a/src/mainboard/google/deltaur/Kconfig.name b/src/mainboard/google/deltaur/Kconfig.name index 5c4c12b..2e04d67 100644 --- a/src/mainboard/google/deltaur/Kconfig.name +++ b/src/mainboard/google/deltaur/Kconfig.name @@ -2,8 +2,6 @@ config BOARD_GOOGLE_DELTAN bool "-> Deltan" - select BOARD_GOOGLE_BASEBOARD_DELTAUR config BOARD_GOOGLE_DELTAUR bool "-> Deltaur" - select BOARD_GOOGLE_BASEBOARD_DELTAUR 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60366 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b523ebee2d2af8585736588306ca687dfe16003 Gerrit-Change-Number: 60366 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022