coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: ec/kontron/it8516e/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60648 ) Change subject: ec/kontron/it8516e/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... ec/kontron/it8516e/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: I81e976de964f6ae3528884debaf2b24ddf8ed28a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/kontron/it8516e/acpi/pm_channels.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/60648/1 diff --git a/src/ec/kontron/it8516e/acpi/pm_channels.asl b/src/ec/kontron/it8516e/acpi/pm_channels.asl index 0ac0467..5df72c0 100644 --- a/src/ec/kontron/it8516e/acpi/pm_channels.asl +++ b/src/ec/kontron/it8516e/acpi/pm_channels.asl @@ -35,7 +35,7 @@ If (And (Local0, EC_ERROR_MASK)) { Return (0) } - Multiply (Local0, 10, Local0) /* Convert to 10th °C */ + Local0 *= 10 Return (Local0 + 2732) /* Return as 10th Kelvin */ } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81e976de964f6ae3528884debaf2b24ddf8ed28a Gerrit-Change-Number: 60648 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60647 ) Change subject: ec/google/chromeec/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: Iea86e77df6c76756ed336f57a906ac0757aef1cf Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/60647/1 diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 69d608b..99478bc 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -201,7 +201,7 @@ Local0 += \_SB.PCI0.LPCB.EC0.TOFS /* Convert to 1/10 Kelvin */ - Multiply (Local0, 10, Local0) + Local0 *= 10 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea86e77df6c76756ed336f57a906ac0757aef1cf Gerrit-Change-Number: 60647 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60646 ) Change subject: ec/lenovo/h8/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: Idfc08803946cc2d4537db4be8d1bc07e48aa6fed Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/60646/1 diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 85cfdb5..d8346a1 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -11,7 +11,7 @@ Method(C2K, 1, NotSerialized) { - Multiply(Arg0, 10, Local0) + Local0 = Arg0 * 10 Local0 += 2732 if (LLessEqual(Local0, 2732)) { Return (3000) -- To view, visit https://review.coreboot.org/c/coreboot/+/60646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idfc08803946cc2d4537db4be8d1bc07e48aa6fed Gerrit-Change-Number: 60646 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common/cse: Implement HECI notify
by Tim Wawrzynczak (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Arthur Heymans, Felix Singer, Subrata Banik, Angel Pons, Patrick Rudolph, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Implement HECI notify ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60405/comment/3cb299c6_ce5d05d6 PS8, Line 9: required heci operation `the required HECI operations` File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/60405/comment/4856ceaf_099b68d0 PS7, Line 279: HeciEnabled > > > Ah, the HECI device can be enabled and initialised in coreboot, but hidden before booting an OS. […] Yes I have been on vacation, good guess 😄 I think I like where you're going here guys: 0) Drop HeciEnabled 1) Always keep the HECI devices (at least HECI1) to perform all of the CSE operations, instead of using BOOT_STATE entries 2) A Kconfig to decide whether or not to "function disable" the CSE/HECI devices before booting the payload. a) The means of doing this (via HECI_DISABLE_USING_SMM for example) is chipset-specific and irrelevant to the point at hand. This means coreboot can handle all of the required CSE operations, but the user can decide to disable CSE before payload if desired. -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 22:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60645 ) Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: Id2a0b13522761e7113d1dc5b78d0dfd19a6cfd94 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/arch/x86/acpi/debug.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/60645/1 diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index 60f1595..fe6bda2 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -86,9 +86,9 @@ { and(Arg0, 0x0f, Local0) if (LLess(Local0, 10)) { - add(Local0, 0x30, Local0) + Local0 += 0x30 } else { - add(Local0, 0x37, Local0) + Local0 += 0x37 } OUTC(Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2a0b13522761e7113d1dc5b78d0dfd19a6cfd94 Gerrit-Change-Number: 60645 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/soc/intel: Remove unused <delay.h>
by Tim Wawrzynczak (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60604 ) Change subject: src/soc/intel: Remove unused <delay.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8e6221a9801d5198171dc9cd564000d19720a42 Gerrit-Change-Number: 60604 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 01 Jan 2022 22:27:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake/fsp_params.c: Use `is_dev_enabled()`
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60026 ) Change subject: soc/intel/tigerlake/fsp_params.c: Use `is_dev_enabled()` ...................................................................... soc/intel/tigerlake/fsp_params.c: Use `is_dev_enabled()` Change-Id: I3e79f637bedec0bdca1312291328b2385bd027a7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60026 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index 40676f1..f04c3d7 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -530,10 +530,7 @@ /* USB4/TBT */ for (i = 0; i < ARRAY_SIZE(params->ITbtPcieRootPortEn); i++) { dev = pcidev_on_root(SA_DEV_SLOT_TBT, i); - if (dev) - params->ITbtPcieRootPortEn[i] = dev->enabled; - else - params->ITbtPcieRootPortEn[i] = 0; + params->ITbtPcieRootPortEn[i] = is_dev_enabled(dev); } /* PCH FIVR settings override */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e79f637bedec0bdca1312291328b2385bd027a7 Gerrit-Change-Number: 60026 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: src/acpi: Remove unused <acpi/acpi.h>
by Tim Wawrzynczak (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Lance Zhao, HAOUAS Elyes. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60635 ) Change subject: src/acpi: Remove unused <acpi/acpi.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1684e6386da9db0ff41e78078f7d72c1fb4a499e Gerrit-Change-Number: 60635 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 01 Jan 2022 22:22:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
by Tim Wawrzynczak (Code Review) 01 Jan '22

01 Jan '22

Attention is currently required from: Felix Singer, Subrata Banik, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 ) Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60402/comment/ba3a0a8b_2c2e9c97 PS7, Line 10: support `supports` https://review.coreboot.org/c/coreboot/+/60402/comment/c368ffe9_14dd4a2f PS7, Line 17: implementation `implementations` File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/60402/comment/d8cf1709_b546eb00 PS7, Line 307: support nit, here and below: `supports` -- To view, visit https://review.coreboot.org/c/coreboot/+/60402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64 Gerrit-Change-Number: 60402 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 22:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Increment() with ASL 2.0 syntax
by 9elements QA (Code Review) 01 Jan '22

01 Jan '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60579 ) Change subject: arch/x86/acpi: Replace Increment() with ASL 2.0 syntax ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/87065 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/87064 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87063 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/87062 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87061 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/87060 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/87059 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/87058 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60579 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45ce13509f3e93d7d8cd69689604f24b926bcfbc Gerrit-Change-Number: 60579 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jan 2022 22:09:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022