coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: superio/acpi: Replace LEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Felix Held. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60657 ) Change subject: superio/acpi: Replace LEqual(a,b) with ASL 2.0 syntax ...................................................................... superio/acpi: Replace LEqual(a,b) with ASL 2.0 syntax Replace `LEqual(a, b)` with `a == b`. Change-Id: Ia09c54465af47f5779917ed71bb3ea148864dfd1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/superio/acpi/pnp.asl M src/superio/acpi/pnp_kbc.asl 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/60657/1 diff --git a/src/superio/acpi/pnp.asl b/src/superio/acpi/pnp.asl index d5a26a7..dc5c390 100644 --- a/src/superio/acpi/pnp.asl +++ b/src/superio/acpi/pnp.asl @@ -81,7 +81,7 @@ ENTER_CONFIG_MODE (PM_LDN)\ Store (PM_REG, Local0)\ EXIT_CONFIG_MODE ()\ - If (LEqual(Local0, PM_VAL)) { Return (3) }\ + If (Local0 == PM_VAL) { Return (3) }\ Else { Return (0) }\ /* Disable power saving mode */ diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl index 22a0556..ba03e19 100644 --- a/src/superio/acpi/pnp_kbc.asl +++ b/src/superio/acpi/pnp_kbc.asl @@ -156,7 +156,7 @@ Method (_STA) { Store (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._STA (), Local0) - If (LEqual (Local0, DEVICE_PRESENT_ACTIVE)) { + If (Local0 == DEVICE_PRESENT_ACTIVE) { PNP_GENERIC_STA(SUPERIO_KBC_PS2LDN) } Else { Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia09c54465af47f5779917ed71bb3ea148864dfd1 Gerrit-Change-Number: 60657 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86/acpi: Replace LEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60656 ) Change subject: arch/x86/acpi: Replace LEqual(a,b) with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace LEqual(a,b) with ASL 2.0 syntax Replace `LEqual(a, b)` with `a == b`. Change-Id: Iabfaaee22011a75cc981607d366d61660838ab21 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/arch/x86/acpi/debug.asl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/60656/1 diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index fe6bda2..cfe3646 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -51,7 +51,7 @@ Method(THRE) { and(CLSR, 0x20, local0) - while (Lequal(local0, Zero)) { + while (local0 == 0) { and(CLSR, 0x20, local0) } } @@ -72,7 +72,7 @@ */ Method(OUTC, 1) { - if (LEqual(Arg0, 0x0a)) { + if (Arg0 == 0x0a) { OUTX(0x0d) } OUTX(Arg0) @@ -133,7 +133,7 @@ Method(DBGO, 1) { /* DINI() */ - if (LEqual(ObjectType(Arg0), 1)) { + if (ObjectType(Arg0) == 1) { if (LGreater(Arg0, 0xffff)) { DBGD(Arg0) } else { @@ -149,7 +149,7 @@ store(0, Local1) while (One) { store(GETC(BDBG, Local1), Local0) - if (LEqual(Local0, 0)) { + if (Local0 == 0) { return (0) } OUTC(Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabfaaee22011a75cc981607d366d61660838ab21 Gerrit-Change-Number: 60656 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60655 ) Change subject: ec/google/chromeec/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax Replace `Divide (a, b, , c)` with `c = a / b`. Change-Id: I26117087c09109cfc480cbe01d3761a02a12c61b Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl M src/ec/google/chromeec/acpi/ec.asl 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/60655/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index ce4462d..c28c78a 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -78,11 +78,11 @@ Store (Local0, Arg1[1]) // Design Capacity of Warning - Divide (Local0 * DWRN, 100, , Local2) + Local2 = Local0 * DWRN / 100 Store (Local2, Arg1[5]) // Design Capacity of Low - Divide (Local0 * DLOW, 100, , Local2) + Local2 = Local0 * DLOW / 100 Store (Local2, Arg1[6]) // Get battery info from mainboard @@ -118,11 +118,11 @@ Store (Local0, Arg1[2]) // Design Capacity of Warning - Divide (Local0 * DWRN, 100, , Local2) + Local2 = Local0 * DWRN / 100 Store (Local2, Arg1[6]) // Design Capacity of Low - Divide (Local0 * DLOW, 100, , Local2) + Local2 = Local0 * DLOW / 100 Store (Local2, Arg1[7]) // Cycle Count diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 99478bc..49e7efc 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -423,7 +423,7 @@ Store (ToInteger (Arg0), ^PATI) /* Temperature is passed in 1/10 Kelvin */ - Divide (ToInteger (Arg1), 10, , Local1) + Local1 = ToInteger (Arg1) / 10 /* Adjust by EC temperature offset */ ^PATT = Local1 - ^TOFS @@ -450,7 +450,7 @@ Store (ToInteger (Arg0), ^PATI) /* Temperature is passed in 1/10 Kelvin */ - Divide (ToInteger (Arg1), 10, , Local1) + Local1 = ToInteger (Arg1) / 10 /* Adjust by EC temperature offset */ ^PATT = Local1 - ^TOFS -- To view, visit https://review.coreboot.org/c/coreboot/+/60655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26117087c09109cfc480cbe01d3761a02a12c61b Gerrit-Change-Number: 60655 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60654 ) Change subject: ec/quanta/it8518/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Divide(a,b,,c) with ASL 2.0 syntax Replace `Divide (a, b, , c)` with `c = a / b`. Change-Id: I9b8262396755197dfbe044e3dc6a6a75c903f093 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60654/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 316a342..48c8e35 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -149,8 +149,8 @@ // Design capacity of High (5%) // Design capacity of Low (1%) // - Divide (Local0, 20, , PBIF[5]) - Divide (Local0, 100, , PBIF[6]) + PBIF[5] = Local0 / 20 + PBIF[6] = Local0 / 100 // // Design voltage @@ -287,7 +287,7 @@ If (Local6) { Local1 *= ECVO - Divide (Local1, 1000, , Local1) + Local1 /= 1000 } Store (Local1, PBST[1]) -- To view, visit https://review.coreboot.org/c/coreboot/+/60654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b8262396755197dfbe044e3dc6a6a75c903f093 Gerrit-Change-Number: 60654 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
by Michael Niewöhner (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 ) Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ...................................................................... Patch Set 4: (7 comments) Patchset: PS4: > In some cases there are holes between GPP groups in the same community. […] meh, confirmed. We've seen that on other platforms already, but TGL seems to be special.... I put together all information I have and these are my results: Range starts come from the PCH ds, ends are calculated (16*pad count-1) *** marks additional ranges where the pad names come from refcode. These pads are either NC, used internally or hide behind the various undocumented `RSVD` pads. The offsets in these cases are educated guesses based on end/start of the adjacent ranges, but it turns out they fit perfectly ;) ``` com0 GPP_B0 - GPP_B23 -> 24p -> 0x700-0x87f GSPI0_CLK_LOOPBK - GSPI1_ -> 2p -> 0x880-0x89f *** GPP_T0 - GPP_T1 -> 2p -> 0x8a0-0x8bf *** GPP_T2 - GPP_T3 -> 2p -> 0x8c0-0x8df GPP_T4 - GPP_T15 -> 12p -> 0x8e0-0x99f *** GPP_A0 - GPP_A23 -> 24p -> 0x9a0-0xb1f ESPI_CLK_LOOPBK ... 0xb20- *** com1 GPP_S0 - GPP_S7 -> 8p -> 0x700-0x77f GPP_H0 - GPP_H23 -> 24p -> 0x780-0x8ff GPP_D0 - GPP_D19 -> 20p -> 0x900-0xa3f GSPI2_CLK_LOOPBK -> 1p -> 0xa40-0xa4f *** GPP_U0-U3 -> 4p -> 0xa50-0xa8f *** GPP_U4 - GPP_U5 -> 2p -> 0xa90-0xaaf GPP_U6 - GPP_U19 -> 14p -> 0xab0-0xbcf *** GSPI3_CLK_LOOPBK - GSPI6_ -> 4p -> 0xcd0- *** com2 GPD0 - GPD11 -> 12p -> 0x700-0x7bf INPUT3VSEL 0x7c0 *** SLP_LANB 0x7d0 *** SLP_SUSB 0x7e0 *** WAKEB 0x7f0 *** DRAM_RESETB 0x7d0 *** com4 GPP_C0 - GPP_C23 -> 24p -> 0x700-0x7bf GPP_F0 - GPP_F23 -> 24p -> 0x880-0x9ff GPPF_CLK_LOOPBK -> 1p -> 0xa00-0xa0f *** L_BKLTEN -> 1p -> 0xa10-0xa1f *** L_BKLTCTL -> 1p -> 0xa20-0xb2f *** L_VDDEN -> 1p -> 0xa30-0xc3f *** SYS_PWROK -> 1p -> 0xa40-0xd4f *** SYS_RESETB -> 1p -> 0xa50-0xe5f *** MLK_RSTB -> 1p -> 0xa60-0xa6f *** GPP_E0 - GPP_E23 -> 24p -> 0xa70-0xbef GPPE_CLK_LOOPBK -> 1p -> 0xbf0-0xbff *** com5 GPP_R0 - GPP_R7 -> 8p -> 0x700-0x78f ``` File util/inteltool/gpio_names/tigerlake.h: https://review.coreboot.org/c/coreboot/+/56171/comment/438b129e_fc779329 PS4, Line 135: }; missing GSPI2_CLK_LOOPBK https://review.coreboot.org/c/coreboot/+/56171/comment/8a4bbc3d_4a3111f5 PS4, Line 169: }; 24 is GPPE_CLK_LOOPBK, "n/a", "THC0_CLK_LOOPBACK" https://review.coreboot.org/c/coreboot/+/56171/comment/f954fc89_bca2d3d9 PS4, Line 179: const char *const tigerlake_pch_lp_fe_hole_names[] = { this is the HVMOS group, compare util/inteltool/gpio_names/cannonlake_lp.h or util/inteltool/gpio_names/icelake.h L_BKLTEN, L_BKLTEN, L_BKLTCTL, L_BKLTCTL, L_VDDEN, L_VDDEN, SYS_PWROK, SYS_PWROK SYS_RESETB, SYS_RESETB, MLK_RSTB, MLK_RSTB, https://review.coreboot.org/c/coreboot/+/56171/comment/357a950f_697401da PS4, Line 221: }; 24 is GPPF_CLK_LOOPBK, "n/a", "THC1_CLK_LOOPBACK" https://review.coreboot.org/c/coreboot/+/56171/comment/e36413df_438c2c0b PS4, Line 336: "Reserved", one too much. GPP_U4 is on offset 5 https://review.coreboot.org/c/coreboot/+/56171/comment/bf299447_1cf90b2e PS4, Line 361: }; you can add these as well - all with NF1: INPUT3VSEL SLP_LANB SLP_SUSB WAKEB DRAM_RESETB -- To view, visit https://review.coreboot.org/c/coreboot/+/56171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08 Gerrit-Change-Number: 56171 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jan 2022 23:10:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/slippy: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60653 ) Change subject: mb/google/slippy: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/slippy: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: I63b8b8a086e2c5ede765855b3c803206edf87690 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/slippy/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/60653/1 diff --git a/src/mainboard/google/slippy/acpi/thermal.asl b/src/mainboard/google/slippy/acpi/thermal.asl index 176b08d..e01195f 100644 --- a/src/mainboard/google/slippy/acpi/thermal.asl +++ b/src/mainboard/google/slippy/acpi/thermal.asl @@ -35,7 +35,7 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 // Convert to Kelvin Local0 += 2732 @@ -90,7 +90,7 @@ Local0 += \_SB.PCI0.LPCB.EC0.TOFS // Convert to 1/10 Kelvin - Multiply (Local0, 10, Local0) + Local0 *= 10 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63b8b8a086e2c5ede765855b3c803206edf87690 Gerrit-Change-Number: 60653 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/jecht: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60652 ) Change subject: mb/google/jecht: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/jecht: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: Idc24216209bbfe73ef4197d4b8101f0d7e5891f7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/60652/1 diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index c8808dd..e608ae4 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -24,7 +24,7 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 // Convert to Kelvin Local0 += 2732 diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index c8808dd..e608ae4 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -24,7 +24,7 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 // Convert to Kelvin Local0 += 2732 diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index c8808dd..e608ae4 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -24,7 +24,7 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 // Convert to Kelvin Local0 += 2732 diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index 2a7b3f0..564102e 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -39,7 +39,7 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 // Convert to Kelvin Local0 += 2732 -- To view, visit https://review.coreboot.org/c/coreboot/+/60652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc24216209bbfe73ef4197d4b8101f0d7e5891f7 Gerrit-Change-Number: 60652 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/kahlee: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60651 ) Change subject: mb/google/kahlee: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/kahlee: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: I19835510b89cd243277f0c9701209c81bdf6ea29 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/60651/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl index 2930def..81fe434 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -21,7 +21,7 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 /* Convert to Kelvin */ Local0 += 2732 -- To view, visit https://review.coreboot.org/c/coreboot/+/60651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19835510b89cd243277f0c9701209c81bdf6ea29 Gerrit-Change-Number: 60651 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/cyan: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60650 ) Change subject: mb/google/cyan: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/cyan: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: Ib8719143a5a217173b34931e9c0ef02e9895d0a5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/60650/1 diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl index 8852345..621e5d3 100644 --- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl @@ -203,7 +203,7 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 /* Convert to Kelvin */ Local0 += 2732 -- To view, visit https://review.coreboot.org/c/coreboot/+/60650 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8719143a5a217173b34931e9c0ef02e9895d0a5 Gerrit-Change-Number: 60650 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 01 Jan '22

01 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60649 ) Change subject: ec/quanta/it8518/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Multiply(a,b,c) with ASL 2.0 syntax Replace `Multiply (a, b, c)` with `c = a * b`. Change-Id: Ied407753ee3bb024c8c0350c45312c337ac799e5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/60649/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 4fcc30c..316a342 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -119,7 +119,7 @@ // If (Local7) { - Multiply (SBFC, 10, PBIF[2]) + PBIF[2] = SBFC * 10 } Else { @@ -137,7 +137,7 @@ // If (Local7) { - Multiply (SBDC, 10, Local0) + Local0 = SBDC * 10 } Else { @@ -286,7 +286,7 @@ If (Local6) { - Multiply (ECVO, Local1, Local1) + Local1 *= ECVO Divide (Local1, 1000, , Local1) } Store (Local1, PBST[1]) @@ -299,7 +299,7 @@ // ACPI spec : 0 - mWh : 1 - mAh If (Local6) { - Multiply (ECRC, 10, Local1) + Local1 = ECRC * 10 } Else { -- To view, visit https://review.coreboot.org/c/coreboot/+/60649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied407753ee3bb024c8c0350c45312c337ac799e5 Gerrit-Change-Number: 60649 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022