coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60685 ) Change subject: ec/quanta/it8518/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: I86a11ab5d2667661af3491174001001e644083e3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/60685/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 8ca54f7..5fa9502 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -317,7 +317,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Local2 - Local3) && Local1 < Local2 + Local3) + If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86a11ab5d2667661af3491174001001e644083e3 Gerrit-Change-Number: 60685 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60684 ) Change subject: ec/smsc/mec1308/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: I04f3cc2dbba59d732c9c52a4b90a32481f9da337 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60684/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 1e34e0d..e30c005 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -157,7 +157,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Local2 - Local3) && Local1 < Local2 + Local3) + If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04f3cc2dbba59d732c9c52a4b90a32481f9da337 Gerrit-Change-Number: 60684 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60683 ) Change subject: ec/lenovo/h8/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: I1dbe6c325ed33a4dd15e4d6315b2308d8351974e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/60683/1 diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 8244bbc7..bdc0642 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -17,7 +17,7 @@ Return (3000) } - if (LGreater(Local0, 4012)) { + if (Local0 > 4012) { Return (3000) } Return (Local0) @@ -47,7 +47,7 @@ /* Get critical temperature in degree celsius */ Method (GCRT, 0, NotSerialized) { Store (\TCRT, Local0) - if (LGreater (Local0, 0)) { + if (Local0 > 0) { Return (Local0) } Return (127) @@ -56,7 +56,7 @@ /* Get passive temperature in degree celsius */ Method (GPSV, 0, NotSerialized) { Store (\TPSV, Local0) - if (LGreater (Local0, 0)) { + if (Local0 > 0) { Return (Local0) } Return (95) -- To view, visit https://review.coreboot.org/c/coreboot/+/60683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dbe6c325ed33a4dd15e4d6315b2308d8351974e Gerrit-Change-Number: 60683 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60682 ) Change subject: ec/google/chromeec/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: Ie6238ead464d79b3576846f3b5b92b658972eec8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/60682/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 7a9a538..253ab8e 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -210,7 +210,7 @@ // See if within ~6% of full ShiftRight (Local2, 4, Local3) - If (LGreater (Local1, Local2 - Local3) && Local1 < Local2 + Local3) + If (Local1 > Local2 - Local3 && Local1 < Local2 + Local3) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6238ead464d79b3576846f3b5b92b658972eec8 Gerrit-Change-Number: 60682 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60681 ) Change subject: drivers/intel/gma/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: I56479726f91f33e1d3062a31f1efb82c0814316c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/60681/1 diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index a24434f..c1f1104 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -54,7 +54,7 @@ /* Always keep BCLP up to date, even if driver is not ready. It requires a full 8-bit brightness value. 255 = 100% */ Store (Arg0 * 255 / 100, Local1) - If (LGreater(Local1, 255)) { + If (Local1 > 255) { Store (255, Local1) } /* also set valid bit */ @@ -71,7 +71,7 @@ Store (0x1, ASLE) Store (0x20, Local0) - While (LGreater(Local0, Zero)) + While (Local0 > 0) { Sleep (1) If (And (ASLC, 0x2) == 0) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56479726f91f33e1d3062a31f1efb82c0814316c Gerrit-Change-Number: 60681 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60680 ) Change subject: soc/intel/apollolake/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: If56097f02640d801ffff50cc2624feadddb98122 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/pcie_port.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/60680/1 diff --git a/src/soc/intel/apollolake/acpi/pcie_port.asl b/src/soc/intel/apollolake/acpi/pcie_port.asl index cfdb6de..5b08b7b 100644 --- a/src/soc/intel/apollolake/acpi/pcie_port.asl +++ b/src/soc/intel/apollolake/acpi/pcie_port.asl @@ -71,7 +71,7 @@ * and link to train */ While (L23R) { - If (Lgreater (Local0, 4)) { + If (Local0 > 4) { Break } Sleep (16) @@ -91,7 +91,7 @@ Sleep (16) Store (0, Local0) While (L23E) { - If (Lgreater (Local0, 4)) { + If (Local0 > 4) { Break } Sleep (16) -- To view, visit https://review.coreboot.org/c/coreboot/+/60680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56097f02640d801ffff50cc2624feadddb98122 Gerrit-Change-Number: 60680 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/poppy/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60679 ) Change subject: mb/google/poppy/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... mb/google/poppy/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: Ife3793e6a498092937dd267e91295e4b0bfcd9c7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60679/1 diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index b973200..4809f26 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -12,7 +12,7 @@ PMOF () } Method (_STA, 0, Serialized) { - If (LGreater(STA,0)) { + If (STA > 0) { Return (0x1) } Else { -- To view, visit https://review.coreboot.org/c/coreboot/+/60679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife3793e6a498092937dd267e91295e4b0bfcd9c7 Gerrit-Change-Number: 60679 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
by Michael Niewöhner (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 ) Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > verified by checking register dump: […] ``` com 2 root@debian:~# memtool md -l 0xfd6c0700+0x800 # GPD fd6c0700: 04000702 00003060 00000000 00000000 ....`0.......... fd6c0710: 04000702 00003c61 00000000 00000000 ....a<.......... fd6c0720: 04000102 00000062 00000000 00000000 ....b........... fd6c0730: 04000702 00003063 00000010 00000000 ....c0.......... fd6c0740: 04000600 00000064 00000000 00000000 ....d........... fd6c0750: 04000600 00000065 00000000 00000000 ....e........... fd6c0760: 44000700 00000066 00000000 00000000 ...Df........... fd6c0770: 04000201 00000067 00000000 00000000 ....g........... fd6c0780: 04000700 00000068 00000000 00000000 ....h........... fd6c0790: 04000200 00000069 00000000 00000000 ....i........... fd6c07a0: 44000500 0000306a 00000000 00000000 ...Dj0.......... fd6c07b0: 44000102 0000306b 00000000 00000000 ...Dk0.......... fd6c07c0: 00000700 00000000 00000000 00000000 ................ fd6c07d0: 00000700 00000000 00000000 00000000 ................ fd6c07e0: 00000700 00000000 00000000 00000000 ................ fd6c07f0: 00000702 00000000 00000000 00000000 ................ fd6c0800: 00000700 00000000 00000000 00000000 ................ fd6c0810: 00000000 00000000 00000000 00000000 ................ fd6c0820: 00000000 00000000 00000000 00000000 ................ com 4 root@debian:~# memtool md -l 0xfd6a0700+0x800 # GPP_C fd6a0700: 44000702 0003c06e 00000000 00000000 ...Dn........... fd6a0710: 44000702 0003c06f 00000000 00000000 ...Do........... fd6a0720: 44000201 00000070 00000100 00000000 ...Dp........... fd6a0730: 44000702 00000071 00000000 00000000 ...Dq........... fd6a0740: 44000702 00000072 00000000 00000000 ...Dr........... fd6a0750: 44000300 00000073 00000000 00000000 ...Ds........... fd6a0760: 04000702 00000074 00000000 00000000 ....t........... fd6a0770: 04000702 00000075 00000000 00000000 ....u........... fd6a0780: 44000300 00000076 00000000 00000000 ...Dv........... fd6a0790: 40100102 00003077 00000000 00000000 ...@w0.......... fd6a07a0: 44000300 00000018 00000000 00000000 ...D............ fd6a07b0: 44000300 00000019 00000000 00000000 ...D............ fd6a07c0: 44000300 0000001a 00000000 00000000 ...D............ fd6a07d0: 84000201 0000001b 00000000 00000000 ................ fd6a07e0: 44000300 0000101c 00000000 00000000 ...D............ fd6a07f0: 44000300 0000001d 00000000 00000000 ...D............ fd6a0800: 44000702 0000001e 00000000 00000000 ...D............ fd6a0810: 44000702 0000001f 00000000 00000000 ...D............ fd6a0820: 44000702 00000020 00000000 00000000 ...D ........... fd6a0830: 44000702 00000021 00000000 00000000 ...D!........... fd6a0840: 44000300 00000022 00000000 00000000 ...D"........... fd6a0850: 44000300 00000023 00000000 00000000 ...D#........... fd6a0860: 84000201 00000024 00000000 00000000 ....$........... fd6a0870: 40880102 00000025 00000000 00000000 ...@%........... # GPP_F fd6a0880: 44000700 00000056 00000100 00000000 ...DV........... fd6a0890: 44000702 00003057 00000100 00000000 ...DW0.......... fd6a08a0: 44000700 00000058 00000900 00000000 ...DX........... fd6a08b0: 44000702 00003059 00000100 00000000 ...DY0.......... fd6a08c0: 44000300 0000005a 00000100 00000000 ...DZ........... fd6a08d0: 44000300 0000005b 00000100 00000000 ...D[........... fd6a08e0: 44000300 0000005c 00000100 00000000 ...D\........... fd6a08f0: 44000300 0000005d 00000000 00000000 ...D]........... fd6a0900: 44000300 0000005e 00000000 00000000 ...D^........... fd6a0910: 44000300 0000005f 00000000 00000000 ...D_........... fd6a0920: 44000300 00000060 00000000 00000000 ...D`........... fd6a0930: 44000300 00000061 00000000 00000000 ...Da........... fd6a0940: 44000300 00000062 00000000 00000000 ...Db........... fd6a0950: 44000300 00000063 00000000 00000000 ...Dc........... fd6a0960: 44000300 00000064 00000000 00000000 ...Dd........... fd6a0970: 44000300 00000065 00000000 00000000 ...De........... fd6a0980: 44000300 00000066 00000000 00000000 ...Df........... fd6a0990: 84000102 00000067 00000000 00000000 ....g........... fd6a09a0: 44000300 00000068 00000000 00000000 ...Dh........... fd6a09b0: 44000300 00000069 00000000 00000000 ...Di........... fd6a09c0: 44000300 0003c06a 00000000 00000000 ...Dj........... fd6a09d0: 44000100 0003d06b 00000000 00000000 ...Dk........... fd6a09e0: 44000300 0003c06c 00000000 00000000 ...Dl........... fd6a09f0: 44000300 0003c06d 00000000 00000000 ...Dm........... # GPPF_CLK_LOOPBK fd6a0a00: 40000f00 00000000 00000000 00000000 ...@............ ^^ # HVMOS fd6a0a10: 40000700 00000000 00000000 00000000 ...@............ fd6a0a20: 40000700 00000000 00000000 00000000 ...@............ fd6a0a30: 40000700 00000000 00000000 00000000 ...@............ fd6a0a40: 40000702 0003c000 00000000 00000000 ...@............ fd6a0a50: 40000702 0003c000 00000000 00000000 ...@............ fd6a0a60: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_E fd6a0a70: 44000300 00000026 00000000 00000000 ...D&........... fd6a0a80: 84000200 00000027 00000000 00000000 ....'........... fd6a0a90: 44000300 00000028 00000000 00000000 ...D(........... fd6a0aa0: 44000102 00001029 00000000 00000000 ...D)........... fd6a0ab0: 44000300 00000030 00000000 00000000 ...D0........... fd6a0ac0: 44000300 00000031 00000000 00000000 ...D1........... fd6a0ad0: 44000300 00000032 00000800 00000000 ...D2........... fd6a0ae0: 44000300 00000033 00000000 00000000 ...D3........... fd6a0af0: 44000300 00000034 00000000 00000000 ...D4........... fd6a0b00: 44000300 00000035 00000800 00000000 ...D5........... fd6a0b10: 44000300 00000036 00000900 00000000 ...D6........... fd6a0b20: 44000300 00000037 00000900 00000000 ...D7........... fd6a0b30: 44000300 00000038 00000000 00000000 ...D8........... fd6a0b40: 44000300 00000039 00000000 00000000 ...D9........... fd6a0b50: 44000702 0002403a 00000000 00000000 ...D:@.......... fd6a0b60: 44000100 0000103b 00000000 00000000 ...D;........... fd6a0b70: 82840102 0000003c 00000000 00000000 ....<........... fd6a0b80: 44000300 0000003d 00000000 00000000 ...D=........... fd6a0b90: 44000300 00003c3e 00000000 00000000 ...D><.......... fd6a0ba0: 44000300 00003c3f 00000000 00000000 ...D?<.......... fd6a0bb0: 40880102 00000040 00000000 00000000 ...@@........... fd6a0bc0: 44000300 00000041 00000000 00000000 ...DA........... fd6a0bd0: 44000300 00000042 00000000 00000000 ...DB........... fd6a0be0: 44000300 00000043 00000000 00000000 ...DC........... # GPPE_CLK_LOOPBK fd6a0bf0: 40000700 00000000 00000100 00000000 ...@............ ^^ # JTAG fd6a0c00: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c10: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c20: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c30: 40000702 0003fc00 00000000 00000000 ...@............ fd6a0c40: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c50: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c60: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c70: 40000700 00003c00 00000000 00000000 ...@.<.......... fd6a0c80: 40000700 00003c00 00000800 00000000 ...@.<.......... fd6a0c90: 00000000 00000000 00000000 00000000 ................ fd6a0ca0: 00000000 00000000 00000000 00000000 ................ fd6a0cb0: 00000000 00000000 00000000 00000000 ................ fd6a0cc0: 00000000 00000000 00000000 00000000 ................ fd6a0cd0: 00000000 00000000 00000000 00000000 ................ com5 root@debian:~# memtool md -l 0xfd690700+0x800 # GPP_R fd690700: 44000700 0003c058 00000000 00000000 ...DX........... fd690710: 44000700 0003fc59 00000000 00000000 ...DY........... fd690720: 44000600 0003fc5a 00000000 00000000 ...DZ........... fd690730: 44000700 0003fc5b 00000000 00000000 ...D[........... fd690740: 44000700 0003c05c 00000000 00000000 ...D\........... fd690750: 44000300 0000005d 00000000 00000000 ...D]........... fd690760: 44000300 0000005e 00000000 00000000 ...D^........... fd690770: 44000300 0000005f 00000000 00000000 ...D_........... fd690780: 40000700 0003fc00 00000800 00000000 ...@............ ^^ # SPI fd690790: 40000700 0003fc00 00000800 00000000 ...@............ fd6907a0: 40000700 0003fc00 00000800 00000000 ...@............ fd6907b0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907c0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907d0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907e0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907f0: 40000700 0003fc00 00000000 00000000 ...@............ fd690800: 40000700 00000000 00000000 00000000 ...@............ fd690810: 00000000 00000000 00000000 00000000 ................ fd690820: 00000000 00000000 00000000 00000000 ................ fd690830: 00000000 00000000 00000000 00000000 ................ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/56171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08 Gerrit-Change-Number: 56171 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 02 Jan 2022 00:57:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
by Michael Niewöhner (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 ) Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > meh, confirmed. We've seen that on other platforms already, but TGL seems to be special.... […] verified by checking register dump: ``` com0 root@debian:~# memtool md -l 0xfd6e0700+0x500 # GPP_B fd6e0700: 44000700 0003c018 00000100 00000000 ...D............ fd6e0710: 44000700 0003c019 00000100 00000000 ...D............ fd6e0720: 44000102 0000301a 00000000 00000000 ...D.0.......... fd6e0730: 80800102 0000001b 00000000 00000000 ................ fd6e0740: 44000300 0000001c 00000000 00000000 ...D............ fd6e0750: 44000300 0000001d 00000000 00000000 ...D............ fd6e0760: 44000300 0000001e 00000000 00000000 ...D............ fd6e0770: 44000300 0000001f 00000000 00000000 ...D............ fd6e0780: 44000300 00000020 00000000 00000000 ...D ........... fd6e0790: 44000300 00000021 00000000 00000000 ...D!........... fd6e07a0: 44000300 00000022 00000000 00000000 ...D"........... fd6e07b0: 04000702 00000023 00000000 00000000 ....#........... fd6e07c0: 44000700 0003c024 00000000 00000000 ...D$........... fd6e07d0: 44000700 0003c025 00000000 00000000 ...D%........... fd6e07e0: 44000200 0003c026 00000000 00000000 ...D&........... fd6e07f0: 44000300 00000027 00000000 00000000 ...D'........... fd6e0800: 44000300 00000028 00000000 00000000 ...D(........... fd6e0810: 44000300 00000029 00000000 00000000 ...D)........... fd6e0820: 44000300 0000002a 00000100 00000000 ...D*........... fd6e0830: 44000300 0000002b 00000000 00000000 ...D+........... fd6e0840: 44000300 0000002c 00000000 00000000 ...D,........... fd6e0850: 44000300 0000002d 00000000 00000000 ...D-........... fd6e0860: 44000300 0000002e 00000000 00000000 ...D............ fd6e0870: 44000200 0000002f 00000000 00000000 ...D/........... # GSPI0_CLK_LOOPBK fd6e0880: 40000700 00000000 00000000 00000000 ...@............ # GSPI1_CLK_LOOPBK fd6e0890: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_T fd6e08a0: 44000300 00000030 00000000 00000000 ...D0........... fd6e08b0: 44000300 00000031 00000000 00000000 ...D1........... fd6e08c0: 44000300 00000032 00000000 00000000 ...D2........... fd6e08d0: 44000300 00000033 00000000 00000000 ...D3........... fd6e08e0: 44000300 00000034 00000000 00000000 ...D4........... fd6e08f0: 44000300 00000035 00000000 00000000 ...D5........... fd6e0900: 44000300 00000036 00000000 00000000 ...D6........... fd6e0910: 44000300 00000037 00000000 00000000 ...D7........... fd6e0920: 44000300 00000038 00000000 00000000 ...D8........... fd6e0930: 44000300 00000039 00000000 00000000 ...D9........... fd6e0940: 44000300 0000003a 00000000 00000000 ...D:........... fd6e0950: 44000300 0000003b 00000000 00000000 ...D;........... fd6e0960: 44000300 0000003c 00000000 00000000 ...D<........... fd6e0970: 44000300 0000003d 00000000 00000000 ...D=........... fd6e0980: 44000300 0000003e 00000000 00000000 ...D>........... fd6e0990: 44000300 0000003f 00000000 00000000 ...D?........... # GPP_A fd6e09a0: 44000700 0003f040 00000100 00000000 ...D@........... fd6e09b0: 44000702 0003f041 00000100 00000000 ...DA........... fd6e09c0: 44000700 0003f042 00000100 00000000 ...DB........... fd6e09d0: 44000700 0003f043 00000100 00000000 ...DC........... fd6e09e0: 44000700 0003f044 00000100 00000000 ...DD........... fd6e09f0: 44000700 0003d045 00000100 00000000 ...DE........... fd6e0a00: 44000700 0003c046 00000100 00000000 ...DF........... fd6e0a10: 44000300 00000047 00000000 00000000 ...DG........... fd6e0a20: 44000b00 00000048 00000100 00000000 ...DH........... fd6e0a30: 44000b00 00000049 00000100 00000000 ...DI........... fd6e0a40: 44000300 0000004a 00000000 00000000 ...DJ........... fd6e0a50: 44000300 0000004b 00000000 00000000 ...DK........... fd6e0a60: 44000402 0000004c 00000000 00000000 ...DL........... fd6e0a70: 84000201 0000004d 00000000 00000000 ....M........... fd6e0a80: 44000300 0000004e 00000000 00000000 ...DN........... fd6e0a90: 44000300 0000004f 00000000 00000000 ...DO........... fd6e0aa0: 44000300 00000050 00000000 00000000 ...DP........... fd6e0ab0: 44000300 00024051 00000000 00000000 ...DQ@.......... fd6e0ac0: 44000700 00024052 00000000 00000000 ...DR@.......... fd6e0ad0: 44000300 00000053 00000000 00000000 ...DS........... fd6e0ae0: 44000300 00000054 00000000 00000000 ...DT........... fd6e0af0: 44000300 0003c055 00000000 00000000 ...DU........... fd6e0b00: 44000300 0003c056 00000000 00000000 ...DV........... fd6e0b10: 84000200 00000057 00000000 00000000 ....W........... # ESPI_CLK_LOOPBK fd6e0b20: 40000700 00000000 00000100 00000000 ...@............ ^^ fd6e0b30: 00000000 00000000 00000000 00000000 ................ fd6e0b40: 00000000 00000000 00000000 00000000 ................ fd6e0b50: 00000000 00000000 00000000 00000000 ................ fd6e0b60: 00000000 00000000 00000000 00000000 ................ fd6e0b70: 00000000 00000000 00000000 00000000 ................ fd6e0b80: 00000000 00000000 00000000 00000000 ................ fd6e0b90: 00000000 00000000 00000000 00000000 ................ fd6e0ba0: 00000000 00000000 00000000 00000000 ................ fd6e0bb0: 00000000 00000000 00000000 00000000 ................ fd6e0bc0: 00000000 00000000 00000000 00000000 ................ fd6e0bd0: 00000000 00000000 00000000 00000000 ................ fd6e0be0: 00000000 00000000 00000000 00000000 ................ fd6e0bf0: 00000000 00000000 00000000 00000000 ................ com 1 root@debian:~# memtool md -l 0xfd6d0700+0x500 # GPP_S fd6d0700: 44000300 0180006c 00000000 00000000 ...Dl........... fd6d0710: 44000300 0180006d 00000000 00000000 ...Dm........... fd6d0720: 44000300 0180006e 00000000 00000000 ...Dn........... fd6d0730: 44000300 0180006f 00000000 00000000 ...Do........... fd6d0740: 44000300 01800070 00000000 00000000 ...Dp........... fd6d0750: 44000300 01800071 00000000 00000000 ...Dq........... fd6d0760: 44000100 01800072 00000000 00000000 ...Dr........... fd6d0770: 44000100 01800073 00000000 00000000 ...Ds........... # GPP_H fd6d0780: 44000300 00001074 00000000 00000000 ...Dt........... fd6d0790: 44000300 00001075 00000000 00000000 ...Du........... fd6d07a0: 44000300 00001076 00000000 00000000 ...Dv........... fd6d07b0: 44000100 00001077 00000000 00000000 ...Dw........... fd6d07c0: 44000702 00000018 00000000 00000000 ...D............ fd6d07d0: 44000702 00000019 00000000 00000000 ...D............ fd6d07e0: 44000102 0000001a 00000000 00000000 ...D............ fd6d07f0: 44000300 0000001b 00000000 00000000 ...D............ fd6d0800: 44000100 0000101c 00000100 00000000 ...D............ fd6d0810: 44000100 0000101d 00000100 00000000 ...D............ fd6d0820: 44000300 0000001e 00000000 00000000 ...D............ fd6d0830: 44000300 0000001f 00000000 00000000 ...D............ fd6d0840: 44000300 00000020 00000000 00000000 ...D ........... fd6d0850: 44000300 00000021 00000000 00000000 ...D!........... fd6d0860: 44000300 00000022 00000000 00000000 ...D"........... fd6d0870: 44000300 00000023 00000000 00000000 ...D#........... fd6d0880: 44000700 0003c024 00000000 00000000 ...D$........... fd6d0890: 44000602 0003c025 00000000 00000000 ...D%........... fd6d08a0: 44000700 0003c026 00000000 00000000 ...D&........... fd6d08b0: 44000300 0003c027 00000000 00000000 ...D'........... fd6d08c0: 44000300 00000028 00000000 00000000 ...D(........... fd6d08d0: 44000300 00000029 00000000 00000000 ...D)........... fd6d08e0: 44000300 0000002a 00000000 00000000 ...D*........... fd6d08f0: 44000300 0000002b 00000000 00000000 ...D+........... # GPP_D fd6d0900: 44000201 0000002c 00000000 00000000 ...D,........... fd6d0910: 44000100 0000002d 00000000 00000000 ...D-........... fd6d0920: 44000100 0000102e 00000000 00000000 ...D............ fd6d0930: 44000102 0000002f 00000000 00000000 ...D/........... fd6d0940: 44000300 00000030 00000000 00000000 ...D0........... fd6d0950: 44000702 00000031 00000000 00000000 ...D1........... fd6d0960: 44000702 00000032 00000000 00000000 ...D2........... fd6d0970: 44000702 00000033 00000000 00000000 ...D3........... fd6d0980: 44000702 00000034 00000000 00000000 ...D4........... fd6d0990: 84000301 00000035 00000000 00000000 ....5........... fd6d09a0: 44000300 00000036 00000000 00000000 ...D6........... fd6d09b0: 44000100 00001037 00000000 00000000 ...D7........... fd6d09c0: 44000300 00000038 00000000 00000000 ...D8........... fd6d09d0: 44000300 00000039 00000000 00000000 ...D9........... fd6d09e0: 84000201 0000003a 00000000 00000000 ....:........... fd6d09f0: 44000300 0000003b 00000000 00000000 ...D;........... fd6d0a00: 44000300 0000003c 00000000 00000000 ...D<........... fd6d0a10: 44000100 0000003d 00000000 00000000 ...D=........... fd6d0a20: 44000102 0000003e 00000000 00000000 ...D>........... fd6d0a30: 44000300 0000003f 00000000 00000000 ...D?........... # GSPI2_CLK_LOOPBK fd6d0a40: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_U fd6d0a50: 44000300 00000040 00000000 00000000 ...D@........... fd6d0a60: 44000300 00000041 00000000 00000000 ...DA........... fd6d0a70: 44000300 00000042 00000000 00000000 ...DB........... fd6d0a80: 44000300 00000043 00000000 00000000 ...DC........... fd6d0a90: 44000300 00000044 00000000 00000000 ...DD........... fd6d0aa0: 44000300 00000045 00000000 00000000 ...DE........... fd6d0ab0: 44000300 00000046 00000000 00000000 ...DF........... fd6d0ac0: 44000300 00000047 00000000 00000000 ...DG........... fd6d0ad0: 44000300 00000048 00000000 00000000 ...DH........... fd6d0ae0: 44000300 00000049 00000000 00000000 ...DI........... fd6d0af0: 44000300 0000004a 00000000 00000000 ...DJ........... fd6d0b00: 44000300 0000004b 00000000 00000000 ...DK........... fd6d0b10: 44000300 0000004c 00000000 00000000 ...DL........... fd6d0b20: 44000300 0000004d 00000000 00000000 ...DM........... fd6d0b30: 44000300 0000004e 00000000 00000000 ...DN........... fd6d0b40: 44000300 0000004f 00000000 00000000 ...DO........... fd6d0b50: 44000300 00000050 00000000 00000000 ...DP........... fd6d0b60: 44000300 00000051 00000000 00000000 ...DQ........... fd6d0b70: 44000300 00000052 00000000 00000000 ...DR........... fd6d0b80: 44000300 00000053 00000000 00000000 ...DS........... # GSPI3_CLK_LOOPBK fd6d0b90: 40000700 00000000 00000000 00000000 ...@............ # GSPI4_CLK_LOOPBK fd6d0ba0: 40000700 00000000 00000000 00000000 ...@............ # GSPI5_CLK_LOOPBK fd6d0bb0: 40000700 00000000 00000000 00000000 ...@............ # GSPI6_CLK_LOOPBK fd6d0bc0: 40000700 00000000 00000000 00000000 ...@............ # VGPIO fd6d0bd0: 40000200 00000000 00000000 00000000 ...@............ fd6d0be0: 44000102 00000054 00000000 00000000 ...DT........... fd6d0bf0: 40000003 00000000 00000000 00000000 ...@............ fd6d0c00: 40000402 00000000 00000000 00000000 ...@............ fd6d0c10: 40000400 00000000 00000000 00000000 ...@............ fd6d0c20: 40000400 00000000 00000000 00000000 ...@............ fd6d0c30: 40000402 00000000 00000000 00000000 ...@............ fd6d0c40: 40000402 00000000 00000000 00000000 ...@............ fd6d0c50: 40000400 00000000 00000000 00000000 ...@............ fd6d0c60: 40000400 00000000 00000000 00000000 ...@............ fd6d0c70: 40000402 00000000 00000000 00000000 ...@............ fd6d0c80: 40000402 00000000 00000000 00000000 ...@............ fd6d0c90: 40000400 00000000 00000000 00000000 ...@............ fd6d0ca0: 40000400 00000000 00000000 00000000 ...@............ fd6d0cb0: 40000402 00000000 00000000 00000000 ...@............ fd6d0cc0: 40000402 00000000 00000000 00000000 ...@............ fd6d0cd0: 40000400 00000000 00000000 00000000 ...@............ fd6d0ce0: 40000400 00000000 00000000 00000000 ...@............ fd6d0cf0: 40000402 00000000 00000000 00000000 ...@............ fd6d0d00: 40000400 00000000 00000000 00000000 ...@............ fd6d0d10: 40000400 00000000 00000000 00000000 ...@............ fd6d0d20: 40000400 00000000 00000000 00000000 ...@............ fd6d0d30: 40000400 00000000 00000000 00000000 ...@............ fd6d0d40: 40000400 00000000 00000000 00000000 ...@............ fd6d0d50: 40000400 00000000 00000000 00000000 ...@............ fd6d0d60: 40000400 00000000 00000000 00000000 ...@............ fd6d0d70: 40000400 00000000 00000000 00000000 ...@............ fd6d0d80: 00000000 00000000 00000000 00000000 ................ fd6d0d90: 00000000 00000000 00000000 00000000 ................ fd6d0da0: 00000000 00000000 00000000 00000000 ................ fd6d0db0: 00000000 00000000 00000000 00000000 ................ fd6d0dc0: 00000000 00000000 00000000 00000000 ................ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/56171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6071a999be9e8a372997db0369218f297e579d08 Gerrit-Change-Number: 56171 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Wonkyu Kim Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Wonkyu Kim Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 02 Jan 2022 00:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace LLess(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60678 ) Change subject: mb/google/jecht/acpi: Replace LLess(a,b) with ASL 2.0 syntax ...................................................................... mb/google/jecht/acpi: Replace LLess(a,b) with ASL 2.0 syntax Replace `LLess(a, b)` with `a < b`. Change-Id: Id61c537cc91edbd407fb6429eb4dd2bc8bc7f123 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/60678/1 diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index 564102e..d0522ca 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -129,7 +129,7 @@ TTB2 () } } Else { - If (LLess (Local0, THERMAL_POLICY_1_THRESHOLD_OFF)) { + If (Local0 < THERMAL_POLICY_1_THRESHOLD_OFF) { TTB2 () } ElseIf (LLessEqual (Local0, THERMAL_POLICY_0_THRESHOLD_OFF)) { TTB1 () -- To view, visit https://review.coreboot.org/c/coreboot/+/60678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61c537cc91edbd407fb6429eb4dd2bc8bc7f123 Gerrit-Change-Number: 60678 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022