coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60702 ) Change subject: soc/intel/apollolake/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: Ife6ab0ded1dcf6e67535b0bf1d837ce86778de39 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/pch_hda.asl M src/soc/intel/apollolake/acpi/pcie_port.asl M src/soc/intel/apollolake/acpi/scs.asl 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/60702/1 diff --git a/src/soc/intel/apollolake/acpi/pch_hda.asl b/src/soc/intel/apollolake/acpi/pch_hda.asl index 5739dff..fa87b5a 100644 --- a/src/soc/intel/apollolake/acpi/pch_hda.asl +++ b/src/soc/intel/apollolake/acpi/pch_hda.asl @@ -39,7 +39,7 @@ * NHLT Query only supported for revision 1 and * if NHLT address and length are set in NVS. */ - If (Arg1 == 1 && LNotEqual (NHLA, Zero) && LNotEqual (NHLL, Zero)) { + If (Arg1 == 1 && NHLA != 0 && NHLL != 0) { Return (Buffer (One) { 0x03 }) } Else { diff --git a/src/soc/intel/apollolake/acpi/pcie_port.asl b/src/soc/intel/apollolake/acpi/pcie_port.asl index 5b08b7b..19f5297 100644 --- a/src/soc/intel/apollolake/acpi/pcie_port.asl +++ b/src/soc/intel/apollolake/acpi/pcie_port.asl @@ -49,7 +49,7 @@ Method (_ON, 0, Serialized) { - If (PDST == 1 && LNotEqual (\PRT0, 0)) { + If (PDST == 1 && \PRT0 != 0) { /* Enter this condition if device * is connected */ @@ -83,7 +83,7 @@ Method (_OFF, 0, Serialized) { /* Set L23_Rdy Entry Request (L23ER) */ - If (PDST == 1 && LNotEqual (\PRT0, 0)) { + If (PDST == 1 && \PRT0 != 0) { /* enter this condition if device * is connected */ diff --git a/src/soc/intel/apollolake/acpi/scs.asl b/src/soc/intel/apollolake/acpi/scs.asl index e8263a5..d57af21 100644 --- a/src/soc/intel/apollolake/acpi/scs.asl +++ b/src/soc/intel/apollolake/acpi/scs.asl @@ -118,7 +118,7 @@ Method (_INI, 0) { /* Check SDCard CD port is valid */ - If (LNotEqual (\SCDP, 0) && LNotEqual (\SCDO, 0)) + If (\SCDP != 0 && \SCDO != 0) { /* Store DW0 address of SD_CD */ Store (GDW0 (\SCDP, \SCDO), SCD0) @@ -133,7 +133,7 @@ Method (_PS0, 0, NotSerialized) { /* Check SDCard CD port is valid */ - If (LNotEqual (\SCDP, 0) && LNotEqual (\SCDO, 0)) + If (\SCDP != 0 && \SCDO != 0) { /* Store DW0 into local0 to get rxstate of GPIO */ Store (\_SB.GPC0 (SCD0), Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6ab0ded1dcf6e67535b0bf1d837ce86778de39 Gerrit-Change-Number: 60702 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60701 ) Change subject: ec/smsc/mec1308/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: Ib34dc8d84815d0885f30b3ea8ceb2fb95a833d50 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/60701/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 5aafce1..dbc08dd 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -123,7 +123,7 @@ Store (Local1, PBST[0]) // Notify if battery state has changed since last time - If (LNotEqual (Local1, BSTP)) { + If (Local1 != BSTP) { Store (Local1, BSTP) Notify (BAT0, 0x80) } @@ -133,7 +133,7 @@ // Store (SWAB (BTPR), Local1) - If (LNotEqual (Local1, 0xFFFFFFFF) && Local1 >= 0x8000) { + If (Local1 != 0xFFFFFFFF && Local1 >= 0x8000) { Xor (Local1, 0xFFFF, Local1) Local1++ } @@ -143,7 +143,7 @@ // 2: BATTERY REMAINING CAPACITY // Store (SWAB (BTRA), Local1) - If (LNotEqual (Local1, 0xFFFFFFFF) && Local1 >= 0x8000) { + If (Local1 != 0xFFFFFFFF && Local1 >= 0x8000) { Xor (Local1, 0xFFFF, Local1) Local1++ } -- To view, visit https://review.coreboot.org/c/coreboot/+/60701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib34dc8d84815d0885f30b3ea8ceb2fb95a833d50 Gerrit-Change-Number: 60701 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60700 ) Change subject: ec/lenovo/h8/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: Ic114e097a08488106554ce2dec61fa219d7cf1d0 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60700/1 diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index 48e76dc..0eeeb60 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -35,13 +35,13 @@ Method (MHKP, 0, NotSerialized) { Store (BTN, Local0) - If (LNotEqual (Local0, Zero)) { + If (Local0 != 0) { Store (Zero, BTN) Local0 += 0x1000 Return (Local0) } Store (BTAB, Local0) - If (LNotEqual (Local0, Zero)) { + If (Local0 != 0) { Store (Zero, BTAB) Local0 += 0x5000 Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic114e097a08488106554ce2dec61fa219d7cf1d0 Gerrit-Change-Number: 60700 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60699 ) Change subject: ec/google/chromeec/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: I2e0c5961fcc90c97666f49837a71f6c0bdc429b3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl M src/ec/google/chromeec/acpi/ec.asl 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/60699/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 4cc5ac4..702fbb1 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -19,7 +19,7 @@ } Store (Arg0, \_SB.PCI0.LPCB.EC0.BTID) Store (5, Local0) // Timeout 5 msec - While (LNotEqual (BTIX, Arg0)) + While (BTIX != Arg0) { Sleep (1) Local0-- @@ -29,7 +29,7 @@ } } #else - If (LNotEqual (0, Arg0)) { + If (Arg0 != 0) { Return (One) } #endif @@ -180,7 +180,7 @@ Store (Local1, Arg1[0]) // Notify if battery state has changed since last time - If (LNotEqual (Local1, DeRefOf (Arg2))) { + If (Local1 != DeRefOf (Arg2)) { Store (Local1, Arg2) If (Arg0 == 0) { Notify (BAT0, 0x80) diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 35e0e00..e28fa1a 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -494,7 +494,7 @@ Store (^PATI, Local0) /* When sensor ID returns 0xFF then no more events */ - While (LNotEqual (Local0, EC_TEMP_SENSOR_NOT_PRESENT)) + While (Local0 != EC_TEMP_SENSOR_NOT_PRESENT) { #ifdef HAVE_THERM_EVENT_HANDLER \_SB.DPTF.TEVT (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e0c5961fcc90c97666f49837a71f6c0bdc429b3 Gerrit-Change-Number: 60699 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60698 ) Change subject: drivers/intel/gma/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: Ib1b3f85f95511e903948b385e86e5102d5b43add Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/common.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/60698/1 diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 860e1a8..0d7f576 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -38,7 +38,7 @@ Notify (LCD0, 0x87) } Else { Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, 2)) + If (Local0 != 2) { Local0-- } @@ -56,7 +56,7 @@ Notify (LCD0, 0x86) } Else { Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, SizeOf(BRIG) - 1)) + If (Local0 != SizeOf(BRIG) - 1) { Local0++ } -- To view, visit https://review.coreboot.org/c/coreboot/+/60698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1b3f85f95511e903948b385e86e5102d5b43add Gerrit-Change-Number: 60698 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: sio/winbond/w83627hf/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Felix Held. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60697 ) Change subject: sio/winbond/w83627hf/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... sio/winbond/w83627hf/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: I24cf4fd70e887c14006975f494be63c34f8a75e6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/superio/winbond/w83627hf/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60697/1 diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 1e387e2..075cd11 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -422,7 +422,7 @@ ENTER_CONFIG_MODE (1) And(OPT1, 0x3, Local1) If (ACTR) { - If (LNotEqual(Local1, 2)) { + If (Local1 != 2) { Store (0x0D, Local0) } Else { Store (0x0D, Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24cf4fd70e887c14006975f494be63c34f8a75e6 Gerrit-Change-Number: 60697 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60696 ) Change subject: arch/x86/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual(a, b)` with `a != b`. Change-Id: If0e9fcea680d487c28a965e944b3333bb5a07026 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/arch/x86/acpi/globutil.asl 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/60696/1 diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index 5a21765..2ea4f96 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -78,8 +78,7 @@ Store(SLEN(Arg1), Local3) While(Local2 < Local3) { - if (LNotEqual(Derefof(Local0[Local2]), - Derefof(Local1[Local2]))) { + if (Derefof(Local0[Local2]) != Derefof(Local1[Local2])) { Return(0) } Local2++ @@ -93,7 +92,7 @@ Method(I2BM, 1) { Store(0, Local0) - if (LNotEqual(ARG0, 0)) { + if (ARG0 != 0) { Store(1, Local1) ShiftLeft(Local1, ARG0, Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0e9fcea680d487c28a965e944b3333bb5a07026 Gerrit-Change-Number: 60696 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Decrement() with ASL 2.0 syntax
by 9elements QA (Code Review) 02 Jan '22

02 Jan '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60589 ) Change subject: drivers/intel/gma/acpi: Replace Decrement() with ASL 2.0 syntax ...................................................................... Patch Set 3: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/87175 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/87174 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87173 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/87172 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87171 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/87170 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/87169 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/87168 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45c3d339652dd457cd4664ed03123eee2d7a5684 Gerrit-Change-Number: 60589 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Jan 2022 01:57:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Mod(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60695 ) Change subject: soc/intel/apollolake/acpi: Replace Mod(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Mod(a,b) with ASL 2.0 syntax Replace `Mod(a, b)` with `a % b`. Change-Id: I261bae12558e07b0a5523f16f1750be6bb3b5555 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/scs.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60695/1 diff --git a/src/soc/intel/apollolake/acpi/scs.asl b/src/soc/intel/apollolake/acpi/scs.asl index 840cfbe..e8263a5 100644 --- a/src/soc/intel/apollolake/acpi/scs.asl +++ b/src/soc/intel/apollolake/acpi/scs.asl @@ -125,7 +125,7 @@ /* Get the current SD_CD ownership */ Store (\_SB.GHO (\SCDP, \SCDO), Local0) /* Set host ownership as GPIO in HOSTSW_OWN reg */ - Or (Local0, ShiftLeft (1, Mod (\SCDO, 32)), Local0) + Or (Local0, ShiftLeft (1, \SCDO % 32), Local0) \_SB.SHO (\SCDP, \SCDO, Local0) } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I261bae12558e07b0a5523f16f1750be6bb3b5555 Gerrit-Change-Number: 60695 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60694 ) Change subject: mb/google/jecht/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... mb/google/jecht/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: I56e8fdb2503a84ded2bcf183402602579c3f2997 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/60694/1 diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0 // Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) } @@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0 // Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) } @@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index e608ae4..84aea6f 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -77,7 +77,7 @@ Local1 = 255 - Local0 // Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) } @@ -94,7 +94,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index d0522ca..3aa8fc3 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -117,13 +117,13 @@ } If (LEqual (THTB, 2)) { - If (LGreaterEqual (Local0, THERMAL_POLICY_0_THRESHOLD_ON)) { + If (Local0 >= THERMAL_POLICY_0_THRESHOLD_ON) { TTB0 () - } ElseIf (LGreaterEqual (Local0, THERMAL_POLICY_1_THRESHOLD_ON)) { + } ElseIf (Local0 >= THERMAL_POLICY_1_THRESHOLD_ON) { TTB1 () } } ElseIf (LEqual (THTB, 1)) { - If (LGreaterEqual (Local0, THERMAL_POLICY_0_THRESHOLD_ON)) { + If (Local0 >= THERMAL_POLICY_0_THRESHOLD_ON) { TTB0 () } ElseIf (LLessEqual (Local0, THERMAL_POLICY_1_THRESHOLD_OFF)) { TTB2 () @@ -185,7 +185,7 @@ Local1 = 255 - Local0 // Handle values greater than Tj_max - If (LGreaterEqual (Local1, \TMAX)) { + If (Local1 >= \TMAX) { Return (CTOK (\TMAX)) } @@ -202,7 +202,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TMAX), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll -- To view, visit https://review.coreboot.org/c/coreboot/+/60694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56e8fdb2503a84ded2bcf183402602579c3f2997 Gerrit-Change-Number: 60694 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022