Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60689 )
Change subject: ec/smsc/mec1308/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83d7fe29d112ba0ed0f72798f2b5436ecf0a6a2
Gerrit-Change-Number: 60689
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:49:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60691 )
Change subject: ec/quanta/it8518/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60691
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99cc4cf08ad74f2cb84e0ad16e615e03bbf388af
Gerrit-Change-Number: 60691
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:49:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60692 )
Change subject: mb/google/slippy/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c16893b9c98f36fd2c210ed301c2ebb65f95368
Gerrit-Change-Number: 60692
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:49:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60693 )
Change subject: mb/google/kahlee/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60693
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7975a8cad4078a523de2466919982ad540f5dd3
Gerrit-Change-Number: 60693
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:49:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60669 )
Change subject: ec/smsc/mec1308/acpi: Replace LEqual(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60669
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic58e22046aa13549747692f4b21184cf573aa4d3
Gerrit-Change-Number: 60669
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:47:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 )
Change subject: ec/starlabs/merlin: Apply EC settings when suspending
......................................................................
Patch Set 6:
(2 comments)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/57f04fc8_8cd8f10b
PS6, Line 9: /* Store current EC settings */
Suggest amending the comment to /* Store current EC settings in CMOS */ to remove any ambiguity about where they are going.
https://review.coreboot.org/c/coreboot/+/60165/comment/9777d3b7_55e74544
PS6, Line 10: \_SB.PCI0.LPCB.TPLS = \_SB.PCI0.LPCB.EC.TPLA
It would make the code more obvious if the names of the ECRAM and corresponding CMOS entries were given the same names.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf
Gerrit-Change-Number: 60165
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60672 )
Change subject: ec/smsc/mec1308/acpi: Replace LLess(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60672
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96cf05f575a2868b2ad0c00fd5486d6e2c5d90a
Gerrit-Change-Number: 60672
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:47:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60673 )
Change subject: ec/quanta/it8518/acpi: Replace LLess(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1fe60116645d0cdad9e7ac600bc1062b54b40d
Gerrit-Change-Number: 60673
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:47:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60671 )
Change subject: ec/quanta/ene_kb3940q/acpi: Replace LLess(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic04ce82fbfd36bbd2e0cfda1a92ca0a18e1fcd73
Gerrit-Change-Number: 60671
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:46:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60678 )
Change subject: mb/google/jecht/acpi: Replace LLess(a,b) with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id61c537cc91edbd407fb6429eb4dd2bc8bc7f123
Gerrit-Change-Number: 60678
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Sun, 02 Jan 2022 08:46:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment