coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz
by 9elements QA (Code Review) 02 Jan '22

02 Jan '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60301 ) Change subject: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz ...................................................................... Patch Set 11: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/87148 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/87147 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87146 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/87145 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87144 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/87143 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/87142 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/87141 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34 Gerrit-Change-Number: 60301 Gerrit-PatchSet: 11 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Jan 2022 01:27:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60693 ) Change subject: mb/google/kahlee/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... mb/google/kahlee/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: Id7975a8cad4078a523de2466919982ad540f5dd3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/60693/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl index 81fe434..ebf7641 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -55,7 +55,7 @@ /* Critical temperature in deci-kelvin */ Store (CTOK (\TCRT), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) /* Wait 1 second for EC to re-poll */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7975a8cad4078a523de2466919982ad540f5dd3 Gerrit-Change-Number: 60693 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/slippy/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60692 ) Change subject: mb/google/slippy/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... mb/google/slippy/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: I5c16893b9c98f36fd2c210ed301c2ebb65f95368 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/slippy/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/60692/1 diff --git a/src/mainboard/google/slippy/acpi/thermal.asl b/src/mainboard/google/slippy/acpi/thermal.asl index e01195f..bb90ae2 100644 --- a/src/mainboard/google/slippy/acpi/thermal.asl +++ b/src/mainboard/google/slippy/acpi/thermal.asl @@ -102,7 +102,7 @@ // Critical temperature in deci-kelvin Store (CTOK (\TCRT), Local1) - If (LGreaterEqual (Local0, Local1)) { + If (Local0 >= Local1) { Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for EC to re-poll -- To view, visit https://review.coreboot.org/c/coreboot/+/60692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c16893b9c98f36fd2c210ed301c2ebb65f95368 Gerrit-Change-Number: 60692 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60691 ) Change subject: ec/quanta/it8518/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: I99cc4cf08ad74f2cb84e0ad16e615e03bbf388af Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/60691/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 5fa9502..67843fd3 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -261,7 +261,7 @@ // 1: BATTERY PRESENT RATE/CURRENT // Store (ECAC, Local1) - If (LGreaterEqual (Local1, 0x8000)) + If (Local1 >= 0x8000) { If (And (Local0, 1)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I99cc4cf08ad74f2cb84e0ad16e615e03bbf388af Gerrit-Change-Number: 60691 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60690 ) Change subject: ec/google/chromeec/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: I72875f68e143f9384c91588cd453d2987fda526d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/60690/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 253ab8e..4cc5ac4 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -14,7 +14,7 @@ If (BTIX == Arg0) { Return (Zero) } - If (LGreaterEqual (Arg0, BTCN)) { + If (Arg0 >= BTCN) { Return (One) } Store (Arg0, \_SB.PCI0.LPCB.EC0.BTID) -- To view, visit https://review.coreboot.org/c/coreboot/+/60690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72875f68e143f9384c91588cd453d2987fda526d Gerrit-Change-Number: 60690 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60689 ) Change subject: ec/smsc/mec1308/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: If83d7fe29d112ba0ed0f72798f2b5436ecf0a6a2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/60689/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index e30c005..5aafce1 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -133,7 +133,7 @@ // Store (SWAB (BTPR), Local1) - If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { + If (LNotEqual (Local1, 0xFFFFFFFF) && Local1 >= 0x8000) { Xor (Local1, 0xFFFF, Local1) Local1++ } @@ -143,7 +143,7 @@ // 2: BATTERY REMAINING CAPACITY // Store (SWAB (BTRA), Local1) - If (LNotEqual (Local1, 0xFFFFFFFF) && LGreaterEqual (Local1, 0x8000)) { + If (LNotEqual (Local1, 0xFFFFFFFF) && Local1 >= 0x8000) { Xor (Local1, 0xFFFF, Local1) Local1++ } -- To view, visit https://review.coreboot.org/c/coreboot/+/60689 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If83d7fe29d112ba0ed0f72798f2b5436ecf0a6a2 Gerrit-Change-Number: 60689 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 sy...
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60688 ) Change subject: soc/intel/cannonlake/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace LGreaterEqual(a,b) with ASL 2.0 syntax Replace `LGreaterEqual(a, b)` with `a >= b`. Change-Id: Ic9836acb4d32f2ce30c3c6d488bc22ddc64bf365 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl M src/soc/intel/cannonlake/acpi/scs.asl 3 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/60688/1 diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index 265bcfb..d16c67a 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -61,31 +61,31 @@ Method (GADD, 1, NotSerialized) { /* GPIO Community 0 */ - If (LGreaterEqual (Arg0, GPP_A0) && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) + If (Arg0 >= GPP_A0 && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) { Store (PID_GPIOCOM0, Local0) Local1 = Arg0 - GPP_A0 } /* GPIO Community 1 */ - If (LGreaterEqual (Arg0, GPP_D0) && LLessEqual (Arg0, vSD3_CD_B)) + If (Arg0 >= GPP_D0 && LLessEqual (Arg0, vSD3_CD_B)) { Store (PID_GPIOCOM1, Local0) Local1 = Arg0 - GPP_D0 } /* GPIO Community 2 */ - If (LGreaterEqual (Arg0, GPD0) && LLessEqual (Arg0, DRAM_RESET_B)) + If (Arg0 >= GPD0 && LLessEqual (Arg0, DRAM_RESET_B)) { Store (PID_GPIOCOM2, Local0) Local1 = Arg0 - GPD0 } /* GPIO Community 3 */ - If (LGreaterEqual (Arg0, HDA_BCLK) && LLessEqual (Arg0, TRIGGER_OUT)) + If (Arg0 >= HDA_BCLK && LLessEqual (Arg0, TRIGGER_OUT)) { Store (PID_GPIOCOM3, Local0) Local1 = Arg0 - HDA_BCLK } /* GPIO Community 4*/ - If (LGreaterEqual (Arg0, GPP_C0) && LLessEqual (Arg0, CL_RST_B)) + If (Arg0 >= GPP_C0 && LLessEqual (Arg0, CL_RST_B)) { Store (PID_GPIOCOM4, Local0) Local1 = Arg0 - GPP_C0 diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index f60fd56..495069d 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -67,25 +67,25 @@ Method (GADD, 1, NotSerialized) { /* GPIO Community 0 */ - If (LGreaterEqual (Arg0, GPP_A0) && LLessEqual (Arg0, GSPI1_CLK_LOOPBK)) + If (Arg0 >= GPP_A0 && LLessEqual (Arg0, GSPI1_CLK_LOOPBK)) { Store (PID_GPIOCOM0, Local0) Local1 = Arg0 - GPP_A0 } /* GPIO Community 1 */ - If (LGreaterEqual (Arg0, GPP_C0) && LLessEqual (Arg0, vSSP2_RXD)) + If (Arg0 >= GPP_C0 && LLessEqual (Arg0, vSSP2_RXD)) { Store (PID_GPIOCOM1, Local0) Local1 = Arg0 - GPP_C0 } /* GPIO Community 3*/ - If (LGreaterEqual (Arg0, GPP_K0) && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) + If (Arg0 >= GPP_K0 && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) { Store (PID_GPIOCOM3, Local0) Local1 = Arg0 - GPP_K0 } /* GPIO Community 4*/ - If (LGreaterEqual (Arg0, HDACPU_SDI) && LLessEqual (Arg0, GPP_J11)) + If (Arg0 >= HDACPU_SDI && LLessEqual (Arg0, GPP_J11)) { Store (PID_GPIOCOM4, Local0) Local1 = Arg0 - GPP_I0 diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index 4c01b48..81f3d18 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -75,7 +75,7 @@ { If (Arg0 == ^DSUU) { /* Check the revision */ - If (LGreaterEqual (Arg1, Zero)) { + If (Arg1 >= 0) { /* * Function Index 0 the return value is a buffer * containing one bit for each function index, starting @@ -148,7 +148,7 @@ { If (Arg0 == ^DSUU) { /* Check the revision */ - If (LGreaterEqual (Arg1, Zero)) { + If (Arg1 >= 0) { /* * Function Index 0 the return value is a buffer containing * one bit for each function index, starting with zero. -- To view, visit https://review.coreboot.org/c/coreboot/+/60688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9836acb4d32f2ce30c3c6d488bc22ddc64bf365 Gerrit-Change-Number: 60688 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace Decrement() with ASL 2.0 syntax
by 9elements QA (Code Review) 02 Jan '22

02 Jan '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60586 ) Change subject: mb/aopen/dxplplusu/acpi: Replace Decrement() with ASL 2.0 syntax ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/87130 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/87129 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87128 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/87127 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/87126 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/87125 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/87124 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/87123 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4320d86ce91e7070dc10fcefff6cbc0956be9788 Gerrit-Change-Number: 60586 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Jan 2022 01:15:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60687 ) Change subject: arch/x86/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: I0cabf4f69191fe345fd72619847db384db2e0e87 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/arch/x86/acpi/debug.asl M src/arch/x86/acpi/globutil.asl 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/60687/1 diff --git a/src/arch/x86/acpi/debug.asl b/src/arch/x86/acpi/debug.asl index e13bde0..ed1c60d 100644 --- a/src/arch/x86/acpi/debug.asl +++ b/src/arch/x86/acpi/debug.asl @@ -134,10 +134,10 @@ { /* DINI() */ if (ObjectType(Arg0) == 1) { - if (LGreater(Arg0, 0xffff)) { + if (Arg0 > 0xffff) { DBGD(Arg0) } else { - if (LGreater(Arg0, 0xff)) { + if (Arg0 > 0xff) { DBGW(Arg0) } else { DBGB(Arg0) diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index 18ea9c9..5a21765 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -43,7 +43,7 @@ While(Local4 < Local7) { Store(Derefof(Local0[Local4]), Local2) Store(Derefof(Local1[Local4]), Local3) - if (LGreater(Local2, Local3)) { + if (Local2 > Local3) { Return(One) } else { if (Local2 < Local3) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cabf4f69191fe345fd72619847db384db2e0e87 Gerrit-Change-Number: 60687 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace LGreater(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 02 Jan '22

02 Jan '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60686 ) Change subject: mb/aopen/dxplplusu/acpi: Replace LGreater(a,b) with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace LGreater(a,b) with ASL 2.0 syntax Replace `LGreater(a, b)` with `a > b`. Change-Id: If482b2ad4ba7d4ed1ca8c0695690ede153ed1e2a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/60686/1 diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index f8c7b2e..aab3271 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -38,7 +38,7 @@ And (\_SB.PCI0.RLAR, 0x03FF, Local1) Local1++ - If (LGreater (Local1, 0x40)) + If (Local1 > 0x40) { ShiftLeft (Local1, 0x1A, LELM) } @@ -50,7 +50,7 @@ And (\_SB.PCI0.TOLM, 0xF800, Local1) ShiftRight (Local1, 0x04, Local1) Local1-- - If (LGreater (Local1, 0x10)) + If (Local1 > 0x10) { Local1 -= 0x0F Store (ShiftLeft (Local1, 0x14), MEM2) -- To view, visit https://review.coreboot.org/c/coreboot/+/60686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If482b2ad4ba7d4ed1ca8c0695690ede153ed1e2a Gerrit-Change-Number: 60686 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022