coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/volteer/lindar: Probe for RT1011_ALC5682I_I2S
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Felix Singer, Paul Menzel, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60327 ) Change subject: mb/google/volteer/lindar: Probe for RT1011_ALC5682I_I2S ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60327/comment/392758d0_58ce6676 PS1, Line 10: being `to be disabled` Patchset: PS1: > Tim, is there a corresponding commit in the Chromium repositories? No, I actually think this is an oversight... Lindar is the only volteer variant to use this audio option, so it may have been missed. AP firmware for ChromeOS devices has its own stable branch that no longer tracks master past a certain point (volteer devices are long past this point), so production firmware will only come from that branch now. On the branch, the UPDs are set up so that the DSP will be enabled (PchHdaDspEnable), but the HD audio device will not; because of this, I suspect this is mostly a resource (read: PCI resources) issue which will be corrected by the kernel, as the UPDs seem to require HDA to be enabled b/c of the DSP. Felix, could you post logs before and after this? also lspci before and after? -- To view, visit https://review.coreboot.org/c/coreboot/+/60327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib848b65b4939dd43d78cb7fd7b8b271e95f324be Gerrit-Change-Number: 60327 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:33:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]src: Remove unused <symbols.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60715 ) Change subject: [WIP]src: Remove unused <symbols.h> ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/60715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc8c252255b941a7c91346628d02d697bc510981 Gerrit-Change-Number: 60715 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: update USB 2.0 controller Lane Para...
by Rob Barnes (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Kevin Chiu, Martin Roth - Personal, Bhanu Prakash Maiya, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60089 ) Change subject: mb/google/guybrush/var/nipperkin: update USB 2.0 controller Lane Parameter ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5a6563e93bfa6beb529a5593fcc9124ce62d77f Gerrit-Change-Number: 60089 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60645 ) Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I rebased the patches so that all related follow each other and in preparation to build-test them. -- To view, visit https://review.coreboot.org/c/coreboot/+/60645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2a0b13522761e7113d1dc5b78d0dfd19a6cfd94 Gerrit-Change-Number: 60645 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:23:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by Karthik Ramasubramanian (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: V sujith kumar Reddy, Raul Rangel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60072/comment/ab819ce1_2a489983 PS5, Line 10: soi3 Nit: S0i3 https://review.coreboot.org/c/coreboot/+/60072/comment/8603e73e_5decb924 PS5, Line 11: Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Nit: Please leave a blank line between line 10 and line 11 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 5 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Allow installing to a build root
by Tim Crawford (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Paul Menzel. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60540 ) Change subject: util: Allow installing to a build root ...................................................................... Patch Set 2: (1 comment) File util/ectool/Makefile: https://review.coreboot.org/c/coreboot/+/60540/comment/6fe1db90_db08edf6 PS1, Line 8: PREFIX ?= /usr/local > Actually that is a GNU extension, and not really needed [1], as it can be overridden by: […] Dropped the change. -- To view, visit https://review.coreboot.org/c/coreboot/+/60540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Gerrit-Change-Number: 60540 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:17:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Allow installing to a build root
by Tim Crawford (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Tim Crawford. Hello Felix Singer, build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60540 to look at the new patch set (#2). Change subject: util: Allow installing to a build root ...................................................................... util: Allow installing to a build root Modify util Makefiles to allow installing to a build root specified by DESTDIR. Allows using the `install` target for packaging. Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M util/ectool/Makefile M util/pmh7tool/Makefile M util/spkmodem_recv/Makefile 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/60540/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Gerrit-Change-Number: 60540 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/starlabs/merlin: Apply EC settings when suspending
by Sean Rhodes (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Andy Pont, Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 ) Change subject: ec/starlabs/merlin: Apply EC settings when suspending ...................................................................... Patch Set 13: (1 comment) File src/ec/starlabs/merlin/acpi/suspend.asl: https://review.coreboot.org/c/coreboot/+/60165/comment/37afe5e5_19a096a0 PS12, Line 10: \_SB.PCI0.LPCB.TPLC = \_SB.PCI0.LPCB.EC.TPLE > Can you please elaborate in the commit message, why the assignment was switched? So before, the valu […] Done, and yes they were. -- To view, visit https://review.coreboot.org/c/coreboot/+/60165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf Gerrit-Change-Number: 60165 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Apply EC settings when suspending
by Sean Rhodes (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Sean Rhodes, Andy Pont. Hello build bot (Jenkins), Andy Pont, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60165 to look at the new patch set (#13). Change subject: ec/starlabs/merlin: Apply EC settings when suspending ...................................................................... ec/starlabs/merlin: Apply EC settings when suspending Currently, the settings from CMOS were written to the EC, which was pointless. Now, when suspending, the EC values are stored in CMOS when suspending and subsequently restored when waking. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/60165/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/60165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf Gerrit-Change-Number: 60165 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/taeko: Run-time probe for NVMe SSD and MMC
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Joey Peng, Kevin Chang, Paul Menzel, YH Lin. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60341 ) Change subject: mb/google/brya/var/taeko: Run-time probe for NVMe SSD and MMC ...................................................................... Patch Set 13: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60341/comment/25ed075b_ddaa800f PS13, Line 9: Taeko will use two PCIE port signals with one slot, one CLK and one mention this is for the next build phase (so we understand why it won't apply to taeko4es) https://review.coreboot.org/c/coreboot/+/60341/comment/b2ef7752_d31e9137 PS13, Line 14: Test on takeo trace in FSP log can find the correct root ports have : been set depending on CBI. ``` Build FSP with debug output enabled, and observe the correct root ports being initialized depending on the FW_CONFIG values for BOOT_EMMC and BOOT_NVME. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/60341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4486f23ea02374c84a9b1ce04f568d78aeabd573 Gerrit-Change-Number: 60341 Gerrit-PatchSet: 13 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 17:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022