coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: src/mainboard: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60607 to look at the new patch set (#2). Change subject: src/mainboard: Remove unused <delay.h> ...................................................................... src/mainboard: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: I50fcbb16895662c7451fec1569a8a61398792531 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bobba/variant.c M src/mainboard/google/octopus/variants/dood/variant.c M src/mainboard/google/octopus/variants/garg/variant.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/60607/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50fcbb16895662c7451fec1569a8a61398792531 Gerrit-Change-Number: 60607 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/drivers: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60608 to look at the new patch set (#2). Change subject: src/drivers: Remove unused <delay.h> ...................................................................... src/drivers: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: Ifda7b3a798c8b1736e125b2527f95e697951d7bd Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/aspeed/common/ast_main.c M src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/60608/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifda7b3a798c8b1736e125b2527f95e697951d7bd Gerrit-Change-Number: 60608 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/ec: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60609 to look at the new patch set (#2). Change subject: src/ec: Remove unused <delay.h> ...................................................................... src/ec: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: Id3b79789c66e68aa06c63467f4733adecfee24ec Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/ec/kontron/kempld/kempld_gpio.c M src/ec/starlabs/merlin/ec.c 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60609/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3b79789c66e68aa06c63467f4733adecfee24ec Gerrit-Change-Number: 60609 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/lib: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60610 to look at the new patch set (#2). Change subject: src/lib: Remove unused <delay.h> ...................................................................... src/lib: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: I6fb603a17534e3a1593cb421c618f8119933292a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/lib/dp_aux.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/60610/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fb603a17534e3a1593cb421c618f8119933292a Gerrit-Change-Number: 60610 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/soc/qualcomm: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60602 to look at the new patch set (#2). Change subject: src/soc/qualcomm: Remove unused <delay.h> ...................................................................... src/soc/qualcomm: Remove unused <delay.h> Found using: diff <(git grep -l '#include <delay.h>' -- src/) <(git grep -l 'get_timer_fsb(\|init_timer(\|udelay(\|mdelay(\|delay(' -- src/) |grep "<" Change-Id: Id1e0f4cb9f6181dc2fc45e7b6cb149646111bb3e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/sc7180/clock.c M src/soc/qualcomm/sc7180/display/dsi_phy_pll.c M src/soc/qualcomm/sc7180/display/mdss.c M src/soc/qualcomm/sc7280/clock.c M src/soc/qualcomm/sc7280/cpucp_load_reset.c 5 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/60602/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1e0f4cb9f6181dc2fc45e7b6cb149646111bb3e Gerrit-Change-Number: 60602 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/southbridge: Remove unused <delay.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 ) Change subject: libpayload: Implement new CBFS access API ...................................................................... Patch Set 15: (4 comments) File payloads/libpayload/Kconfig: https://review.coreboot.org/c/coreboot/+/59497/comment/4075b6cb_dba39aff PS8, Line 211: config CBFS > I mean they're still in the same menu in menuconfig (since you're including libcbfs/Kconfig right he […] Done File payloads/libpayload/include/cbfs_glue.h: https://review.coreboot.org/c/coreboot/+/59497/comment/86b91ff9_ae406fd8 PS3, Line 38: { > Not quite sure what you mean by "before". If I recall correctly, there was an issue with this in cbfs_walk() some time ago. I was trying to fix it, but you were faster in CB:57271 Regarding the bounds checks: After thinking about this, I came to the conclusion, that checks you proposed should be enough. Cases covered in this function should not be bound to the device, so offset + size overflow and too large request should be handled here. Other cases will belong to the boot_device_read() function. File payloads/libpayload/libcbfs/Kconfig: https://review.coreboot.org/c/coreboot/+/59497/comment/3032795b_6421b0c4 PS8, Line 16: RO (COREBOOT) region if it isn't available in the active RW region. > This should mention that this only makes sense if CONFIG_VBOOT is enabled in coreboot. […] Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/259417b6_de41cf7c PS8, Line 111: ERROR("Buffer allocation failed"); > nit: would be nice to add mdata->h. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 15 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 15:58:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] drivers/intel/fsp2_0: Add support for FSP_NON_VOLATILE_STORAGE_...
by Subrata Banik (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Anil Kumar K, Tim Wawrzynczak, Paul Menzel, Andrey Petrov, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 ) Change subject: [WIP] drivers/intel/fsp2_0: Add support for FSP_NON_VOLATILE_STORAGE_HOB2 ...................................................................... Patch Set 19: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59638/comment/6606c6a1_8d10112f PS19, Line 8: please add a detailed commit msg File src/drivers/intel/fsp2_0/include/fsp/util.h: https://review.coreboot.org/c/coreboot/+/59638/comment/7341c463_463ff5ab PS19, Line 31: uint64_t can you please consider adding EFI_PHYSICAL_ADDRESS as typedef in a separate CL then adding efi_physical_address datatype here to maintain the FSP spec type as is. https://github.com/coreboot/coreboot/blob/master/src/include/efi/efi_dataty… -- To view, visit https://review.coreboot.org/c/coreboot/+/59638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e Gerrit-Change-Number: 59638 Gerrit-PatchSet: 19 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 15:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/superio: Remove unused <acpi/acpi.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

1 0

Change in coreboot[master]: src/cpu/intel: Remove unused <acpi/acpi.h>
by HAOUAS Elyes (Code Review) 03 Jan '22

03 Jan '22

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022