coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: ifdtool: dump all PCH Straps
by Thomas Heijligen (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Paul Menzel. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25296 ) Change subject: ifdtool: dump all PCH Straps ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Can this be submitted or rebased? I'll take a closer look at it again, but I think this patch got obsolete. https://review.coreboot.org/c/coreboot/+/41693 -- To view, visit https://review.coreboot.org/c/coreboot/+/25296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56c02c00923e018bbd6a0409a08715f39b854d0a Gerrit-Change-Number: 25296 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 21:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Frank Chu, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 ) Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d Gerrit-Change-Number: 60415 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 21:33:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/taeko:Remove duplicate DB_SD fw_config fields.
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60409 ) Change subject: mb/google/brya/var/taeko:Remove duplicate DB_SD fw_config fields. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7814c35f63fd6fa27195d448c4d51fc980aaa9c Gerrit-Change-Number: 60409 Gerrit-PatchSet: 2 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Jan 2022 21:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... mb/google/dedede/var/bugzzy: Initialize display signals on user mode Bugzzy uses panel-built-in touch screen, it needs to set panel power and reset signal to high for touch screen to work. On user mode, coreboot doesn't initialize graphics since there is no screen display before OS. So we would add a WA to initialize required signals on user mode. It takes under 30 ms delay on booting time. BUG=b:205496327 BRANCH=dedede TEST=Verified touch screen worked with test coreboot and test touch screen 028D firmware Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Reviewed-on: https://review.coreboot.org/c/coreboot/+/60190 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/dedede/variants/bugzzy/Makefile.inc A src/mainboard/google/dedede/variants/bugzzy/ramstage.c 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/dedede/variants/bugzzy/Makefile.inc b/src/mainboard/google/dedede/variants/bugzzy/Makefile.inc index fd60a18..7412194 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/Makefile.inc +++ b/src/mainboard/google/dedede/variants/bugzzy/Makefile.inc @@ -1,5 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ramstage-y += gpio.c +ramstage-y += ramstage.c smm-y += variant.c diff --git a/src/mainboard/google/dedede/variants/bugzzy/ramstage.c b/src/mainboard/google/dedede/variants/bugzzy/ramstage.c new file mode 100644 index 0000000..7844b6e --- /dev/null +++ b/src/mainboard/google/dedede/variants/bugzzy/ramstage.c @@ -0,0 +1,59 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <bootstate.h> +#include <arch/mmio.h> +#include <delay.h> +#include <bootmode.h> +#include <device/device.h> +#include <device/pci.h> +#include <soc/pci_devs.h> +#include <drivers/intel/gma/i915_reg.h> + +static void panel_power_on(uintptr_t igd_bar) +{ + setbits32((void *)(igd_bar + PCH_PP_CONTROL), PANEL_POWER_ON); +} + +static void panel_reset_assert(uintptr_t igd_bar) +{ + clrsetbits32((void *)(igd_bar + PCH_GPIOB), + GPIO_CLOCK_VAL_OUT, + GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK); +} + +static void panel_reset_deassert(uintptr_t igd_bar) +{ + const uint32_t data32 = GPIO_CLOCK_VAL_OUT | + GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK; + setbits32((void *)(igd_bar + PCH_GPIOB), data32); +} + +/* + * Bugzzy uses panel-built-in touch screen, it needs to set panel power and + * reset signal to high for touch screen to work. + * On user mode, coreboot doesn't initialize graphics since there is no screen + * display before OS. We would add this WA to initialize required signals on + * user mode. + */ +static void wa_init_display_signal(void *unused) +{ + struct device *igd_dev = pcidev_path_on_root(SA_DEVFN_IGD); + uintptr_t igd_bar; + + if (display_init_required() || !igd_dev) + return; + + igd_bar = find_resource(igd_dev, PCI_BASE_ADDRESS_0)->base; + if (!igd_bar) + return; + + panel_power_on(igd_bar); + mdelay(20); + panel_reset_deassert(igd_bar); + mdelay(2); + panel_reset_assert(igd_bar); + mdelay(2); + panel_reset_deassert(igd_bar); +} + +BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_ENTRY, wa_init_display_signal, NULL); -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 15 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Tim Wawrzynczak (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: shkim, Henry Sun, Evan Green, SH Kim, Paul Menzel, Simon Yang, Edward Doan. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 14 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Comment-Date: Mon, 03 Jan 2022 21:14:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool.h: util/ifdtool.c: Add additional regions for platforms...
by build bot (Jenkins) (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Name of user not set #1004065, Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60729 ) Change subject: util/ifdtool.h: util/ifdtool.c: Add additional regions for platforms that support them. Add Denverton platform support. ...................................................................... Patch Set 1: (1 comment) File util/ifdtool/ifdtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137105): https://review.coreboot.org/c/coreboot/+/60729/comment/c8e20316_f9728581 PS1, Line 43: { "Device Expansion 1", "devexp", "flashregion_5_device_expansion.bin", "SI_DEV_EXP1" }, line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/60729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8a4f26d833b1e628b7a72518d0a27252ec62f7c Gerrit-Change-Number: 60729 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004065 Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Name of user not set #1004065 Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Jan 2022 20:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware
by Matt DeVillier (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak, Angel Pons. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60735 ) Change subject: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Where are the VBTs in the Chromium repositories? not in a public repo unfortunately PS1: might as well add for ARCADA too, and then select INTEL_GMA_HAVE_VBT in Kconfig -- To view, visit https://review.coreboot.org/c/coreboot/+/60735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 Gerrit-Change-Number: 60735 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jan 2022 20:41:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware
by Paul Menzel (Code Review) 03 Jan '22

03 Jan '22

Attention is currently required from: Felix Singer, Matt DeVillier, Tim Wawrzynczak, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60735 ) Change subject: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Where are the VBTs in the Chromium repositories? -- To view, visit https://review.coreboot.org/c/coreboot/+/60735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 Gerrit-Change-Number: 60735 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jan 2022 20:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in blobs[master]: mb/google/sarien: Add VBT from Chromebook firmware
by Paul Menzel (Code Review) 03 Jan '22

03 Jan '22

Paul Menzel has abandoned this change. ( https://review.coreboot.org/c/blobs/+/60734 ) Change subject: mb/google/sarien: Add VBT from Chromebook firmware ...................................................................... Abandoned It’s config data and not a blob, so add it to the coreboot repository https://review.coreboot.org/q/Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 (https://review.coreboot.org/c/coreboot/+/60735). -- To view, visit https://review.coreboot.org/c/blobs/+/60734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ie67ae2ac210bd9b486057d32d18ac348f5335638 Gerrit-Change-Number: 60734 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware
by Paul Menzel (Code Review) 03 Jan '22

03 Jan '22

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60735 ) Change subject: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware ...................................................................... mb/google/sarien/var/sarien: Add VBT from Chromebook firmware Extracted from Chromium OS in developer mode with the device running firwmare . $ sudo dmesg | grep ' DMI:' [ 0.000000] DMI: Dell Inc. Sarien/Sarien, BIOS Google_Sarien.12200.99.0 07/29/2020 $ sudo cbmem -1 coreboot-v1.9308_26_0.0.22-8761-gdba94f429a Wed Jul 29 16:09:30 UTC 2020 bootblock starting (log level: 8)... […] coreboot-v1.9308_26_0.0.22-8761-gdba94f429a Wed Jul 29 16:09:30 UTC 2020 ramstage starting (log level: 8)... […] CBFS: Locating 'vbt.bin' CBFS: Found @ offset 614c0 size 4a0 Found a VBT of 4608 bytes after decompression […] $ sudo cp /sys/kernel/debug/dri/0/i915_vbt vbt.bin Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- A src/mainboard/google/sarien/variants/sarien/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/60735/1 diff --git a/src/mainboard/google/sarien/variants/sarien/data.vbt b/src/mainboard/google/sarien/variants/sarien/data.vbt new file mode 100644 index 0000000..f9c498e --- /dev/null +++ b/src/mainboard/google/sarien/variants/sarien/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/60735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 Gerrit-Change-Number: 60735 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022