coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
by Kangheui Won (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Subrata Banik, Reka Norman, Paul Menzel, Nick Vaccaro. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 ) Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Gerrit-Change-Number: 60271 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 02:14:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR
by Zhi7 Li (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Paul Menzel. Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60337 ) Change subject: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60337/comment/cc0f1fe9_26f82d19 PS3, Line 10: for the memory parts. The memory parts being added are: : Samsung K4U6E3S4AA-MGCR > for Samsung K4U6E3S4AA-MGCR. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic436db8fe3ef6fb8379ec629b128c05c691ea6fe Gerrit-Change-Number: 60337 Gerrit-PatchSet: 4 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 01:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR
by Zhi7 Li (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Zhi7 Li. Hello zanxi chen, Paul Menzel, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60337 to look at the new patch set (#4). Change subject: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR ...................................................................... mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for Samsung K4U6E3S4AA-MGCR. BUG=b:211950312 TEST=emerge-dedede coreboot Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: Ic436db8fe3ef6fb8379ec629b128c05c691ea6fe --- M src/mainboard/google/dedede/variants/storo/memory/Makefile.inc M src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60337/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic436db8fe3ef6fb8379ec629b128c05c691ea6fe Gerrit-Change-Number: 60337 Gerrit-PatchSet: 4 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/soc: Remove unused <stdlib.h>
by Jonathan Zhang (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Christian Walter, Arthur Heymans, Patrick Rudolph, HAOUAS Elyes, Tim Chu, Felix Held. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60617 ) Change subject: src/soc: Remove unused <stdlib.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08e1a680de9bfcc7d74e88a15abe9eef327b4961 Gerrit-Change-Number: 60617 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 01:44:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms.
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

Name of user not set #1004065 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60737 ) Change subject: util/ifdtool: Add support for Denverton platforms. ...................................................................... util/ifdtool: Add support for Denverton platforms. Signed-off-by: Jeff Daly <jeffd(a)silicom-usa.com> Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60737/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index a6e0f8a..51b72f6 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -237,6 +237,8 @@ return CHIPSET_400_SERIES_ICE_POINT; case PLATFORM_LBG: return CHIPSET_C620_SERIES_LEWISBURG; + case PLATFORM_DNV: + return CHIPSET_DENVERTON; default: return CHIPSET_PCH_UNKNOWN; } @@ -251,16 +253,17 @@ static int is_platform_ifd_2(void) { static const int ifd_2_platforms[] = { - PLATFORM_APL, - PLATFORM_GLK, - PLATFORM_CNL, - PLATFORM_LBG, - PLATFORM_ICL, - PLATFORM_TGL, - PLATFORM_JSL, - PLATFORM_EHL, PLATFORM_ADL, + PLATFORM_APL, + PLATFORM_CNL, + PLATFORM_DNV, + PLATFORM_EHL, + PLATFORM_GLK, + PLATFORM_ICL, + PLATFORM_JSL, + PLATFORM_LBG, PLATFORM_SKLKBL, + PLATFORM_TGL, }; unsigned int i; @@ -726,6 +729,12 @@ (flmstr & (1 << (wr_shift + 1))) ? "enabled" : "disabled"); printf(" Flash Descriptor Write Access: %s\n", (flmstr & (1 << wr_shift)) ? "enabled" : "disabled"); + if (platform == PLATFORM_DNV) { + printf(" 10GB A Region Write Access: %s\n", + (flmstr & (1 << (wr_shift + 11))) ? "enabled" : "disabled"); + printf(" 10GB B Region Write Access: %s\n", + (flmstr & (1 << (wr_shift + 12))) ? "enabled" : "disabled"); + } if (ifd_version >= IFD_VERSION_2) printf(" EC Region Read Access: %s\n", @@ -741,6 +750,12 @@ (flmstr & (1 << (rd_shift + 1))) ? "enabled" : "disabled"); printf(" Flash Descriptor Read Access: %s\n", (flmstr & (1 << rd_shift)) ? "enabled" : "disabled"); + if (platform == PLATFORM_DNV) { + printf(" 10GB A Region Read Access: %s\n", + (flmstr & (1 << (rd_shift + 11))) ? "enabled" : "disabled"); + printf(" 10GB B Region Read Access: %s\n", + (flmstr & (1 << (rd_shift + 12))) ? "enabled" : "disabled"); + } /* Requestor ID doesn't exist for ifd 2 */ if (ifd_version < IFD_VERSION_2) @@ -1639,6 +1654,7 @@ " adl - Alder Lake\n" " aplk - Apollo Lake\n" " cnl - Cannon Lake\n" + " dnv - Denverton\n" " lbg - Lewisburg PCH\n" " ehl - Elkhart Lake\n" " glk - Gemini Lake\n" @@ -1895,6 +1911,8 @@ platform = PLATFORM_APL; } else if (!strcmp(optarg, "cnl")) { platform = PLATFORM_CNL; + } else if (!strcmp(optarg, "dnv")) { + platform = PLATFORM_DNV; } else if (!strcmp(optarg, "lbg")) { platform = PLATFORM_LBG; } else if (!strcmp(optarg, "ehl")) { diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 638033f..487250d 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -45,19 +45,21 @@ CHIPSET_500_600_SERIES_TIGER_ALDER_POINT, /* 11th-12th gen Core i/o (LP) * variants onwards */ CHIPSET_C620_SERIES_LEWISBURG, + CHIPSET_DENVERTON, }; enum platform { + PLATFORM_ADL, PLATFORM_APL, PLATFORM_CNL, - PLATFORM_LBG, + PLATFORM_DNV, PLATFORM_EHL, PLATFORM_GLK, PLATFORM_ICL, PLATFORM_JSL, + PLATFORM_LBG, PLATFORM_SKLKBL, PLATFORM_TGL, - PLATFORM_ADL, }; #define LAYOUT_LINELEN 80 -- To view, visit https://review.coreboot.org/c/coreboot/+/60737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced Gerrit-Change-Number: 60737 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004065 Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Add AMP driver setting
by build bot (Jenkins) (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak, Robert Chen, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Add AMP driver setting ...................................................................... Patch Set 8: (8 comments) File src/drivers/i2c/cs35l53/cs35l53.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/6759bcbb_a24e1b08 PS8, Line 72: (config->boost_peak_milliamp % 50)){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/df48ecf1_d4c505ba PS8, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/bebeb899_cd2762d8 PS8, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/c705cbc2_2f87a429 PS8, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/266bd685_961f9826 PS8, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/672efaf9_51033144 PS8, Line 108: if (config->name){ suspect code indent for conditional statements (0, 0) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/f29fe609_32d099fe PS8, Line 108: if (config->name){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/15b27cf0_44485b49 PS8, Line 108: if (config->name){ braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 8 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 01:35:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Add AMP driver setting
by Robert Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak, Robert Chen, Nick Vaccaro, Shon Wang. Robert Chen has uploaded a new patch set (#8) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60331 ) Change subject: mb/google/brya/var/vell: Add AMP driver setting ...................................................................... mb/google/brya/var/vell: Add AMP driver setting update overridetree.cb update Kconfig.name update i2c/C35l53 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c --- A src/drivers/i2c/cs35l53/Kconfig A src/drivers/i2c/cs35l53/Makefile.inc A src/drivers/i2c/cs35l53/chip.h A src/drivers/i2c/cs35l53/cs35l53.c M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 7 files changed, 336 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/60331/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/60331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c Gerrit-Change-Number: 60331 Gerrit-PatchSet: 8 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/ifdtool: Add additional regions for platforms that support them.
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

Name of user not set #1004065 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60736 ) Change subject: util/ifdtool: Add additional regions for platforms that support them. ...................................................................... util/ifdtool: Add additional regions for platforms that support them. Some Intel SoCs support additional IFD regions for things like embedded LAN FW or Innovation Engine firmware, etc. Signed-off-by: Jeff Daly <jeffd(a)silicom-usa.com> Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 30 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/60736/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index ca5d3b8..a6e0f8a 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -40,10 +40,17 @@ { "Intel ME", "me", "flashregion_2_intel_me.bin", "SI_ME" }, { "GbE", "gbe", "flashregion_3_gbe.bin", "SI_GBE" }, { "Platform Data", "pd", "flashregion_4_platform_data.bin", "SI_PDR" }, - { "Reserved", "res1", "flashregion_5_reserved.bin", NULL }, - { "Reserved", "res2", "flashregion_6_reserved.bin", NULL }, + { "Device Expansion1", "devexp", "flashregion_5_device_expansion.bin", "SI_DEV_EXP1" }, + { "Secondary BIOS", "bios2", "flashregion_6_bios2.bin", "SI_BIOS2" }, { "Reserved", "res3", "flashregion_7_reserved.bin", NULL }, { "EC", "ec", "flashregion_8_ec.bin", "SI_EC" }, + { "Reserved", "res4", "flashregion_9_reserved.bin", NULL }, + { "IE", "ie", "flashregion_10_ie.bin", "SI_IE" }, + { "10GbA", "10gba", "flashregion_11_10gbeA.bin", "SI_10GBA" }, + { "10GbB", "10gbb", "flashregion_12_10gbeB.bin", "SI_10GBB" }, + { "Reserved", "res6", "flashregion_13_reserved.bin", NULL }, + { "Reserved", "res7", "flashregion_14_reserved.bin", NULL }, + { "PTT", "ptt", "flashregion_15_ptt.bin", "SI_PTT"} }; /* port from flashrom */ @@ -78,6 +85,7 @@ "400 series Ice Point", "500 series Tiger Point/ 600 series Alder Point", "C620 series Lewisburg", + "Denverton", NULL }; @@ -1642,7 +1650,7 @@ " -V | --newvalue The new value to write into PCH strap specified by -S\n" " -v | --version: print the version\n" " -h | --help: print this help\n\n" - "<region> is one of Descriptor, BIOS, ME, GbE, Platform, res1, res2, res3\n" + "<region> is one of Descriptor, BIOS, ME, GbE, Platform, res1, res2, res3, EC, 10GB[A/B], PDR\n" "\n"); } @@ -1735,12 +1743,24 @@ region_type = 4; else if (!strcasecmp("res1", region_type_string)) region_type = 5; + else if (!strcasecmp("Device", region_type_string)) + region_type = 5; else if (!strcasecmp("res2", region_type_string)) region_type = 6; + else if (!strcasecmp("Secondary", region_type_string)) + region_type = 6; else if (!strcasecmp("res3", region_type_string)) region_type = 7; else if (!strcasecmp("EC", region_type_string)) region_type = 8; + else if (!strcasecmp("IE", region_type_string)) + region_type = 10; + else if (!strcasecmp("10GbA", region_type_string)) + region_type = 11; + else if (!strcasecmp("10GbB", region_type_string)) + region_type = 12; + else if (!strcasecmp("PTT", region_type_string)) + region_type = 15; if (region_type == -1) { fprintf(stderr, "No such region type: '%s'\n\n", region_type_string); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 4f63e20..638033f 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -117,7 +117,7 @@ } __attribute__((packed)) fdbar_t; // regions -#define MAX_REGIONS 9 +#define MAX_REGIONS 16 #define MAX_REGIONS_OLD 5 enum flash_regions { @@ -126,7 +126,13 @@ REGION_ME, REGION_GBE, REGION_PDR, + REGION_DEV_EXP1, + REGION_BIOS2, REGION_EC = 8, + REGION_IE = 10, + REGION_10GBA, + REGION_10GBB, + REGION_PTT = 15, }; typedef struct { -- To view, visit https://review.coreboot.org/c/coreboot/+/60736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6 Gerrit-Change-Number: 60736 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004065 Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Disable autonomous GPIO power management
by David Wu (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Nick Vaccaro. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60388 ) Change subject: mb/google/brya/var/kano: Disable autonomous GPIO power management ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60388/comment/ab50fa04_87ddbef7 PS1, Line 7: disabled > `Disable` Done https://review.coreboot.org/c/coreboot/+/60388/comment/e59c0529_113e47a3 PS1, Line 8: : Used H1 firmware where the last version number is 0.0.22, 0.3.22 or : less to production that will need to disable autonomous GPIO power : management and then can get H1 version by gsctool -a -f -M > suggestion: […] Done Patchset: PS3: Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/60388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9607af42a00c1b5f38c6e4e0effdeeaba18af5ff Gerrit-Change-Number: 60388 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 01:22:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Disable autonomous GPIO power management
by David Wu (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Nick Vaccaro. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60388 to look at the new patch set (#3). Change subject: mb/google/brya/var/kano: Disable autonomous GPIO power management ...................................................................... mb/google/brya/var/kano: Disable autonomous GPIO power management When using cr50 FW 0.0.22/0.3.22 or earlier, its interrupt pulses are too short to be detected when autonomous GPIO power management is enabled, therefore disable autonomous GPIO PM. BUG=b:201266532 TEST=FW_NAME=kano emerge-brya coreboot and verify it builds without error. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I9607af42a00c1b5f38c6e4e0effdeeaba18af5ff --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/60388/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9607af42a00c1b5f38c6e4e0effdeeaba18af5ff Gerrit-Change-Number: 60388 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022