coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/corsola: Support audio
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hung-Te Lin, yu jiaxin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 ) Change subject: mb/google/corsola: Support audio ...................................................................... Patch Set 3: (12 comments) File src/mainboard/google/corsola/mainboard.c: https://review.coreboot.org/c/coreboot/+/60738/comment/74459542_40613819 PS1, Line 29: /* Power on audio */ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/3e3e6413_f544da3f PS1, Line 30: mtcmos_audio_power_on(); > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/9fb43bcd_82945bfd PS1, Line 30: mtcmos_audio_power_on(); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/4ff9f060_42402130 PS1, Line 32: /* Set up I2S */ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/a1aef76b_a9d4a613 PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/262af78d_2cda8824 PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/754e7bfc_2fcbf8a4 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/19502650_42486298 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/6a317075_1d60502e PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/4bc22417_92be2011 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/4b30e964_e95d9772 PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/60738/comment/47a4e7e3_7d33322f PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); > please, no spaces at the start of a line Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 03:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/anahera: Correct WWAN power sequence
by Chen Wisley (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak. Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60435 ) Change subject: mb/google/brya/anahera: Correct WWAN power sequence ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60435 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab221fd03c637c82f6ce5c8278d432decf1b30c6 Gerrit-Change-Number: 60435 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 03:40:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/anahera: Correct SSD power sequence
by Chen Wisley (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak, Wisley Chen. Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60434 ) Change subject: mb/google/brya/anahera: Correct SSD power sequence ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66345d985f4db4f13b23c0a21c179835908b6574 Gerrit-Change-Number: 60434 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 03:40:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Support audio
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, yu jiaxin, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), yu jiaxin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60738 to look at the new patch set (#3). Change subject: mb/google/corsola: Support audio ...................................................................... mb/google/corsola: Support audio Turn on setting of audio power and select I2S pin-mux. BUG=b:204164695 TEST=Verified by CLI command(badusbbeep/devbeep) on kingler and krabby Signed-off-by: Jiaxin Yu <jiaxin.yu(a)mediatek.com> Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60738/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
by Subrata Banik (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Reka Norman, Paul Menzel, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 ) Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Thanks for rebasing Reka. -- To view, visit https://review.coreboot.org/c/coreboot/+/60271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Gerrit-Change-Number: 60271 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 03:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Support audio
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, yu jiaxin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60738 to look at the new patch set (#2). Change subject: mb/google/corsola: Support audio ...................................................................... mb/google/corsola: Support audio Turn on setting of audio power and select I2S pin-mux. BUG=b:204164695 TEST=Verified by CLI command(badusbbeep/devbeep) on kingler and krabby Signed-off-by: Jiaxin Yu <jiaxin.yu(a)mediatek.com> Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs M src/mainboard/google/corsola/mainboard.c 5 files changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60738/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/corsola: Support audio
by build bot (Jenkins) (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: yu jiaxin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 ) Change subject: mb/google/corsola: Support audio ...................................................................... Patch Set 1: (12 comments) File src/mainboard/google/corsola/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/c7d30201_f414b8c8 PS1, Line 29: /* Power on audio */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/624448d0_e075de5d PS1, Line 30: mtcmos_audio_power_on(); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/fe606505_2e9f7b99 PS1, Line 30: mtcmos_audio_power_on(); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/e9bc0295_9f233826 PS1, Line 32: /* Set up I2S */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/e509d592_9902d43b PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/52614081_3d9a523f PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/c234b108_e87ea1fb PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/859d4e99_e12f3b35 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/ba20f4ec_b17bc187 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/fcb74817_9ef40e00 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/5d4a4937_fca78f05 PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/1028a060_27f8abdd PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 03:03:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Support audio
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: yu jiaxin. Hello yu jiaxin, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/60738 to review the following change. Change subject: mb/google/corsola: Support audio ...................................................................... mb/google/corsola: Support audio Turn on setting of audio power and select I2S pin-mux. BUG=b:204164695 TEST=Verified by CLI command(badusbbeep/devbeep) on kingler and krabby Signed-off-by: Jiaxin Yu <jiaxin.yu(a)mediatek.com> Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60738/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index 910d8d6..747b507 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -24,6 +24,18 @@ register_bl31_aux_param(&param_reset.h); } +static void configure_audio(void) +{ + /* Power on audio */ + mtcmos_audio_power_on(); + + /* Set up I2S */ + gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); + gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); + gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); + gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); +} + static void mainboard_init(struct device *dev) { mtk_msdc_configure_emmc(true); @@ -35,6 +47,8 @@ setup_usb_host(); + configure_audio(); + if (spm_init()) printk(BIOS_ERR, "spm init failed, system suspend may not work\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed
by Kenneth Chan (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 ) Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60442/comment/7e054db5_68eebdc9 PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2. > Modified uid="0" for 0x29, uid="1" for 0x2a. Tested on proto build and audio work well. Thanks. Done File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60442/comment/927e9729_47049d80 PS4, Line 151: register "uid" = "1" > Remove probed=1 from 0x2a. Tested on proto build and audio work well. Thanks. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I542f886fe63205777837d7146169177b043cc5f2 Gerrit-Change-Number: 60442 Gerrit-PatchSet: 5 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 02:19:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed
by Kenneth Chan (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 ) Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60442/comment/95c859e7_46f777ad PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2. > OK. […] Modified uid="0" for 0x29, uid="1" for 0x2a. Tested on proto build and audio work well. Thanks. File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60442/comment/3a4a464a_40d7367b PS4, Line 151: register "uid" = "1" > Looks like the probed parameter was added in https://review.coreboot. […] Remove probed=1 from 0x2a. Tested on proto build and audio work well. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/60442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I542f886fe63205777837d7146169177b043cc5f2 Gerrit-Change-Number: 60442 Gerrit-PatchSet: 5 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 02:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022