coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/amd/common/pi/agesawrapper.c: Include <string.h>
by HAOUAS Elyes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60641 ) Change subject: soc/amd/common/pi/agesawrapper.c: Include <string.h> ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/common/pi/agesawrapper.c: https://review.coreboot.org/c/coreboot/+/60641/comment/f70a1da3_bc14d6c4 PS3, Line 67: memcpy needs <string.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b7b3a94acbb7e4f9614fcf3f06d68e6ac72f4f1 Gerrit-Change-Number: 60641 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 08:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mainboard/starlabs/labtop: Remove unused <option.h>
by HAOUAS Elyes (Code Review) 04 Jan '22

04 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60751 ) Change subject: src/mainboard/starlabs/labtop: Remove unused <option.h> ...................................................................... src/mainboard/starlabs/labtop: Remove unused <option.h> Found using: diff <(git grep -l '#include <option.h>' -- src/) <(git grep -l 'sanitize_cmos(\|get_uint_option(\|set_uint_option(\|get_uint_option(\|set_uint_option' -- src/) |grep ">" Change-Id: Ib79dfa73b8a30ae1b1e432318bd42e4e3d845af3 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/starlabs/labtop/smbios.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/60751/1 diff --git a/src/mainboard/starlabs/labtop/smbios.c b/src/mainboard/starlabs/labtop/smbios.c index 9acf64f..f11f126 100644 --- a/src/mainboard/starlabs/labtop/smbios.c +++ b/src/mainboard/starlabs/labtop/smbios.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <ec/starlabs/merlin/ec.h> -#include <option.h> #include <smbios.h> #include <types.h> #include <uuid.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib79dfa73b8a30ae1b1e432318bd42e4e3d845af3 Gerrit-Change-Number: 60751 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [TEST] Touchscreen reset delay to 200ms
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60750 ) Change subject: [TEST] Touchscreen reset delay to 200ms ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/60750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f Gerrit-Change-Number: 60750 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] Touchscreen reset delay to 200ms
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

vagdevi.p(a)intel.com has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60750 ) Change subject: [TEST] Touchscreen reset delay to 200ms ...................................................................... [TEST] Touchscreen reset delay to 200ms Signed-off-by: VAGDEVI P <vagdevi.p(a)intel.com> Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f --- M src/mainboard/google/brya/variants/gimble/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/60750/1 diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index 91ae800..9747e55 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -208,7 +208,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "300" + register "generic.reset_delay_ms" = "200" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/60750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f Gerrit-Change-Number: 60750 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Signed-off-by: VAGDEVI P <vagdevi.p@intel.com> Change-Id: If2176f3b26...
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

vagdevi.p(a)intel.com has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60749 ) Change subject: Signed-off-by: VAGDEVI P <vagdevi.p(a)intel.com> Change-Id: If2176f3b26587d4ff6b5c7b06c193ddd1c9cbe86 [TEST] /mb/google/brya/variant/gimble Touchscree reset delay to 200ms ...................................................................... Signed-off-by: VAGDEVI P <vagdevi.p(a)intel.com> Change-Id: If2176f3b26587d4ff6b5c7b06c193ddd1c9cbe86 [TEST] /mb/google/brya/variant/gimble Touchscree reset delay to 200ms Change-Id: I4f1b4ccf94233193c1f9c2dd82fd27a020a62186 --- M src/mainboard/google/brya/variants/gimble/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/60749/1 diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index 91ae800..bd1cdac 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -208,7 +208,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "300" + register "generic.reset_delay_ms" = "2200" register "generic.reset_off_delay_ms" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/60749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f1b4ccf94233193c1f9c2dd82fd27a020a62186 Gerrit-Change-Number: 60749 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/mainboard/google: Remove unused <boardid.h>
by HAOUAS Elyes (Code Review) 04 Jan '22

04 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60748 ) Change subject: src/mainboard/google: Remove unused <boardid.h> ...................................................................... src/mainboard/google: Remove unused <boardid.h> Found using: diff <(git grep -l '#include <boardid.h>' -- src/) <(git grep -l 'UNDEFINED_STRAPPING_ID\|BOARD_ID_UNKNOWN\|BOARD_ID_INIT\|board_id(\|ram_code(\|sku_id(' -- src/) |grep "<" Change-Id: I2611be41e8730a9b189b1b0aa3fe62be0757b371 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/dedede/variants/haboki/gpio.c M src/mainboard/google/guybrush/variants/nipperkin/variant.c M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/mainboard.c M src/mainboard/google/octopus/variants/bloog/variant.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/bobba/variant.c M src/mainboard/google/octopus/variants/dood/gpio.c M src/mainboard/google/octopus/variants/foob/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/variant.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_rialto/board.h 14 files changed, 0 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/60748/1 diff --git a/src/mainboard/google/dedede/variants/haboki/gpio.c b/src/mainboard/google/dedede/variants/haboki/gpio.c index 12286c6..ab13dba 100644 --- a/src/mainboard/google/dedede/variants/haboki/gpio.c +++ b/src/mainboard/google/dedede/variants/haboki/gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <boardid.h> #include <fw_config.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/guybrush/variants/nipperkin/variant.c b/src/mainboard/google/guybrush/variants/nipperkin/variant.c index c53d691..c9e52c3 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/variant.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> -#include <boardid.h> #include <device/device.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/herobrine/board.h b/src/mainboard/google/herobrine/board.h index 4278c11..4130def 100644 --- a/src/mainboard/google/herobrine/board.h +++ b/src/mainboard/google/herobrine/board.h @@ -4,7 +4,6 @@ #define _COREBOOT_SRC_MAINBOARD_GOOGLE_HEROBRINE_BOARD_H_ #include <assert.h> -#include <boardid.h> #include <gpio.h> #define GPIO_SD_CD_L GPIO(91) diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index fcc468e..5237342 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include "board.h" -#include <boardid.h> #include <bootblock_common.h> #include <console/console.h> #include <device/device.h> diff --git a/src/mainboard/google/octopus/variants/bloog/variant.c b/src/mainboard/google/octopus/variants/bloog/variant.c index 28f2ce8..498c5c4 100644 --- a/src/mainboard/google/octopus/variants/bloog/variant.c +++ b/src/mainboard/google/octopus/variants/bloog/variant.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <boardid.h> #include <ec/google/chromeec/ec.h> #include <sar.h> #include <baseboard/variants.h> diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c index 11fe9b5..f5ba83a 100644 --- a/src/mainboard/google/octopus/variants/bobba/gpio.c +++ b/src/mainboard/google/octopus/variants/bobba/gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <boardid.h> #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c index aa98a90..a5a16df 100644 --- a/src/mainboard/google/octopus/variants/bobba/variant.c +++ b/src/mainboard/google/octopus/variants/bobba/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> -#include <boardid.h> #include <sar.h> #include <baseboard/variants.h> #include <gpio.h> diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c index dfb88d8..639e9ca 100644 --- a/src/mainboard/google/octopus/variants/dood/gpio.c +++ b/src/mainboard/google/octopus/variants/dood/gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <boardid.h> #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/octopus/variants/foob/gpio.c b/src/mainboard/google/octopus/variants/foob/gpio.c index 3e059c8..1cc044e 100644 --- a/src/mainboard/google/octopus/variants/foob/gpio.c +++ b/src/mainboard/google/octopus/variants/foob/gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <boardid.h> #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index c285a88..dad442b 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <boardid.h> #include <gpio.h> #include <soc/gpio.h> #include <variant/sku.h> diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 5a0f8e6..abff81b 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> -#include <boardid.h> #include <ec/google/chromeec/ec.h> #include <drivers/intel/gma/opregion.h> #include <baseboard/variants.h> diff --git a/src/mainboard/google/veyron/board.h b/src/mainboard/google/veyron/board.h index 10c36df..a2b9e2f 100644 --- a/src/mainboard/google/veyron/board.h +++ b/src/mainboard/google/veyron/board.h @@ -3,7 +3,6 @@ #ifndef __MAINBOARD_GOOGLE_VEYRON_BOARD_H #define __MAINBOARD_GOOGLE_VEYRON_BOARD_H -#include <boardid.h> #include <gpio.h> #define GPIO_BACKLIGHT GPIO(7, A, 2) diff --git a/src/mainboard/google/veyron_mickey/board.h b/src/mainboard/google/veyron_mickey/board.h index bed6177..b7d7118 100644 --- a/src/mainboard/google/veyron_mickey/board.h +++ b/src/mainboard/google/veyron_mickey/board.h @@ -3,7 +3,6 @@ #ifndef __MAINBOARD_GOOGLE_VEYRON_MICKEY_BOARD_H #define __MAINBOARD_GOOGLE_VEYRON_MICKEY_BOARD_H -#include <boardid.h> #include <gpio.h> #define GPIO_RESET GPIO(0, B, 5) diff --git a/src/mainboard/google/veyron_rialto/board.h b/src/mainboard/google/veyron_rialto/board.h index 5bd1656..af3966c 100644 --- a/src/mainboard/google/veyron_rialto/board.h +++ b/src/mainboard/google/veyron_rialto/board.h @@ -3,7 +3,6 @@ #ifndef __MAINBOARD_GOOGLE_VEYRON_RIALTO_BOARD_H #define __MAINBOARD_GOOGLE_VEYRON_RIALTO_BOARD_H -#include <boardid.h> #include <gpio.h> #define GPIO_RESET GPIO(0, B, 5) -- To view, visit https://review.coreboot.org/c/coreboot/+/60748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2611be41e8730a9b189b1b0aa3fe62be0757b371 Gerrit-Change-Number: 60748 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: chromeos: Add an elog for Chrome OS diagnostic boot
by Hsuan-ting Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Yu-Ping Wu, Aaron Durbin. Hello build bot (Jenkins), Hsuan Ting Chen, Jack Rosenthal, Yu-Ping Wu, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54948 to look at the new patch set (#13). Change subject: chromeos: Add an elog for Chrome OS diagnostic boot ...................................................................... chromeos: Add an elog for Chrome OS diagnostic boot Add an elog type 0xb6 for Chrome OS diagnostics related events and log the message while booting the diagnostic tool: __func__: Logged diagnostic boot BRANCH=none BUG=b:185551931, b:177196147 TEST=emerge-volteer coreboot vboot_reference Change-Id: Icb675fc431d4c45e4f432b2d12cac6dcfb2d5e3a Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M src/vendorcode/google/chromeos/elog.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/54948/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/54948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb675fc431d4c45e4f432b2d12cac6dcfb2d5e3a Gerrit-Change-Number: 54948 Gerrit-PatchSet: 13 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/acpi: Remove unused <acpi/acpi.h>
by Lance Zhao (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: HAOUAS Elyes. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60635 ) Change subject: src/acpi: Remove unused <acpi/acpi.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60635 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1684e6386da9db0ff41e78078f7d72c1fb4a499e Gerrit-Change-Number: 60635 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 04 Jan 2022 07:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "[TEST]"
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60746 ) Change subject: Revert "[TEST]" ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/60746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I635ea83a57e982cf7fe7b2792a588817ae522184 Gerrit-Change-Number: 60746 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: Revert "[TEST]"
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

vagdevi.p(a)intel.com has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60746 ) Change subject: Revert "[TEST]" ...................................................................... Revert "[TEST]" This reverts commit a7ec50ae5e678ebaa6de8822684dc6d9d90ce9c5. Change-Id: I635ea83a57e982cf7fe7b2792a588817ae522184 --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/60746/1 diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index 9b920c8..b330e98 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -23,7 +23,7 @@ register "HeciEnabled" = "1" # Enable CNVi BT - #register "CnviBtCore" = "true" + register "CnviBtCore" = "true" register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C0 register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC1)" # USB2_C1 @@ -133,8 +133,12 @@ device ref tcss_dma1 on end device ref xhci on end device ref shared_sram on end - device ref cnvi_wifi off end - + device ref cnvi_wifi on + chip drivers/wifi/generic + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end device ref i2c3 on end device ref heci1 on end device ref sata on end -- To view, visit https://review.coreboot.org/c/coreboot/+/60746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I635ea83a57e982cf7fe7b2792a588817ae522184 Gerrit-Change-Number: 60746 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022