vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60746 )
Change subject: Revert "[TEST]"
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635ea83a57e982cf7fe7b2792a588817ae522184
Gerrit-Change-Number: 60746
Gerrit-PatchSet: 1
Gerrit-Owner: vagdevi.p(a)intel.com
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak, Casper Chang.
Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 )
Change subject: mb/google/brya/var/primus: Fix some GPIO programming
......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/google/brya/variants/primus/gpio.c:
https://review.coreboot.org/c/coreboot/+/60104/comment/8af7edf6_a62db0bd
PS25, Line 62:
> Why add the blank line?
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98
Gerrit-Change-Number: 60104
Gerrit-PatchSet: 27
Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 06:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: vagdevi.p(a)intel.com.
vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60745 )
Change subject: [TEST]
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaba7810e519896dc0118e76bb2b893175b763b1
Gerrit-Change-Number: 60745
Gerrit-PatchSet: 1
Gerrit-Owner: vagdevi.p(a)intel.com
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: vagdevi.p(a)intel.com
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60745 )
Change subject: [TEST]
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137148):
https://review.coreboot.org/c/coreboot/+/60745/comment/335978b5_c8bf6f8a
PS1, Line 137:
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/60745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaba7810e519896dc0118e76bb2b893175b763b1
Gerrit-Change-Number: 60745
Gerrit-PatchSet: 1
Gerrit-Owner: vagdevi.p(a)intel.com
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 06:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment