coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Andy Pont, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58428 to look at the new patch set (#76). Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... mainboard/starlabs: Add LabTop Mk IV Tested using MrChromeBox's `uefipayload_202107` branch: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/labtop-mk-iv-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/labtop_cml.md M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/Kconfig.name M src/mainboard/starlabs/labtop/Makefile.inc M src/mainboard/starlabs/labtop/dsdt.asl A src/mainboard/starlabs/labtop/spd/Makefile.inc A src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex A src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex A src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/starlabs/labtop/variants/cml/Makefile.inc A src/mainboard/starlabs/labtop/variants/cml/board.fmd A src/mainboard/starlabs/labtop/variants/cml/data.vbt A src/mainboard/starlabs/labtop/variants/cml/devicetree.cb A src/mainboard/starlabs/labtop/variants/cml/devtree.c A src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads A src/mainboard/starlabs/labtop/variants/cml/gpio.c A src/mainboard/starlabs/labtop/variants/cml/hda_verb.c A src/mainboard/starlabs/labtop/variants/cml/romstage.c 19 files changed, 1,301 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/58428/76 -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 76 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Andy Pont, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58428 to look at the new patch set (#74). Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... mainboard/starlabs: Add LabTop Mk IV Tested using MrChromeBox's `uefipayload_202107` branch: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/labtop-mk-iv-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/labtop_cml.md M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/Kconfig.name M src/mainboard/starlabs/labtop/Makefile.inc M src/mainboard/starlabs/labtop/dsdt.asl A src/mainboard/starlabs/labtop/spd/Makefile.inc A src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex A src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex A src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/starlabs/labtop/variants/cml/Makefile.inc A src/mainboard/starlabs/labtop/variants/cml/board.fmd A src/mainboard/starlabs/labtop/variants/cml/data.vbt A src/mainboard/starlabs/labtop/variants/cml/devicetree.cb A src/mainboard/starlabs/labtop/variants/cml/devtree.c A src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads A src/mainboard/starlabs/labtop/variants/cml/gpio.c A src/mainboard/starlabs/labtop/variants/cml/hda_verb.c A src/mainboard/starlabs/labtop/variants/cml/romstage.c 19 files changed, 1,302 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/58428/74 -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 74 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/cse: Add config to disable CSE at pre-boot
by Subrata Banik (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 ) Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/60721/comment/a858e87b_4e7d9632 PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot. > So it's just about hiding the interface, right? If so, we should name the > option like that and also the commit summary should say so. "DISABLE_CSE" Yes, you are right. Will rename as suggested. > is easily confused with other options that actually disable the CSE (tell > it to halt after the CSE booted, cf. CB:52800). make sense to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/60721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e127816c506df3ac0cf973b69021d02d05bef4a Gerrit-Change-Number: 60721 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Add config to disable CSE at pre-boot
by Nico Huber (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 ) Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/60721/comment/f426be34_3584f283 PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot. So it's just about hiding the interface, right? If so, we should name the option like that and also the commit summary should say so. "DISABLE_CSE" is easily confused with other options that actually disable the CSE (tell it to halt after the CSE booted, cf. CB:52800). -- To view, visit https://review.coreboot.org/c/coreboot/+/60721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e127816c506df3ac0cf973b69021d02d05bef4a Gerrit-Change-Number: 60721 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:36:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed
by Rob Barnes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Bhanu Prakash Maiya, Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 ) Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I542f886fe63205777837d7146169177b043cc5f2 Gerrit-Change-Number: 60442 Gerrit-PatchSet: 5 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Increase CBFS_MCACHE size to 8 KiB
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60529 ) Change subject: soc/mediatek/mt8186: Increase CBFS_MCACHE size to 8 KiB ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e627ede3774665575006f752f89101e3c5bde9f Gerrit-Change-Number: 60529 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:23:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Support audio
by Rex-BC Chen (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Hung-Te Lin, yu jiaxin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 ) Change subject: mb/google/corsola: Support audio ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b Gerrit-Change-Number: 60738 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Disconnect unused GPIO's
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/60754 ) Change subject: mb/starlabs/labtop: Disconnect unused GPIO's ...................................................................... mb/starlabs/labtop: Disconnect unused GPIO's Disconnect all GPIO's that aren't connected to anything. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2050da62f73c0f99fbfef013c22e35225cc480c4 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 42 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60754/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2050da62f73c0f99fbfef013c22e35225cc480c4 Gerrit-Change-Number: 60754 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Update GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60759 ) Change subject: mb/starlabs/labtop: Update GPIOs ...................................................................... mb/starlabs/labtop: Update GPIOs Update GPIOs from the AMI port, so they are correctly configured. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I27ecf066685f2a81ac884a9f276c518544449443 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/60759/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index b15aa6b..59a05ad 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -26,29 +26,29 @@ /* REFERENCE: EP PER SCHEMATIC */ /* GPD0: PCH_BATLOW# */ - PAD_CFG_NF(GPD0, UP_20K, PWROK, NF1), + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* GPD1: AC_PRESENT */ - PAD_CFG_NF(GPD1, NATIVE, PWROK, NF1), + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD3: SIO_PWRBTN# */ - PAD_CFG_NF(GPD3, UP_20K, PWROK, NF1), + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: SIO_SLP_S3# */ - PAD_CFG_NF(GPD4, NONE, PWROK, NF1), + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* GPD5: SIO_SLP_S4# */ - PAD_CFG_NF(GPD5, NONE, PWROK, NF1), + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* GPD6: SIO_SLP_A# */ - PAD_CFG_NF(GPD6, NONE, PWROK, NF1), + PAD_CFG_NF(GPD6, NONE, DEEP, NF1), /* GPD7: PCH_TBT_PERST# */ - PAD_CFG_GPO(GPD7, 0, PWROK), + PAD_CFG_GPO(GPD7, 0, PLTRST), /* GPD8: SUSCLK */ - PAD_CFG_NF(GPD8, NONE, PWROK, NF1), + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: SIO_SLP_WLAN# */ - PAD_CFG_NF(GPD9, NONE, PWROK, NF1), + PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: SIO_SLP_S5# */ - PAD_CFG_NF(GPD10, NONE, PWROK, NF1), + PAD_CFG_NF(GPD10, NONE, DEEP, NF1), /* GPD11: PM_LANPHY_EN */ - PAD_CFG_GPO(GPD11, 0, PWROK), + PAD_CFG_NF(GPD11, NONE, DEEP, NF1), /* A0: ESPI_IO_0 */ /* A1: ESPI_IO_1 */ @@ -62,7 +62,7 @@ /* A8: WLAN_PCM_RST */ PAD_CFG_NF(GPP_A8, NONE, DEEP, NF2), /* A9: WLAN_PCM_CLKREQ0 */ - PAD_CFG_NF(GPP_A9, NONE, DEEP, NF3), + PAD_CFG_NF(GPP_A9, NONE, DEEP, NF2), /* A10: WLAN_PCM_IN */ PAD_NC(GPP_A10, NONE), /* A11: M2_CPU_SSD_RST_N */ @@ -115,7 +115,7 @@ /* B10: PWR_MON_I2C_SCL_R */ PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), /* B11: I2C_PMC_PD_INT_N */ - PAD_CFG_NF(GPP_B11, NONE, PWROK, NF1), + PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM_SLP_S0_N */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* B13: PLT_RST_N */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ecf066685f2a81ac884a9f276c518544449443 Gerrit-Change-Number: 60759 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/starlabs/labtop: Update CNVi GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60758 ) Change subject: mb/starlabs/labtop: Update CNVi GPIOs ...................................................................... mb/starlabs/labtop: Update CNVi GPIOs Update GPIOs from the AMI port, so they are correctly configured. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I9fc9963e91da0267c8740fee20a3ec41895b4953 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/60758/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index 8ae3875..b15aa6b 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -279,15 +279,15 @@ /* F0: CNV_BRI_DT_BT_UART0_RTS_R */ PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), /* F1: CNV_BRI_RSP_BT_UART0_RX_R */ - PAD_CFG_NF(GPP_F1, UP_20K, DEEP, NF1), + PAD_CFG_NF(GPP_F1, NONE, DEEP, NF1), /* F2: CNV_RGI_DT_BT_UART0_TX_R */ PAD_CFG_NF(GPP_F2, NONE, DEEP, NF1), /* F3: CNV_RGI_RSP_BT_UART0_CTS */ - PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), + PAD_CFG_NF(GPP_F3, NONE, DEEP, NF1), /* F4: Not Connected */ PAD_NC(GPP_F4, NONE), /* F5: GPPC_F5_MODEM_CLKREQ */ - PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3), + PAD_NC(GPP_F5, NONE), /* F6: Not Connected */ PAD_NC(GPP_F6, NONE), /* F7: BIOS_REC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fc9963e91da0267c8740fee20a3ec41895b4953 Gerrit-Change-Number: 60758 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022