Attention is currently required from: Felix Singer, Matt DeVillier, Tim Wawrzynczak, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60735 )
Change subject: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> might as well add for ARCADA too, and then select INTEL_GMA_HAVE_VBT in Kconfig
Is it the same? If not, where could I get it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7
Gerrit-Change-Number: 60735
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 09:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Julius Werner.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59497
to look at the new patch set (#16).
Change subject: libpayload: Implement new CBFS access API
......................................................................
libpayload: Implement new CBFS access API
This commit adds new CBFS API, which is based on the one available in
the main coreboot source tree. Libpayload implementation supports RO/RW
file lookups and file contents verification.
Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile.inc
M payloads/libpayload/include/cbfs.h
M payloads/libpayload/include/cbfs_core.h
A payloads/libpayload/include/cbfs_glue.h
A payloads/libpayload/include/cbfs_legacy.h
A payloads/libpayload/libcbfs/Kconfig
M payloads/libpayload/libcbfs/Makefile.inc
M payloads/libpayload/libcbfs/cbfs.c
M payloads/libpayload/libcbfs/cbfs_core.c
A payloads/libpayload/libcbfs/cbfs_legacy.c
M payloads/libpayload/tests/Makefile.inc
A payloads/libpayload/tests/include/mocks/cbfs_util.h
A payloads/libpayload/tests/libcbfs/Makefile.inc
A payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c
A payloads/libpayload/tests/libcbfs/cbfs-verification-test.c
A payloads/libpayload/tests/mocks/cbfs_file_mock.c
A payloads/libpayload/tests/mocks/die.c
18 files changed, 1,815 insertions(+), 437 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59497/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/59497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7
Gerrit-Change-Number: 59497
Gerrit-PatchSet: 16
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60714
to look at the new patch set (#2).
Change subject: libpayload/libcbfs: Add unverified_area APIs
......................................................................
libpayload/libcbfs: Add unverified_area APIs
This patch introduces equivalents of unverified_area CBFS access
functions added to the main coreboot tree in CB:59678
Change-Id: Ibadfd2a5cb6ad037ef1222b0a4301f90a79a127b
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
---
M payloads/libpayload/include/cbfs.h
M payloads/libpayload/libcbfs/cbfs.c
M payloads/libpayload/tests/libcbfs/Makefile.inc
M payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c
4 files changed, 159 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60714/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibadfd2a5cb6ad037ef1222b0a4301f90a79a127b
Gerrit-Change-Number: 60714
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )
Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15:
Next time, please add a summary of the bug discussion and the boot time increase to the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db
Gerrit-Change-Number: 60190
Gerrit-PatchSet: 15
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 08:58:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
vagdevi.p(a)intel.com has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60750 )
Change subject: [TEST] Touchscreen reset delay to 200ms
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f
Gerrit-Change-Number: 60750
Gerrit-PatchSet: 1
Gerrit-Owner: vagdevi.p(a)intel.com
Gerrit-MessageType: deleteReviewer