coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/starlabs/labtop: Add comments for GPIO End Points
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 ) Change subject: mb/starlabs/labtop: Add comments for GPIO End Points ...................................................................... Patch Set 25: (1 comment) This change is ready for review. File src/mainboard/starlabs/labtop/variants/tgl/gpio.c: https://review.coreboot.org/c/coreboot/+/60123/comment/8750c8a3_53a046d3 PS19, Line 28: /* GPD0 --[ GPD0 ]-- PCH_BATLOW# */ > TBH it's pretty hard to review that due to the line offsets. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 25 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 10:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable CNVi DDR RFIM for base board brya
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak, Ronak Kanabar. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60740 ) Change subject: mb/google/brya: Enable CNVi DDR RFIM for base board brya ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60740/comment/809b2e45_96c7b0b0 PS3, Line 9: set sets https://review.coreboot.org/c/coreboot/+/60740/comment/1a1acd5c_87c16d7f PS3, Line 9: Enable enables https://review.coreboot.org/c/coreboot/+/60740/comment/8e795c13_589663e0 PS3, Line 11: Please add why you do that change. https://review.coreboot.org/c/coreboot/+/60740/comment/c611741a_a44e9abc PS3, Line 14: debug FSP Is that available, if not, how can it be checked without it? -- To view, visit https://review.coreboot.org/c/coreboot/+/60740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Gerrit-Change-Number: 60740 Gerrit-PatchSet: 3 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 10:42:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Fix some GPIO programming
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Ariel Fang, Tim Wawrzynczak, Casper Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Fix some GPIO programming ...................................................................... Patch Set 27: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/80bfe134_656c147a PS27, Line 10: so this CL programs them as PAD_NC Please clarify by adding something like: > … after checking them against schematics. -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 27 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 10:38:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/primus: Fix some GPIO programming
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Ariel Fang, Tim Wawrzynczak, Casper Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus: Fix some GPIO programming ...................................................................... Patch Set 27: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/70a845fd_4f79b3f7 PS27, Line 2: Ariel_Fang Please change to Ariel Fang: $ git config --global user.name "Ariel Fang" $ git commit --amend --author="Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>" https://review.coreboot.org/c/coreboot/+/60104/comment/bd9c3a2a_fe105b8e PS27, Line 19: Ariel_Fang Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 27 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 10:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TEST] Touchscreen reset delay to 200ms
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: vagdevi.p(a)intel.com. vagdevi.p(a)intel.com has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/60750 ) Change subject: [TEST] Touchscreen reset delay to 200ms ...................................................................... Removed cc Paul Menzel. -- To view, visit https://review.coreboot.org/c/coreboot/+/60750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f Gerrit-Change-Number: 60750 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] Touchscreen reset delay to 200ms
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: vagdevi.p(a)intel.com. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60750 ) Change subject: [TEST] Touchscreen reset delay to 200ms ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60750/comment/89ff210e_4cf570d6 PS1, Line 2: VAGDEVI No capitalization needed. https://review.coreboot.org/c/coreboot/+/60750/comment/d812bfae_dbdf56db PS1, Line 7: [TEST] Touchscreen reset delay to 200ms If this is ready for submit, please rewrite and follow the other commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/60750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51470423657aab8948ed0c5b230d4181b5e2600f Gerrit-Change-Number: 60750 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-Comment-Date: Tue, 04 Jan 2022 10:33:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Matt DeVillier, Tim Wawrzynczak, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60735 ) Change subject: mb/google/sarien/var/sarien: Add VBT from Chromebook firmware ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > might as well add for ARCADA too, and then select INTEL_GMA_HAVE_VBT in Kconfig Is it the same? If not, where could I get it? -- To view, visit https://review.coreboot.org/c/coreboot/+/60735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibab8a7b0b3f721ca434ac38b51528b81e66f3bb7 Gerrit-Change-Number: 60735 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 09:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/libcbfs: Add unverified_area APIs
by Jakub Czapiga (Code Review) 04 Jan '22

04 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60714 to look at the new patch set (#2). Change subject: libpayload/libcbfs: Add unverified_area APIs ...................................................................... libpayload/libcbfs: Add unverified_area APIs This patch introduces equivalents of unverified_area CBFS access functions added to the main coreboot tree in CB:59678 Change-Id: Ibadfd2a5cb6ad037ef1222b0a4301f90a79a127b Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/include/cbfs.h M payloads/libpayload/libcbfs/cbfs.c M payloads/libpayload/tests/libcbfs/Makefile.inc M payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c 4 files changed, 159 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60714/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibadfd2a5cb6ad037ef1222b0a4301f90a79a127b Gerrit-Change-Number: 60714 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Paul Menzel, Julius Werner. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59497 to look at the new patch set (#16). Change subject: libpayload: Implement new CBFS access API ...................................................................... libpayload: Implement new CBFS access API This commit adds new CBFS API, which is based on the one available in the main coreboot source tree. Libpayload implementation supports RO/RW file lookups and file contents verification. Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/Kconfig M payloads/libpayload/Makefile.inc M payloads/libpayload/include/cbfs.h M payloads/libpayload/include/cbfs_core.h A payloads/libpayload/include/cbfs_glue.h A payloads/libpayload/include/cbfs_legacy.h A payloads/libpayload/libcbfs/Kconfig M payloads/libpayload/libcbfs/Makefile.inc M payloads/libpayload/libcbfs/cbfs.c M payloads/libpayload/libcbfs/cbfs_core.c A payloads/libpayload/libcbfs/cbfs_legacy.c M payloads/libpayload/tests/Makefile.inc A payloads/libpayload/tests/include/mocks/cbfs_util.h A payloads/libpayload/tests/libcbfs/Makefile.inc A payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c A payloads/libpayload/tests/libcbfs/cbfs-verification-test.c A payloads/libpayload/tests/mocks/cbfs_file_mock.c A payloads/libpayload/tests/mocks/die.c 18 files changed, 1,815 insertions(+), 437 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59497/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 16 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Paul Menzel (Code Review) 04 Jan '22

04 Jan '22

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: Next time, please add a summary of the bug discussion and the boot time increase to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 15 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 08:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022