coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/starlabs/labtop: Update trackpad GPIO
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60757 ) Change subject: mb/starlabs/labtop: Update trackpad GPIO ...................................................................... mb/starlabs/labtop: Update trackpad GPIO Update trackpad GPIO to avoid IRQ Storm, that causes high power consumption when idling or in S3. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ieee27bd9079617ab95f4f1e27ef98b49e89e5b41 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/60757/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index 7edd32d..8ae3875 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -158,7 +158,7 @@ /* C7: SML1_DATA */ PAD_CFG_NF(GPP_C7, NONE, PWROK, NF1), /* C8: CLICK_PAD_INT_N */ - PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST), /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), /* C10: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieee27bd9079617ab95f4f1e27ef98b49e89e5b41 Gerrit-Change-Number: 60757 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/starlabs/labtop: Enable TPM_IRQ GPIO
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60756 ) Change subject: mb/starlabs/labtop: Enable TPM_IRQ GPIO ...................................................................... mb/starlabs/labtop: Enable TPM_IRQ GPIO Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ife88075e70184b46e69f2e24c70b85ec254edd64 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/60756/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index ec7fd86..7edd32d 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -170,7 +170,7 @@ /* C13: Not Connected */ PAD_NC(GPP_C13, NONE), /* C14: TPM_IRQ */ - PAD_NC(GPP_C14, NONE), + PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), /* C15: TPM_RST */ PAD_NC(GPP_C15, NONE), /* C16: I2C0_SDA */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife88075e70184b46e69f2e24c70b85ec254edd64 Gerrit-Change-Number: 60756 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/starlabs/labtop: Don't configure ESPI GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60755 ) Change subject: mb/starlabs/labtop: Don't configure ESPI GPIOs ...................................................................... mb/starlabs/labtop: Don't configure ESPI GPIOs Don't configure ESPI GPIOs as they are configured elsewhere. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I052fbfccd075d19340d3e27ad0c62965c80badaf --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/60755/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index c889da9..ec7fd86 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -51,19 +51,12 @@ PAD_CFG_GPO(GPD11, 0, PWROK), /* A0: ESPI_IO_0 */ - PAD_CFG_NF(GPP_A0, UP_20K, DEEP, NF1), /* A1: ESPI_IO_1 */ - PAD_CFG_NF(GPP_A1, UP_20K, DEEP, NF1), /* A2: ESPI_IO_2 */ - PAD_CFG_NF(GPP_A2, UP_20K, DEEP, NF1), /* A3: ESPI_IO_3 */ - PAD_CFG_NF(GPP_A3, UP_20K, DEEP, NF1), /* A4: ESPI_CS_L */ - PAD_CFG_NF(GPP_A4, UP_20K, DEEP, NF1), /* A5: ESPI_CLK */ - PAD_CFG_NF(GPP_A5, DN_20K, DEEP, NF1), /* A6: Not Connected(TP764) */ - PAD_CFG_NF(GPP_A6, NONE, DEEP, NF1), /* A7: WLAN_PCM_CLK */ PAD_NC(GPP_A7, NONE), /* A8: WLAN_PCM_RST */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I052fbfccd075d19340d3e27ad0c62965c80badaf Gerrit-Change-Number: 60755 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya: Enable CNVi DDR RFIM for base board brya
by Ronak Kanabar (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60740 ) Change subject: mb/google/brya: Enable CNVi DDR RFIM for base board brya ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60740/comment/ca56ac01_6286f4ee PS3, Line 9: Enable > enables Done https://review.coreboot.org/c/coreboot/+/60740/comment/417cc9f4_635ac1c8 PS3, Line 9: set > sets Done https://review.coreboot.org/c/coreboot/+/60740/comment/b5960bbe_ede9ef73 PS3, Line 14: debug FSP > Is that available, if not, how can it be checked without it? Debug FSP need to build using FSP source. -- To view, visit https://review.coreboot.org/c/coreboot/+/60740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Gerrit-Change-Number: 60740 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 11:05:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable CNVi DDR RFIM for base board brya
by Ronak Kanabar (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Tim Wawrzynczak, Ronak Kanabar. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60740 to look at the new patch set (#4). Change subject: mb/google/brya: Enable CNVi DDR RFIM for base board brya ...................................................................... mb/google/brya: Enable CNVi DDR RFIM for base board brya This patch sets CnviDdrRfim UPD and enables CNVI DDR RFIM for all brya variants. BUG=b:201724512 BRANCH=None TEST=Build and boot with debug FSP and verify CnviDdrRfim UPD value. Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com> --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/60740/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Gerrit-Change-Number: 60740 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Add comments for GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Andy Pont, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60123 to look at the new patch set (#29). Change subject: mb/starlabs/labtop: Add comments for GPIOs ...................................................................... mb/starlabs/labtop: Add comments for GPIOs Add comment for each GPIO details its endpoint based on the schematic. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 211 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60123/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 29 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Tidy up GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Andy Pont, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60123 to look at the new patch set (#28). Change subject: mb/starlabs/labtop: Tidy up GPIOs ...................................................................... mb/starlabs/labtop: Tidy up GPIOs Add label to GPIO and categorise per device Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 211 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60123/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 28 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Tidy up GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Andy Pont, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60123 to look at the new patch set (#27). Change subject: mb/starlabs/labtop: Tidy up GPIOs ...................................................................... mb/starlabs/labtop: Tidy up GPIOs Add label to GPIO and categorise per device Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 210 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60123/27 -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/latop: Disconnect unused GPIO's
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60754 ) Change subject: mb/starlabs/latop: Disconnect unused GPIO's ...................................................................... mb/starlabs/latop: Disconnect unused GPIO's Disconnect all GPIO's that aren't connected to anything. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2050da62f73c0f99fbfef013c22e35225cc480c4 --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 42 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60754/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c index 07a66af..2fae17d 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c @@ -30,7 +30,7 @@ /* GPD1: AC_PRESENT */ PAD_CFG_NF(GPD1, NATIVE, PWROK, NF1), /* GPD2: LAN_WAKE# */ - PAD_CFG_NF(GPD2, NATIVE, PWROK, NF1), + PAD_NC(GPD2, NONE), /* GPD3: SIO_PWRBTN# */ PAD_CFG_NF(GPD3, UP_20K, PWROK, NF1), /* GPD4: SIO_SLP_S3# */ @@ -79,7 +79,7 @@ /* A13: Not Connected */ PAD_NC(GPP_A13, NONE), /* A14: Not Connected */ - PAD_CFG_GPO(GPP_A14, 0, PLTRST), + PAD_NC(GPP_A14, NONE), /* A15 Not Connected */ PAD_NC(GPP_A15, NONE), /* A16: USB2_OCB_3 */ @@ -134,7 +134,7 @@ /* B16: M2_PCH_SSD_PWREN */ PAD_NC(GPP_B16, NONE), /* B17: Not Connected */ - PAD_CFG_GPO(GPP_B17, 0, PWROK), + PAD_NC(GPP_B17, NONE), /* B18: UF_CAM_STROBE */ PAD_CFG_GPO(GPP_B18, 0, DEEP), /* B19: GSPI1_CS0_FPS_N */ @@ -169,13 +169,13 @@ /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), /* C10: Not Connected */ - PAD_CFG_GPO(GPP_C10, 0, PWROK), + PAD_NC(GPP_C10, NONE), /* C11: Not Connected */ - PAD_CFG_GPO(GPP_C11, 0, PWROK), + PAD_NC(GPP_C11, NONE), /* C12: Not Connected */ - PAD_CFG_NF(GPP_C12, NONE, DEEP, NF1), + PAD_NC(GPP_C12, NONE), /* C13: Not Connected */ - PAD_CFG_GPO(GPP_C13, 1, PLTRST), + PAD_NC(GPP_C13, NONE), /* C14: TPM_IRQ */ PAD_NC(GPP_C14, NONE), /* C15: TPM_RST */ @@ -198,27 +198,27 @@ /* D1: ACCEL2_INT */ PAD_NC(GPP_D1, NONE), /* D2: Not Connected */ - PAD_CFG_GPI(GPP_D2, NONE, DEEP), + PAD_NC(GPP_D2, NONE), /* D3: Not Connected */ - PAD_CFG_GPI(GPP_D3, NONE, DEEP), + PAD_NC(GPP_D3, NONE), /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), /* D5: CLKREQ0_M2_SSD_N */ - PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), + PAD_NC(GPP_D5, NONE), /* D6: CLKREQ1_WLAN_N */ - PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), + PAD_NC(GPP_D6, NONE), /* D7: LAN_CLKREQ# */ - PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), + PAD_NC(GPP_D7, NONE), /* D8: Not Connected */ - PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), + PAD_NC(GPP_D8, NONE), /* D9: Not Connected */ - PAD_NC(GPP_D9, NATIVE), + PAD_NC(GPP_D9, NONE), /* D10: Not Connected */ - PAD_NC(GPP_D10, NATIVE), + PAD_NC(GPP_D10, NONE), /* D11: Not Connected */ - PAD_NC(GPP_D11, NATIVE), + PAD_NC(GPP_D11, NONE), /* D12: Not Connected */ - PAD_NC(GPP_D12, NATIVE), + PAD_NC(GPP_D12, NONE), /* D13: Not Connected */ PAD_NC(GPP_D13, NONE), /* D14: Not Connected */ @@ -228,9 +228,9 @@ /* D16: CPU_SSD_PWREN */ PAD_CFG_GPO(GPP_D16, 1, PLTRST), /* D17: Not Connected */ - PAD_CFG_GPI(GPP_D17, NONE, DEEP), + PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ - PAD_CFG_GPI(GPP_D18, NONE, DEEP), + PAD_NC(GPP_D18, NONE), /* D19: GPPC_D_19_WFCAM_PD_N */ PAD_CFG_TERM_GPO(GPP_D19, 1, UP_20K, DEEP), @@ -265,9 +265,9 @@ /* E14: EDP_HPD */ PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ - PAD_CFG_NF(GPP_E15, NONE, DEEP, NF2), + PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ - PAD_CFG_NF(GPP_E16, NONE, DEEP, NF2), + PAD_NC(GPP_E16, NONE), /* E17: Not Connected */ PAD_NC(GPP_E17, NONE), /* E18: TBT_LSX0_TXD */ @@ -275,13 +275,13 @@ /* E19: TBT_LSX0_RXD */ PAD_NC(GPP_E19, NATIVE), /* E20: Not Connected */ - PAD_NC(GPP_E20, NATIVE), + PAD_NC(GPP_E20, NONE), /* E21: TBT_LSX1_RXD */ PAD_NC(GPP_E21, NATIVE), /* E22: Not Connected */ - PAD_CFG_NF(GPP_E22, DN_20K, DEEP, NF2), + PAD_NC(GPP_E22, NONE), /* E23: Not Connected */ - PAD_CFG_GPO(GPP_E23, 0, DEEP), + PAD_NC(GPP_E23, NONE), /* F0: CNV_BRI_DT_BT_UART0_RTS_R */ PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), @@ -292,9 +292,9 @@ /* F3: CNV_RGI_RSP_BT_UART0_CTS */ PAD_CFG_NF(GPP_F3, UP_20K, DEEP, NF1), /* F4: Not Connected */ - PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1), + PAD_NC(GPP_F4, NONE), /* F5: GPPC_F5_MODEM_CLKREQ */ - PAD_CFG_NF(GPP_F5, NONE, DEEP, NF2), + PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3), /* F6: Not Connected */ PAD_NC(GPP_F6, NONE), /* F7: BIOS_REC */ @@ -302,7 +302,7 @@ /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: Not Connected */ - PAD_CFG_GPO(GPP_F9, 1, PLTRST), + PAD_NC(GPP_F9, NONE), /* F10: GPPC_F_10 */ PAD_CFG_GPO(GPP_F10, 0, DEEP), /* F11: Not Connected */ @@ -324,9 +324,9 @@ /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), /* F20: Not Connected */ - PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), + PAD_NC(GPP_F20, NONE), /* F21: Not Connected */ - PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), /* F23: Not Connected */ @@ -341,17 +341,17 @@ /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H4: GSENSOR_I2C_SDA */ - PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), + PAD_NC(GPP_H4, NONE), /* H5: GSENSOR_I2C_SCL */ - PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), + PAD_NC(GPP_H5, NONE), /* H6: Not Connected */ - PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), + PAD_NC(GPP_H6, NONE), /* H7: Not Connected */ - PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), + PAD_NC(GPP_H7, NONE), /* H8: Not Connected */ - PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1), + PAD_NC(GPP_H8, NONE), /* H9: Not Connected */ - PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), + PAD_NC(GPP_H9, NONE), /* H10: Not Connected */ PAD_NC(GPP_H10, NONE), /* H11: Not Connected */ @@ -361,7 +361,7 @@ /* H13: Not Connected */ PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ - PAD_CFG_GPO(GPP_H14, 1, PLTRST), + PAD_NC(GPP_H14, NONE), /* H15: Not Connected */ PAD_NC(GPP_H15, NONE), /* H16: DDIB_DDC_SCL */ @@ -379,7 +379,7 @@ /* H22: Not Connected */ PAD_NC(GPP_H22, NONE), /* H23: Not Connected */ - PAD_CFG_GPO(GPP_H23, 0, DEEP), + PAD_NC(GPP_H23, NONE), /* R0: HDA_BCLK */ PAD_CFG_NF(GPP_R0, NONE, DEEP, NF1), @@ -390,11 +390,11 @@ /* R3: HDA_SDI_0_SSP0_RXD */ PAD_CFG_NF(GPP_R3, NATIVE, DEEP, NF1), /* R4: Not Connected */ - PAD_CFG_NF(GPP_R4, NONE, DEEP, NF1), + PAD_NC(GPP_R4, NONE), /* R5: Not Connected */ - PAD_CFG_GPO(GPP_R5, 0, PLTRST), + PAD_NC(GPP_R5, NONE), /* R6: Not Connected */ - PAD_CFG_GPO(GPP_R6, 1, PLTRST), + PAD_NC(GPP_R6, NONE), /* R7: Not Connected */ PAD_NC(GPP_R7, NONE), @@ -416,9 +416,9 @@ PAD_NC(GPP_S7, NONE), /* T2: Not Connected */ - PAD_CFG_NF(GPP_T2, DN_20K, DEEP, NF2), + PAD_NC(GPP_T2, NONE), /* T3: Not Connected */ - PAD_CFG_NF(GPP_T3, DN_20K, DEEP, NF2), + PAD_NC(GPP_T3, NONE), /* U4: Not Connected */ PAD_NC(GPP_U4, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/60754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2050da62f73c0f99fbfef013c22e35225cc480c4 Gerrit-Change-Number: 60754 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/starlabs/labtop: Tidy up GPIOs
by Sean Rhodes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Andy Pont, Angel Pons, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Andy Pont, Angel Pons, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60123 to look at the new patch set (#26). Change subject: mb/starlabs/labtop: Tidy up GPIOs ...................................................................... mb/starlabs/labtop: Tidy up GPIOs Add label to GPIO and categorise per device Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a --- M src/mainboard/starlabs/labtop/variants/tgl/gpio.c 1 file changed, 209 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60123/26 -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 26 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022