Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro, Alan Huang, Zhuohao Lee.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60439 )
Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60439/comment/367a9715_86ab9cef
PS4, Line 9: latest schematics
Boards with older schematics were not sold, right?
https://review.coreboot.org/c/coreboot/+/60439/comment/70e6bc97_ac43bc25
PS4, Line 9: The latest schematics changes the TPM I2C from I2C3 to I2C1.
: This patch moves the TPM I2C setting from the board layer to the
: baseboard and fixes the TPM I2C bus assignment.
Please either add a blank line between paragraphs, or reflow for 72 characters per line.
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60439/comment/4e972149_478c08ad
PS4, Line 91: .rise_time_ns = 600,
: .fall_time_ns = 400,
: .data_hold_time_ns = 50,
Where are these values from?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c
Gerrit-Change-Number: 60439
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth - Personal, Stefan Reinauer.
Hello build bot (Jenkins), Martin Roth - Personal, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60761
to look at the new patch set (#3).
Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key
......................................................................
payloads/tianocore: Add option to use F7 as Boot Manager key
The coreboot version of Tianocore maps Escape to the boot menu.
This is problematic for many Linux distributions that use GRUB,
as this also maps Escape to access it's menu. This option can
be used to use F7 to replace Escape
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
---
M payloads/external/Makefile.inc
M payloads/external/tianocore/Kconfig
M payloads/external/tianocore/Makefile
3 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60761/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
Gerrit-Change-Number: 60761
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rex-BC Chen, Paul Menzel.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60529
to look at the new patch set (#10).
Change subject: soc/mediatek/mt8186: Increase CBFS_MCACHE size to 8KiB
......................................................................
soc/mediatek/mt8186: Increase CBFS_MCACHE size to 8KiB
The current CBFS mcache size (roughly 7KiB) is insufficient for mt8186,
so we need to increase it by 1KiB (and decrease the stack by 1KiB).
Error logs:
CBFS ERROR: mcache overflow, should increase CBFS_MCACHE size!
CBFS: mcache @0x0010e004 built for 63 files, used 0xde4 of 0xdfc bytes
BUG=b:202871018
TEST=no cbfs error logs.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I1e627ede3774665575006f752f89101e3c5bde9f
---
M src/soc/mediatek/mt8186/include/soc/memlayout.ld
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60529/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/60529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e627ede3774665575006f752f89101e3c5bde9f
Gerrit-Change-Number: 60529
Gerrit-PatchSet: 10
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rex-BC Chen, Paul Menzel.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60529 )
Change subject: soc/mediatek/mt8186: Increase CBFS_MCACHE size to 8 KiB
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60529/comment/2e5c9bc8_278e24ae
PS9, Line 10: increase it by 1KiB.
maybe:
we need to increase it by 1KiB (and decrease the stack by 1KiB).
--
To view, visit https://review.coreboot.org/c/coreboot/+/60529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e627ede3774665575006f752f89101e3c5bde9f
Gerrit-Change-Number: 60529
Gerrit-PatchSet: 9
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 13:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 )
Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/60721/comment/93c3b604_d5307b1b
PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot.
> Hmm, Why not keep HECI in the name? DISABLE_HECI or HIDE_HECI
The only problem that I'm trying to avoid by not calling it "Heci" alone is that, there are multiple Heci devices so, DISABLE_HECI might sounds like we are providing API to make all heci devices disable.
device pci 16.0 alias heci1 off end
device pci 16.1 alias heci2 off end
device pci 16.4 alias heci3 off end
device pci 16.5 alias heci4 off end
Otherwise we might need to say DISABLE/HIDE_HECI1 ? to specify its CSE/Heci1 alone. WDYT?
> would be very clear to me. It could still say CSE in the prompt, e.g.
> "Disable CSE interface (HECI)".
Sure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e127816c506df3ac0cf973b69021d02d05bef4a
Gerrit-Change-Number: 60721
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 12:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60643 )
Change subject: payloads/tianocore: Add option to change Boot Menu key
......................................................................
Abandoned
Created in a different way
--
To view, visit https://review.coreboot.org/c/coreboot/+/60643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41df3e15aa73be41fb9836fe6e202319b02a3ffb
Gerrit-Change-Number: 60643
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: abandon
Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60761 )
Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key
......................................................................
payloads/tianocore: Add option to use F7 as Boot Manager key
The coreboot version of Tianocore maps Escape to the boot menu.
This is problematic for many Linux distributions that use GRUB,
as this also maps Escape to access it's menu. This option can
be used to specific an F-Key to replace Escape
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
---
M payloads/external/Makefile.inc
M payloads/external/tianocore/Kconfig
M payloads/external/tianocore/Makefile
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60761/1
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index ade22b5..e5c76bf 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -148,6 +148,7 @@
CONFIG_TIANOCORE_UPSTREAM=$(CONFIG_TIANOCORE_UPSTREAM) \
CONFIG_ECAM_MMCONF_BASE_ADDRESS=$(CONFIG_ECAM_MMCONF_BASE_ADDRESS) \
CONFIG_TIANOCORE_ABOVE_4G_MEMORY=$(CONFIG_TIANOCORE_ABOVE_4G_MEMORY) \
+ CONFIG_TIANOCORE_BOOT_MANAGER_F7=$(CONFIG_TIANOCORE_BOOT_MANAGER_F7) \
CONFIG_TIANOCORE_BOOT_TIMEOUT=$(CONFIG_TIANOCORE_BOOT_TIMEOUT) \
CONFIG_TIANOCORE_CBMEM_LOGGING=$(CONFIG_TIANOCORE_CBMEM_LOGGING) \
CONFIG_TIANOCORE_COREBOOTPAYLOAD=$(CONFIG_TIANOCORE_COREBOOTPAYLOAD) \
diff --git a/payloads/external/tianocore/Kconfig b/payloads/external/tianocore/Kconfig
index 1291122..bbc3788 100644
--- a/payloads/external/tianocore/Kconfig
+++ b/payloads/external/tianocore/Kconfig
@@ -116,6 +116,13 @@
bool "Enable Secure Boot Support"
default y
+config TIANOCORE_BOOT_MANAGER_F7
+ bool "Use F7 key for Boot Manager"
+ default n
+ help
+ Use F7 as the hot-key to access the Boot Manager. This replaces
+ the default key of Esc, which can conflict with GRUB.
+
endif
if TIANOCORE_COREBOOTPAYLOAD
diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile
index e54b739..3aadf8e 100644
--- a/payloads/external/tianocore/Makefile
+++ b/payloads/external/tianocore/Makefile
@@ -46,6 +46,9 @@
4G=-D ABOVE_4G_MEMORY=FALSE
endif
+ifeq ($(CONFIG_TIANOCORE_BOOT_MANAGER_F7),y)
+KEY=-D BOOT_MANAGER_F7=TRUE
+endif
ifeq ($(CONFIG_TIANOCORE_SECUREBOOT),y)
SB=-D SECURE_BOOT_ENABLE=TRUE
--
To view, visit https://review.coreboot.org/c/coreboot/+/60761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
Gerrit-Change-Number: 60761
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-MessageType: newchange