Attention is currently required from: Name of user not set #1004065, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60737 )
Change subject: util/ifdtool: Add support for Denverton platforms.
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60737/comment/61902837_5c640d5b
PS1, Line 7: util/ifdtool: Add support for Denverton platforms.
Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/c/coreboot/+/60737/comment/2bab4c7e_2666c22d
PS1, Line 8:
Please mention, that you sort the enum members, and add TEST= on what device you tested this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced
Gerrit-Change-Number: 60737
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1004065
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Name of user not set #1004065
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Name of user not set #1004065, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 )
Change subject: util/ifdtool: Add additional regions for platforms that support them.
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60736/comment/79b17f71_c05ab810
PS1, Line 7: util/ifdtool: Add additional regions for platforms that support them.
Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/c/coreboot/+/60736/comment/4a4ae165_19cff032
PS1, Line 9: Some Intel SoCs
… like X …
https://review.coreboot.org/c/coreboot/+/60736/comment/1ada13b1_1c7b2cde
PS1, Line 9: Some Intel SoCs support additional IFD regions for things like embedded LAN FW or
: Innovation Engine firmware, etc.
Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/60736/comment/018f1a60_b7e31c9d
PS1, Line 11:
Maybe add TEST= with an example command, you tested.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64cc1d787f15a01dff7db89218410228fd0082a6
Gerrit-Change-Number: 60736
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1004065
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Name of user not set #1004065
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:08:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, David Wu, Subrata Banik, Tim Wawrzynczak, Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60739 )
Change subject: mb/google/brya: Allow primus variant to choose eNEM CAR
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65d12de08adf85140976e1a7659ad7b684aa75c8
Gerrit-Change-Number: 60739
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:05:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, yu jiaxin, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 )
Change subject: mb/google/corsola: Support audio
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60738/comment/8a45129c_f19e4e10
PS4, Line 7: Support
Configure
https://review.coreboot.org/c/coreboot/+/60738/comment/178f1c9f_99e19b9a
PS4, Line 9: Turn on setting of audio power and select I2S pin-mux.
… according to schematics?
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60738/comment/e7abe88f_34f4abbf
PS3, Line 29: /* Power on audio */
Unnecessary, as the function name is descriptive enough.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6374d0e5535b7cff4df8759312786fef8b94b6b
Gerrit-Change-Number: 60738
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: yu jiaxin <jiaxin.yu(a)mediatek.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: yu jiaxin <jiaxin.yu(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60388 )
Change subject: mb/google/brya/var/kano: Disable autonomous GPIO power management
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60388/comment/ff5f8ac0_2b0417e3
PS3, Line 11:
Is the cr50 FW being fixed, so this is just a workaround?
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60388/comment/c195541b_33aeff49
PS3, Line 18: disabled
disables
https://review.coreboot.org/c/coreboot/+/60388/comment/fd7100b1_4d15bc71
PS3, Line 18: otherwise
since?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9607af42a00c1b5f38c6e4e0effdeeaba18af5ff
Gerrit-Change-Number: 60388
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Joey Peng, YH Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60341 )
Change subject: mb/google/brya/var/taeko: Run-time probe for NVMe SSD and MMC
......................................................................
Patch Set 14: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4486f23ea02374c84a9b1ce04f568d78aeabd573
Gerrit-Change-Number: 60341
Gerrit-PatchSet: 14
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:00:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro, Alan Huang, Zhuohao Lee.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60439 )
Change subject: mb/google/brya/var/brask: Change TPM I2C to I2C1
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60439/comment/367a9715_86ab9cef
PS4, Line 9: latest schematics
Boards with older schematics were not sold, right?
https://review.coreboot.org/c/coreboot/+/60439/comment/70e6bc97_ac43bc25
PS4, Line 9: The latest schematics changes the TPM I2C from I2C3 to I2C1.
: This patch moves the TPM I2C setting from the board layer to the
: baseboard and fixes the TPM I2C bus assignment.
Please either add a blank line between paragraphs, or reflow for 72 characters per line.
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60439/comment/4e972149_478c08ad
PS4, Line 91: .rise_time_ns = 600,
: .fall_time_ns = 400,
: .data_hold_time_ns = 50,
Where are these values from?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d5a8fde1866c5dd4587ab5af2d41724c60ee0c
Gerrit-Change-Number: 60439
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth - Personal, Stefan Reinauer.
Hello build bot (Jenkins), Martin Roth - Personal, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60761
to look at the new patch set (#3).
Change subject: payloads/tianocore: Add option to use F7 as Boot Manager key
......................................................................
payloads/tianocore: Add option to use F7 as Boot Manager key
The coreboot version of Tianocore maps Escape to the boot menu.
This is problematic for many Linux distributions that use GRUB,
as this also maps Escape to access it's menu. This option can
be used to use F7 to replace Escape
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
---
M payloads/external/Makefile.inc
M payloads/external/tianocore/Kconfig
M payloads/external/tianocore/Makefile
3 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60761/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ided23e82161488768aa3b7d54ab17e9c922d6d11
Gerrit-Change-Number: 60761
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset