coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: mb/google/trogdor: Add LCM_ID to SKU_ID
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57329 to look at the new patch set (#4). Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID ...................................................................... mb/google/trogdor: Add LCM_ID to SKU_ID In order to distinguish which mipi panel to use, it need to read the LCM_ID, and combine the LCM_ID and SKU_ID into a new SKU_ID BUG=b:197708579,b:191574572 TEST=LCM_ID should be set correctly. BRANCH=none Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/trogdor/boardid.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/57329/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/nipperkin: update nipperkin config
by Eric Peers (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Kevin Chiu, Martin Roth, Rob Barnes, Karthik Ramasubramanian, Felix Held. Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57263 ) Change subject: mb/google/guybrush/nipperkin: update nipperkin config ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb: https://review.coreboot.org/c/coreboot/+/57263/comment/b7c7b37f_33b2c450 PS1, Line 26: option WWAN_FM350GL 2 if not in use/intended to be used, recommend removal. -- To view, visit https://review.coreboot.org/c/coreboot/+/57263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58a9b8393a965a9c793802d3e660829863b74375 Gerrit-Change-Number: 57263 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Sep 2021 03:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, Paul Menzel, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57201 ) Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57201/comment/c24548fe_54550c06 PS1, Line 9: Commit cf5d58328fe004d967466be42de62d6bab4c3133 > I’d use the short hash, and please add the commit message summary in brackets behind. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 5 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 03:01:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, shkim, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57201 to look at the new patch set (#5). Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... soc/intel/jasperlake: Utilize vbt data size Kconfig option Commit cf5d58328f(increase vbt_data size) had changed the vbt data size to 9 Kib in drivers/gma. This change makes use of Kconfig option to pick the size for jasperlake. BUG=b:194029827 BRANCH=dedede TEST=build and boot bugzzy and verify fw screen is loaded Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/57201/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 5 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, shkim, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57201 to look at the new patch set (#4). Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... soc/intel/jasperlake: Utilize vbt data size Kconfig option Commit cf5d58328f(increase vbt_data size) had changed the vbt data size to 9 Kib in drivers/gma. This change makes use of Kconfig option to pick the size for jasperlake. BUG=b:194029827 BRANCH=dedede TEST=build and boot bugzzy and verify fw screen is loaded Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/57201/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 4 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57201 to look at the new patch set (#3). Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... soc/intel/jasperlake: Utilize vbt data size Kconfig option Commit cf5d58328f(increase vbt_data size) had changed the size 9 Kib in drivers/gma. This change makes use of Kconfig option to pick the size for jasperlake. BUG=b:194029827 BRANCH=dedede TEST=build and boot bugzzy and verify fw screen is loaded Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/57201/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 3 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [UNTESTED] drivers/intel/fsp2_0/Makefile: add condition for FSP-T CBF...
by Furquan Shaikh (Code Review) 02 Sep '21

02 Sep '21

1 0

Change in coreboot[master]: drivers/intel/fsp/Makefile: warn when FSP files aren't specified
by Furquan Shaikh (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, Andrey Petrov, Patrick Rudolph, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57219 ) Change subject: drivers/intel/fsp/Makefile: warn when FSP files aren't specified ...................................................................... Patch Set 1: Code-Review+2 (3 comments) File src/drivers/intel/fsp2_0/Makefile.inc: https://review.coreboot.org/c/coreboot/+/57219/comment/abbae5aa_6e50fcec PS1, Line 101: CONFIG_FSP_T_FILE > CB:57220 […] Ack https://review.coreboot.org/c/coreboot/+/57219/comment/d255c082_2f73a4ea PS1, Line 102: warning > wasn't sure if this will break some case, so i made this print a warning and not throw an error It might make sense to make this an error. If ADD_FSP_BINARIES are set and the files are not provided, then it is an invalid condition. https://review.coreboot.org/c/coreboot/+/57219/comment/2de18c4a_aad2c3fb PS1, Line 105: $(call strip_quotes,$(CONFIG_FSP_M_FILE)) > no, FSP_M_CBFS is the result of calling strip_quotes on CONFIG_FSP_M_CBFS, not CONFIG_FSP_M_FILE Ack. -- To view, visit https://review.coreboot.org/c/coreboot/+/57219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5f2d75d066f0b4e491e9c8420b7a0cbd4ba9e28 Gerrit-Change-Number: 57219 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/edid_fill_fb: Make framebuffer orientation to be configurable
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, Paul Menzel, SH Kim, Julius Werner, Yu-Ping Wu, Karthik Ramasubramanian. shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 ) Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57327/comment/154439cc_abfe6ba5 PS1, Line 9: , t > . T Done File src/lib/edid_fill_fb.c: https://review.coreboot.org/c/coreboot/+/57327/comment/d85c1349_183438a1 PS1, Line 77: 1 > -1 OMG. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/57327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa Gerrit-Change-Number: 57327 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:44:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/edid_fill_fb: Make framebuffer orientation to be configurable
by Yu-Ping Wu (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, shkim, Paul Menzel, SH Kim, Julius Werner, Karthik Ramasubramanian. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 ) Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57327/comment/06d6097e_b770fefa PS1, Line 9: , t . T File src/lib/edid_fill_fb.c: https://review.coreboot.org/c/coreboot/+/57327/comment/c9e41724_b5064547 PS1, Line 77: 1 -1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa Gerrit-Change-Number: 57327 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021