coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by Dun Tan (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Patrick Rudolph, Paul Menzel, King Sumo. Dun Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57296 ) Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... Patch Set 4: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57296/comment/e3241dbf_a739d835 PS3, Line 7: Fix the bug > Fix bug Done https://review.coreboot.org/c/coreboot/+/57296/comment/7442efce_874bbcb3 PS3, Line 7: Uefipayload > UefiPayload Done https://review.coreboot.org/c/coreboot/+/57296/comment/6cc68705_d815461a PS3, Line 7: cbftool > cbfstool Done https://review.coreboot.org/c/coreboot/+/57296/comment/72618e39_a7dced95 PS3, Line 9: The patch is to fix "Not a usable UEFI firmware volume" issue when : creating CBFS/flash image. > Is that documented somewhere? Please add a reference, or elaborate how to reproduce this. […] Done https://review.coreboot.org/c/coreboot/+/57296/comment/0267f3de_7fcb50a5 PS3, Line 10: This issue is caused by adding FvNameGuid : in UefiPayloadEntry.fdf in EDKII. There is an ext header between header : of Fv and header of PayloadEntry in Fv with FvNameGuid. The ext header : causes the UefiPayloadEntry to be found incorrectly when parsing Fv. > Please mention that in the commit message. Done https://review.coreboot.org/c/coreboot/+/57296/comment/23ac070a_547648e7 PS3, Line 14: > Please add the link and offending EDK2 commit hash to the commit message as well. Done Patchset: PS4: Thanks. The commit hash in edk2 and bugzila link have been added in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 4 Gerrit-Owner: Dun Tan <dun.tan(a)intel.com> Gerrit-Reviewer: King Sumo <kingsumos(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ray Ni <ray.ni(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:20:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Comment-In-Reply-To: King Sumo <kingsumos(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by Dun Tan (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Patrick Rudolph, Dun Tan, King Sumo. Hello Ray Ni, build bot (Jenkins), Patrick Rudolph, Patrick Rudolph, King Sumo, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57296 to look at the new patch set (#4). Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... util/cbftool: Fix the bug in parsing Uefipayload with extended header The patch is to fix "Not a usable UEFI firmware volume" issue when creating CBFS/flash image. This issue is caused by adding FvNameGuid in UefiPayloadEntry.fdf in EDKII. There is an ext header between header of Fv and header of PayloadEntry in Fv with FvNameGuid. The ext header causes the UefiPayloadEntry to be found incorrectly when parsing Fv. Commit in EDKII: 4bac086e8e007c7143e33f87bb96238326d1d6ba Bugzila: https://bugzilla.tianocore.org/show_bug.cgi?id=3585 Signed-off-by: Dun Tan <dun.tan(a)intel.com> Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/fv.h 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/57296/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 4 Gerrit-Owner: Dun Tan <dun.tan(a)intel.com> Gerrit-Reviewer: King Sumo <kingsumos(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ray Ni <ray.ni(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Dun Tan <dun.tan(a)intel.com> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Make framebuffer orientation to be configurable
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, Paul Menzel, Julius Werner. shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57199 ) Change subject: drivers/intel/fsp2_0: Make framebuffer orientation to be configurable ...................................................................... Patch Set 1: (1 comment) This change is ready for review. File src/drivers/intel/fsp2_0/graphics.c: https://review.coreboot.org/c/coreboot/+/57199/comment/9f7e31fe_627876dc PS1, Line 103: enum lb_fb_orientation __weak fsp_get_framebuffer_orientation(void) > There's a call to fb_add_framebuffer_info_ex() above. I have no idea why it couldn't be done inside that function or below. Thanks, it seems good to place the orientation override. Please see a new patch - CB:57327. -- To view, visit https://review.coreboot.org/c/coreboot/+/57199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If51d2698d5fdf651183a908717076c8a14605997 Gerrit-Change-Number: 57199 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:12:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: shkim <sh_.kim(a)samsung.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by build bot (Jenkins) (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: zanxi chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/trogdor/boardid.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127300): https://review.coreboot.org/c/coreboot/+/57329/comment/62ed2bcf_cb5b9a8a PS2, Line 50: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 2 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:11:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

zanxi chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... mb/google/trogdor: Read LCM_ID and put into SKU_ID Read/return LCM_ID as part of SKU_ID, so the mipi panel can be compatible in this way. BUG=b:197708579,b:191574572 TEST=LCM_ID should be set correctly. BRANCH=none Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/trogdor/boardid.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/57329/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 2 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

zanxi chen has removed Weimin Wu from this change. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... Removed reviewer Weimin Wu. -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

zanxi chen has removed Xuxin Xiong from this change. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... Removed reviewer Xuxin Xiong. -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by build bot (Jenkins) (Code Review) 02 Sep '21

02 Sep '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/trogdor/boardid.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127299): https://review.coreboot.org/c/coreboot/+/57329/comment/ada52502_17b7700d PS1, Line 50: if (CONFIG(TROGDOR_HAS_MIPI_PANEL)) suspect code indent for conditional statements (16, 20) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127299): https://review.coreboot.org/c/coreboot/+/57329/comment/afa84460_3b5720bc PS1, Line 52: else suspect code indent for conditional statements (16, 20) -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 02:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Read LCM_ID and put into SKU_ID
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

zanxi chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Read LCM_ID and put into SKU_ID ...................................................................... mb/google/trogdor: Read LCM_ID and put into SKU_ID Read/return LCM_ID as part of SKU_ID, so the mipi panel can be compatible in this way. BUG=b:197708579,b:191574572 TEST=LCM_ID should be set correctly. BRANCH=none Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/trogdor/boardid.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/57329/1 diff --git a/src/mainboard/google/trogdor/boardid.c b/src/mainboard/google/trogdor/boardid.c index c972160..3c3ba99 100644 --- a/src/mainboard/google/trogdor/boardid.c +++ b/src/mainboard/google/trogdor/boardid.c @@ -42,6 +42,19 @@ return id; } +static uint8_t lcm_id(void) +{ + static uint32_t id = UNDEFINED_STRAPPING_ID; + const gpio_t pins[] = {[0] = GPIO(4)}; + if (id == UNDEFINED_STRAPPING_ID) { + if (CONFIG(TROGDOR_HAS_MIPI_PANEL)) + id = gpio_base2_value(pins, ARRAY_SIZE(pins)); + else + id = 0; + } + return id; +} + uint32_t sku_id(void) { static uint32_t id = UNDEFINED_STRAPPING_ID; @@ -56,5 +69,7 @@ id = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); } + id = lcm_id() << 4 | id; + return id; } -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Adjust framebuffer orientation
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: SH Kim. Hello SH Kim, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/57328 to review the following change. Change subject: mb/google/dedede/var/bugzzy: Adjust framebuffer orientation ...................................................................... mb/google/dedede/var/bugzzy: Adjust framebuffer orientation Bugzzy's panel displays portrait mode as default, this change rotates the screen to show landscape firmware UI. BUG=b:194967458 BRANCH=dedede TEST=Built checked FW screen UI on bugzzy Change-Id: Ia3477255bab4d99bad5948fd5a4828aa61d8cfa0 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/mainboard/google/dedede/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/57328/1 diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 3167055..2ac83a2 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -80,6 +80,9 @@ default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-dedede-16MiB.fmd" if BOARD_ROMSIZE_KB_16384 default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-dedede-32MiB.fmd" if BOARD_ROMSIZE_KB_32768 +config FRAMEBUFFER_ORIENTATION_OVERRIDE + default 3 if BOARD_GOOGLE_SASUKE # LB_FB_ORIENTATION_RIGHT_UP + config MAINBOARD_DIR default "google/dedede" -- To view, visit https://review.coreboot.org/c/coreboot/+/57328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3477255bab4d99bad5948fd5a4828aa61d8cfa0 Gerrit-Change-Number: 57328 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021