coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Felix Singer (Code Review) 03 Sep '21

03 Sep '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57393 to look at the new patch set (#3). Change subject: util/liveiso: Make neovim the default editor ...................................................................... util/liveiso: Make neovim the default editor Make neovim the default editor and create aliases for vi and vim. The NixOS module for neovim is currently broken. Thus, add a note to `description.md` to do that later. Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix M util/liveiso/description.md 2 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/57393/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Felix Singer (Code Review) 03 Sep '21

03 Sep '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57393 to look at the new patch set (#2). Change subject: util/liveiso: Make neovim the default editor ...................................................................... util/liveiso: Make neovim the default editor Make neovim the default editor and create aliases for vi and vim. The NixOS module for neovim is currently broken. Thus, add a note to description.md to do that later. Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix M util/liveiso/description.md 2 files changed, 16 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/57393/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by Karthik Ramasubramanian (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Jamie Chen, shkim, Paul Menzel, SH Kim, Patrick Rudolph. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57201 ) Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 9 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 20:46:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Felix Singer (Code Review) 03 Sep '21

03 Sep '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57393 ) Change subject: util/liveiso: Make neovim the default editor ...................................................................... util/liveiso: Make neovim the default editor Make neovim the default editor and create aliases for vi and vim. Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/57393/1 diff --git a/util/liveiso/common.nix b/util/liveiso/common.nix index 941e624..1b05474 100644 --- a/util/liveiso/common.nix +++ b/util/liveiso/common.nix @@ -87,6 +87,14 @@ }; }; + programs.neovim = { + enable = true; + defaultEditor = true; + package = pkgs.neovim; + viAlias = true; + vimAlias = true; + }; + environment.systemPackages = with pkgs; [ acpica-tools btrfs-progs @@ -127,7 +135,6 @@ mkpasswd ms-sys msr-tools - neovim nixos-install-tools ntfsprogs openssl -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Reorganize bootblock_mainboard_early_init()
by Karthik Ramasubramanian (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57318 ) Change subject: mb/google/guybrush: Reorganize bootblock_mainboard_early_init() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a6b8e2284e232c30c9f36ea7c6ab044e2644f7b Gerrit-Change-Number: 57318 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 20:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/dram: Add addtional LPDDR4 speed grades
by Rob Barnes (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Raul Rangel, Nikolai Vyssotski, Julian Schroeder, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57294 ) Change subject: device/dram: Add addtional LPDDR4 speed grades ...................................................................... Patch Set 2: (4 comments) File src/device/dram/lpddr4.c: https://review.coreboot.org/c/coreboot/+/57294/comment/27d9be26_f315e658 PS1, Line 42: 1600 > 1333 How did I miss this. Done. https://review.coreboot.org/c/coreboot/+/57294/comment/2caed414_0f106c89 PS1, Line 51: 934 > should this be 933? Could go either way. JEDEC Standard No. 79-4C / Table 169 says DDR4-1866 tck(avg) min = 1.071ns. 1/1.071ns = 933.7 mhz. https://review.coreboot.org/c/coreboot/+/57294/comment/895de45f_12420048 PS1, Line 52: 2400 > 1866 Done https://review.coreboot.org/c/coreboot/+/57294/comment/e730528a_75e9f3eb PS1, Line 81: 2137 > should this be 2133? JEDEC Standard No. 209-4 Table 88 says LPDDR4-4266 tck(avg) min = 0.467ns. 1/0.467 = 2141Mhz, so this could technically be even higher. idk why 2137 was chosen originally. Maybe set it to 2133+1? -- To view, visit https://review.coreboot.org/c/coreboot/+/57294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7706fd4ad5a7df68c07b8ca43261429ba140c61 Gerrit-Change-Number: 57294 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 20:19:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/dram: Add addtional LPDDR4 speed grades
by Rob Barnes (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Raul Rangel, Rob Barnes, Julian Schroeder. Hello build bot (Jenkins), Raul Rangel, Julian Schroeder, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57294 to look at the new patch set (#2). Change subject: device/dram: Add addtional LPDDR4 speed grades ...................................................................... device/dram: Add addtional LPDDR4 speed grades Add additonal LPDDR4 speed grades. This is needed because the limited set has casued confusion when the reported speed did not match expectations. There does not seem to be a definitive list of LPDDR4 speed grades, so this list is derieved from JEDEC 209-4C and a survey of commonly used LPDDR4 speed grades. BUG=b:194184950 TEST=Boot, dmidecode -t 17 reports correct speed BRANCH=None Change-Id: Ie7706fd4ad5a7df68c07b8ca43261429ba140c61 Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/device/dram/lpddr4.c 1 file changed, 36 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/57294/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7706fd4ad5a7df68c07b8ca43261429ba140c61 Gerrit-Change-Number: 57294 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/trogdor: Add LCM_ID to SKU_ID
by Philip Chen (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: zanxi chen, Bob Moragues, Julius Werner, Xuxin Xiong. Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 ) Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > If we use SKU ID to indentify different panel, it means each SKU can only support one of these two p […] How is assigning another GPIO as a panel identifier any better? You merge lcm_id into sku_id anyway. IOW, each sku_id only supports one panel, no matter you introduce a new GPIO or not. -- To view, visit https://review.coreboot.org/c/coreboot/+/57329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2 Gerrit-Change-Number: 57329 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Wenli Xu <xuwenli(a)huaqin.corp-partner.google.com> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 19:56:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philip Chen <philipchen(a)google.com> Comment-In-Reply-To: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17
by Karthik Ramasubramanian (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Henry Sun, Chen Wisley, Paul Menzel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57204 ) Change subject: mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/mainboard/google/dedede/variants/drawcia/gpio.c: https://review.coreboot.org/c/coreboot/+/57204/comment/da015084_433a813f PS3, Line 41: PAD_NC(GPP_H0, NONE), > PAD_NC(GPP_H17, NONE), Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib65580babf7d21535df2bd8d33bb19261bebfe15 Gerrit-Change-Number: 57204 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 19:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google: Unify all variants to start with "-> "
by Paul Fagerburg (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Martin Roth. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57391 ) Change subject: mb/google: Unify all variants to start with "-> " ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57391/comment/86d2f4a6_33bc5ce6 PS1, Line 11: chang change -- To view, visit https://review.coreboot.org/c/coreboot/+/57391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab9e6207fff5a7d2f6d76e5ca33eeaca721a224f Gerrit-Change-Number: 57391 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 03 Sep 2021 19:47:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021