Attention is currently required from: zanxi chen, Bob Moragues, Julius Werner, Xuxin Xiong.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 )
Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
If we use SKU ID to indentify different panel, it means each SKU can only support one of these two p […]
How is assigning another GPIO as a panel identifier any better?
You merge lcm_id into sku_id anyway.
IOW, each sku_id only supports one panel, no matter you introduce a new GPIO or not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2
Gerrit-Change-Number: 57329
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: Wenli Xu
xuwenli@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 19:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-MessageType: comment