coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Michael Niewöhner (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 39: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 39 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Fri, 03 Sep 2021 18:50:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Michael Niewöhner (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 39: (3 comments) File util/liveiso/build-console.sh: https://review.coreboot.org/c/coreboot/+/50194/comment/a136f79b_e764f209 PS30, Line 1: bash sh File util/liveiso/build-graphical.sh: https://review.coreboot.org/c/coreboot/+/50194/comment/a908d825_9b5d19e0 PS30, Line 1: bash sh File util/liveiso/description.md: https://review.coreboot.org/c/coreboot/+/50194/comment/bc24a2e9_6d8d9b21 PS30, Line 3: nit: one newline is enough -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 39 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Fri, 03 Sep 2021 18:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common/i2c: Add support for I2C common driver
by Shelley Chen (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55952 ) Change subject: soc/qualcomm/common/i2c: Add support for I2C common driver ...................................................................... Patch Set 17: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55952/comment/27060dce_848f582b PS2, Line 7: soc: common > Please put *qualcomm* in the prefix. Done https://review.coreboot.org/c/coreboot/+/55952/comment/2d7f8e1c_55bebcde PS2, Line 9: This implements i2c driver for qualcomm chipsets > Moved Existing SoC specific code to common code Done -- To view, visit https://review.coreboot.org/c/coreboot/+/55952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16e6fc2c1c24b9814d1803bffd5cfbb657201cfb Gerrit-Change-Number: 55952 Gerrit-PatchSet: 17 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Sep 2021 18:09:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Refactor QSPI driver
by Shelley Chen (Code Review) 03 Sep '21

03 Sep '21

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55322 ) Change subject: sc7280: Refactor QSPI driver ...................................................................... sc7280: Refactor QSPI driver Refactor Qcom QSPI driver to separate common and SoC specific driver code. BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org> Change-Id: Ibe1dc3fe8bd71957ff8604ef4c9d97963100ccfb Reviewed-on: https://review.coreboot.org/c/coreboot/+/55322 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Shelley Chen <shchen(a)google.com> --- M src/soc/qualcomm/sc7280/Kconfig M src/soc/qualcomm/sc7280/Makefile.inc M src/soc/qualcomm/sc7280/bootblock.c M src/soc/qualcomm/sc7280/include/soc/addressmap.h D src/soc/qualcomm/sc7280/spi.c 5 files changed, 25 insertions(+), 19 deletions(-) Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved diff --git a/src/soc/qualcomm/sc7280/Kconfig b/src/soc/qualcomm/sc7280/Kconfig index 1bba460..fad3040 100644 --- a/src/soc/qualcomm/sc7280/Kconfig +++ b/src/soc/qualcomm/sc7280/Kconfig @@ -26,4 +26,13 @@ select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_STARTS_IN_BOOTBLOCK +config SC7280_QSPI + bool + default y if COMMON_CBFS_SPI_WRAPPER + prompt "Build Flash Using SPI-NOR" + +config BOOT_DEVICE_SPI_FLASH_BUS + int + default 16 + endif diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.inc index b44c754..9c85968 100644 --- a/src/soc/qualcomm/sc7280/Makefile.inc +++ b/src/soc/qualcomm/sc7280/Makefile.inc @@ -1,10 +1,11 @@ ifeq ($(CONFIG_SOC_QUALCOMM_SC7280),y) all-y += ../common/timer.c -all-y += spi.c all-y += ../common/gpio.c all-y += ../common/clock.c all-y += clock.c +all-y += ../common/spi.c +all-$(CONFIG_SC7280_QSPI) += ../common/qspi.c ################################################################################ bootblock-y += bootblock.c diff --git a/src/soc/qualcomm/sc7280/bootblock.c b/src/soc/qualcomm/sc7280/bootblock.c index 807bb25..ce86151 100644 --- a/src/soc/qualcomm/sc7280/bootblock.c +++ b/src/soc/qualcomm/sc7280/bootblock.c @@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <soc/mmu.h> +#include <soc/clock.h> +#include <soc/qspi_common.h> void bootblock_soc_init(void) { - sc7280_mmu_init(); + clock_init(); + quadspi_init(37500 * KHz); } diff --git a/src/soc/qualcomm/sc7280/include/soc/addressmap.h b/src/soc/qualcomm/sc7280/include/soc/addressmap.h index 82c84ae..6ef6533 100644 --- a/src/soc/qualcomm/sc7280/include/soc/addressmap.h +++ b/src/soc/qualcomm/sc7280/include/soc/addressmap.h @@ -14,4 +14,14 @@ #define SILVER_PLL_BASE 0x18280000 #define TLMM_TILE_BASE 0x0F100000 +/* SC7280 QSPI GPIO PINS */ +#define QSPI_CS GPIO(15) +#define QSPI_DATA_0 GPIO(12) +#define QSPI_DATA_1 GPIO(13) +#define QSPI_CLK GPIO(14) + +#define GPIO_FUNC_QSPI_DATA_0 GPIO12_FUNC_QSPI_DATA_0 +#define GPIO_FUNC_QSPI_DATA_1 GPIO13_FUNC_QSPI_DATA_1 +#define GPIO_FUNC_QSPI_CLK GPIO14_FUNC_QSPI_CLK + #endif /* __SOC_QUALCOMM_SC7280_ADDRESS_MAP_H__ */ diff --git a/src/soc/qualcomm/sc7280/spi.c b/src/soc/qualcomm/sc7280/spi.c deleted file mode 100644 index 50aa395..0000000 --- a/src/soc/qualcomm/sc7280/spi.c +++ /dev/null @@ -1,16 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <spi-generic.h> -#include <spi_flash.h> - -static const struct spi_ctrlr spi_ctrlr; - -const struct spi_ctrlr_buses spi_ctrlr_bus_map[] = { - { - .ctrlr = &spi_ctrlr, - .bus_start = CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, - .bus_end = CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, - }, -}; - -const size_t spi_ctrlr_bus_map_count = ARRAY_SIZE(spi_ctrlr_bus_map); -- To view, visit https://review.coreboot.org/c/coreboot/+/55322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe1dc3fe8bd71957ff8604ef4c9d97963100ccfb Gerrit-Change-Number: 55322 Gerrit-PatchSet: 25 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: [WIP] util/liveiso: Add documentation about persistent storage
by Michael Niewöhner (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56983 ) Change subject: [WIP] util/liveiso: Add documentation about persistent storage ...................................................................... Patch Set 2: (1 comment) File util/liveiso/description.md: https://review.coreboot.org/c/coreboot/+/56983/comment/839c4fe0_2e44c569 PS2, Line 15: * Build one of the configurations using `build-console.sh` or `build-graphical.sh`. You can find the resulting ISO image in `result/iso/`. : * Partition your USB drive. : * Using MS-DOS partition table : ``` : parted -s /dev/sdx mklabel msdos : parted -s /dev/sdx mkpart primary 1MB 100MB # EFI boot partition + bootloader configs + kernel/initrd : parted -s /dev/sdx mkpart logical 100MB 1.1GB # Partition for storing squashfs container : parted -s /dev/sdx mkpart logical 1.1GB 4GB # Partition for persistent storage : parted -s /dev/sdx set 1 boot on # Make legacy bootloader able to recognize this partition : parted -s /dev/sdx name 1 cbboot : parted -s /dev/sdx name 2 cbrootfs : parted -s /dev/sdx name 3 cbpersistent : ``` : : * Using GPT partition table : ``` : parted -s /dev/sdx mklabel gpt : parted -s /dev/sdx mkpart primary 1MB 2MB # Boot partition for legacy boot loaders : parted -s /dev/sdx mkpart primary 2MB 100MB # EFI boot partition + bootloader configs + kernel/initrd : parted -s /dev/sdx mkpart logical 100MB 1.1GB # Partition for storing squashfs container : parted -s /dev/sdx mkpart logical 1.1GB 4GB # Partition for persistent storage : parted -s /dev/sdx set 1 bios_grub on # Make legacy bootloader able to recognize this partition : parted -s /dev/sdx set 2 boot on # Make EFI bootloader able to recognize this partition : parted -s /dev/sdx name 2 cbboot : parted -s /dev/sdx name 3 cbrootfs : parted -s /dev/sdx name 4 cbpersistent : ``` : just an idea: you could add a sfdisk script instead -- To view, visit https://review.coreboot.org/c/coreboot/+/56983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If298049c16712a5fdf99a8b953402cf5a0d265e9 Gerrit-Change-Number: 56983 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:54:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7
by Angel Pons (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Kyösti Mälkki, Swift Geek (Sebastian Grzywna). Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57306 ) Change subject: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f Gerrit-Change-Number: 57306 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/sconfig: Refactor handling of SMBIOS data
by Angel Pons (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57369 ) Change subject: util/sconfig: Refactor handling of SMBIOS data ...................................................................... Patch Set 1: (1 comment) File util/sconfig/main.c: https://review.coreboot.org/c/coreboot/+/57369/comment/e825c509_27b9ebc7 PS1, Line 1116: ptr->smbios_slot_length); > This list may grow in the future. Is it worth to maintain it just to […] I guess not. Should I get rid of these in a separate change, or in this commit? -- To view, visit https://review.coreboot.org/c/coreboot/+/57369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f36d6c6f26e79558d360d319d09b0b8426def0e Gerrit-Change-Number: 57369 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: SMBIOS: Allow skipping default SMBIOS generation
by Angel Pons (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57366 ) Change subject: SMBIOS: Allow skipping default SMBIOS generation ...................................................................... Patch Set 1: (2 comments) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/57366/comment/bc45b07e_fa3188cf PS1, Line 1223: } else { > Sorry, I mixed that up a little. Your change is sound, just the […] I see. I would've expected that disabled devices are never found here, though. But yes, skipping disabled devices makes sense. So, should I make a patch that skips disabled devices? https://review.coreboot.org/c/coreboot/+/57366/comment/217b411b_9e56c5bb PS1, Line 1225: len += smbios_generate_type41_from_devtree(dev, handle, current); > Instead of exposing these as API, we'd usually have a default get_smbios_data() that […] Sounds good. -- To view, visit https://review.coreboot.org/c/coreboot/+/57366 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefbf072b1203d04a98c9d26a30f22cfebe769eb4 Gerrit-Change-Number: 57366 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:37:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Initialize WWAN GPIOs the same for PCI vs USB
by Karthik Ramasubramanian (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57317 ) Change subject: mb/google/guybrush: Initialize WWAN GPIOs the same for PCI vs USB ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > With too many tables, it is hard for me to get the complete picture. Here is what I understood. […] Realized that step 1) is not in PSP verstage and it is done very early in bootblock. If so, why is it required only when PSP verstage is not enabled? File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/57317/comment/fcdd1b8c_5b476806 PS3, Line 172: /* Assert all AUX reset lines */ > Delayed question. But better late than never. […] Correction: Why do we need to do early bootblock initialization of *AUX_RESET* GPIOs only when PSP verstage is not enabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/57317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a7cb883fc8dd6bbc6077b8ea99182f17f888b Gerrit-Change-Number: 57317 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/sconfig: Refactor handling of SMBIOS data
by Nico Huber (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Patrick Rudolph, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57369 ) Change subject: util/sconfig: Refactor handling of SMBIOS data ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File util/sconfig/main.c: https://review.coreboot.org/c/coreboot/+/57369/comment/f04fa82c_bc2f3c36 PS1, Line 1116: ptr->smbios_slot_length); This list may grow in the future. Is it worth to maintain it just to avoid printing some unnecessary CPP guards? -- To view, visit https://review.coreboot.org/c/coreboot/+/57369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f36d6c6f26e79558d360d319d09b0b8426def0e Gerrit-Change-Number: 57369 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 17:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021