coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: elogtool: add next_available_event_offset function
by Ricardo Quesada (Code Review) 04 Sep '21

04 Sep '21

Ricardo Quesada has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57395 ) Change subject: elogtool: add next_available_event_offset function ...................................................................... elogtool: add next_available_event_offset function This function is "extracted" from cmd_clear(). This new function will be called from cmd_add(), and new command that will be added in a future CL (see CL chain). Additional minor fixes: - calls usage() if no valid commands are passed. - Slightly improves usage() output. Needed for cmd_clear() BUG=b:172210863 TEST=elogtool clear Change-Id: I0d8ecc893675758d7f90845282a588d367b55567 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> --- M util/cbfstool/elogtool.c 1 file changed, 33 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/57395/1 diff --git a/util/cbfstool/elogtool.c b/util/cbfstool/elogtool.c index 4ab8494..a3cd9de 100644 --- a/util/cbfstool/elogtool.c +++ b/util/cbfstool/elogtool.c @@ -49,8 +49,8 @@ "USAGE:\n" "\t%s COMMAND [-f <filename>]\n\n" "where, COMMAND is:\n" - " list = lists all the event logs in human readable format\n" - " clear = clears all the event logs\n" + " list lists all the event logs in human readable format\n" + " clear clears all the event logs\n" "\n" "ARGS\n" "-f, --file <filename> File that holds event log partition.\n" @@ -115,6 +115,23 @@ return ELOGTOOL_EXIT_SUCCESS; } +static int next_available_event_offset(const struct buffer *buf) +{ + const struct event_header *event; + int offset = sizeof(struct elog_header); + + event = buffer_get(buf) + offset; + while ((const void *)(event) < buffer_end(buf)) { + if (event->type == ELOG_TYPE_EOL || event->length == 0) + break; + + offset += event->length; + assert((size_t)offset <= buffer_size(buf) && "Out of bounds"); + event = elog_get_next_event(event); + } + return offset; +} + static int cmd_list(const struct buffer *buf) { const struct event_header *event; @@ -141,34 +158,27 @@ */ static int cmd_clear(const struct buffer *b) { - const struct event_header *event; - uint32_t used_data_size = 0; + uint32_t offset; struct buffer buf; - void *data_offset; + void *start; - /* Clone the buffer to avoid changing the offset of the original buffer */ - buffer_clone(&buf, b); - /* eventlog_init_event() expects buffer to point to the event */ - buffer_seek(&buf, sizeof(struct elog_header)); - + start = buffer_get(b); /* * Calculate the size of the "used" buffer, needed for ELOG_TYPE_LOG_CLEAR. * Then overwrite the entire buffer with ELOG_TYPE_EOL. * Finally insert a LOG_CLEAR event into the buffer. */ - event = data_offset = buffer_get(&buf); - while ((const void *)(event) < buffer_end(&buf)) { - if (event->type == ELOG_TYPE_EOL || event->length == 0) - break; + offset = next_available_event_offset(b); + memset(start + sizeof(struct elog_header), ELOG_TYPE_EOL, + buffer_size(b) - sizeof(struct elog_header)); - used_data_size += event->length; - event = elog_get_next_event(event); - } + /* Clone the buffer to avoid changing the offset of the original buffer */ + buffer_clone(&buf, b); + buffer_seek(&buf, sizeof(struct elog_header)); - memset(data_offset, ELOG_TYPE_EOL, buffer_size(&buf)); + offset -= sizeof(struct elog_header); - if (!eventlog_init_event(&buf, ELOG_TYPE_LOG_CLEAR, - &used_data_size, sizeof(used_data_size))) + if (!eventlog_init_event(&buf, ELOG_TYPE_LOG_CLEAR, &offset, sizeof(offset))) return ELOGTOOL_EXIT_NOT_ENOUGH_BUFFER_SPACE; return ELOGTOOL_EXIT_SUCCESS; @@ -231,8 +241,10 @@ } } - if (i == ARRAY_SIZE(cmds)) + if (i == ARRAY_SIZE(cmds)) { + usage(argv[0]); ret = ELOGTOOL_EXIT_BAD_ARGS; + } if (!ret && cmds[i].write_back) ret = elog_write(&buf, filename); -- To view, visit https://review.coreboot.org/c/coreboot/+/57395 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d8ecc893675758d7f90845282a588d367b55567 Gerrit-Change-Number: 57395 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: elog: move MAX_EVENT_SIZE to commonlib/bsd/include
by Ricardo Quesada (Code Review) 04 Sep '21

04 Sep '21

Ricardo Quesada has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57394 ) Change subject: elog: move MAX_EVENT_SIZE to commonlib/bsd/include ...................................................................... elog: move MAX_EVENT_SIZE to commonlib/bsd/include Moves MAX_EVENT_SIZE to commonlib/bsd/include, and renames it ELOG_MAX_EVENT_SIZE to give it an "scoped" name. The moving is needed because this defined will be used from util/cbfstool (see next CL in the chain). BUG=b:172210863 TEST=compiles Ok Change-Id: I86b06d257dda5b325a8478a044045b2a63fb1a84 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> --- M src/commonlib/bsd/include/commonlib/bsd/elog.h M src/drivers/elog/elog.c M src/include/elog.h 3 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/57394/1 diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h index d428b5d..ab3fa4b 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/elog.h +++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h @@ -311,6 +311,9 @@ } __packed; +/* Only the 7-LSB are used for size */ +#define ELOG_MAX_EVENT_SIZE 0x7F + enum cb_err elog_verify_header(const struct elog_header *header); const struct event_header *elog_get_next_event(const struct event_header *event); const void *event_get_data(const struct event_header *event); diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 69567c0..ca2ec6e 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -246,7 +246,7 @@ if (len < (sizeof(*event) + sizeof(checksum))) return 0; - if (len > MAX_EVENT_SIZE) + if (len > ELOG_MAX_EVENT_SIZE) return 0; event = elog_get_event_buffer(offset, len); @@ -613,7 +613,7 @@ static int elog_find_flash(void) { size_t total_size; - size_t reserved_space = ELOG_MIN_AVAILABLE_ENTRIES * MAX_EVENT_SIZE; + size_t reserved_space = ELOG_MIN_AVAILABLE_ENTRIES * ELOG_MAX_EVENT_SIZE; struct region_device *rdev = &elog_state.nv_dev; elog_debug("%s()\n", __func__); @@ -801,7 +801,7 @@ /* Header + Data + Checksum */ event_size = sizeof(*event) + data_size + 1; - if (event_size > MAX_EVENT_SIZE) { + if (event_size > ELOG_MAX_EVENT_SIZE) { printk(BIOS_ERR, "ELOG: Event(%X) data size too " "big (%d)\n", event_type, event_size); return -1; diff --git a/src/include/elog.h b/src/include/elog.h index 206018d..29904cd 100644 --- a/src/include/elog.h +++ b/src/include/elog.h @@ -6,8 +6,6 @@ #include <commonlib/bsd/elog.h> #include <stdint.h> -#define MAX_EVENT_SIZE 0x7F - #if CONFIG(ELOG) /* Eventlog backing storage must be initialized before calling elog_init(). */ extern int elog_init(void); -- To view, visit https://review.coreboot.org/c/coreboot/+/57394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86b06d257dda5b325a8478a044045b2a63fb1a84 Gerrit-Change-Number: 57394 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Lock PAM registers in finalize
by Furquan Shaikh (Code Review) 04 Sep '21

04 Sep '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57185 ) Change subject: soc/intel/elkhartlake: Lock PAM registers in finalize ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6fce70d6b0386906850884880dadbf45597452d Gerrit-Change-Number: 57185 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 04 Sep 2021 00:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Lock PAM registers in finalize
by Furquan Shaikh (Code Review) 04 Sep '21

04 Sep '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57184 ) Change subject: soc/intel/cannonlake: Lock PAM registers in finalize ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ae22f9df4834508dfa304050fad44d45df45334 Gerrit-Change-Number: 57184 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 04 Sep 2021 00:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Lock PAM registers in finalize
by Furquan Shaikh (Code Review) 04 Sep '21

04 Sep '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57183 ) Change subject: soc/intel/jasperlake: Lock PAM registers in finalize ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10f859f30b260d012f0bc8755f32413d8b2cf267 Gerrit-Change-Number: 57183 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 04 Sep 2021 00:35:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/edid_fill_fb: Make framebuffer orientation to be configurable
by Julius Werner (Code Review) 04 Sep '21

04 Sep '21

Attention is currently required from: shkim, Paul Menzel, SH Kim, Yu-Ping Wu, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 ) Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I just followed Kconfig option is better than c code for the static return for orientation, but I al […] Well... I mean I guess we can do this but I still think the existing API was better. This weak function callback thing makes the control flow very complicated and requires mainboard code to be able to respond with the panel properties on demand. For the Kukui board you're now calling get_active_panel() twice, which is not a function that was designed to be called twice and will waste time on doing the same CBFS lookup twice now. I guess you could rewrite it to cache the result and support that, but... why make this so complicated? The previous flow made perfect sense for those boards. I think the real problem here is that the FSP graphics driver is too far removed from the mainboard and doesn't allow to directly pass anything in or out. The cleanest solution for that would be to fix it so that the mainboard init code actually calls something to trigger display initialization and then gets something back (e.g. a struct fb_info pointer). If we don't want to do that, because it's a bit too big of a change maybe, you could also do something like have the FSP graphics driver store the fb_info pointer in a global and provide a function for the mainboard code to retrieve it and add additional info to it. -- To view, visit https://review.coreboot.org/c/coreboot/+/57327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa Gerrit-Change-Number: 57327 Gerrit-PatchSet: 4 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 04 Sep 2021 00:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: shkim <sh_.kim(a)samsung.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Initialize WWAN GPIOs the same for PCI vs USB
by Martin Roth (Code Review) 04 Sep '21

04 Sep '21

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57317 ) Change subject: mb/google/guybrush: Initialize WWAN GPIOs the same for PCI vs USB ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > Realized that step 1) is not in PSP verstage and it is done very early in bootblock. […] Here are the tables: - Early - called either in psp_verstage if it's enabled or early bootblock if psp_verstage is not enabled. Initializes everything needed for PSP_verstage as well as starting the power sequencing for PCIe. - Bootblock - Happens late in the bootblock. Next step in the power sequencing. - PCIe_RST - happens in romstage just before FSP-S. This brings the PCIe devices out of reset. - Ramstage - Initialize or Re-Initialize everything. - Finalize - Finish enabling the Fingerprint MCU. - Sleep/shutdown - Power off the Fingerprint MCU. There's also another call for the fingerprint MCU power, but that's self contained. WWAN & WWAN have power signals in addition to the aux reset lines. SD card & NVME only have aux reset. The power on is handled in hardware when power comes up, and firmware has no control over those signals. So here's the power-on sequence for all of the devices: - Early: Enable WWAN & WLAN power - Bootblock: Bring WWAN out of reset and enable it - all that's left for the power-on sequence it to deassert the PCIE_RST signal - Romstage: Aux_RST is deasserted for all 4 devices that can be on the PCIe bus. If WWAN is only using USB, PCIe training on that link doesn't happen, so the device stays in USB mode. All of the devices need to be brought up in the correct power-on sequence so that the training can occur. If someone wants to try moving that to ACPI and letting the linux kernel do all of the allocation and everything, I'd be happy to let them, but without AGESA doing the PCIe bus training, there might be a bunch of additional code that's needed in a driver that's written specifically to handle that. File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/57317/comment/ab05e1d9_455ad013 PS3, Line 172: /* Assert all AUX reset lines */ > Correction: Why do we need to do early bootblock initialization of *AUX_RESET* GPIOs only when PSP v […] Because if PSP_Verstage is enabled, it gets done in psp_verstage instead of in early bootblock. On board rev0, we need to enable pcie_rst early, but we want to keep all of those signals disabled because we want to keep the PCIe reset lines asserted until we're ready to do the pcie training. The way we'd prefer this to happen (though it makes no real difference) is to raise the AUX lines early and bring everything out of reset by just raising the single pcie_rst signal. We can do that with board rev2, but it will break all of the rev0 boards. -- To view, visit https://review.coreboot.org/c/coreboot/+/57317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a7cb883fc8dd6bbc6077b8ea99182f17f888b Gerrit-Change-Number: 57317 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 22:55:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Felix Singer (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57393 ) Change subject: util/liveiso: Make neovim the default editor ...................................................................... Patch Set 4: (1 comment) File util/liveiso/common.nix: https://review.coreboot.org/c/coreboot/+/57393/comment/bbca4186_6bddd19e PS3, Line 95: vi = "nvim"; > not sure about this, since `vi` is a different editor and it's present by default Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 03 Sep 2021 21:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Felix Singer (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57393 to look at the new patch set (#4). Change subject: util/liveiso: Make neovim the default editor ...................................................................... util/liveiso: Make neovim the default editor Make neovim the default editor and create aliases for vi and vim. The NixOS module for neovim is currently broken. Thus, add a note to `description.md` to do that later. Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix M util/liveiso/description.md 2 files changed, 13 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/57393/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Michael Niewöhner (Code Review) 03 Sep '21

03 Sep '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57393 ) Change subject: util/liveiso: Make neovim the default editor ...................................................................... Patch Set 3: (1 comment) File util/liveiso/common.nix: https://review.coreboot.org/c/coreboot/+/57393/comment/e3adf286_f0a82054 PS3, Line 95: vi = "nvim"; not sure about this, since `vi` is a different editor and it's present by default -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 03 Sep 2021 21:33:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021