coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: cannonlake mainboards: Set PMC as hidden in devicetree
by Michael Niewöhner (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Furquan Shaikh, Matt DeVillier, Jeremy Soller, Tim Wawrzynczak, Angel Pons, Karthik Ramasubramanian. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 ) Change subject: cannonlake mainboards: Set PMC as hidden in devicetree ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > Interesting. On another discussion on the hidden field I was told different. https://review.coreboot.org/c/coreboot/+/53925/1/src/soc/intel/skylake/chip… Ah. Erm. Forget it.... confusion on my side. Sorry for the noise ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/56008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355 Gerrit-Change-Number: 56008 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 20:32:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cannonlake mainboards: Set PMC as hidden in devicetree
by Michael Niewöhner (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Furquan Shaikh, Matt DeVillier, Jeremy Soller, Tim Wawrzynczak, Angel Pons, Karthik Ramasubramanian. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 ) Change subject: cannonlake mainboards: Set PMC as hidden in devicetree ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > There's something about hidden bridges. Actually, devices directly below […] Interesting. On another discussion on the hidden field I was told different. https://review.coreboot.org/c/coreboot/+/53925/1/src/soc/intel/skylake/chip… -- To view, visit https://review.coreboot.org/c/coreboot/+/56008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355 Gerrit-Change-Number: 56008 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 20:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add public gerrit account
by Public Gerrit (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Martin Roth, Stefan Reinauer, David Hendricks, Angel Pons, Werner Zeh. Public Gerrit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51208 ) Change subject: Add public gerrit account ...................................................................... Patch Set 4: (1 comment) File Documentation/getting_started/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/51208/comment/57a6aa5b_81c6e2f1 PS4, Line 323: edit anonymous > I think it might be better to create a web interface than to just publish a username/password. […] Yes, simply take over the idea and make it possible like the project likes it. The account data is known. A much more simple web interface then the recent one would be great, but at the moment this is the only known workaround. It would also make it much more simple to create bugreports on https://ticket.coreboot.org . Since some time the account creation seems to required manual approval from the website-admin and that dont happen that quick. This leads to people not opening the tickets they liked to open. When you try to login you get following message: "Your account was created and is now pending administrator approval." -- To view, visit https://review.coreboot.org/c/coreboot/+/51208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf6d7c47bba10d89956cbb683b8da2e8e04e269d Gerrit-Change-Number: 51208 Gerrit-PatchSet: 4 Gerrit-Owner: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 16:18:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]Documentation: Improve x86_64
by Paul Menzel (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Patrick Rudolph, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56017 ) Change subject: [WIP]Documentation: Improve x86_64 ...................................................................... Patch Set 3: (5 comments) File Documentation/arch/x86/x86_64.md: https://review.coreboot.org/c/coreboot/+/56017/comment/fc423e2e_59e9848b PS2, Line 3: contains documentation about > documents Done https://review.coreboot.org/c/coreboot/+/56017/comment/ddf2bd15_c721addd PS2, Line 27: instructions, which are not only slower, but also increase code size. > As you have a blank line above, I’d separate the items by a blank line. Done https://review.coreboot.org/c/coreboot/+/56017/comment/601de9c7_3f541eed PS2, Line 28: pagetables > Above you spell it as two words. Done https://review.coreboot.org/c/coreboot/+/56017/comment/80b1a957_b9c8e0c5 PS2, Line 36: constrains > constraints Done https://review.coreboot.org/c/coreboot/+/56017/comment/87bb6875_1c6301e7 PS2, Line 37: constrains > constraints Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Gerrit-Change-Number: 56017 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 03 Jul 2021 16:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib/bsd/future: Introduce future API
by Paul Menzel (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56047 ) Change subject: commonlib/bsd/future: Introduce future API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I’d move the discussion to the mailing list. -- To view, visit https://review.coreboot.org/c/coreboot/+/56047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I125a946233f122c2848704296efbcb3ca3c96079 Gerrit-Change-Number: 56047 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 16:00:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/board_status: Do not display grep message
by Paul Menzel (Code Review) 03 Jul '21

03 Jul '21

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56056 ) Change subject: util/board_status: Do not display grep message ...................................................................... util/board_status: Do not display grep message Redirect stdout and stderr from grep to check for unknown timestamps, when no timestamps are stored, which is already logged earlier. Failed to run "/root/coreboot/util/cbmem/cbmem -t", ignoring Getting remote dmesg grep: /tmp/coreboot_board_status.dXmbUIBP/emulation/qemu-i440fx/4.14-876-gdb28040ee1/2021-07-02T23_14_33Z/coreboot_timestamps.txt: Datei oder Verzeichnis nicht gefunden Change-Id: Ib5400d4bd17e957b4cc1bf75bbd332d60ad226f5 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M util/board_status/board_status.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56056/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 292bffa..f5254f1 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -501,7 +501,7 @@ exit $EXIT_FAILURE fi -if [ $(grep -- unknown "${tmpdir}/${results}/coreboot_timestamps.txt") ]; then +if [ $(grep -- unknown "${tmpdir}/${results}/coreboot_timestamps.txt" >/dev/null 2>&1) ]; then echo "Unknown timestamps found in 'coreboot_timestamps.txt'." \ "Please rebuild the 'cbmem' utility and try again." exit $EXIT_FAILURE -- To view, visit https://review.coreboot.org/c/coreboot/+/56056 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5400d4bd17e957b4cc1bf75bbd332d60ad226f5 Gerrit-Change-Number: 56056 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/usb4/retimer: remove redundant structure member group(PLD)
by Maulik V Vaghela (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, John Zhao. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56025 ) Change subject: drivers/intel/usb4/retimer: remove redundant structure member group(PLD) ...................................................................... Patch Set 6: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56025/comment/54a85319_bbb41a60 PS5, Line 9: We > we Done https://review.coreboot.org/c/coreboot/+/56025/comment/0e47163d_3fccb9da PS5, Line 10: and devicetree need not fill PLD structure now > … so the devicetree does not need to fill the PLD structure anymore. Done https://review.coreboot.org/c/coreboot/+/56025/comment/1daef21f_fb15b38e PS5, Line 10: removing > remove Done https://review.coreboot.org/c/coreboot/+/56025/comment/62b1d190_f2c6d1cb PS5, Line 11: redundant > obsolete Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a561677ab65ddb870d1b00b35ee9d7a22ef9c70 Gerrit-Change-Number: 56025 Gerrit-PatchSet: 6 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 13:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]Documentation: Improve x86_64
by Patrick Rudolph (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Patrick Rudolph, Arthur Heymans. Patrick Rudolph has uploaded a new patch set (#3) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/56017 ) Change subject: [WIP]Documentation: Improve x86_64 ...................................................................... [WIP]Documentation: Improve x86_64 Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/x86/index.md A Documentation/arch/x86/x86_64.md 2 files changed, 105 insertions(+), 92 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/56017/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Gerrit-Change-Number: 56017 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib/region: Add support for asynchronous readat
by build bot (Jenkins) (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 ) Change subject: commonlib/region: Add support for asynchronous readat ...................................................................... Patch Set 4: (6 comments) File src/commonlib/include/commonlib/region.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/7c15f0f3_fab0b140 PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'const struct region_device *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/e73eba4e_d874ea7b PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/f25d840a_74eb451a PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'void *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/7763a9dd_799c25c7 PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/182ef0ce_8c02925a PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name File src/commonlib/region.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/27eea7e4_9737b02b PS4, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/55856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9702c9e6abe992ea401fa08ba71e5080c3c29d9a Gerrit-Change-Number: 55856 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Jul 2021 02:27:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib/region: Add support for asynchronous readat
by Raul Rangel (Code Review) 03 Jul '21

03 Jul '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. Hello build bot (Jenkins), Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55856 to look at the new patch set (#4). Change subject: commonlib/region: Add support for asynchronous readat ...................................................................... commonlib/region: Add support for asynchronous readat This CL adds support asynchronous readat support for region_devices. It uses the new futures API. Asynchronous operations be be performed in the background leaving the AP free to perform other work. AMD SoCs have a dedicated SPI DMA controller that can be used to perform asynchronous reads. The goal is to load certain stages, payloads, and oproms asynchronously into a cache before the items are actually needed. This will reduce the amount of time we spend waiting for SPI transactions. BUG=b:179699789 TEST=compiles Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I9702c9e6abe992ea401fa08ba71e5080c3c29d9a --- M src/commonlib/include/commonlib/region.h M src/commonlib/region.c 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/55856/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/55856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9702c9e6abe992ea401fa08ba71e5080c3c29d9a Gerrit-Change-Number: 55856 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021