coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Hello Nico Huber, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56058 to look at the new patch set (#2). Change subject: device: Extend `devtree_die()` log information ...................................................................... device: Extend `devtree_die()` log information If the `config_of()` function is called with a non-NULL `dev` argument, but its `chip_info` member is NULL, it is possible to print information about `dev` to make debugging easier. Pass `dev` to `devtree_die()` and call the `dev_path()` function with it. Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/device/device_const.c M src/include/device/device.h 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56058/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Nico Huber (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56058 ) Change subject: device: Extend `devtree_die()` log information ...................................................................... Patch Set 1: (1 comment) File src/device/device_const.c: https://review.coreboot.org/c/coreboot/+/56058/comment/0128e845_ac780859 PS1, Line 316: die("DEVTREE: dev %s or chip_info is NULL\n", dev_path(dev)); > Like this? […] yep, looks good -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56058 ) Change subject: device: Extend `devtree_die()` log information ...................................................................... Patch Set 1: (1 comment) File src/device/device_const.c: https://review.coreboot.org/c/coreboot/+/56058/comment/fa4897af_c34edd7c PS1, Line 316: die("DEVTREE: dev %s or chip_info is NULL\n", dev_path(dev)); > This would look very confusing: […] Like this? if (dev) die("DEVTREE: chip_info of dev %s is NULL\n", dev_path(dev)); else die("DEVTREE: dev is NULL\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Nico Huber (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56058 ) Change subject: device: Extend `devtree_die()` log information ...................................................................... Patch Set 1: (1 comment) File src/device/device_const.c: https://review.coreboot.org/c/coreboot/+/56058/comment/957cbb32_f70a6e56 PS1, Line 316: die("DEVTREE: dev %s or chip_info is NULL\n", dev_path(dev)); This would look very confusing: DEVTREE: dev <null> or chip_info is NULL Maybe make it individual die() statements? -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:12:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Reflow strings in printk statements
by Nico Huber (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56057 ) Change subject: device: Reflow strings in printk statements ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5284429ca6d07debf2d6c4fdbffa286140fb7694 Gerrit-Change-Number: 56057 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Reflow strings in printk statements
by Paul Menzel (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56057 ) Change subject: device: Reflow strings in printk statements ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5284429ca6d07debf2d6c4fdbffa286140fb7694 Gerrit-Change-Number: 56057 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:07:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56058 ) Change subject: device: Extend `devtree_die()` log information ...................................................................... device: Extend `devtree_die()` log information If the `config_of()` function is called with a non-NULL `dev` argument, but its `chip_info` member is NULL, it is possible to print information about `dev` to make debugging easier. Pass `dev` to `devtree_die()` and call the `dev_path()` function with it. Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/device/device_const.c M src/include/device/device.h 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56058/1 diff --git a/src/device/device_const.c b/src/device/device_const.c index 7e7f2f1..c01efe4 100644 --- a/src/device/device_const.c +++ b/src/device/device_const.c @@ -311,9 +311,9 @@ printk(BIOS_ERR, "BUG: %s requests hidden 00:%02x.%u\n", func, devfn >> 3, devfn & 7); } -void __noreturn devtree_die(void) +void __noreturn devtree_die(const struct device *dev) { - die("DEVTREE: dev or chip_info is NULL\n"); + die("DEVTREE: dev %s or chip_info is NULL\n", dev_path(dev)); } /** diff --git a/src/include/device/device.h b/src/include/device/device.h index 8f0650f..4100a5d 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -364,7 +364,7 @@ /* Robust discovery of chip_info. */ void devtree_bug(const char *func, pci_devfn_t devfn); -void __noreturn devtree_die(void); +void __noreturn devtree_die(const struct device *dev); /* * Dies if `dev` or `dev->chip_info` are NULL. Returns `dev->chip_info` otherwise. @@ -377,7 +377,7 @@ if (dev && dev->chip_info) return dev->chip_info; - devtree_die(); + devtree_die(dev); } /* -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: device: Reflow strings in printk statements
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56057 ) Change subject: device: Reflow strings in printk statements ...................................................................... device: Reflow strings in printk statements To ease finding some log messages, reflow their strings to use one line. Tested with BUILD_TIMELESS=1, Asrock B85M Pro4 remains identical. Change-Id: I5284429ca6d07debf2d6c4fdbffa286140fb7694 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/device/device_util.c M src/device/pci_device.c M src/device/pci_rom.c 3 files changed, 25 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/56057/1 diff --git a/src/device/device_util.c b/src/device/device_util.c index a5d1860..8ee8afc 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -870,8 +870,8 @@ resource->flags = IORESOURCE_MEM | IORESOURCE_RESERVE | IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; - printk(BIOS_DEBUG, "Adding PCIe enhanced config space BAR " - "0x%08lx-0x%08lx.\n", (unsigned long)(resource->base), + printk(BIOS_DEBUG, "Adding PCIe enhanced config space BAR 0x%08lx-0x%08lx.\n", + (unsigned long)(resource->base), (unsigned long)(resource->base + resource->size)); } diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 63c1dc5..4b5e73b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -149,8 +149,7 @@ */ if (moving == 0) { if (value != 0) { - printk(BIOS_DEBUG, "%s register %02lx(%08lx), " - "read-only ignoring it\n", + printk(BIOS_DEBUG, "%s register %02lx(%08lx), read-only ignoring it\n", dev_path(dev), index, value); } resource->flags = 0; @@ -234,8 +233,7 @@ resource->flags |= IORESOURCE_MEM | IORESOURCE_READONLY; } else { if (value != 0) { - printk(BIOS_DEBUG, "%s register %02lx(%08lx), " - "read-only ignoring it\n", + printk(BIOS_DEBUG, "%s register %02lx(%08lx), read-only ignoring it\n", dev_path(dev), index, value); } resource->flags = 0; @@ -512,8 +510,8 @@ we can treat it like an empty resource. */ resource->size = 0; } else { - printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx not " - "assigned\n", dev_path(dev), resource->index, + printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx not assigned\n", + dev_path(dev), resource->index, resource_type(resource), resource->size); return; } @@ -980,9 +978,9 @@ default: bad: if (dev->enabled) { - printk(BIOS_ERR, "%s [%04x/%04x/%06x] has unknown " - "header type %02x, ignoring.\n", dev_path(dev), - dev->vendor, dev->device, + printk(BIOS_ERR, + "%s [%04x/%04x/%06x] has unknown header type %02x, ignoring.\n", + dev_path(dev), dev->vendor, dev->device, dev->class >> 8, dev->hdr_type); } } @@ -1107,8 +1105,9 @@ if ((id == 0xffffffff) || (id == 0x00000000) || (id == 0x0000ffff) || (id == 0xffff0000)) { if (dev->enabled) { - printk(BIOS_INFO, "PCI: Static device %s not " - "found, disabling it.\n", dev_path(dev)); + printk(BIOS_INFO, + "PCI: Static device %s not found, disabling it.\n", + dev_path(dev)); dev->enabled = 0; } return dev; diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 663895c..334d99b 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -78,14 +78,14 @@ rom_header = (struct rom_header *)rom_address; } - printk(BIOS_SPEW, "PCI expansion ROM, signature 0x%04x, " - "INIT size 0x%04x, data ptr 0x%04x\n", + printk(BIOS_SPEW, + "PCI expansion ROM, signature 0x%04x, INIT size 0x%04x, data ptr 0x%04x\n", le32_to_cpu(rom_header->signature), rom_header->size * 512, le32_to_cpu(rom_header->data)); if (le32_to_cpu(rom_header->signature) != PCI_ROM_HDR) { - printk(BIOS_ERR, "Incorrect expansion ROM header " - "signature %04x\n", le32_to_cpu(rom_header->signature)); + printk(BIOS_ERR, "Incorrect expansion ROM header signature %04x\n", + le32_to_cpu(rom_header->signature)); return NULL; } @@ -97,13 +97,13 @@ if ((dev->vendor != rom_data->vendor || dev->device != rom_data->device) && (vendev == mapped_vendev)) { - printk(BIOS_ERR, "ID mismatch: vendor ID %04x, " - "device ID %04x\n", dev->vendor, dev->device); + printk(BIOS_ERR, "ID mismatch: vendor ID %04x, device ID %04x\n", + dev->vendor, dev->device); return NULL; } - printk(BIOS_SPEW, "PCI ROM image, Class Code %04x%02x, " - "Code Type %02x\n", rom_data->class_hi, rom_data->class_lo, + printk(BIOS_SPEW, "PCI ROM image, Class Code %04x%02x, Code Type %02x\n", + rom_data->class_hi, rom_data->class_lo, rom_data->type); if (dev->class != ((rom_data->class_hi << 8) | rom_data->class_lo)) { @@ -152,17 +152,17 @@ if (dev != vga_pri) return NULL; /* Only one VGA supported. */ #endif if ((void *)PCI_VGA_RAM_IMAGE_START != rom_header) { - printk(BIOS_DEBUG, "Copying VGA ROM Image from %p to " - "0x%x, 0x%x bytes\n", rom_header, - PCI_VGA_RAM_IMAGE_START, rom_size); + printk(BIOS_DEBUG, + "Copying VGA ROM Image from %p to 0x%x, 0x%x bytes\n", + rom_header, PCI_VGA_RAM_IMAGE_START, rom_size); memcpy((void *)PCI_VGA_RAM_IMAGE_START, rom_header, rom_size); } return (struct rom_header *) (PCI_VGA_RAM_IMAGE_START); } - printk(BIOS_DEBUG, "Copying non-VGA ROM image from %p to %p, 0x%x " - "bytes\n", rom_header, pci_ram_image_start, rom_size); + printk(BIOS_DEBUG, "Copying non-VGA ROM image from %p to %p, 0x%x bytes\n", + rom_header, pci_ram_image_start, rom_size); memcpy(pci_ram_image_start, rom_header, rom_size); pci_ram_image_start += rom_size; -- To view, visit https://review.coreboot.org/c/coreboot/+/56057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5284429ca6d07debf2d6c4fdbffa286140fb7694 Gerrit-Change-Number: 56057 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/board_status: Do not display grep message
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56056 ) Change subject: util/board_status: Do not display grep message ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56056/comment/8d007625_5dc3895b PS1, Line 14: Datei oder Verzeichnis nicht gefunden No such file or directory -- To view, visit https://review.coreboot.org/c/coreboot/+/56056 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5400d4bd17e957b4cc1bf75bbd332d60ad226f5 Gerrit-Change-Number: 56056 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 09:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Implement readat_async
by Paul Menzel (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55857 ) Change subject: soc/amd/common/block/lpc/spi_dma: Implement readat_async ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/common/block/lpc/spi_dma.c: https://review.coreboot.org/c/coreboot/+/55857/comment/b363b882_29adcdcb PS5, Line 34: * can always move the number to a Kconfig if necessary. */ Please use one of the recommended multi-line comment styles [1]. [1]: https://doc.coreboot.org/contributing/coding_style.html#commenting -- To view, visit https://review.coreboot.org/c/coreboot/+/55857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0be555956581fd82bbe1482d8afa8828c61aaa00 Gerrit-Change-Number: 55857 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 04 Jul 2021 07:35:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021