coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: Add public gerrit account
by Michael Niewöhner (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Martin Roth, Stefan Reinauer, David Hendricks, Angel Pons, Public Gerrit, Werner Zeh. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51208 ) Change subject: Add public gerrit account ...................................................................... Patch Set 4: Code-Review-2 (1 comment) Patchset: PS4: Sorry, but no. IMO there are no reasons to comment, edit or whatever anonymously. It's naive to believe such account wouldn't be misused. -- To view, visit https://review.coreboot.org/c/coreboot/+/51208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf6d7c47bba10d89956cbb683b8da2e8e04e269d Gerrit-Change-Number: 51208 Gerrit-PatchSet: 4 Gerrit-Owner: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 04 Jul 2021 13:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add public gerrit account
by Michael Niewöhner (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Martin Roth, Stefan Reinauer, David Hendricks, Angel Pons, Public Gerrit, Werner Zeh. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51208 ) Change subject: Add public gerrit account ...................................................................... Patch Set 4: (1 comment) File Documentation/getting_started/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/51208/comment/6c429ee0_de1dc056 PS4, Line 323: edit anonymous > This account is unlikely to be used inappropriately. When you want to do bad things, you use fake data and not some account like this one. What? That would imply that actions are monitored and checked. -- To view, visit https://review.coreboot.org/c/coreboot/+/51208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf6d7c47bba10d89956cbb683b8da2e8e04e269d Gerrit-Change-Number: 51208 Gerrit-PatchSet: 4 Gerrit-Owner: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 04 Jul 2021 13:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Public Gerrit <public-gerrit(a)guerrillamail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR
by build bot (Jenkins) (Code Review) 04 Jul '21

04 Jul '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56062 ) Change subject: libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/drivers/storage/ahci_common.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123321): https://review.coreboot.org/c/coreboot/+/56062/comment/e227b4b2_4da09127 PS1, Line 159: printf("ahci: HBA_PxCMD_CR not set (cmd_stat=0x%"PRIx32")\n", dev->port->cmd_stat); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/56062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b94cf4aa40dce587f52350ff4624946aeaafcc0 Gerrit-Change-Number: 56062 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 13:15:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR
by Paul Menzel (Code Review) 04 Jul '21

04 Jul '21

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56062 ) Change subject: libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR ...................................................................... libpayload: Continue in ahci_cmdslot_exec() despite unset HBA_PxCMD_CR On the Asus F2A85-M PRO, using FILO with the libpayload storage drivers `ata_read512()` fails with the attached SSD drive. ahci: Found SATA controller 00:11.00 (1022:7801). ahci: ATA drive on port #7. ata: Identified SanDisk SDSSDP064G [2.0.0] ata: Support for LBA-48 enabled. ERROR: No such CMOS option (boot_devices) filo> kernel hda3:/vmlinuz dev=hda3, path=/vmlinuz Disk read error dev=1 drive=0 sector=0 Couldn't read sector. device read failed. Can't open partition 3. Error 15: File not found printf-debugging reveals, that `ahci_cmdslot_exec()` aborts early, as `HBA_PxCMD_CR`, defined as 1 << 15, is not set. On the AMD device cmd_stat is 0x6017 every time `ahci_cmdslot_exec()` is executed. Not erroring out, fixes the issue. Print a warning instead. Change-Id: I2b94cf4aa40dce587f52350ff4624946aeaafcc0 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M payloads/libpayload/drivers/storage/ahci_common.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/56062/1 diff --git a/payloads/libpayload/drivers/storage/ahci_common.c b/payloads/libpayload/drivers/storage/ahci_common.c index f3abc5f..e684dbf 100644 --- a/payloads/libpayload/drivers/storage/ahci_common.c +++ b/payloads/libpayload/drivers/storage/ahci_common.c @@ -156,7 +156,7 @@ const int slotnum = 0; /* We always use the first slot. */ if (!(dev->port->cmd_stat & HBA_PxCMD_CR)) - return -1; + printf("ahci: HBA_PxCMD_CR not set (cmd_stat=0x%"PRIx32")\n", dev->port->cmd_stat); /* Trigger command execution. */ dev->port->cmd_issue |= (1 << slotnum); -- To view, visit https://review.coreboot.org/c/coreboot/+/56062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b94cf4aa40dce587f52350ff4624946aeaafcc0 Gerrit-Change-Number: 56062 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: supermicro/x11: enable COMB via LPC
by Alexander Couzens (Code Review) 04 Jul '21

04 Jul '21

Alexander Couzens has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51759 ) Change subject: supermicro/x11: enable COMB via LPC ...................................................................... supermicro/x11: enable COMB via LPC Allow to use the 2nd COM port of the AST2400 which can be also used via IPMI/serial-over-lan. Change-Id: I6f9c85b1f5428d3c3acf7a2f20296134c4611b1e Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51759 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M src/mainboard/supermicro/x11-lga1151-series/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 3342b04..b2497e5 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -14,6 +14,7 @@ select SUPERIO_ASPEED_HAS_UART_DELAY_WORKAROUND select NO_FADT_8042 select DRIVERS_UART_8250IO + select SOC_INTEL_COMMON_BLOCK_LPC_COMB_ENABLE if BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES -- To view, visit https://review.coreboot.org/c/coreboot/+/51759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f9c85b1f5428d3c3acf7a2f20296134c4611b1e Gerrit-Change-Number: 51759 Gerrit-PatchSet: 5 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: supermicro/x11: enable COMB via LPC
by Alexander Couzens (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Paul Menzel, Michael Niewöhner, Alexander Couzens, Patrick Rudolph. Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51759 ) Change subject: supermicro/x11: enable COMB via LPC ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/51759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f9c85b1f5428d3c3acf7a2f20296134c4611b1e Gerrit-Change-Number: 51759 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 13:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] [POC] serialICE: introduce serialice stage
by Michael Niewöhner (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Michael Niewöhner. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54140 ) Change subject: [RFC] [POC] serialICE: introduce serialice stage ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/54140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0912c0482e95723e2209d30410d1af7e5a3c122 Gerrit-Change-Number: 54140 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 04 Jul 2021 12:39:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cannonlake mainboards: Set PMC as hidden in devicetree
by Michael Niewöhner (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Furquan Shaikh, Matt DeVillier, Jeremy Soller, Tim Wawrzynczak, Angel Pons, Karthik Ramasubramanian. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 ) Change subject: cannonlake mainboards: Set PMC as hidden in devicetree ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I wonder if we should set it for P2SB, too, then -- To view, visit https://review.coreboot.org/c/coreboot/+/56008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355 Gerrit-Change-Number: 56008 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 04 Jul 2021 12:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/intel/microcode: Add support for extended signature table
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54734 ) Change subject: src/intel/microcode: Add support for extended signature table ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Seems like this change caused regressions: https://ticket.coreboot.org/issues/313 -- To view, visit https://review.coreboot.org/c/coreboot/+/54734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1466caf4a4ba1f9a0214bdde19cce57dd65dacbd Gerrit-Change-Number: 54734 Gerrit-PatchSet: 8 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 11:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Extend `devtree_die()` log information
by Angel Pons (Code Review) 04 Jul '21

04 Jul '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56058 ) Change subject: device: Extend `devtree_die()` log information ...................................................................... Patch Set 1: (1 comment) File src/device/device_const.c: https://review.coreboot.org/c/coreboot/+/56058/comment/7de3f3a1_9fa0c2a7 PS1, Line 316: die("DEVTREE: dev %s or chip_info is NULL\n", dev_path(dev)); > yep, looks good Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62f93bd7a4a4e55a84c1436e57e48804de730080 Gerrit-Change-Number: 56058 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 04 Jul 2021 10:27:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021