Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52221
to look at the new patch set (#20).
Change subject: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
......................................................................
mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
- Add OEM string configurability to enable/disable I2S codec support for
MAX98373 codecs
- AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board
Bug=None
Test=With CBI FW_CONFIG set to 0x100, check I2S audio output on expansion
card
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Makefile.inc
M src/mainboard/intel/adlrvp/devicetree_m.cb
A src/mainboard/intel/adlrvp/fw_config.c
M src/mainboard/intel/adlrvp/gpio_m.c
5 files changed, 87 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/52221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
Gerrit-Change-Number: 52221
Gerrit-PatchSet: 20
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52221
to look at the new patch set (#19).
Change subject: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
......................................................................
mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
- Add OEM string configurability to enable/disable I2S codec support for
MAX98373 codecs
- AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Makefile.inc
M src/mainboard/intel/adlrvp/devicetree_m.cb
A src/mainboard/intel/adlrvp/fw_config.c
M src/mainboard/intel/adlrvp/gpio_m.c
5 files changed, 87 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/52221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
Gerrit-Change-Number: 52221
Gerrit-PatchSet: 19
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52221
to look at the new patch set (#18).
Change subject: [WIP] mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
......................................................................
[WIP] mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
- Add OEM string configurability to enable/disable I2S codec support for
MAX98373 codecs
- AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Makefile.inc
M src/mainboard/intel/adlrvp/devicetree_m.cb
A src/mainboard/intel/adlrvp/fw_config.c
M src/mainboard/intel/adlrvp/gpio_m.c
5 files changed, 87 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/52221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda
Gerrit-Change-Number: 52221
Gerrit-PatchSet: 18
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56120 )
Change subject: Makefile.inc: Drop the cbfs master header from non-X86
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I'd move this earlier, which should clean up the other commits a fair amount.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9
Gerrit-Change-Number: 56120
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Jul 2021 15:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55368
to look at the new patch set (#3).
Change subject: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
......................................................................
mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
This feature was added for discovering correct audio topology
using OEM string e.g., "ADL_MAX98373_ALC5682I_I2S" for discovering
boards having audio expansion card
Bug=None
Test= With CBI FW_CONFIG set to 0x100
localhost /home/root # dmidecode -t 11
# dmidecode 3.2
Getting SMBIOS data from sysfs.
SMBIOS 3.0 present.
Handle 0x0009, DMI type 11, 5 bytes
OEM Strings
String 1: ADL_MAX98373_ALC5682I_I2S
Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
---
M src/mainboard/intel/adlrvp/mainboard.c
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55368/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/55368
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f
Gerrit-Change-Number: 55368
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 )
Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > This also breaks reproducibility guarantees because intermediate steps don't get an implicit order […]
no, macros and functions are evaluated in parse order. So when you add intermediates A, B, C, D, ... the current setup ensures that B depends on A, C on B and A, D on C, B, A, ... (which could be optimized by a small amount by removing the transitive dependencies), creating a stable execution order.
Without that order-only dependency, executing C, A, D, B would be a valid strategy (and depending on how many parallel make jobs you have and what happens in them, that might well happen).
I added that order-only target in https://review.coreboot.org/c/coreboot/+/49358 specifically to avoid race conditions that we were seeing...
--
To view, visit https://review.coreboot.org/c/coreboot/+/56113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387
Gerrit-Change-Number: 56113
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Jul 2021 15:19:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55368
to look at the new patch set (#2).
Change subject: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
......................................................................
mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
Bug=None
Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
---
M src/mainboard/intel/adlrvp/mainboard.c
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55368/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/55368
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f
Gerrit-Change-Number: 55368
Gerrit-PatchSet: 2
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 )
Change subject: Makefile.inc: Remove unused IFITTOOL dependency
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56112/comment/0fa8e087_ae5c0f22
PS1, Line 9: somewhere else
> > how about adding the IFITTOOL dependency there? […]
I haven't found a lot of dependencies for IFITTOOL, so maybe better to add it there.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf
Gerrit-Change-Number: 56112
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Jul 2021 15:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Arthur Heymans.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56114
to look at the new patch set (#2).
Change subject: Makefile.inc: Split of image generation in multiple targets
......................................................................
Makefile.inc: Split of image generation in multiple targets
The big '$(obj)/coreboot.pre' target did a lot of things and made the
build process inflexible. Split of much of the functionality in
INTERMEDIATE targets that can have proper dependencies.
Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.inc
M src/arch/x86/Makefile.inc
2 files changed, 46 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/56114/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353
Gerrit-Change-Number: 56114
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset