coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: arch/x86: Helper functions to get deterministic cache parameters
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 ) Change subject: arch/x86: Helper functions to get deterministic cache parameters ...................................................................... Patch Set 2: (3 comments) File src/cpu/intel/common/common_init.c: https://review.coreboot.org/c/coreboot/+/55965/comment/c85dbc38_9fca7fbf PS1, Line 329: get_cache_info > Yeah that sounds good, take the leaf and the ecx argument Ack https://review.coreboot.org/c/coreboot/+/55965/comment/027ecd46_97c9a41c PS1, Line 331: 0x03 > For this case, it would still be useful, […] Ack https://review.coreboot.org/c/coreboot/+/55965/comment/24a3c7ba_0ebd323d PS1, Line 332: : const size_t assoc = CPUID_CACHE_WAYS_OF_ASSOC(res) + 1; : const size_t partitions = CPUID_CACHE_PHYS_LINE(res) + 1; : const size_t cache_line_size = CPUID_CACHE_COHER_LINE(res) + 1; : const size_t number_of_sets = CPUID_CACHE_NO_OF_SETS(res) + 1; : const size_t cache_size = assoc * partitions * cache_line_size * number_of_sets; : printk(BIOS_INFO, "Cache Information : "); : printk(BIOS_INFO, "assoc=%zd par=%zd line_size=%zd sets=%zd\n", : assoc, partitions, cache_line_size, number_of_sets); : printk(BIOS_INFO, "@@ cache_size 0x%lx bytes\n", cache_size); > thats good idea may be Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/55965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Gerrit-Change-Number: 55965 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 16:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Helper functions to get deterministic cache parameters
by build bot (Jenkins) (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 ) Change subject: arch/x86: Helper functions to get deterministic cache parameters ...................................................................... Patch Set 2: (2 comments) File src/arch/x86/cpu_common.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123527): https://review.coreboot.org/c/coreboot/+/55965/comment/314d8d03_3a1b3132 PS2, Line 127: break; break is not useful after a goto or return Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123527): https://review.coreboot.org/c/coreboot/+/55965/comment/62f551c1_728a76de PS2, Line 130: break; break is not useful after a goto or return -- To view, visit https://review.coreboot.org/c/coreboot/+/55965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Gerrit-Change-Number: 55965 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 16:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Helper functions to get deterministic cache parameters
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55965 to look at the new patch set (#2). Change subject: arch/x86: Helper functions to get deterministic cache parameters ...................................................................... arch/x86: Helper functions to get deterministic cache parameters This patch creates helper function that internally detects the CPU type (AMD or Intel) and pick the leaf to send CPUID instruction with different cache level to retrieve deterministic cache parameters. Lists of helper functions generated as part of this CL: 1. cpu_check_deterministic_cache_cpuid_supported => if CPU has support for deterministic cache using CPUID instruction. 2. cpu_get_cache_ways_assoc_info => Get cache ways for associativity. 3. cpu_get_cache_type => Get cache type. 4. cpu_get_cache_level => Get cache level. 5. cpu_get_cache_phy_partition_info => Get cache physical partitions. 6. cpu_get_cache_line_size => Get cahce line size. 7. cpu_get_cache_sets => Get cache number of sets. 8. cpu_is_cache_full_assoc => Check if cache is fully associative. 9. cpu_get_max_cache_share => Cores are sharing this cache. 10. get_cache_size => Calculate the cache size. Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 206 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/55965/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Gerrit-Change-Number: 55965 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS O...
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Sathyanarayana Nujella, Selma Bensaid, Jairaj Arava. Hello Sathyanarayana Nujella, build bot (Jenkins), Selma Bensaid, Jairaj Arava, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52221 to look at the new patch set (#21). Change subject: mb/intel/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string ...................................................................... mb/intel/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string - Add OEM string configurability to enable/disable I2S codec support for MAX98373 codecs - AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board Bug=None Test=With CBI FW_CONFIG set to 0x100, check I2S audio output on expansion card Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/adlrvp/devicetree_m.cb A src/mainboard/intel/adlrvp/fw_config.c M src/mainboard/intel/adlrvp/gpio_m.c 5 files changed, 87 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/52221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda Gerrit-Change-Number: 52221 Gerrit-PatchSet: 21 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Anil Kumar K. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52221 to look at the new patch set (#20). Change subject: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string ...................................................................... mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string - Add OEM string configurability to enable/disable I2S codec support for MAX98373 codecs - AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board Bug=None Test=With CBI FW_CONFIG set to 0x100, check I2S audio output on expansion card Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/adlrvp/devicetree_m.cb A src/mainboard/intel/adlrvp/fw_config.c M src/mainboard/intel/adlrvp/gpio_m.c 5 files changed, 87 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/52221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda Gerrit-Change-Number: 52221 Gerrit-PatchSet: 20 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Anil Kumar K. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52221 to look at the new patch set (#19). Change subject: mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string ...................................................................... mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string - Add OEM string configurability to enable/disable I2S codec support for MAX98373 codecs - AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/adlrvp/devicetree_m.cb A src/mainboard/intel/adlrvp/fw_config.c M src/mainboard/intel/adlrvp/gpio_m.c 5 files changed, 87 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/52221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda Gerrit-Change-Number: 52221 Gerrit-PatchSet: 19 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS O...
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Anil Kumar K. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52221 to look at the new patch set (#18). Change subject: [WIP] mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string ...................................................................... [WIP] mb/adlrvp : Enable I2S audio codecs on ADL-M RVP using SMBIOS OEM string - Add OEM string configurability to enable/disable I2S codec support for MAX98373 codecs - AUDIO=ADL_MAX98373_ALC5682I_I2S: enable max98373 codec using expansion board Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/adlrvp/devicetree_m.cb A src/mainboard/intel/adlrvp/fw_config.c M src/mainboard/intel/adlrvp/gpio_m.c 5 files changed, 87 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52221/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/52221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda Gerrit-Change-Number: 52221 Gerrit-PatchSet: 18 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Drop the cbfs master header from non-X86
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56120 ) Change subject: Makefile.inc: Drop the cbfs master header from non-X86 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'd move this earlier, which should clean up the other commits a fair amount. -- To view, visit https://review.coreboot.org/c/coreboot/+/56120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9 Gerrit-Change-Number: 56120 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Jul 2021 15:31:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Anil Kumar K. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55368 to look at the new patch set (#3). Change subject: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings ...................................................................... mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings This feature was added for discovering correct audio topology using OEM string e.g., "ADL_MAX98373_ALC5682I_I2S" for discovering boards having audio expansion card Bug=None Test= With CBI FW_CONFIG set to 0x100 localhost /home/root # dmidecode -t 11 # dmidecode 3.2 Getting SMBIOS data from sysfs. SMBIOS 3.0 present. Handle 0x0009, DMI type 11, 5 bytes OEM Strings String 1: ADL_MAX98373_ALC5682I_I2S Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55368/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f Gerrit-Change-Number: 55368 Gerrit-PatchSet: 3 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > This also breaks reproducibility guarantees because intermediate steps don't get an implicit order […] no, macros and functions are evaluated in parse order. So when you add intermediates A, B, C, D, ... the current setup ensures that B depends on A, C on B and A, D on C, B, A, ... (which could be optimized by a small amount by removing the transitive dependencies), creating a stable execution order. Without that order-only dependency, executing C, A, D, B would be a valid strategy (and depending on how many parallel make jobs you have and what happens in them, that might well happen). I added that order-only target in https://review.coreboot.org/c/coreboot/+/49358 specifically to avoid race conditions that we were seeing... -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Jul 2021 15:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021