coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
by Anil Kumar K (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Anil Kumar K. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55368 to look at the new patch set (#2). Change subject: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings ...................................................................... mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings Bug=None Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/55368/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f Gerrit-Change-Number: 55368 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Remove unused IFITTOOL dependency
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 ) Change subject: Makefile.inc: Remove unused IFITTOOL dependency ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56112/comment/0fa8e087_ae5c0f22 PS1, Line 9: somewhere else > > how about adding the IFITTOOL dependency there? […] I haven't found a lot of dependencies for IFITTOOL, so maybe better to add it there. -- To view, visit https://review.coreboot.org/c/coreboot/+/56112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf Gerrit-Change-Number: 56112 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Jul 2021 15:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Drop the cbfs master header from non-X86
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56120 to look at the new patch set (#2). Change subject: Makefile.inc: Drop the cbfs master header from non-X86 ...................................................................... Makefile.inc: Drop the cbfs master header from non-X86 The pointer to the header has a x86 top mmaped address even though the boot medium is not mapped that way. If no pointer is used to find the header FMAP is needed. If FMAP is used anyway there is no need for a cbfs master header. Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/arch/x86/Makefile.inc 2 files changed, 7 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/56120/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9 Gerrit-Change-Number: 56120 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Split of image generation in multiple targets
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56114 to look at the new patch set (#2). Change subject: Makefile.inc: Split of image generation in multiple targets ...................................................................... Makefile.inc: Split of image generation in multiple targets The big '$(obj)/coreboot.pre' target did a lot of things and made the build process inflexible. Split of much of the functionality in INTERMEDIATE targets that can have proper dependencies. Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/arch/x86/Makefile.inc 2 files changed, 46 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/56114/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353 Gerrit-Change-Number: 56114 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Remove unused IFITTOOL dependency
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 ) Change subject: Makefile.inc: Remove unused IFITTOOL dependency ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56112/comment/9caebba8_e6c133a2 PS1, Line 9: somewhere else > how about adding the IFITTOOL dependency there? That's already the case afaik. Maybe adding it for $(obj)/coreboot.rom makes sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/56112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf Gerrit-Change-Number: 56112 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 15:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This also breaks reproducibility guarantees because intermediate steps don't get an implicit ordering that follows add_intermediate evaluation order. Was that not already the case with intermediate targets? -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 15:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This also breaks reproducibility guarantees because intermediate steps don't get an implicit ordering that follows add_intermediate evaluation order. -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Jul 2021 14:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is about circular dependencies. Let me update the message to reflect that. -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 14:56:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Remove unused IFITTOOL dependency
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 ) Change subject: Makefile.inc: Remove unused IFITTOOL dependency ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56112/comment/4c7353a8_8e6fac2c PS1, Line 9: somewhere else how about adding the IFITTOOL dependency there? -- To view, visit https://review.coreboot.org/c/coreboot/+/56112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf Gerrit-Change-Number: 56112 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Jul 2021 14:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Remove explicit ramstage dependency for coreboot.rom
by Patrick Georgi (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56111 ) Change subject: Makefile.inc: Remove explicit ramstage dependency for coreboot.rom ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I648f97198772d30d6d267ab9d6f7fa8d1d5d0e91 Gerrit-Change-Number: 56111 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 14:53:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021