Attention is currently required from: Martin Roth, Arthur Heymans.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56114
to look at the new patch set (#2).
Change subject: Makefile.inc: Split of image generation in multiple targets
......................................................................
Makefile.inc: Split of image generation in multiple targets
The big '$(obj)/coreboot.pre' target did a lot of things and made the
build process inflexible. Split of much of the functionality in
INTERMEDIATE targets that can have proper dependencies.
Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.inc
M src/arch/x86/Makefile.inc
2 files changed, 46 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/56114/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353
Gerrit-Change-Number: 56114
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 )
Change subject: Makefile.inc: Remove unused IFITTOOL dependency
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56112/comment/9caebba8_e6c133a2
PS1, Line 9: somewhere else
> how about adding the IFITTOOL dependency there?
That's already the case afaik. Maybe adding it for $(obj)/coreboot.rom makes sense.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf
Gerrit-Change-Number: 56112
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 15:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 )
Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This also breaks reproducibility guarantees because intermediate steps don't get an implicit ordering that follows add_intermediate evaluation order.
Was that not already the case with intermediate targets?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387
Gerrit-Change-Number: 56113
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 15:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 )
Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This also breaks reproducibility guarantees because intermediate steps don't get an implicit ordering that follows add_intermediate evaluation order.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387
Gerrit-Change-Number: 56113
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Jul 2021 14:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 )
Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is about circular dependencies. Let me update the message to reflect that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387
Gerrit-Change-Number: 56113
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 14:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56112 )
Change subject: Makefile.inc: Remove unused IFITTOOL dependency
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56112/comment/4c7353a8_8e6fac2c
PS1, Line 9: somewhere else
how about adding the IFITTOOL dependency there?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf
Gerrit-Change-Number: 56112
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 06 Jul 2021 14:55:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56111 )
Change subject: Makefile.inc: Remove explicit ramstage dependency for coreboot.rom
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I648f97198772d30d6d267ab9d6f7fa8d1d5d0e91
Gerrit-Change-Number: 56111
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 14:53:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment