coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: security/intel/cbnt/Makefile.inc: Improve build flow
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56119 to look at the new patch set (#3). Change subject: security/intel/cbnt/Makefile.inc: Improve build flow ...................................................................... security/intel/cbnt/Makefile.inc: Improve build flow Now that adding all files to cbfs is a distinct Makefile target in the buildprocess called "add_prebuild_files", it can be used to streamline setting up cbnt. Using 'files_added::' is not needed any longer. Change-Id: I22aa140202f0665b7095a01cb138af4986aa9ac3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/cbnt/Makefile.inc 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/56119/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22aa140202f0665b7095a01cb138af4986aa9ac3 Gerrit-Change-Number: 56119 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Split of image generation in multiple targets
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56114 to look at the new patch set (#3). Change subject: Makefile.inc: Split of image generation in multiple targets ...................................................................... Makefile.inc: Split of image generation in multiple targets The big '$(obj)/coreboot.pre' target did a lot of things and made the build process inflexible. Split of much of the functionality in INTERMEDIATE targets that can have proper dependencies. Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc 1 file changed, 29 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/56114/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353 Gerrit-Change-Number: 56114 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Drop the cbfs master header from non-X86
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56120 to look at the new patch set (#3). Change subject: Makefile.inc: Drop the cbfs master header from non-X86 ...................................................................... Makefile.inc: Drop the cbfs master header from non-X86 The pointer to the header has a x86 top mmaped address even though the boot medium is not mapped that way. If no pointer is used to find the header FMAP is needed. If FMAP is used anyway there is no need for a cbfs master header. Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc 1 file changed, 2 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/56120/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d693bdd4ddaf4c9b3cffb4ea9879c761200aca9 Gerrit-Change-Number: 56120 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile.inc: Fix IFITTOOL dependencies
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth, Arthur Heymans. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56112 to look at the new patch set (#2). Change subject: Makefile.inc: Fix IFITTOOL dependencies ...................................................................... Makefile.inc: Fix IFITTOOL dependencies Add IFITTOOL as a dependency where needed and remove where it is unneeded. Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc M src/security/intel/cbnt/Makefile.inc 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/56112/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c9fc19cca0c72e80d3218dbcc76b89b04feacf Gerrit-Change-Number: 56112 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Implement report_cache_info() function
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55654 to look at the new patch set (#3). Change subject: soc/intel/alderlake: Implement report_cache_info() function ...................................................................... soc/intel/alderlake: Implement report_cache_info() function Make use of deterministic cache helper functions from Alder Lake SoC code to print useful information during boot as below: CPU: Genuine Intel(R) 0000 CPU: ID 906a0, Alderlake Platform, ucode: 00000019 CPU: AES supported, TXT supported, VT supported Cache Information for Level3: assoc=12 par=1 line_size=64 sets=16384 @@ cache_size 0xc00000 bytes Change-Id: I30a56266015d69abccb885b3f230689488ee0360 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/alderlake/bootblock/report_platform.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/55654/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30a56266015d69abccb885b3f230689488ee0360 Gerrit-Change-Number: 55654 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/intel/common: Allow common_init.c compile for bootblock
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55966 ) Change subject: cpu/intel/common: Allow common_init.c compile for bootblock ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/55966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9efdc3c21549faead168930d4ccb9906a7c7e900 Gerrit-Change-Number: 55966 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: arch/x86: smbios write 7 table using deterministic cache helper funct...
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56121 ) Change subject: arch/x86: smbios write 7 table using deterministic cache helper functions ...................................................................... arch/x86: smbios write 7 table using deterministic cache helper functions This patch makes use of deterministic cache helper functions, for example: cpu_get_cache_type(), cpu_get_cache_level() etc. from arch/x86/cpu_common.c file. Also, change argument for get_number_of_caches() function that receives cpu_get_max_cache_share() data directly. TEST=Able to dump SMBIOS Table 7 with this CL, no changes seen in output. SMBIOS Cache Information : cache_type = 1 level = 1 assoc=12 par=1 line_size=64 number_of_sets = 64 sets=2 @@ cache_size 0x48000 bytes cache_type = 2 level = 1 assoc=8 par=1 line_size=64 number_of_sets = 64 sets=2 @@ cache_size 0x30000 bytes cache_type = 3 level = 2 assoc=10 par=1 line_size=64 number_of_sets = 2048 sets=8 @@ cache_size 0x140000 bytes cache_type = 3 level = 3 assoc=12 par=1 line_size=64 number_of_sets = 16384 sets=64 @@ cache_size 0xc00000 bytes Change-Id: Iedbd3b745629dea57c3ad6b0d187eab2bcc3f7d3 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/smbios.c 1 file changed, 13 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/56121/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index e686992..cd5a50c 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -489,9 +489,8 @@ return 0; /* Unknown */ } -static size_t get_number_of_caches(struct cpuid_result res_deterministic_cache) +static size_t get_number_of_caches(const size_t max_logical_cpus_sharing_cache) { - size_t max_logical_cpus_sharing_cache = 0; size_t number_of_cpus_per_package = 0; size_t max_logical_cpus_per_package = 0; struct cpuid_result res; @@ -503,8 +502,6 @@ max_logical_cpus_per_package = (res.ebx >> 16) & 0xff; - max_logical_cpus_sharing_cache = ((res_deterministic_cache.eax >> 14) & 0xfff) + 1; - /* Check if it's last level cache */ if (max_logical_cpus_sharing_cache == max_logical_cpus_per_package) return 1; @@ -797,30 +794,13 @@ int *max_struct_size, struct smbios_type4 *type4) { - struct cpuid_result res; - unsigned int cnt = 0; + unsigned int cnt = CACHE_L0; int len = 0; - u32 leaf; if (!cpu_have_cpuid()) return len; - if (cpu_is_intel()) { - res = cpuid(0); - if (res.eax < 4) - return len; - leaf = 4; - } else if (cpu_is_amd()) { - res = cpuid(0x80000000); - if (res.eax < 0x80000001) - return len; - - res = cpuid(0x80000001); - if (!(res.ecx & (1 << 22))) - return len; - - leaf = 0x8000001d; - } else { + if (cpu_check_deterministic_cache_cpuid_supported() == CPUID_TYPE_INVALID) { printk(BIOS_DEBUG, "SMBIOS: Unknown CPU\n"); return len; } @@ -829,16 +809,15 @@ enum smbios_cache_associativity associativity; enum smbios_cache_type type; - res = cpuid_ext(leaf, cnt++); - - const u8 cache_type = CPUID_CACHE_TYPE(res); - const u8 level = CPUID_CACHE_LEVEL(res); - const size_t assoc = CPUID_CACHE_WAYS_OF_ASSOC(res) + 1; - const size_t partitions = CPUID_CACHE_PHYS_LINE(res) + 1; - const size_t cache_line_size = CPUID_CACHE_COHER_LINE(res) + 1; - const size_t number_of_sets = CPUID_CACHE_NO_OF_SETS(res) + 1; + const u8 cache_type = cpu_get_cache_type(cnt); + const u8 level = cpu_get_cache_level(cnt); + const size_t assoc = cpu_get_cache_ways_assoc_info(cnt); + const size_t partitions = cpu_get_cache_phy_partition_info(cnt); + const size_t cache_line_size = cpu_get_cache_line_size(cnt); + const size_t number_of_sets = cpu_get_cache_sets(cnt); + const size_t cache_share = cpu_get_max_cache_share(cnt); const size_t cache_size = assoc * partitions * cache_line_size * number_of_sets - * get_number_of_caches(res); + * get_number_of_caches(cache_share); if (!cache_type) /* No more caches in the system */ @@ -859,7 +838,7 @@ break; } - if (CPUID_CACHE_FULL_ASSOC(res)) + if (cpu_is_cache_full_assoc(cnt)) associativity = SMBIOS_CACHE_ASSOCIATIVITY_FULL; else associativity = smbios_cache_associativity(assoc); @@ -883,6 +862,7 @@ break; } } + cnt++; }; return len; -- To view, visit https://review.coreboot.org/c/coreboot/+/56121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedbd3b745629dea57c3ad6b0d187eab2bcc3f7d3 Gerrit-Change-Number: 56121 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Makefile.inc: Remove the $(INTERMEDIATE) dependency
by Arthur Heymans (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56113 ) Change subject: Makefile.inc: Remove the $(INTERMEDIATE) dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > no, macros and functions are evaluated in parse order. So when you add intermediates A, B, C, D, ... the current setup ensures that B depends on A, C on B and A, D on C, B, A, ... (which could be optimized by a small amount by removing the transitive dependencies), creating a stable execution order. > > Without that order-only dependency, executing C, A, D, B would be a valid strategy (and depending on how many parallel make jobs you have and what happens in them, that might well happen). > > I added that order-only target in https://review.coreboot.org/c/coreboot/+/49358 specifically to avoid race conditions that we were seeing... Ok I hope that does not put too much restrictions on the order of things? -- To view, visit https://review.coreboot.org/c/coreboot/+/56113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8d84c32f242ff3309ced3a1b5f3dc4565d3387 Gerrit-Change-Number: 56113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 16:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Helper functions to get deterministic cache parameters
by Subrata Banik (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55965 to look at the new patch set (#3). Change subject: arch/x86: Helper functions to get deterministic cache parameters ...................................................................... arch/x86: Helper functions to get deterministic cache parameters This patch creates helper function that internally detects the CPU type (AMD or Intel) and pick the leaf to send CPUID instruction with different cache level to retrieve deterministic cache parameters. Lists of helper functions generated as part of this CL : 1. cpu_check_deterministic_cache_cpuid_supported => if CPU has support for deterministic cache using CPUID instruction. 2. cpu_get_cache_ways_assoc_info => Get cache ways for associativity. 3. cpu_get_cache_type => Get cache type. 4. cpu_get_cache_level => Get cache level. 5. cpu_get_cache_phy_partition_info => Get cache physical partitions. 6. cpu_get_cache_line_size => Get cahce line size. 7. cpu_get_cache_sets => Get cache number of sets. 8. cpu_is_cache_full_assoc => Check if cache is fully associative. 9. cpu_get_max_cache_share => Cores are sharing this cache. 10. get_cache_size => Calculate the cache size. Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/cpu_common.c M src/arch/x86/include/arch/cpu.h 2 files changed, 204 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/55965/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095 Gerrit-Change-Number: 55965 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021