coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: IMOK: Add IMOK method support for DPTF
by Felix Held (Code Review) 08 Jul '21

08 Jul '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54688 ) Change subject: IMOK: Add IMOK method support for DPTF ...................................................................... IMOK: Add IMOK method support for DPTF Add IMOK method support for DPTF BRANCH=None BUG=b:187797417 TEST=Built and tested on dedede board Change-Id: I8edfa3bcaa6bde0b9690fcace000cd582dcc81d2 Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54688 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/drivers/intel/dptf/dptf.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index f9b4dee..24a371d 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -118,6 +118,15 @@ } /* \_SB.DPTF */ +static void write_imok(void) +{ + acpigen_write_method("IMOK", 1); + /* Return (Arg0) */ + acpigen_emit_byte(RETURN_OP); + acpigen_emit_byte(ARG0_OP); + acpigen_write_method_end(); +} +/* \_SB.DPTF */ static void write_oem_variables(const struct drivers_intel_dptf_config *config) { int i; @@ -217,6 +226,7 @@ write_open_dptf_device(dev, platform_info); write_fan(config, platform_info); write_oem_variables(config); + write_imok(); write_generic_devices(config, platform_info); acpigen_pop_len(); /* DPTF Device (write_open_dptf_device) */ -- To view, visit https://review.coreboot.org/c/coreboot/+/54688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8edfa3bcaa6bde0b9690fcace000cd582dcc81d2 Gerrit-Change-Number: 54688 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/guybrush: enable psp_verstage by default
by Karthik Ramasubramanian (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Kangheui Won. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55832 ) Change subject: mb/google/guybrush: enable psp_verstage by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08befb93213aeb67e6a1e5fa91273ae61025707e Gerrit-Change-Number: 55832 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 15:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: enable psp_verstage by default
by Martin Roth (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Kangheui Won. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55832 ) Change subject: mb/google/guybrush: enable psp_verstage by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08befb93213aeb67e6a1e5fa91273ae61025707e Gerrit-Change-Number: 55832 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 15:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Fix the NULL pointer in parameters
by Martin Roth (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Bao Zheng, Zheng Bao. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55550 ) Change subject: amdfwtool: Fix the NULL pointer in parameters ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2c65013d48fc1ad88d3caf6ef59824745c992de Gerrit-Change-Number: 55550 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 08 Jul 2021 15:33:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Use relative address for EFS gen2
by Martin Roth (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Paul Menzel, Zheng Bao, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55211 ) Change subject: amdfwtool: Use relative address for EFS gen2 ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a54f8ce5004915a7fa407dcd7d59a64d88aad0d Gerrit-Change-Number: 55211 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 08 Jul 2021 15:33:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/*/Makefile.inc: Do some cosmetics
by Martin Roth (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Arthur Heymans, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56117 ) Change subject: soc/amd/*/Makefile.inc: Do some cosmetics ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I'm not sure this makes things more understandable, but I don't have any outright objection to it. It seems like using $< against a macro is maybe bad since the macro obfuscates what the prerequisites are. -- To view, visit https://review.coreboot.org/c/coreboot/+/56117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea2322ca1abd43900f3631b7965f07fed4235ca0 Gerrit-Change-Number: 56117 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 08 Jul 2021 15:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable I2S audio codecs on ADL-M RVP
by Sathyanarayana Nujella (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Anil Kumar K, Selma Bensaid, Tim Wawrzynczak. Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52221 ) Change subject: mb/intel/adlrvp: Enable I2S audio codecs on ADL-M RVP ...................................................................... Patch Set 28: (1 comment) File src/mainboard/intel/adlrvp/devicetree_m.cb: https://review.coreboot.org/c/coreboot/+/52221/comment/e44822e2_1a56fb40 PS28, Line 231: i2c 1a on can you please also add "probe AUDIO ADL_MAX98373_ALC5682I_I2S" for this entry too? -- To view, visit https://review.coreboot.org/c/coreboot/+/52221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2649647e58c5f30e2b539d534adf2a4e68f4fda Gerrit-Change-Number: 52221 Gerrit-PatchSet: 28 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 14:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7180: Add display support for mipi panels
by Vinod Polimera (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, Mars Chen, mturney mturney. Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 ) Change subject: sc7180: Add display support for mipi panels ...................................................................... Patch Set 22: (1 comment) File src/mainboard/google/trogdor/mainboard.c: https://review.coreboot.org/c/coreboot/+/52662/comment/4059f000_ea338997 PS22, Line 106: get_panel_config > If we want to implement more panel, we will modify ramstage info to Makefile. […] You can append new panels info to the same panel_driver.c and attach it to the get_panel_config(). I have just added an sample panel info in panel_driver. -- To view, visit https://review.coreboot.org/c/coreboot/+/52662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f Gerrit-Change-Number: 52662 Gerrit-PatchSet: 22 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 14:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
by Name of user not set (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons. wouter.eckhardt(a)prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56086 ) Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I've tested this on one of our boards. Seems to work fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/56086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Gerrit-Change-Number: 56086 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 14:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
by Michael Niewöhner (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Jan Tatje. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 ) Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Also works just fine. […] Sorry, I meant testing that option without your patch here :) -- To view, visit https://review.coreboot.org/c/coreboot/+/56071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce Gerrit-Change-Number: 56071 Gerrit-PatchSet: 3 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Comment-Date: Thu, 08 Jul 2021 14:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jan Tatje <jan(a)jnt.io> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021