coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE
by Patrick Georgi (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Idwer Vollering, Arthur Heymans, Krystian Hebel. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55039 ) Change subject: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia88c0625cefa1e594ac1849271a71c3aacc8ce78 Gerrit-Change-Number: 55039 Gerrit-PatchSet: 4 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 13:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/lib/fmap.c: use le*toh() functions where needed
by Patrick Georgi (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Krystian Hebel. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55038 ) Change subject: src/lib/fmap.c: use le*toh() functions where needed ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: To catch all the places where wrapping is needed, you could try coccinelle (https://coccinelle.gitlabpages.inria.fr/website/) with the following semantic patch. It has some weaknesses because it would wrap things multiple times on re-invocation, but it at least should point out the right places to look into and patch in something vaguely reasonable. @ lhs_nareas @ struct fmap f; expression E; @@ f.nareas = + htole16( E + ) ; @ lhs_flags @ struct fmap f; expression E; @@ f.flags = + htole16( E + ) ; @ lhs_size @ struct fmap f; expression E; @@ f.size = + htole32( E + ) ; @ lhs_offset @ struct fmap f; expression E; @@ f.offset = + htole32( E + ) ; @ lhs_base @ struct fmap f; expression E; @@ f.base = + htole64( E + ) ; @ depends on !lhs_nareas @ struct fmap f; @@ + le16toh( f.nareas +) @ depends on !lhs_flags @ struct fmap f; @@ + le16toh( f.flags +) @ depends on !lhs_size @ struct fmap f; @@ + le32toh( f.size +) @ depends on !lhs_offset @ struct fmap f; @@ + le32toh( f.offset +) @ depends on !lhs_base @ struct fmap f; @@ + le64toh( f.base +) -- To view, visit https://review.coreboot.org/c/coreboot/+/55038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8784ac29101531db757249496315f43e4008de4f Gerrit-Change-Number: 55038 Gerrit-PatchSet: 1 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 13:01:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/lib/fmap.c: use le*toh() functions where needed
by Patrick Georgi (Code Review) 08 Jul '21

08 Jul '21

1 0

Change in coreboot[master]: ppc64/byteorder.h: define use of big endian
by Patrick Georgi (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Maciej Pijanowski, Krystian Hebel, Ron Minnich. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55037 ) Change subject: ppc64/byteorder.h: define use of big endian ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55037/comment/fa14a045_3494aa67 PS1, Line 12: configuration is changed. > Any chance you use something before this https://github. […] I never use the make targets, I use buildgcc directly. See ./buildgcc -h: Platforms for GCC & GDB: x86_64 i386-elf i386-mingw32 riscv-elf arm aarch64 powerpc64le-linux-gnu nds32le-elf powerpc64le-linux-gnu. So yes, we can, in principle support both. -- To view, visit https://review.coreboot.org/c/coreboot/+/55037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id31328a832d11db20822733304b0ae477e858d25 Gerrit-Change-Number: 55037 Gerrit-PatchSet: 1 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 12:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maciej Pijanowski Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
by Name of user not set (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons. wouter.eckhardt(a)prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56086 ) Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > This change effects all variants Ah, thanks for confimring. I got confused the hda_verb.c file that also in the R4 board variant directory. My bad... File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c: https://review.coreboot.org/c/coreboot/+/56086/comment/574cfa92_b48bd41a PS2, Line 8: 0x10ec0888, /* Subsystem ID */ > The first ID is the read-only ID, used to identify the codec. […] My guess would be that it was intended to be used as a second ID to match the verb table to the codec (though that would cause problems for clean devices, since those would not have the updated subsystem ID yet...). As far as I can tell, it's not used (maybe because of the issue with clean devices?). So I guess we can leave it as is. -- To view, visit https://review.coreboot.org/c/coreboot/+/56086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Gerrit-Change-Number: 56086 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: wouter.eckhardt(a)prodrive-technologies.com Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7180: Add display support for mipi panels
by Mars Chen (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. Mars Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 ) Change subject: sc7180: Add display support for mipi panels ...................................................................... Patch Set 22: (1 comment) File src/mainboard/google/trogdor/mainboard.c: https://review.coreboot.org/c/coreboot/+/52662/comment/3445bf0c_05348daa PS22, Line 106: get_panel_config If we want to implement more panel, we will modify ramstage info to Makefile.inc and add more panel_drver.c. How do I get specified panel from "get_panel_config" -- To view, visit https://review.coreboot.org/c/coreboot/+/52662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f Gerrit-Change-Number: 52662 Gerrit-PatchSet: 22 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 10:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: Support IGD Opregion 2.1
by Angel Pons (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Subrata Banik, Meera Ravindranath, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 ) Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ...................................................................... Patch Set 14: (1 comment) File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/c/coreboot/+/52758/comment/e57a9460_3b10ac82 PS13, Line 105: INTEL_GMA_OPREGION_2_0 > If we have to keep both 2.0 and 2.1 can we find a way to make 2.1 as the default? I think all future platforms would want to select 2.1, so it is better to keep that as the default. Hmmm, can we try to not rely on implicit defaults? I'd rather have each platform explicitly select the Opregion version it is meant to be used with. Yes, I know that what I suggested in https://review.coreboot.org/c/coreboot/+/52758/comment/bd09c08d_c09e941a/ selects 2.0 by default, but it's easy to rework the Kconfig options so that nothing is selected by default. I'd do this in another commit (which would also select 2.0 on ADL), then update ADL to use 2.1 in a third commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/52758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b Gerrit-Change-Number: 52758 Gerrit-PatchSet: 14 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 08 Jul 2021 10:37:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Meera Ravindranath <meera.ravindranath(a)intel.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Disable xDCI in devicetree
by Sridhar Siricilla (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Meera Ravindranath, Archana Patni. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52262 ) Change subject: mb/intel/adlrvp: Disable xDCI in devicetree ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94102240b13d2b96e0295f41bc2b0ba078faf342 Gerrit-Change-Number: 52262 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Archana Patni <archana.patni(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: monika.a(a)intel.com Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Archana Patni <archana.patni(a)intel.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 09:40:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: add FOR_COREBOOT define
by Hung-Te Lin (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56158 ) Change subject: vc/mediatek/mt8195: add FOR_COREBOOT define ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7a6e24f41c1fda167b5d6bb2d8a2c5c79dda8de Gerrit-Change-Number: 56158 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 09:36:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: add FOR_COREBOOT define
by Rex-BC Chen (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56158 ) Change subject: vc/mediatek/mt8195: add FOR_COREBOOT define ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7a6e24f41c1fda167b5d6bb2d8a2c5c79dda8de Gerrit-Change-Number: 56158 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 09:31:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021