coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7125 discussions

Change in coreboot[master]: drivers/generic/ioapic: Use arch/x86/ioapic
by Kyösti Mälkki (Code Review) 04 Jun '21

04 Jun '21

Attention is currently required from: Kyösti Mälkki. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55185 to look at the new patch set (#3). Change subject: drivers/generic/ioapic: Use arch/x86/ioapic ...................................................................... drivers/generic/ioapic: Use arch/x86/ioapic Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/arch/x86/include/arch/ioapic.h M src/arch/x86/ioapic.c M src/drivers/generic/ioapic/ioapic.c 3 files changed, 20 insertions(+), 74 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/55185/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f Gerrit-Change-Number: 55185 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Update DPTF parameters
by Tao Xia (Code Review) 04 Jun '21

04 Jun '21

Tao Xia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55208 ) Change subject: mb/google/dedede/var/sasukette: Update DPTF parameters ...................................................................... mb/google/dedede/var/sasukette: Update DPTF parameters Update DPTF parameters from internal thermal team. BUG=b:180875580 BRANCH=dedede TEST=emerge-dedede coreboot Signed-off-by: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Change-Id: Id18a38cddbcacbafbe2c54d94dbda5e00de02b3b --- M src/mainboard/google/dedede/variants/sasukette/overridetree.cb 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/55208/1 diff --git a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb index 0f48365..16bf546 100644 --- a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb @@ -74,7 +74,42 @@ .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, }" # Camera + register "power_limits_config" = "{ + .tdp_pl1_override = 7, + .tdp_pl2_override = 20, + }" + + register "tcc_offset" = "10" # TCC of 95C + device domain 0 on + device pci 04.0 on + chip drivers/intel/dptf + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 52, 5000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 54, 5000), + [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 54, 5000),}" + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 90, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 90, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 90, SHUTDOWN),}" + register "controls.power_limits.pl1" = "{ + .min_power = 5000, + .max_power = 7000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 28 * MSECS_PER_SEC, + .granularity = 250,}" + register "controls.power_limits.pl2" = "{ + .min_power = 20000, + .max_power = 20000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000,}" + device generic 0 on end + end + end # SA Thermal device device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/55208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id18a38cddbcacbafbe2c54d94dbda5e00de02b3b Gerrit-Change-Number: 55208 Gerrit-PatchSet: 1 Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/kracko: Add P-sensor support
by Tony Huang (Code Review) 04 Jun '21

04 Jun '21

Hello build bot (Jenkins), Wisley Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55133 to look at the new patch set (#6). Change subject: mb/google/dedede/var/kracko: Add P-sensor support ...................................................................... mb/google/dedede/var/kracko: Add P-sensor support Configure GPIO D22/D23/E11. Add P-sensor to device tree, these registers are draft version. BUG=b:178092096 BRANCH=dedede TEST=built firmware and dmesg shows STH9324 initial success. Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/kracko/gpio.c M src/mainboard/google/dedede/variants/kracko/overridetree.cb 2 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/55133/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/55133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Gerrit-Change-Number: 55133 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/kracko: Add P-sensor support
by Tony Huang (Code Review) 04 Jun '21

04 Jun '21

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55133 ) Change subject: mb/google/dedede/var/kracko: Add P-sensor support ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Please help review. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/55133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Gerrit-Change-Number: 55133 Gerrit-PatchSet: 5 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 04 Jun 2021 09:14:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/kracko: Add P-sensor support
by Tony Huang (Code Review) 04 Jun '21

04 Jun '21

Hello build bot (Jenkins), Wisley Chen, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55133 to look at the new patch set (#5). Change subject: mb/google/dedede/var/kracko: Add P-sensor support ...................................................................... mb/google/dedede/var/kracko: Add P-sensor support Configure GPIO D22/D23/E11. Add P-sensor to device tree, these registers are draft version. BUG=b:178092096 BRANCH=dedede TEST=built firmware and dmesg shows STH9324 initial success. Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/kracko/gpio.c M src/mainboard/google/dedede/variants/kracko/overridetree.cb 2 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/55133/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/55133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Gerrit-Change-Number: 55133 Gerrit-PatchSet: 5 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/lapic: Declare start_cpu() static
by Arthur Heymans (Code Review) 04 Jun '21

04 Jun '21

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55188 ) Change subject: cpu/x86/lapic: Declare start_cpu() static ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Not sure why Jenkins complains... -- To view, visit https://review.coreboot.org/c/coreboot/+/55188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4b91834a1b6de2a902ab914610ab76c1423f1e9 Gerrit-Change-Number: 55188 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 04 Jun 2021 09:10:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/kracko: Add P-sensor support
by Tony Huang (Code Review) 04 Jun '21

04 Jun '21

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55133 ) Change subject: mb/google/dedede/var/kracko: Add P-sensor support ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/55133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c8feedd6efc1a471304322a17480c836e22349e Gerrit-Change-Number: 55133 Gerrit-PatchSet: 4 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 04 Jun 2021 09:09:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/generic/ioapic: Use arch/x86/ioapic
by Kyösti Mälkki (Code Review) 04 Jun '21

04 Jun '21

Attention is currently required from: Kyösti Mälkki. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55185 to look at the new patch set (#2). Change subject: drivers/generic/ioapic: Use arch/x86/ioapic ...................................................................... drivers/generic/ioapic: Use arch/x86/ioapic Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/arch/x86/include/arch/ioapic.h M src/arch/x86/ioapic.c M src/drivers/generic/ioapic/ioapic.c 3 files changed, 19 insertions(+), 73 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/55185/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f Gerrit-Change-Number: 55185 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp: Use device aliases
by Angel Pons (Code Review) 04 Jun '21

04 Jun '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 ) Change subject: mb/intel/adlrvp: Use device aliases ...................................................................... Patch Set 2: (8 comments) File src/mainboard/intel/adlrvp/devicetree.cb: https://review.coreboot.org/c/coreboot/+/55205/comment/3399877b_418f3745 PS2, Line 320: device pci 10.0 off end : device pci 10.1 off end : device pci 10.6 off end # THC0 : device pci 10.7 off end # THC1 chipset.cb only has the first two: device pci 10.0 alias thc0 off end device pci 10.1 alias thc1 off end https://review.coreboot.org/c/coreboot/+/55205/comment/fc6fa6a2_94dc8cb0 PS2, Line 324: device pci 11.0 off end : device pci 11.1 off end : device pci 11.2 off end : device pci 11.3 off end : device pci 11.4 off end : device pci 11.5 off end chipset.cb doesn't have any of these. Do these PCI devices exist at all? https://review.coreboot.org/c/coreboot/+/55205/comment/7bddcd8a_509b3687 PS2, Line 331: device pci 12.5 off end chipset.cb doesn't have this https://review.coreboot.org/c/coreboot/+/55205/comment/9e0d3644_19142ecb PS2, Line 334: device pci 13.1 off end chipset.cb doesn't have this https://review.coreboot.org/c/coreboot/+/55205/comment/6dad0a6d_beeaacb3 PS2, Line 362: device pci 16.2 off end # CSME : device pci 16.3 off end # CSME These two devices don't appear in chipset.cb for some reason. On older platforms, these used to be IDE-R and KT, respectively. https://review.coreboot.org/c/coreboot/+/55205/comment/549a8e89_92b3fd5d PS2, Line 317: chip drivers/usb/acpi : register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" : device usb 0.0 on : chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.9 on end : end : end : end chipset.cb also has a `chip drivers/usb/acpi` with stuff inside. Shouldn't this be updated too? https://review.coreboot.org/c/coreboot/+/55205/comment/9e34c572_5d0d478d PS2, Line 352: device ref pch_espi on end alderlake chipset.cb already enables this: device pci 1f.0 alias pch_espi on end https://review.coreboot.org/c/coreboot/+/55205/comment/8dcab8c8_0de3dd38 PS2, Line 366: device ref fast_spi on end alderlake chipset.cb already enables this: device pci 1f.5 alias fast_spi on end -- To view, visit https://review.coreboot.org/c/coreboot/+/55205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9e82d953416c076588974f3167d00ae96f01bb5 Gerrit-Change-Number: 55205 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Fri, 04 Jun 2021 08:56:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/lapic: Separate stop_this_cpu()
by build bot (Jenkins) (Code Review) 04 Jun '21

04 Jun '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55193 ) Change subject: cpu/x86/lapic: Separate stop_this_cpu() ...................................................................... Patch Set 1: (1 comment) File src/cpu/x86/lapic/lapic_cpu_stop.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120699): https://review.coreboot.org/c/coreboot/+/55193/comment/1a7b2233_e7ee9a34 PS1, Line 22: #define dprintk(LEVEL, args...) do { printk(LEVEL, ##args); } while (0) Single statement macros should not use a do {} while (0) loop -- To view, visit https://review.coreboot.org/c/coreboot/+/55193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5696da4dfe98579a3b37a027966b6758f22574aa Gerrit-Change-Number: 55193 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Jun 2021 08:44:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021