Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55206
to look at the new patch set (#3).
Change subject: mb/intel/sm: Use device aliases
......................................................................
mb/intel/sm: Use device aliases
Use the device aliases provided by alderlake chipset.cb instead of
the raw pci device+function. Take advantage of the default states
in chipset.cb and only list the devices that are enabled for all
shadowmountain board variants.
TEST=Dump devicetree device enable list without and with this CL, no
difference observed.
Change-Id: I2b769d653ad8ad8ff069a0787d00ff33ead5c912
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
1 file changed, 41 insertions(+), 73 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/55206/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/55206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b769d653ad8ad8ff069a0787d00ff33ead5c912
Gerrit-Change-Number: 55206
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55205
to look at the new patch set (#4).
Change subject: mb/intel/adlrvp: Use device aliases
......................................................................
mb/intel/adlrvp: Use device aliases
Use the device aliases provided by alderlake chipset.cb instead of
the raw pci device+function. Take advantage of the default states
in chipset.cb and only list the devices that are enabled for all
different adlrvp boards.
TEST=Dump devicetree device enable list without and with this CL, no
difference observed.
Change-Id: Ib9e82d953416c076588974f3167d00ae96f01bb5
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/mainboard/intel/adlrvp/devicetree.cb
M src/mainboard/intel/adlrvp/devicetree_m.cb
M src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb
M src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb
4 files changed, 88 insertions(+), 151 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/55205/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e82d953416c076588974f3167d00ae96f01bb5
Gerrit-Change-Number: 55205
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 )
Change subject: mb/intel/adlrvp: Use device aliases
......................................................................
Patch Set 3:
(7 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/b04a1065_0222a53c
PS2, Line 320: device pci 10.0 off end
: device pci 10.1 off end
: device pci 10.6 off end # THC0
: device pci 10.7 off end # THC1
> Hmmm, I see. It's somewhat annoying (why couldn't ADL-P and ADL-S use the same PCI B:D. […]
true
https://review.coreboot.org/c/coreboot/+/55205/comment/9628e877_c4e5afb6
PS2, Line 324: device pci 11.0 off end
: device pci 11.1 off end
: device pci 11.2 off end
: device pci 11.3 off end
: device pci 11.4 off end
: device pci 11.5 off end
> Alright, I see. I'd appreciate if you could remove ADL-S devices in a separate commit.
CB:55221 Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/9498bd56_ae98a4ce
PS2, Line 331: device pci 12.5 off end
> I'd remove it in the same commit that removes the ADL-S devices (see comment above), and mention why […]
CB:55221 Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/769e433c_51b2909f
PS2, Line 334: device pci 13.1 off end
> Its for ADL-S
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/49117629_adf98c19
PS3, Line 372: # W/A to FSP issue
> Does this comment still apply?
good point, let me keep those as is, till the time i have verify with latest FSP
File src/mainboard/intel/adlrvp/devicetree_m.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/c1bb0d3d_34b5ea4c
PS3, Line 202: device ref pch_espi on end
> Already on in chipset. […]
Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/34005b2f_aca466ce
PS3, Line 216: device ref fast_spi on end
> Already on in chipset. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/55205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e82d953416c076588974f3167d00ae96f01bb5
Gerrit-Change-Number: 55205
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 11:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55221 )
Change subject: mb/intel/{adlrvp, sm}: Remove ADL-S devices from ADL-P/M devicetree.cb
......................................................................
mb/intel/{adlrvp, sm}: Remove ADL-S devices from ADL-P/M devicetree.cb
Change-Id: I095394d9a79506346b8464c850d03cbd8ce2b812
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/mainboard/intel/adlrvp/devicetree.cb
M src/mainboard/intel/adlrvp/devicetree_m.cb
M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
3 files changed, 0 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/55221/1
diff --git a/src/mainboard/intel/adlrvp/devicetree.cb b/src/mainboard/intel/adlrvp/devicetree.cb
index 23913cc..04c3272 100644
--- a/src/mainboard/intel/adlrvp/devicetree.cb
+++ b/src/mainboard/intel/adlrvp/devicetree.cb
@@ -319,19 +319,9 @@
device pci 0e.0 off end # VMD
device pci 10.0 off end
device pci 10.1 off end
- device pci 10.6 off end # THC0
- device pci 10.7 off end # THC1
- device pci 11.0 off end
- device pci 11.1 off end
- device pci 11.2 off end
- device pci 11.3 off end
- device pci 11.4 off end
- device pci 11.5 off end
device pci 12.0 off end # SensorHUB
- device pci 12.5 off end
device pci 12.6 off end # GSPI2
device pci 13.0 off end # GSPI3
- device pci 13.1 off end
device pci 14.0 on
chip drivers/usb/acpi
register "desc" = ""Root Hub""
diff --git a/src/mainboard/intel/adlrvp/devicetree_m.cb b/src/mainboard/intel/adlrvp/devicetree_m.cb
index 4e4135f..4ebfff2 100644
--- a/src/mainboard/intel/adlrvp/devicetree_m.cb
+++ b/src/mainboard/intel/adlrvp/devicetree_m.cb
@@ -174,19 +174,9 @@
device pci 0e.0 off end # VMD
device pci 10.0 off end
device pci 10.1 off end
- device pci 10.6 off end # THC0
- device pci 10.7 off end # THC1
- device pci 11.0 off end
- device pci 11.1 off end
- device pci 11.2 off end
- device pci 11.3 off end
- device pci 11.4 off end
- device pci 11.5 off end
device pci 12.0 off end # SensorHUB
- device pci 12.5 off end
device pci 12.6 off end # GSPI2
device pci 13.0 off end # GSPI3
- device pci 13.1 off end
device pci 14.0 on
chip drivers/usb/acpi
register "desc" = ""Root Hub""
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
index 43a23a1..52b35fa 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
@@ -200,19 +200,9 @@
device pci 0e.0 off end # VMD
device pci 10.0 off end
device pci 10.1 off end
- device pci 10.6 off end # THC0
- device pci 10.7 off end # THC1
- device pci 11.0 off end
- device pci 11.1 off end
- device pci 11.2 off end
- device pci 11.3 off end
- device pci 11.4 off end
- device pci 11.5 off end
device pci 12.0 off end # SensorHUB
- device pci 12.5 off end
device pci 12.6 off end # GSPI2
device pci 13.0 off end # GSPI3
- device pci 13.1 off end
device pci 14.0 on
chip drivers/usb/acpi
register "desc" = ""Root Hub""
--
To view, visit https://review.coreboot.org/c/coreboot/+/55221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I095394d9a79506346b8464c850d03cbd8ce2b812
Gerrit-Change-Number: 55221
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph.
Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55215
to review the following change.
Change subject: cpu/intel/model_206ax/acpi.c: Do not report P_BLK
......................................................................
cpu/intel/model_206ax/acpi.c: Do not report P_BLK
IO MWAIT redirection is disabled, which means reads to the P_LVL2 and
P_LVL3 "registers" will never produce any C-state transition requests.
Moreover, the register resource descriptors for all reported C-states
use the FFixedHW address space, not I/O.
Change-Id: I026835dd24d7ac1e1bae2d851e011e1670abaad4
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/cpu/intel/model_206ax/acpi.c
1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/55215/1
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c
index 526a6d4..f1d03c8 100644
--- a/src/cpu/intel/model_206ax/acpi.c
+++ b/src/cpu/intel/model_206ax/acpi.c
@@ -306,7 +306,7 @@
void generate_cpu_entries(const struct device *device)
{
- int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;
+ int coreID, cpuID;
int totalcores = dev_count_cpu();
int cores_per_package = get_logical_cores_per_package();
int numcpus = totalcores/cores_per_package;
@@ -316,15 +316,9 @@
for (cpuID = 1; cpuID <= numcpus; cpuID++) {
for (coreID = 1; coreID <= cores_per_package; coreID++) {
- if (coreID > 1) {
- pcontrol_blk = 0;
- plen = 0;
- }
-
/* Generate processor \_SB.CPUx */
acpigen_write_processor(
- (cpuID-1)*cores_per_package+coreID-1,
- pcontrol_blk, plen);
+ (cpuID-1)*cores_per_package+coreID-1, 0, 0);
/* Generate P-state tables */
generate_P_state_entries(
--
To view, visit https://review.coreboot.org/c/coreboot/+/55215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I026835dd24d7ac1e1bae2d851e011e1670abaad4
Gerrit-Change-Number: 55215
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange