coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7127 discussions

Change in coreboot[master]: security/vboot: Add support for ZTE spaces
by Paul Menzel (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Andrey Pronin, Aseda Aboagye, Julius Werner, Aaron Durbin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55242 ) Change subject: security/vboot: Add support for ZTE spaces ...................................................................... Patch Set 2: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55242/comment/02c980b7_bd37179d PS2, Line 16: successfully. Please document how to do that. Patchset: PS2: Is successful create logged somehow? File src/security/vboot/secdata_tpm.c: https://review.coreboot.org/c/coreboot/+/55242/comment/727e1f53_1debe4b0 PS2, Line 194: * should be rare (interru pted initialization), so no big harm Stray tab. https://review.coreboot.org/c/coreboot/+/55242/comment/6d98d087_6e55d819 PS2, Line 263: * Setup the Zero-Touch Enrollment(ZTE) related spaces. Verb is spelled with a space: Set up. https://review.coreboot.org/c/coreboot/+/55242/comment/012382e1_9462f4c4 PS2, Line 288: VBDEBUG("%s: Failed to setup RMA + SN Bits space\n", __func__); set up https://review.coreboot.org/c/coreboot/+/55242/comment/bb4e0c45_d89b9697 PS2, Line 292: /* Setup Board ID */ Set up Comment can be removed, as it’s clear from the code. https://review.coreboot.org/c/coreboot/+/55242/comment/d7102245_4275b5a5 PS2, Line 298: VBDEBUG("%s: Failed to setup Board ID space\n", __func__); Set up (same below) https://review.coreboot.org/c/coreboot/+/55242/comment/8222c3f7_d7db64b3 PS2, Line 302: /* Setup RMA Bytes counter */ Set up https://review.coreboot.org/c/coreboot/+/55242/comment/062abedf_6f6a0522 PS2, Line 308: VBDEBUG("%s: Failed to define RMA Bytes space\n", __func__); Use consistent wording (set up), and RMA Bytes Counter space. https://review.coreboot.org/c/coreboot/+/55242/comment/1df50965_8dddc04a PS2, Line 352: * these are setup elsewhere via TPM vendor commands. set up -- To view, visit https://review.coreboot.org/c/coreboot/+/55242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97e3ae7e18fc9ee9a02afadbbafeb226b41af0eb Gerrit-Change-Number: 55242 Gerrit-PatchSet: 2 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)chromium.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 07:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_set_bits()`
by Paul Menzel (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Andrey Pronin, Christian Walter, Aseda Aboagye, Aaron Durbin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55241 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_set_bits()` ...................................................................... Patch Set 1: (1 comment) File src/security/tpm/tss/tcg-2.0/tss.c: https://review.coreboot.org/c/coreboot/+/55241/comment/3ff0bd27_7b8adbab PS1, Line 333: printk(BIOS_INFO, "%s: response is %x\n", Should that be more debug level? Please paste some of these lines from your device to the commit messages too. I see, it’s done elsewhere too, but for me this needs to be fixed to be debug. -- To view, visit https://review.coreboot.org/c/coreboot/+/55241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ca6376bb9f7ed8fd1167c2c80f1e8d3c3f46653 Gerrit-Change-Number: 55241 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 06:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]soc/intel/common/block/pmc: Don't link get_uint_option in SMM
by Kyösti Mälkki (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Nico Huber, Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Morgan Jang, Andrey Petrov, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55114 ) Change subject: [RFC]soc/intel/common/block/pmc: Don't link get_uint_option in SMM ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55114/comment/e10c9c37_f74b27e4 PS2, Line 19: With this change the option can no longer be updated at runtime. Also see CB:55238 commit message text; update at runtime required going thru ACPI S5 to have desired affect anyways. Patchset: PS2: Also CB:55238 squashed into this or fixed separately. -- To view, visit https://review.coreboot.org/c/coreboot/+/55114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60986979d7f7905b312b7d03abd46ac0465ae4cf Gerrit-Change-Number: 55114 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 05 Jun 2021 06:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] pc80/rtc/option: Move register backup for SMI
by Kyösti Mälkki (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Angel Pons, Alexander Couzens, Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49253 ) Change subject: [RFC] pc80/rtc/option: Move register backup for SMI ...................................................................... Patch Set 7: (2 comments) File src/drivers/pc80/rtc/option.c: https://review.coreboot.org/c/coreboot/+/49253/comment/8955332f_8148e208 PS7, Line 122: cmos_backup_idx(); "Datasheet says this register is write-only." Comment from lynxpoint about the CMOS index register pair 0x70/0x72. File src/southbridge/intel/lynxpoint/smihandler.c: https://review.coreboot.org/c/coreboot/+/49253/comment/41704a8b_ff85b09a PS6, Line 85: tmp70 = inb(0x70); > Datasheet says this register is write-only. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/49253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I025e9952a949834755f5cbc3dfe7b26ab9aaa032 Gerrit-Change-Number: 49253 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 06:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Update gpio setting
by Tao Xia (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Henry Sun, Karthik Ramasubramanian. Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55175 ) Change subject: mb/google/dedede/var/storo: Update gpio setting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc214fcd9c4631368a71f4d59bb644df739982ab Gerrit-Change-Number: 55175 Gerrit-PatchSet: 1 Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 05:17:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/blipper: Update DPTF parameters
by Tao Xia (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Henry Sun, Karthik Ramasubramanian. Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54715 ) Change subject: mb/google/dedede/var/blipper: Update DPTF parameters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I379c0ea79a7c27bdd81ed41a54135f7284fb6412 Gerrit-Change-Number: 54715 Gerrit-PatchSet: 2 Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 05:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Hook up FSP repository
by Furquan Shaikh (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Nathaniel L Desimone. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 ) Change subject: soc/intel/tigerlake: Hook up FSP repository ...................................................................... Patch Set 15: (4 comments) File src/mainboard/google/volteer/Kconfig: https://review.coreboot.org/c/coreboot/+/48713/comment/df96696a_abe63ac1 PS15, Line 23: FSP_TYPE_CLIENT Since the default FSP type is FSP_TYPE_CLIENT, there is no need to explicitly select this at the mainboard level. File src/soc/intel/tigerlake/Kconfig: https://review.coreboot.org/c/coreboot/+/48713/comment/b3626fe2_fba4b996 PS15, Line 220: depends on HAVE_INTEL_FSP_REPO This is not really a dependency, right? https://review.coreboot.org/c/coreboot/+/48713/comment/9e2d5d63_1839c269 PS15, Line 226: default y ``` default y if !FSP_TYPE_IOT ``` https://review.coreboot.org/c/coreboot/+/48713/comment/697ab9ac_0a93a701 PS15, Line 227: depends on HAVE_INTEL_FSP_REPO same comment as L220. -- To view, visit https://review.coreboot.org/c/coreboot/+/48713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7 Gerrit-Change-Number: 48713 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Comment-Date: Sat, 05 Jun 2021 04:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Fix X2APIC NMI entry in ACPI MADT
by Wonkyu Kim (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55182 ) Change subject: soc/intel/common: Fix X2APIC NMI entry in ACPI MADT ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/55182/comment/f4be5af7_6813e2f0 PS1, Line 86: 0xffffffff, 0xd, 1); > Thanks for finding out the this. Do you have detail failure from original code? […] if (is_x2apic_mode()) current += acpi_create_madt_lx2apic_nmi((acpi_madt_lx2apic_nmi_t *)current, 0xffffffff, 0xd, 1); else current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current, 0xff, 5, 1); This logic is working fine. Can you also check it from your side? -- To view, visit https://review.coreboot.org/c/coreboot/+/55182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c0537a3efba942329f80d7cfdbd910b8958516f Gerrit-Change-Number: 55182 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 03:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Fix X2APIC NMI entry in ACPI MADT
by Wonkyu Kim (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55182 ) Change subject: soc/intel/common: Fix X2APIC NMI entry in ACPI MADT ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/55182/comment/de02a493_fc9524ef PS1, Line 86: 0xffffffff, 0xd, 1); > I'd like to know reasoning for the different flags here. 5 vs 0xd. Thanks for finding out the this. Do you have detail failure from original code? It's better add this info as test method for x2apic mode. According to our testing to boot and check x2apic mode from OS, we did not find out any issue. So, we may also add the use case one of verification method 0xD is active high and level trigger is the value is from reference BIOS code. Checked reference bios code again, it looks we may need to use either acpi_create_madt_lapic_nmi or acpi_create_madt_lx2apic_nmi. I mean like below. current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current, 0xff, 5, 1); if (is_x2apic_mode()) current += acpi_create_madt_lx2apic_nmi((acpi_madt_lx2apic_nmi_t *)current, 0xffffffff, 0xd, 1); else current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current, 0xff, 5, 1); Let me also check this from my side. -- To view, visit https://review.coreboot.org/c/coreboot/+/55182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c0537a3efba942329f80d7cfdbd910b8958516f Gerrit-Change-Number: 55182 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 03:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: northbridge/haswell/gma.c: Add Desktop HD 4400 id
by Angel Pons (Code Review) 05 Jun '21

05 Jun '21

Attention is currently required from: Máté Kukri, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55243 ) Change subject: northbridge/haswell/gma.c: Add Desktop HD 4400 id ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I'll try to find if we're missing any other IDs -- To view, visit https://review.coreboot.org/c/coreboot/+/55243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7c38206b1ddfe486298cd3921fcb762a89ec51 Gerrit-Change-Number: 55243 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 05 Jun 2021 03:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021