coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7127 discussions

Change in coreboot[master]: sb/intel/lynxpoint: Add SerialIO UART console support
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52489 ) Change subject: sb/intel/lynxpoint: Add SerialIO UART console support ...................................................................... Patch Set 11: (1 comment) Patchset: PS9: > > BDW's pch_uart_init() is never called. Hence I assume things work […] I've added a TODO comment and also mentioned this issue in the commit message. Would it work for you? -- To view, visit https://review.coreboot.org/c/coreboot/+/52489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022 Gerrit-Change-Number: 52489 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Add SerialIO UART console support
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52489 to look at the new patch set (#11). Change subject: sb/intel/lynxpoint: Add SerialIO UART console support ...................................................................... sb/intel/lynxpoint: Add SerialIO UART console support Derived from Broadwell and adapted to follow what soc/intel does. Note that SERIALIO_UART_CONSOLE is meant to be selected from the mainboards which expose a SerialIO UART. UART_FOR_CONSOLE also needs to be set in mainboard Kconfig accordingly. It is possible that some of the UART configuration steps in bootblock are unnecessary. However, some of the steps turn off power management features and others are undocumented: omitting them could cause weird issues. Finally, add a config file to ensure the code gets build-tested. Tested on out-of-tree Compal LA-A992P, SerialIO UART 0 can be used to receive coreboot and SeaBIOS logs. Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- A configs/config.google_panther.pch_serialio_uart M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/Makefile.inc M src/southbridge/intel/lynxpoint/bootblock.c M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/serialio.c A src/southbridge/intel/lynxpoint/uart.c A src/southbridge/intel/lynxpoint/uart_init.c 8 files changed, 125 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/52489/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/52489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022 Gerrit-Change-Number: 52489 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55254 ) Change subject: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/alderlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/55254/comment/21fb0a75_7f2b725e PS1, Line 147: if(cse_get_rw_rdev(&desc_dev) < 0) > space required before the open parenthesis '(' Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/55254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 Gerrit-Change-Number: 55254 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55254 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon ...................................................................... soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon The patch updates PMC Descriptpr which is part of Descriptor Region if system equipped with Alderlake B silicon. TEST=Verified PMC Descriptor getting modified for Alderlake B silicon if not updated. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 --- M src/soc/intel/alderlake/romstage/romstage.c 1 file changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/55254/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 Gerrit-Change-Number: 55254 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] src/superio/smsc: Add support for the SCH5555
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Máté Kukri (mkukri), Michael Niewöhner, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 ) Change subject: [WIP] src/superio/smsc: Add support for the SCH5555 ...................................................................... Patch Set 4: (1 comment) File src/superio/smsc/sch5555/ramstage.c: https://review.coreboot.org/c/coreboot/+/55250/comment/499255b6_c47e2931 PS4, Line 54: uint8_t tmp = pnp_read_config(lpci, bar + 1); : pnp_write_config(lpci, bar + 1, tmp | 0x80); > That's only defined in simple device "mode". CB:55255 to the rescue! 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/55250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 Gerrit-Change-Number: 55250 Gerrit-PatchSet: 4 Gerrit-Owner: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] src/superio/smsc: Add support for the SCH5555
by Paul Menzel (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Máté Kukri (mkukri), Angel Pons, Michael Niewöhner, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 ) Change subject: [WIP] src/superio/smsc: Add support for the SCH5555 ...................................................................... Patch Set 4: (6 comments) Patchset: PS4: Looks good to me, if the commit message is extended (datasheet name/revision, mentioning of RE and where/how it was tested). File src/superio/smsc/sch5555/bootblock.c: https://review.coreboot.org/c/coreboot/+/55250/comment/8fdc87ae_7c341ddd PS4, Line 29: * sequences could actually be sent before the serial enable function is called Please add a dot/period at the end of sentences. https://review.coreboot.org/c/coreboot/+/55250/comment/f39d3d29_64105e6b PS4, Line 64: Setup Set up File src/superio/smsc/sch5555/ramstage.c: https://review.coreboot.org/c/coreboot/+/55250/comment/d6b701ab_eba15269 PS4, Line 42: * Thus we ignore the index and choose what BAR to set just based on the LDN Please add period/dot at the end of sentences. File src/superio/smsc/sch5555/sch5555.h: https://review.coreboot.org/c/coreboot/+/55250/comment/46215292_31047510 PS4, Line 51: // Please use /* * */ Or just one line. https://review.coreboot.org/c/coreboot/+/55250/comment/b9ef05a9_9857e7e0 PS4, Line 68: // Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/55250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 Gerrit-Change-Number: 55250 Gerrit-PatchSet: 4 Gerrit-Owner: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/pnp: Always provide `pnp_unset_and_set_config`
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55255 ) Change subject: device/pnp: Always provide `pnp_unset_and_set_config` ...................................................................... device/pnp: Always provide `pnp_unset_and_set_config` The `pnp_unset_and_set_config` function was only available when building with `ENV_PNP_SIMPLE_DEVICE` set. Add the complementary definition using device pointers, for the sake of completeness. Change-Id: I2a21e635f41f3f786057500fa96a2b3116e30d76 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/device/pnp_device.c M src/include/device/pnp.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/55255/1 diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 259d449..699007d 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -47,6 +47,15 @@ return inb(dev->path.pnp.port + 1); } +void pnp_unset_and_set_config(struct device *dev, u8 reg, u8 unset, u8 set) +{ + outb(reg, dev->path.pnp.port); + u8 value = inb(dev->path.pnp.port + 1); + value &= ~unset; + value |= set; + outb(value, dev->path.pnp.port + 1); +} + void pnp_set_logical_device(struct device *dev) { pnp_write_config(dev, 0x07, dev->path.pnp.device & 0xff); diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index 955eac2..770a640 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -13,6 +13,7 @@ /* Primitive PNP resource manipulation */ void pnp_write_config(struct device *dev, u8 reg, u8 value); u8 pnp_read_config(struct device *dev, u8 reg); +void pnp_unset_and_set_config(struct device *dev, u8 reg, u8 unset, u8 set); void pnp_set_logical_device(struct device *dev); void pnp_set_enable(struct device *dev, int enable); int pnp_read_enable(struct device *dev); -- To view, visit https://review.coreboot.org/c/coreboot/+/55255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a21e635f41f3f786057500fa96a2b3116e30d76 Gerrit-Change-Number: 55255 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/lenovo/w541: Add Thinkpad W541
by amersel (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph. amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 ) Change subject: mb/lenovo/w541: Add Thinkpad W541 ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: I've purchased another W541 to see if my screen mod is the cause of the libgfxinit issues. In the coming days I'll post an update with my results, just have to take the time to disassemble it and flash it. -- To view, visit https://review.coreboot.org/c/coreboot/+/52659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08 Gerrit-Change-Number: 52659 Gerrit-PatchSet: 12 Gerrit-Owner: amersel Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo/w541: Add Thinkpad W541
by amersel (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph. Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52659 to look at the new patch set (#12). Change subject: mb/lenovo/w541: Add Thinkpad W541 ...................................................................... mb/lenovo/w541: Add Thinkpad W541 Adds support for the Thinkpad W541 based on Peter Lemenkov's initial W541 port. Compiled and tested with SeaBIOS booting into Arch Linux 5.10.32-lts using a VGA BIOS ROM extracted using VBiosFinder. The Haswell mrc.bin blob is required. Tested working: - SATA SSD - SATA DVD drive - All USB ports - Sdcard - Speakers/headphone jack - Keyboard/touchpad - VGA - mini DisplayPort (Thunderbolt untested) - eDP laptop screen - Camera - Smartcard reader - Internal flashing when IFD is unlocked - Thinkpad basic dock - CMOS options - WLAN - Bluetooth - Ethernet - Using me_cleaner Not working: - libgfxinit - Keyboard backlight - Each boot takes 20s Signed-off-by: Amersel <amersel(a)runbox.me> Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08 --- A src/mainboard/lenovo/w541/Kconfig A src/mainboard/lenovo/w541/Kconfig.name A src/mainboard/lenovo/w541/Makefile.inc A src/mainboard/lenovo/w541/acpi/ec.asl A src/mainboard/lenovo/w541/acpi/platform.asl A src/mainboard/lenovo/w541/acpi/superio.asl A src/mainboard/lenovo/w541/acpi_tables.c A src/mainboard/lenovo/w541/board_info.txt A src/mainboard/lenovo/w541/cmos.default A src/mainboard/lenovo/w541/cmos.layout A src/mainboard/lenovo/w541/data.vbt A src/mainboard/lenovo/w541/devicetree.cb A src/mainboard/lenovo/w541/dsdt.asl A src/mainboard/lenovo/w541/gma-mainboard.ads A src/mainboard/lenovo/w541/gpio.c A src/mainboard/lenovo/w541/hda_verb.c A src/mainboard/lenovo/w541/mainboard.c A src/mainboard/lenovo/w541/romstage.c A src/mainboard/lenovo/w541/smihandler.c 19 files changed, 767 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52659/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/52659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08 Gerrit-Change-Number: 52659 Gerrit-PatchSet: 12 Gerrit-Owner: amersel Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: northbridge/haswell/gma.c: Add Desktop HD 4400 id
by Paul Menzel (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Máté Kukri (mkukri), Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55243 ) Change subject: northbridge/haswell/gma.c: Add Desktop HD 4400 id ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/haswell/gma.c: https://review.coreboot.org/c/coreboot/+/55243/comment/edc7b118_7687e5e4 PS1, Line 98: case 0x8086041e: /* GT2 Desktop (HD 4400) */ Please sort the IDs (after 041a). -- To view, visit https://review.coreboot.org/c/coreboot/+/55243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7c38206b1ddfe486298cd3921fcb762a89ec51 Gerrit-Change-Number: 55243 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021