coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7127 discussions

Change in coreboot[master]: soc/intel/intel: Add Alder Lake device ID
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55256 ) Change subject: soc/intel/intel: Add Alder Lake device ID ...................................................................... soc/intel/intel: Add Alder Lake device ID Add Alder Lake specific Graphics device ID. As per latest document number: 641765, this ID got an update. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I6f36256505a3e07c6197079ea2013991e841401b --- M src/include/device/pci_ids.h M src/soc/intel/alderlake/bootblock/report_platform.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/55256/1 diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index eeb23ae..8276a3e 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3816,6 +3816,7 @@ #define PCI_DEVICE_ID_INTEL_ADL_P_GT2_1 0x46b0 #define PCI_DEVICE_ID_INTEL_ADL_P_GT2_2 0x46a1 #define PCI_DEVICE_ID_INTEL_ADL_P_GT2_3 0x46a3 +#define PCI_DEVICE_ID_INTEL_ADL_P_GT2_4 0x46a8 #define PCI_DEVICE_ID_INTEL_ADL_S_GT1 0x4680 #define PCI_DEVICE_ID_INTEL_ADL_M_GT1 0x46c0 diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c index 15391ab..c5f9254 100644 --- a/src/soc/intel/alderlake/bootblock/report_platform.c +++ b/src/soc/intel/alderlake/bootblock/report_platform.c @@ -103,6 +103,7 @@ { PCI_DEVICE_ID_INTEL_ADL_P_GT2_1, "Alderlake P GT2" }, { PCI_DEVICE_ID_INTEL_ADL_P_GT2_2, "Alderlake P GT2" }, { PCI_DEVICE_ID_INTEL_ADL_P_GT2_3, "Alderlake P GT2" }, + { PCI_DEVICE_ID_INTEL_ADL_P_GT2_4, "Alderlake P GT2" }, { PCI_DEVICE_ID_INTEL_ADL_M_GT1, "Alderlake M GT1" }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/55256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f36256505a3e07c6197079ea2013991e841401b Gerrit-Change-Number: 55256 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: Update PMC Descriptor for Alderlake B0 silicon
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55254 to look at the new patch set (#3). Change subject: soc/intel/alderlake: Update PMC Descriptor for Alderlake B0 silicon ...................................................................... soc/intel/alderlake: Update PMC Descriptor for Alderlake B0 silicon The patch updates PMC Descriptpr which is part of Descriptor Region if system equipped with Alderlake B silicon. TEST=Verified PMC Descriptor getting modified for Alderlake B silicon if not updated. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 --- M src/soc/intel/alderlake/romstage/romstage.c 1 file changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/55254/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 Gerrit-Change-Number: 55254 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{common,alderlake}: Use generic name "Alderlake Platform"
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Rizwan Qureshi, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Rizwan Qureshi, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55252 to look at the new patch set (#2). Change subject: soc/intel/{common,alderlake}: Use generic name "Alderlake Platform" ...................................................................... soc/intel/{common,alderlake}: Use generic name "Alderlake Platform" The patch rename all ADL-P and ADL-M Silicon CPUID macros and define generic name "Alderlake Platform" as macro value. The macros are renamed as below: CPUID_ALDERLAKE_P_A0 -> CPUID_ALDERLAKE_A0 CPUID_ALDERLAKE_P_B0 -> CPUID_ALDERLAKE_B0 CPUID_ALDERLAKE_M_A0 -> CPUID_ALDERLAKE_C0 TEST=Verify boot on Brya. After change, relevent coreboot logs appear as below: CPU: ID 906a1, Alderlake Platform, ucode: 00000119 CPU: AES supported, TXT supported, VT supported MCH: device id 4601 (rev 03) is Alderlake-P PCH: device id 5181 (rev 00) is Alderlake-P SKU IGD: device id 46b0 (rev 04) is Alderlake P GT2 Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ia06d2b62d4194edd4e104d49b340ac23305a4c15 --- M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/include/intelblocks/mp_init.h 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/55252/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia06d2b62d4194edd4e104d49b340ac23305a4c15 Gerrit-Change-Number: 55252 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device/pnp: Always provide `pnp_unset_and_set_config`
by Máté Kukri (mkukri) (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Felix Held. Máté Kukri (mkukri) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55255 ) Change subject: device/pnp: Always provide `pnp_unset_and_set_config` ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a21e635f41f3f786057500fa96a2b3116e30d76 Gerrit-Change-Number: 55255 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Máté Kukri (mkukri) <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 18:21:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/hp: Add Compal LA-A992P
by build bot (Jenkins) (Code Review) 06 Jun '21

06 Jun '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 ) Change subject: mb/hp: Add Compal LA-A992P ...................................................................... Patch Set 14: (17 comments) File src/mainboard/hp/hp_15_notebook_pc/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d18623d2_9d117175 PS14, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/10a0ff12_551ca5ed PS14, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d01f6566_1bc966f3 PS14, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/730f943f_75c405de PS14, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/e7cd6b72_88f4696a PS14, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/38df34d6_7396d1e4 PS14, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d6182ce7_6e3138a3 PS14, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/f5a08d65_1e1f782f PS14, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/40eab0e8_e2837aa4 PS14, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/11a5065b_3c207e57 PS14, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/96ef813d_68c2f1c1 PS14, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/6072cc90_e6054680 PS14, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/92d1dd3a_2fdfb86d PS14, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/9c18ac71_427d9b32 PS14, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/1026a7c3_963c451e PS14, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/23199dbc_0edb0d08 PS14, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/e275f2f1_aab708c4 PS14, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/52475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I121ed4c1a9ba78abb1560d48c57105fd36d8b587 Gerrit-Change-Number: 52475 Gerrit-PatchSet: 14 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 18:06:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon
by Sridhar Siricilla (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55254 ) Change subject: soc/intel/alderlake: Update PMC Descriptor for Alderlake B silicon ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55254/comment/eded3f1c_56ad6df4 PS2, Line 7: B B0 -- To view, visit https://review.coreboot.org/c/coreboot/+/55254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d9a2ce0f0b3e386eefa1962ce706b58f31a8576 Gerrit-Change-Number: 55254 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:52:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/generic/ioapic: Use arch/x86/ioapic
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55185 ) Change subject: drivers/generic/ioapic: Use arch/x86/ioapic ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/drivers/generic/ioapic/ioapic.c: https://review.coreboot.org/c/coreboot/+/55185/comment/899c61cb_5f8024db PS3, Line 17: config->enable_virtual_wire); > I doubt if irq_on_fsb is worth keeping in devicetree. Usage is bound to CPU model AFAICS. […] The only boards that set `irq_on_fsb` are gm45 boards and samsung/lumpy. I don't get the point of CB:1462 (commit message body does not exist) -- To view, visit https://review.coreboot.org/c/coreboot/+/55185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f Gerrit-Change-Number: 55185 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:47:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/ioapic: Add write_vector() helper
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55184 ) Change subject: arch/x86/ioapic: Add write_vector() helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a44aada7d3dbc016e4044c351534a0d8520f0b2 Gerrit-Change-Number: 55184 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:41:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/ioapic: Split some ioapic utility functions
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55183 ) Change subject: arch/x86/ioapic: Split some ioapic utility functions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70dfec900e8ce6630e61bc3fcbcfd88c097a5600 Gerrit-Change-Number: 55183 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:40:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Add SerialIO UART console support
by build bot (Jenkins) (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52489 ) Change subject: sb/intel/lynxpoint: Add SerialIO UART console support ...................................................................... Patch Set 11: (1 comment) File src/southbridge/intel/lynxpoint/uart_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120886): https://review.coreboot.org/c/coreboot/+/52489/comment/09ff7ef8_a3c41f5a PS11, Line 16: switch (CONFIG_UART_FOR_CONSOLE) { switch and case should be at the same indent -- To view, visit https://review.coreboot.org/c/coreboot/+/52489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022 Gerrit-Change-Number: 52489 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 17:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021