coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/google/guybrush: Configure Pen Detect device
by Furquan Shaikh (Code Review) 04 May '21

04 May '21

Attention is currently required from: Martin Roth, Mathew King, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52906 ) Change subject: mb/google/guybrush: Configure Pen Detect device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52906 To unsubscribe, or for help writing mail filters, visit https://review.… [View More]

1 0

Change in coreboot[master]: mb/google/guybrush: Configure Pen Detect device
by Raul Rangel (Code Review) 04 May '21

04 May '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Mathew King, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52906 ) Change subject: mb/google/guybrush: Configure Pen Detect device ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52906/comment/3ef9f7c4_b07d5e15 PS1, Line 20: suspended &… [View More]

1 0

Change in coreboot[master]: security/vboot: Include fspt.bin in the RO region only
by Felix Held (Code Review) 04 May '21

04 May '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52853 ) Change subject: security/vboot: Include fspt.bin in the RO region only ...................................................................... security/vboot: Include fspt.bin in the RO region only fspt.bin is run before verstage so it is of no use in RW_A/B. Change-Id: I6fe29793fa638312c8b275b6fa8662df78b3b2bd Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.… [View More]

1 0

Change in coreboot[master]: mb/google/dedede/var/cret: Modify reset setting for touchscreen
by Felix Held (Code Review) 04 May '21

04 May '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52727 ) Change subject: mb/google/dedede/var/cret: Modify reset setting for touchscreen ...................................................................... mb/google/dedede/var/cret: Modify reset setting for touchscreen Modify reset pin setting to ACPI_GPIO_OUTPUT_ACTIVE_LOW for ELAN and Weida touchscreen. BUG=b:180547621 BRANCH=dedede TEST=Build the cret board and touchscreen is workable. Signed-off-by: … [View More]Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Change-Id: I912fe8a0e18a4c3527fb8587592b855c93b12406 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52727 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/variants/cret/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/mainboard/google/dedede/variants/cret/overridetree.cb b/src/mainboard/google/dedede/variants/cret/overridetree.cb index 0cf3bdf..512a956 100644 --- a/src/mainboard/google/dedede/variants/cret/overridetree.cb +++ b/src/mainboard/google/dedede/variants/cret/overridetree.cb @@ -114,7 +114,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" register "generic.reset_delay_ms" = "20" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" @@ -132,7 +132,7 @@ register "desc" = ""ELAN Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" register "probed" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" register "reset_delay_ms" = "20" register "reset_off_delay_ms" = "2" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" -- To view, visit https://review.coreboot.org/c/coreboot/+/52727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I912fe8a0e18a4c3527fb8587592b855c93b12406 Gerrit-Change-Number: 52727 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-MessageType: merged [View Less]

1 0

Change in coreboot[master]: mb/*/Kconfig: Drop select USE_OPTION_TABLE
by Felix Held (Code Review) 04 May '21

04 May '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52855 ) Change subject: mb/*/Kconfig: Drop select USE_OPTION_TABLE ...................................................................... mb/*/Kconfig: Drop select USE_OPTION_TABLE Only 4 mainboards selected to use the option table. Use the same default on all boards. Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://… [View More]review.coreboot.org/c/coreboot/+/52855 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/lenovo/x60/Kconfig 4 files changed, 0 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 9eb06ff..5d8f626 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -15,7 +15,6 @@ select INTEL_INT15 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select USE_OPTION_TABLE select I945_LVDS config MAINBOARD_DIR diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index af723a3..4e9583c 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -32,12 +32,4 @@ string default "H81M-HDS" -# -# Since this is a desktop board, the assumption is made that most users -# would want CMOS configuration enabled by default. -# -config USE_OPTION_TABLE - bool - default y - endif diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index 78948b2..365043c 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -7,7 +7,6 @@ select FORCE_AM1_SOCKET_SUPPORT select GFXUMA select HAVE_OPTION_TABLE - select USE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_PIRQ_TABLE select HAVE_ACPI_RESUME diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 8397835..3a82179 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -21,7 +21,6 @@ select BOARD_ROMSIZE_KB_2048 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select USE_OPTION_TABLE select DRIVERS_LENOVO_WACOM select I945_LVDS select INTEL_GMA_HAVE_VBT -- To view, visit https://review.coreboot.org/c/coreboot/+/52855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ef88d5158a2b43f843c26b5b366a899dad8788 Gerrit-Change-Number: 52855 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged [View Less]

1 0

Change in coreboot[master]: mb/google/guybrush: Configure Pen Detect device
by Karthik Ramasubramanian (Code Review) 04 May '21

04 May '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Mathew King. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52906 ) Change subject: mb/google/guybrush: Configure Pen Detect device ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52906/comment/4255a421_1ada1705 PS1, Line 20: suspended > Can you … [View More]

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: Add support for AMD_FSP_PCIE_DEVFUNC_REMAP_HOB_GUID
by Felix Held (Code Review) 04 May '21

04 May '21

Attention is currently required from: Raul Rangel, Marshall Dawson, Matt Papageorge, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52869 ) Change subject: vc/amd/fsp/cezanne: Add support for AMD_FSP_PCIE_DEVFUNC_REMAP_HOB_GUID ...................................................................... Patch Set 1: (2 comments) File src/vendorcode/amd/fsp/cezanne/pcie_routing_hob.h: https://review.coreboot.org/c/coreboot/+/… [View More]

1 0

Change in coreboot[master]: mb/google/guybrush: Configure Pen Detect device
by Raul Rangel (Code Review) 04 May '21

04 May '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Mathew King, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52906 ) Change subject: mb/google/guybrush: Configure Pen Detect device ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52906/comment/9b2a1b1f_a0229838 PS1, Line 20: suspended Can you verify … [View More]

1 0

Change in coreboot[master]: [WIP] soc/amd/cezanne/early_fch: add missing fch_spi_early_init call
by Felix Held (Code Review) 04 May '21

04 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52907 ) Change subject: [WIP] soc/amd/cezanne/early_fch: add missing fch_spi_early_init call ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd say that we should write those registers even though at least some registers have been set up by … [View More]

1 0

Change in coreboot[master]: src: Retype option API to use unsigned integers
by Felix Singer (Code Review) 04 May '21

04 May '21

Attention is currently required from: Damien Zammit, Tristan Corrick, Angel Pons, Alexander Couzens, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52672 ) Change subject: src: Retype option API to use unsigned integers ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52672 To unsubscribe, or for help writing mail filters, … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021