Attention is currently required from: Felix Singer, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52846 )
Change subject: soc/intel/alderlake: Clean up FSP chipset lockdown configuration
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52846/comment/0ac6067d_031cb411
PS7, Line 143: uint8_t
bool
--
To view, visit https://review.coreboot.org/c/coreboot/+/52846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6485bde5b33af067dfb15ca410a164e288b76b2
Gerrit-Change-Number: 52846
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 05 May 2021 11:40:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52845 )
Change subject: soc/intel/jasperlake: Clean up FSP chipset lockdown configuration
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52845/comment/24caa716_6b58fd2d
PS7, Line 106: uint8_t
bool
--
To view, visit https://review.coreboot.org/c/coreboot/+/52845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I367554053f78b760ece6d59f79ce1f0e0f9fdfc6
Gerrit-Change-Number: 52845
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 05 May 2021 11:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52844 )
Change subject: soc/intel/tigerlake: Clean up FSP chipset lockdown configuration
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52844/comment/a4f5f4ce_a928a9ea
PS7, Line 205: uint8_t
bool
--
To view, visit https://review.coreboot.org/c/coreboot/+/52844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0580fb3ec9daafac273dcb091f48ce403c22e8f8
Gerrit-Change-Number: 52844
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 05 May 2021 11:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52096 )
Change subject: soc/intel/skylake: Always use `CHIPSET_LOCKDOWN_COREBOOT`
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Kconfig sounds like a good idea. Unrelated to that decision: I have […]
btw. additional to deciding FSP/CB lockdown via Kconfig, we might also add a choice to lock nothing at all and configs for each lock bit/upd, so stuff can set to unlocked for testing purpose easily without having to hack the code each time. That could look like this:
```
menu "Locking"
choice
prompt "Lock"
default LOCKING_COREBOOT
config LOCKING_DISABLED
bool "Don't lock anything / unlock everything"
config LOCKING_FSP
bool "Let fsp lock stuff"
config LOCKING_COREBOOT
bool "Let coreboot lock stuff"
endchoice
config LOCKING_LOCK_XYZ_SUPPORTED
bool
help
selected by fsp / platforms that support locking this
...
#if !LOCKING_DISABLED
config LOCKING_LOCK_ALL
bool "Lock everything"
select LOCKING_LOCK_XYZ
select ...
default y if !
config LOCKING_LOCK_XYZ
bool "Lock XYZ" if LOCKING_LOCK_XYZ_SUPPORTED
default y
...
#endif
endmenu # Locking
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/52096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24a1a2fab166aa3bfe8e0b07f155f57f2bf745e3
Gerrit-Change-Number: 52096
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 05 May 2021 11:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment