Attention is currently required from: Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54052
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8195: set dram dma property
......................................................................
soc/mediatek/mt8195: set dram dma property
Set dram dma to be non-cacheable to load blob correctly.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I819d40431fc7c9e7549686736d9e70de1c1982f0
---
M src/soc/mediatek/mt8195/Makefile.inc
M src/soc/mediatek/mt8195/mmu_operations.c
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/54052/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/54052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I819d40431fc7c9e7549686736d9e70de1c1982f0
Gerrit-Change-Number: 54052
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54076 )
Change subject: mb/google/volteer/var/volteer2: Configure TCSS OC pins
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54076/comment/e9417382_b13040c5
PS3, Line 9: volteer
> The baseboard does, but I don't have schematics for all the variants to know which ones use the same […]
Baseboard sets GPP_E9/USB_OC0# to NF1.
All variants except for trondo and volet set GPP_A16/USB_OC3# to NF1.
I'll find out if trondo and volet were oversights to not have set USB_OC3#.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Gerrit-Change-Number: 54076
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:46:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54016 )
Change subject: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Surprisingly, platform doesn't go to recovery but I see below error: […]
Hi Tim,
Please disregard my comment above for recovery. After flashing latest EC, I see below error. This is with VBOOT early sync also enabled:
VB2:check_ec_hash() Hexp RW(active): b2799ceccdc0f7fdedadfcec4c247c14e049d7d26d0c56dcb9a2ceddffed8919
VB2:check_ec_hash() Hmir: 0000000000000000000000000000000000000000000000000000000000000000
VB2:check_ec_hash() Hmir != Hexp. Update Hmir.
ec_hash_image: Hash status not done: 2
VB2:check_ec_hash() vb2ex_ec_hash_image(select, &heff, &heff_len) returned 0x10000001
VB2:vb2api_fail() Need recovery, reason: 0x57 / 0x1
VB2:vb2api_ec_sync() ec_sync_phase1(ctx) returned 0x1004
We see below recovery reason:
EC software sync unable to get EC image hash
--
To view, visit https://review.coreboot.org/c/coreboot/+/54016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a4fceb83dc6b20f699b4662e8f421aadafdee5
Gerrit-Change-Number: 54016
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54076 )
Change subject: mb/google/volteer/var/volteer2: Configure TCSS OC pins
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54076/comment/e69d590b_1dae2b6a
PS3, Line 9: volteer
> The baseboard does, but I don't have schematics for all the variants to know which ones use the same […]
I think you should figure out how the pin needs to be configured for all variants. If it is the same as baseboard, just adding it in base devicetree makes sense. Else, you will have to update each individual overridetree.
Catherine/Tom/Zhuohao might be able to help determine this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Gerrit-Change-Number: 54076
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54076
to look at the new patch set (#4).
Change subject: mb/google/volteer/var/volteer2: Configure TCSS OC pins
......................................................................
mb/google/volteer/var/volteer2: Configure TCSS OC pins
TCSS OC pins has not been correctly configured for volteer2.
This patch fills the value from devicetree to correct the OC pins
mapping.
BUG=b:184660529
BRANCH=None
TEST="emerge-volteer coreboot chromeos-bootimage", flash volteer2 and
verify CpuUsb3OverCurrentPin UPDs get set correctly.
Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/volteer/variants/volteer2/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/54076/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/54076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Gerrit-Change-Number: 54076
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54016 )
Change subject: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> does it fail with recovery reason 0x58, VB2_RECOVERY_EC_HASH_SIZE ?
Surprisingly, platform doesn't go to recovery but I see below error:
check_ec_hash: Hexp RW(active): d2d405c3ea7b9e4882ec20b5652f72c0920a4c3644d2a3f2db33909439bf0296
check_ec_hash: Hmir: d2d405c3ea7b9e4882ec20b5652f72c0920a4c3644d2a3f2db33909439bf0296
vboot_hash_image: No valid hash (status=0 size=0). Compute one...
vboot_hash_image: Hash status not done: 2
check_ec_hash: vb2ex_ec_hash_image(select, &heff, &heff_len) returned 0x10000001
update_ec: check_ec_hash(ctx, select) returned 0x10000001
--
To view, visit https://review.coreboot.org/c/coreboot/+/54016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a4fceb83dc6b20f699b4662e8f421aadafdee5
Gerrit-Change-Number: 54016
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54076 )
Change subject: mb/google/volteer: Configure TCSS OC pins
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54076/comment/188206fb_87880ef8
PS3, Line 9: volteer
> Are all volteer variants using the same OC pins?
The baseboard does, but I don't have schematics for all the variants to know which ones use the same OC pins as baseboard. I'm working on seeing if I can get them. If I can't get that information for some reason, should I move this to volteer2 devicetree.cb?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Gerrit-Change-Number: 54076
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:07:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Furquan Shaikh, Henry Sun, Karthik Ramasubramanian.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52851 )
Change subject: mb/google/dedede/var/magolor: Select touchscreen based on SSFC in FW_CONFIG
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Patchset:
PS7:
LGTM and see whether there is any comment from Karthi.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I087ea677a8865fc8c5b3f7c9773bd7f97924dbb3
Gerrit-Change-Number: 52851
Gerrit-PatchSet: 7
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 12 May 2021 05:03:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment