coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: Documentation/releases: Add 4.15 release notes template
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54031 ) Change subject: Documentation/releases: Add 4.15 release notes template ...................................................................... Documentation/releases: Add 4.15 release notes template Change-Id: I52bd1ee6b297ba08e335f5c65941b09f14689a00 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54031 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- A Documentation/releases/coreboot-4.15-relnotes.md M Documentation/releases/index.md 2 files changed, 18 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/Documentation/releases/coreboot-4.15-relnotes.md b/Documentation/releases/coreboot-4.15-relnotes.md new file mode 100644 index 0000000..6244cf6 --- /dev/null +++ b/Documentation/releases/coreboot-4.15-relnotes.md @@ -0,0 +1,16 @@ +Upcoming release - coreboot 4.15 +================================ + +The 4.15 release is planned for October 2021. + +Update this document with changes that should be in the release notes. + +* Please use Markdown. +* See the past few release notes for the general format. +* The chip and board additions and removals will be updated right + before the release, so those do not need to be added. + +Significant changes +------------------- + +### Add significant changes here diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 081d1fc..78ad127 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -14,6 +14,7 @@ * [4.11 - November 2019](coreboot-4.11-relnotes.md) * [4.12 - May 2020](coreboot-4.12-relnotes.md) * [4.13 - November 2020](coreboot-4.13-relnotes.md) +* [4.14 - May 2021](coreboot-4.14-relnotes.md) The checklist contains instructions to ensure that a release covers all important things and provides a reliable format for tarballs, branch @@ -25,4 +26,4 @@ ---------------- Please add to the release notes as changes are added: -* [4.14 - May 2021](coreboot-4.14-relnotes.md) +* [4.15 - October 2021](coreboot-4.15-relnotes.md) -- To view, visit https://review.coreboot.org/c/coreboot/+/54031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52bd1ee6b297ba08e335f5c65941b09f14689a00 Gerrit-Change-Number: 54031 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation/releases: Update checklist
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54030 ) Change subject: Documentation/releases: Update checklist ...................................................................... Documentation/releases: Update checklist Since we want commits to go through 24 hours of review, move the vboot list update a week earlier. Also point more directly at the right script to execute. Change-Id: I49e6dfe22894402d5a0526588f8a04595ac88862 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54030 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/releases/checklist.md 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index 3f19bfb..7e66c4d 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -61,6 +61,8 @@ part of the release notes. - [ ] Finalize release notes (as much as possible), without specifying release commit ids. +- [ ] Run `util/vboot_list/vboot_list.sh` script to update the list of + boards supported by vboot. ### Day of release - [ ] Select a commit ID to base the release upon, announce to IRC, @@ -71,7 +73,6 @@ - [ ] Fill in the release date, remove "Upcoming release" and other filler from the current release notes. - [ ] Run release script. -- [ ] Run vboot_list script. - [ ] Test the release from the actual release tarballs. - [ ] Push signed Tag to repo. - [ ] Announce that the release tag is done on IRC. -- To view, visit https://review.coreboot.org/c/coreboot/+/54030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e6dfe22894402d5a0526588f8a04595ac88862 Gerrit-Change-Number: 54030 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation: Update vboot support list
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54029 ) Change subject: Documentation: Update vboot support list ...................................................................... Documentation: Update vboot support list Created by util/vboot_list/vboot_list.sh Change-Id: I49536c26540c0fd1940a32f588fa49afb55b108a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54029 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/security/vboot/list_vboot.md 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index c9c2fdf..745db24 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -1,15 +1,23 @@ # vboot-enabled devices +## AMD +- Majolica + +## Clevo +- N130WU / N131WU + ## Emulation - QEMU x86 i440fx/piix4 (aka qemu -M pc) - QEMU x86 q35/ich9 (aka qemu -M q35, since v1.4) ## Facebook +- fbg1701 - Facebook Monolith ## Google - Asurada - Hayato +- Spherion - Auron_Paine (Acer C740 Chromebook) - Auron_Yuna (Acer Chromebook 15 (C910/CB5-531)) - Buddy (Acer Chromebase 24) @@ -22,6 +30,7 @@ - Tricky (Dell Chromebox 3010) - Zako (HP Chromebox G1) - Butterfly (HP Pavilion Chromebook 14) +- Cherry - Banon (Acer Chromebook 15 (CB3-532)) - Celes (Samsung Chromebook 3) - Cyan (Acer Chromebook R11 (C738T)) @@ -56,6 +65,7 @@ - Scarlet - Nefario - Rainier +- Guybrush - Akemi - Dratini - Duffy Legacy (32MB) @@ -79,6 +89,7 @@ - Dooly - Ambassador - Genesis +- Herobrine - Guado (ASUS Chromebox CN62) - Jecht - Rikku (Acer Chromebox CXI2) @@ -94,6 +105,7 @@ - Kodama - Kakadu - Flapjack +- Katsu - Jacuzzi - Juniper - Kappa @@ -104,7 +116,10 @@ - Esche - Burnet - Fennel +- Cozmo +- Makomo - Link (Google Chromebook Pixel (2013)) +- Mancomb - Mistral - Nyan - Nyan Big (Acer Chromebook 13 (CB5-311)) @@ -175,6 +190,7 @@ - Woomax - Dirinboz - Shuboz +- Gumboz ## HP - Z220 SFF Workstation @@ -182,14 +198,15 @@ ## Intel - Alderlake-P RVP - Alderlake-P RVP with Chrome EC +- Alderlake-M RVP +- Alderlake-M RVP with Chrome EC - Basking Ridge CRB -- Cannonlake U LPDDR4 RVP -- Cannonlake Y LPDDR4 RVP - Coffeelake U SO-DIMM DDR4 RVP - Coffeelake H SO-DIMM DDR4 RVP11 - Whiskeylake U DDR4 RVP - Coffeelake S U-DIMM DDR4 RVP8 - Cometlake U DDR4 RVP +- Elkhartlake LPDDR4x CRB - Emerald Lake 2 CRB - Galileo - Glkrvp @@ -202,6 +219,7 @@ - Kabylake DDR4 RVP8 - Kabylake DDR4 RVP11 - Kunimitsu +- shadowmountain - Strago - Tigerlake UP3 RVP - Tigerlake UP4 RVP @@ -255,7 +273,7 @@ ## Supermicro - X11SSH-TF - X11SSM-F -- X11SSH-F/X11SSH-LN4F +- X11SSH-F/LN4F ## UP - Squared -- To view, visit https://review.coreboot.org/c/coreboot/+/54029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49536c26540c0fd1940a32f588fa49afb55b108a Gerrit-Change-Number: 54029 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: update USB OC pin mapping
by Kangheui Won (Code Review) 12 May '21

12 May '21

Attention is currently required from: Kane Chen, Chris Wang, chris wang. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51523 ) Change subject: mb/google/zork/var/shuboz: update USB OC pin mapping ...................................................................... Patch Set 10: (2 comments) File src/mainboard/google/zork/variants/baseboard/helpers.c: https://review.coreboot.org/c/coreboot/+/51523/comment/039cf66f_93506e01 PS10, Line 115: int variant_usb_oc_pin_change(void) I think this should be something like variant_is_convertible since we're querying that. File src/mainboard/google/zork/variants/shuboz/variant.c: https://review.coreboot.org/c/coreboot/+/51523/comment/071904a6_23a7bdc2 PS10, Line 50: nit: Can you add some comments here? e.g) one of the model in shuboz variants will have additional camera attached to USB A1 so we should update OC pin settings. -- To view, visit https://review.coreboot.org/c/coreboot/+/51523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc1fa090109e6be54e2a5f49e364f5502f53aca2 Gerrit-Change-Number: 51523 Gerrit-PatchSet: 10 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Wed, 12 May 2021 07:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: configure DMA buffer in DRAM
by Yu-Ping Wu (Code Review) 12 May '21

12 May '21

Attention is currently required from: Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54052 ) Change subject: soc/mediatek/mt8195: configure DMA buffer in DRAM ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I819d40431fc7c9e7549686736d9e70de1c1982f0 Gerrit-Change-Number: 54052 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 12 May 2021 07:26:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: change vpp_sel default mux for 4k support
by Hung-Te Lin (Code Review) 12 May '21

12 May '21

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54082 ) Change subject: soc/mediatek/mt8195: change vpp_sel default mux for 4k support ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54082/comment/2e7070cd_d7754be2 PS1, Line 8: a few words explaining what is vpp_sel and how that is related to 4k (video?) support? -- To view, visit https://review.coreboot.org/c/coreboot/+/54082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6518ed6204528489c41e7161534bbd3734ac851 Gerrit-Change-Number: 54082 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 07:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: change vpp_sel default mux for 4k support
by Rex-BC Chen (Code Review) 12 May '21

12 May '21

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54082 ) Change subject: soc/mediatek/mt8195: change vpp_sel default mux for 4k support ...................................................................... soc/mediatek/mt8195: change vpp_sel default mux for 4k support Signed-off-by: Nancy Lin <nancy.lin(a)mediatek.com> Change-Id: Ib6518ed6204528489c41e7161534bbd3734ac851 --- M src/soc/mediatek/mt8195/pll.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/54082/1 diff --git a/src/soc/mediatek/mt8195/pll.c b/src/soc/mediatek/mt8195/pll.c index 6e85def..9e9718e 100644 --- a/src/soc/mediatek/mt8195/pll.c +++ b/src/soc/mediatek/mt8195/pll.c @@ -332,8 +332,8 @@ { .id = TOP_SCP_SEL, .sel = 7 }, /* 7: mainpll_d6_d2 */ { .id = TOP_BUS_AXIMEM_SEL, .sel = 3 }, /* 3: mainpll_d5_d2 */ /* CLK_CFG_1 */ - { .id = TOP_VPP_SEL, .sel = 2 }, /* 2: mainpll_d5_d2 */ - { .id = TOP_ETHDR_SEL, .sel = 10 }, /* 10: mmpll_d5_d4 */ + { .id = TOP_VPP_SEL, .sel = 9 }, /* 9: mainpll_d4 */ + { .id = TOP_ETHDR_SEL, .sel = 8 }, /* 8: univpll_d6 */ { .id = TOP_IPE_SEL, .sel = 8 }, /* 8: mainpll_d4_d2 */ { .id = TOP_CAM_SEL, .sel = 8 }, /* 8: mainpll_d4_d2 */ /* CLK_CFG_2 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/54082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6518ed6204528489c41e7161534bbd3734ac851 Gerrit-Change-Number: 54082 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec
by Furquan Shaikh (Code Review) 12 May '21

12 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54016 ) Change subject: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Yeah, this is an attribute of the broken mocktpm behavior and the assumptions we have made in differ […] Oops.. My comment was in response to your earlier comment about device rebooting. -- To view, visit https://review.coreboot.org/c/coreboot/+/54016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a4fceb83dc6b20f699b4662e8f421aadafdee5 Gerrit-Change-Number: 54016 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 06:35:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec
by Furquan Shaikh (Code Review) 12 May '21

12 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54016 ) Change subject: mb/intel/adlrvp: Disable EC sync for adlrvp_ext_ec ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Surprisingly, platform doesn't go to recovery but I see below error: […] Yeah, this is an attribute of the broken mocktpm behavior and the assumptions we have made in different places (in this case EFS). The problem here is that `vb2_secdata_kernel_get_ec_hash()` in vboot_reference assumes that it is safe to store/read mirrored hash from TPM and compare it with the expected hash irrespective of whether EFS is being used or not. But, this doesn't really work in case of mocktpm. Aseda recently ran into this on keeby as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/54016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a4fceb83dc6b20f699b4662e8f421aadafdee5 Gerrit-Change-Number: 54016 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 06:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/console: Fix FSP Notify phase postcodes discrepancy
by Subrata Banik (Code Review) 12 May '21

12 May '21

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52894 ) Change subject: include/console: Fix FSP Notify phase postcodes discrepancy ...................................................................... include/console: Fix FSP Notify phase postcodes discrepancy List of changes: 1. Make the FSP notify phases name prior in comments section. 2. Fix discrepancies in FSP notify before and after postcode comments. 3. Add FSP notify postcode macros for after pci enumeration(0xa2) and ready to boot(0xa3) call. Change-Id: Ib4c825d5f1f31f80ad2a03ff5d6006daa7104d23 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/52894 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/intel/fsp2_0/notify.c M src/include/console/post_codes.h 2 files changed, 24 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c index cbccc6e..311ce46 100644 --- a/src/drivers/intel/fsp2_0/notify.c +++ b/src/drivers/intel/fsp2_0/notify.c @@ -38,10 +38,10 @@ if (phase == AFTER_PCI_ENUM) { timestamp_add_now(TS_FSP_AFTER_ENUMERATE); - post_code(POST_FSP_NOTIFY_BEFORE_ENUMERATE); + post_code(POST_FSP_NOTIFY_AFTER_ENUMERATE); } else if (phase == READY_TO_BOOT) { timestamp_add_now(TS_FSP_AFTER_FINALIZE); - post_code(POST_FSP_NOTIFY_BEFORE_FINALIZE); + post_code(POST_FSP_NOTIFY_AFTER_FINALIZE); } else if (phase == END_OF_FIRMWARE) { timestamp_add_now(TS_FSP_AFTER_END_OF_FIRMWARE); post_code(POST_FSP_NOTIFY_AFTER_END_OF_FIRMWARE); diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h index 9b2398c..10793e3 100644 --- a/src/include/console/post_codes.h +++ b/src/include/console/post_codes.h @@ -204,16 +204,16 @@ #define POST_BS_PAYLOAD_BOOT 0x7b /** - * \brief Before calling FSP Notify before End of Firmware + * \brief Before calling FSP Notify (end of firmware) * - * Going to call into FSP binary for Notify phase + * Going to call into FSP binary for Notify phase (end of firmware) */ #define POST_FSP_NOTIFY_BEFORE_END_OF_FIRMWARE 0x88 /** - * \brief Before calling FSP Notify after End of Firmware + * \brief After calling FSP Notify (end of firmware) * - * Going to call into FSP binary for Notify phase + * Going to call into FSP binary for Notify phase (end of firmware) */ #define POST_FSP_NOTIFY_AFTER_END_OF_FIRMWARE 0x89 @@ -246,16 +246,16 @@ #define POST_FSP_SILICON_INIT 0x93 /** - * \brief Before calling FSP Notify before resource allocation + * \brief Before calling FSP Notify (after PCI enumeration) * - * Going to call into FSP binary for Notify phase + * Going to call into FSP binary for Notify phase (after PCI enumeration) */ #define POST_FSP_NOTIFY_BEFORE_ENUMERATE 0x94 /** - * \brief Before calling FSP Notify before finalize + * \brief Before calling FSP Notify (ready to boot) * - * Going to call into FSP binary for Notify phase + * Going to call into FSP binary for Notify phase (ready to boot) */ #define POST_FSP_NOTIFY_BEFORE_FINALIZE 0x95 @@ -302,6 +302,20 @@ #define POST_FSP_MULTI_PHASE_SI_INIT_EXIT 0xa1 /** + * \brief After calling FSP Notify (after PCI enumeration) + * + * Going to call into FSP binary for Notify phase (after PCI enumeration) + */ +#define POST_FSP_NOTIFY_AFTER_ENUMERATE 0xa2 + +/** + * \brief After calling FSP Notify (ready to boot) + * + * Going to call into FSP binary for Notify phase (ready to boot) + */ +#define POST_FSP_NOTIFY_AFTER_FINALIZE 0xa3 + +/** * \brief Invalid or corrupt ROM * * Set if firmware failed to find or validate a resource that is stored in ROM. -- To view, visit https://review.coreboot.org/c/coreboot/+/52894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4c825d5f1f31f80ad2a03ff5d6006daa7104d23 Gerrit-Change-Number: 52894 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021