coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: vboot: Add VB2_CONTEXT_EC_IN_RO
by Daisuke Nojiri (Code Review) 13 May '21

13 May '21

Attention is currently required from: Aaron Durbin. Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54099 ) Change subject: vboot: Add VB2_CONTEXT_EC_IN_RO ...................................................................... Patch Set 2: (1 comment) File src/security/vboot/vboot_logic.c: https://review.coreboot.org/c/coreboot/+/54099/comment/af4e9225_924c9176 PS2, Line 262: VB2_CONTEXT_EC_IN_RO This is being added by https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_refere…. -- To view, visit https://review.coreboot.org/c/coreboot/+/54099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 Gerrit-Change-Number: 54099 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 03:39:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek: Align code indent with code flow
by Jacob Garber (Code Review) 13 May '21

13 May '21

Attention is currently required from: Xi Chen. Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54096 ) Change subject: vc/mediatek: Align code indent with code flow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b8cacd48e86284c5145c4e8ffb6add75a743108 Gerrit-Change-Number: 54096 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Comment-Date: Thu, 13 May 2021 03:34:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add the first FW_CONFIG fields to brya0
by EricR Lai (Code Review) 13 May '21

13 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54097 ) Change subject: mb/google/brya: Add the first FW_CONFIG fields to brya0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74ca5ab5366a17e9e1784ec872b9cd77f8663c7f Gerrit-Change-Number: 54097 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 03:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
by Tim Wawrzynczak (Code Review) 13 May '21

13 May '21

1 0

Change in coreboot[master]: ec/google/chromeec: Remove ec_retimer_fw_update
by Tim Wawrzynczak (Code Review) 13 May '21

13 May '21

Attention is currently required from: John Zhao, Duncan Laurie. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52710 ) Change subject: ec/google/chromeec: Remove ec_retimer_fw_update ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52710/comment/94abc5a4_daefd0cc PS2, Line 11: late later -- To view, visit https://review.coreboot.org/c/coreboot/+/52710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d074b84fb3cb87b443871104b72b6c316af5279 Gerrit-Change-Number: 52710 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Duncan Laurie Gerrit-Comment-Date: Thu, 13 May 2021 03:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
by Tim Wawrzynczak (Code Review) 13 May '21

13 May '21

Attention is currently required from: John Zhao, Duncan Laurie. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 ) Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade ...................................................................... Patch Set 3: (14 comments) Patchset: PS3: Thanks for your patience John!! FYI, shadowmountain also uses `power_gpio` File src/drivers/intel/usb4/retimer/retimer.c: https://review.coreboot.org/c/coreboot/+/52712/comment/25efb590_3b0ed4bb PS3, Line 27: usb4_retimer_iteration_num USB4_RETIMER_ITERATION_NUM https://review.coreboot.org/c/coreboot/+/52712/comment/988b2237_6ca40348 PS3, Line 28: usb4_retimer_poll_cycle USB4_RETIMER_POLL_CYCLE_MS https://review.coreboot.org/c/coreboot/+/52712/comment/9922b8fd_ec6f7011 PS3, Line 29: match suggestion: rename this to `expected_return_value` or similar https://review.coreboot.org/c/coreboot/+/52712/comment/6d70eb67_245a1c4e PS3, Line 32: uint8_t nit: const https://review.coreboot.org/c/coreboot/+/52712/comment/17182c50_ad3f47bd PS3, Line 38: acpigen_write_return_integer this takes a `uint64_t` as an arg, so it will write out as a QWORD of 0xFFFFFFFFFFFFFFFF, will the kernel reinterpret that OK? https://review.coreboot.org/c/coreboot/+/52712/comment/3dc5dd73_100449e7 PS3, Line 98: match = USB_PD_MUX_NONE; : usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_GET_MUX, match); : : /* : * Suspend PD : * Command: USB_RETIMER_FW_UPDATE_SUSPEND_PD : * Expect return value: 0 : */ : match = 0; : usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SUSPEND_PD, match); : : /* : * Set MUX USB Mode : * Command: USB_RETIMER_FW_UPDATE_SUSPEND_PD : * Expect return value: USB_PD_MUX_USB_ENABLED : */ : match = USB_PD_MUX_USB_ENABLED; : usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_USB, match); : : /* : * Set MUX Safe Mode : * Command: USB_RETIMER_FW_UPDATE_SET_SAFE : * Expect return value: USB_PD_MUX_SAFE_MODE : */ : match = USB_PD_MUX_SAFE_MODE; : usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_SAFE, match); : : /* : * Set MUX TBT Mode : * Command: USB_RETIMER_FW_UPDATE_SET_TBT : * Expect return value: USB_PD_MUX_USB4_ENABLED or USB_PD_MUX_TBT_COMPAT_ENABLED : */ : match = USB_PD_MUX_USB4_ENABLED; : usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_TBT, match); : } chrome EC can handle these commands to RFWU ? https://review.coreboot.org/c/coreboot/+/52712/comment/71ef5bed_f36df6c6 PS3, Line 141: Resuem Resume https://review.coreboot.org/c/coreboot/+/52712/comment/6bf89977_f17dce9c PS3, Line 171: poewr power https://review.coreboot.org/c/coreboot/+/52712/comment/ba60c07b_b5111d77 PS3, Line 200: snprintf(pwr, sizeof(pwr), "HR.DFP%d%c%s", port, '.', "PWR"); suggestion: `snprintf(pwr, sizeof(pwr), "HR.DFP%1d.PWR", port);` https://review.coreboot.org/c/coreboot/+/52712/comment/fdd74458_086438b2 PS3, Line 230: snprintf(pwr, sizeof(pwr), "HR.DFP%d%c%s", port, '.', "PWR"); snprintf(pwr, sizeof(pwr), "HR.DFP%1d.PWR", port); https://review.coreboot.org/c/coreboot/+/52712/comment/1b080100_6c46ce35 PS3, Line 322: LOCAL1_OP nit: start with LOCAL0_OP https://review.coreboot.org/c/coreboot/+/52712/comment/89049987_1cde839a PS3, Line 353: 0xf ACPI_STATUS_DEVICE_ALL_ON https://review.coreboot.org/c/coreboot/+/52712/comment/ff580224_5cce2686 PS3, Line 363: UPC_TYPE_PROPRIETARY why PROPRIETARY? -- To view, visit https://review.coreboot.org/c/coreboot/+/52712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406 Gerrit-Change-Number: 52712 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Duncan Laurie Gerrit-Comment-Date: Thu, 13 May 2021 03:15:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/crossgcc: Update gcc to 11.1
by Harshit Sharma (Code Review) 13 May '21

13 May '21

Attention is currently required from: Werner Zeh. Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54050 ) Change subject: util/crossgcc: Update gcc to 11.1 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdee2a8beedd109ee1f0eef6f32f7accbf66674b Gerrit-Change-Number: 54050 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 13 May 2021 02:45:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: enable DPTF functionality for brya
by John Su (Code Review) 13 May '21

13 May '21

Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52859 ) Change subject: mb/google/brya: enable DPTF functionality for brya ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > > Hi John, […] Hi Sumeet I can't find b:187911222. Could you help to add us? I will assign to comment with our thermal team. -- To view, visit https://review.coreboot.org/c/coreboot/+/52859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33266c85aa30869466034ccbab04a3c7820ae2b0 Gerrit-Change-Number: 52859 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Thu, 13 May 2021 02:40:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Modify DPTF parameters
by Stanley Wu (Code Review) 13 May '21

13 May '21

Attention is currently required from: Henry Sun, Paul Fagerburg, Karthik Ramasubramanian. Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52755 ) Change subject: mb/google/dedede/var/boten: Modify DPTF parameters ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/52755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43002db61de650d29cd85944a4eaea1b2f99aec4 Gerrit-Change-Number: 52755 Gerrit-PatchSet: 1 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 13 May 2021 02:13:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi: Add acpigen_write_thermal_zone
by Lance Zhao (Code Review) 13 May '21

13 May '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Tim Wawrzynczak. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54131 ) Change subject: acpi: Add acpigen_write_thermal_zone ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf88477143049119036c00276f9a01985dc0b4d3 Gerrit-Change-Number: 54131 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 01:55:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021