coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/intel/adlrvp: Enable Camera in ADL-M RVP
by Varshit B Pandya (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Rizwan Qureshi, Angel Pons, Subrata Banik. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50265 ) Change subject: mb/intel/adlrvp: Enable Camera in ADL-M RVP ...................................................................... Patch Set 21: (1 comment) File src/mainboard/intel/adlrvp/gpio_m.c: https://review.coreboot.org/c/coreboot/+/50265/comment/850d126b_5b49640a PS21, Line 13: I2C5 SDA > Is NF2 still I2C5 SDA? Yes Angel. -- To view, visit https://review.coreboot.org/c/coreboot/+/50265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e Gerrit-Change-Number: 50265 Gerrit-PatchSet: 21 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 07:39:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable Camera in ADL-M RVP
by Angel Pons (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Varshit B Pandya, Rizwan Qureshi, Subrata Banik. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50265 ) Change subject: mb/intel/adlrvp: Enable Camera in ADL-M RVP ...................................................................... Patch Set 21: Code-Review+1 (1 comment) File src/mainboard/intel/adlrvp/gpio_m.c: https://review.coreboot.org/c/coreboot/+/50265/comment/402c2118_0cc966d2 PS21, Line 13: I2C5 SDA Is NF2 still I2C5 SDA? -- To view, visit https://review.coreboot.org/c/coreboot/+/50265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e Gerrit-Change-Number: 50265 Gerrit-PatchSet: 21 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 07:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/copano: Modify touch controller power sequ...
by Hao Chou (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Wayne3 Wang, Hao Chou, Paul2 Huang, Ken Lu. Hao Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52015 ) Change subject: mb/google/volteer/variants/copano: Modify touch controller power sequence ...................................................................... Patch Set 2: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/52015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea84046c1b1f3fe6ab8bb89d86d00b1e89325f71 Gerrit-Change-Number: 52015 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 07:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: google/grunt: Add ALC5682 ACPI I2S machine driver
by Kevin Chiu (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Akshu Agrawal, Paul Menzel, Aaron Durbin. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51659 ) Change subject: google/grunt: Add ALC5682 ACPI I2S machine driver ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: hi reviewers, could you please help review this one? thank you! -- To view, visit https://review.coreboot.org/c/coreboot/+/51659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f29a2d784a9fc749fff61a9c96c0a487b71a2d7 Gerrit-Change-Number: 51659 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 07:07:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/drivers/generic/nau8315: Add nau8315 support
by leeweitse_seven (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin, EricR Lai. leeweitse_seven has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 ) Change subject: src/drivers/generic/nau8315: Add nau8315 support ...................................................................... Patch Set 4: (5 comments) File src/drivers/generic/nau8315/chip.h: https://review.coreboot.org/c/coreboot/+/51971/comment/b3046021_372ee6ec PS1, Line 8: const char *hid; > And I think we can fixed the HID name. Since kernel driver only look up specific name. Done https://review.coreboot.org/c/coreboot/+/51971/comment/8cb87951_d6d2eaad PS1, Line 13: /* GPIO used to indicate if this device is present */ > I think we can remove this. We can have FW config for present now. Done File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/51971/comment/6cea25a7_104ae3eb PS1, Line 11: #if CONFIG(HAVE_ACPI_TABLES) > use depend for it. please refer my CL. https://review.coreboot. […] Done https://review.coreboot.org/c/coreboot/+/51971/comment/eb46cdf7_19d3f0c7 PS1, Line 53: enable-gpio > enable-gpios Done File src/drivers/generic/nau8315/nau8315.c: https://review.coreboot.org/c/coreboot/+/51971/comment/029de2c6_f6f5a258 PS3, Line 58: return NAU8315_ACPI_NAME; > we can return string here, remove the define. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d Gerrit-Change-Number: 51971 Gerrit-PatchSet: 4 Gerrit-Owner: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Reviewer: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: leeweitse_seven <scott.6986(a)hotmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: dsi: fine tune the delta time for EoTp
by Yu-Ping Wu (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Shaoming Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 ) Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp ...................................................................... Patch Set 5: -Code-Review (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51432/comment/dec18b16_d5a28ea2 PS1, Line 9: We seperate the EoTp packet extra data > so which change did this? we need a reference Shaoming, please address hungte's comment. Commit Message: https://review.coreboot.org/c/coreboot/+/51432/comment/c38428d6_bf6ddfba PS2, Line 7: when EoTp enable > Either […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c Gerrit-Change-Number: 51432 Gerrit-PatchSet: 5 Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:45:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Drop Vref configuration for older boards
by Justin van Son (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter. Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 ) Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards ...................................................................... Patch Set 1: (2 comments) File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c: https://review.coreboot.org/c/coreboot/+/51919/comment/0f61538b_5dbabd05 PS1, Line 42: return AZALIA_PIN_DESC( The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. I have no idea why, but when I change this to the hex equivalent as in case 1, it will work fine. Also, it seems like this configuration makes the driver somehow tie this widget (and thus the output) together with NID 0x14 (green rear line out), causing windows to only have 1 output device, and thus outputting audio to the two devices at the same time. I'm not sure how we can get this separated, even though it should be possible here. https://review.coreboot.org/c/coreboot/+/51919/comment/6fd62340_1a4f7ff9 PS1, Line 69: 0x018707e1, /* port B VREF 50% of LDO-OUT */ You don't need any of the 707 verbs, as they will get reset by realtek driver anyway -- To view, visit https://review.coreboot.org/c/coreboot/+/51919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217 Gerrit-Change-Number: 51919 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:44:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: dsi: fine tune the delta time for EoTp
by Yu-Ping Wu (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Chen-Tsung Hsieh. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 ) Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c Gerrit-Change-Number: 51432 Gerrit-PatchSet: 5 Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:44:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Reserve space for EC SMSC KBC1098/KBC1126
by Iru Cai (vimacs) (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Bill XIE, Julius Werner. Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 ) Change subject: arch/x86: Reserve space for EC SMSC KBC1098/KBC1126 ...................................................................... Patch Set 1: -Code-Review (2 comments) Patchset: PS1: Hmm, I think the code will get complicated if there are more things to add. File src/arch/x86/bootblock.ld: https://review.coreboot.org/c/coreboot/+/51671/comment/8b2e4286_a9d1660d PS1, Line 35: MIN(_KBC1126_FW_LOCATIONS, MIN(_ID_SECTION, _FIT_POINTER)) - EARLYASM_SZ; Hmm, the code will have more ``#if CONFIG(...)`` and ``MIN(...)`` to add if there're more things to add, so using one _ECFW_POINTER like in 51059 may be a better way to do this. -- To view, visit https://review.coreboot.org/c/coreboot/+/51671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f0de0c4d7283e630242fbe84a46e0547783c49e Gerrit-Change-Number: 51671 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Iru Cai (vimacs) <mytbk920423(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:43:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable VT-d
by Meera Ravindranath (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Ronak Kanabar, Patrick Rudolph. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51849 ) Change subject: soc/intel/alderlake: Enable VT-d ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/alderlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/51849/comment/4c13e225_975080d2 PS3, Line 198: /* Disable VT-d support for pre-QS platform */ > Lets first enable the VTD UPD alone and take FSP debug log to see what all FSP is doing. […] @Furquan, we verified the working on the early silicon as well and hence skipped the check like in tigerlake and enabled by default. -- To view, visit https://review.coreboot.org/c/coreboot/+/51849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96a9f3df185002a4e58faa910f867ace0b97ec2b Gerrit-Change-Number: 51849 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 06:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021