Attention is currently required from: Wim Vervoorn.
Hello Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52021
to look at the new patch set (#2).
Change subject: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT
......................................................................
vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT
VENDORCODE_ELTAN_MBOOT should not be used when VBOOT is enabled.
Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled.
BUG = N/A
TEST = run `make menuconfig` and boot Facebook FBG1701
Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/vendorcode/eltan/security/mboot/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52021/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab
Gerrit-Change-Number: 52021
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-MessageType: newpatchset
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52021 )
Change subject: vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT
......................................................................
vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT
VENDORCODE_ELTAN_MBOOT should not be used when VBOOT is enabled.
Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled.
BUG = N/A
TEST = run `make menuconfig` and boot Facebook FBG1701
vc/eltan/security/mboot/Kconfig: Add dependency of VBOOT
VENDORCODE_ELTAN_MBOOT can be enabled when VBOOT is enabled.
Hide VENDOCODE_ELTAN_MBOOT when VBOOT is enabled.
Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/vendorcode/eltan/security/mboot/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/52021/1
diff --git a/src/vendorcode/eltan/security/mboot/Kconfig b/src/vendorcode/eltan/security/mboot/Kconfig
index 540b7b2..4e30cf5 100644
--- a/src/vendorcode/eltan/security/mboot/Kconfig
+++ b/src/vendorcode/eltan/security/mboot/Kconfig
@@ -4,6 +4,7 @@
config VENDORCODE_ELTAN_MBOOT
bool "Measure firmware with mboot."
+ depends on !VBOOT
default n
select VBOOT_LIB
help
--
To view, visit https://review.coreboot.org/c/coreboot/+/52021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac57103431cc7efac5b6019f180572d255e683ab
Gerrit-Change-Number: 52021
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: newchange
Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51836 )
Change subject: soc/amd/picasso: Add entry for PSP NVRAM data & RPMC data
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/picasso/fw.cfg:
https://review.coreboot.org/c/coreboot/+/51836/comment/0f835902_96aa3534
PS8, Line 9: PSPNVRAM_FILE
How will we access these regions without names? like RPMC/PSP_NVRAM region is read/write, when access TA apps request read/write access to PSP which trigger smi to coreboot to access SPI accordingly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51836
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e0c9d651b7c544eabbed8acc0d26ae55960ca3f
Gerrit-Change-Number: 51836
Gerrit-PatchSet: 8
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 01 Apr 2021 11:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Wenbin Mei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/51966/comment/e71b31ea_db4bb7c9
PS4, Line 61:
> space
Ack
https://review.coreboot.org/c/coreboot/+/51966/comment/6cb45b45_b2ce0e96
PS4, Line 133: MSDC_PAD_TUNE_CMD_SEL
> Move to the previous line
Done
https://review.coreboot.org/c/coreboot/+/51966/comment/e8f335a8_2fbf3a62
PS4, Line 459: "%s
> Align with BIOS_ERR
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 11:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Wenbin Mei.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51973
to look at the new patch set (#3).
Change subject: mb/google/asurada: early-init eMMC
......................................................................
mb/google/asurada: early-init eMMC
Some eMMCs need 80+ms for CMD1 to complete. And the payload may need to
access eMMC in the very early stage (for example, Depthcharge needs it
20ms after started) so we have to start initialization in coreboot.
On Hayato Chromebook this can save ~100ms in total.
BUG=b:177389446
TEST=emerge-asurada coreboot
BRANCH=asurada
Signed-off-by: Wenbin Mei <wenbin.mei(a)mediatek.com>
Change-Id: I2f58d203e969dc1a13a479d7dc63b1b162a9ae3f
---
M src/mainboard/google/asurada/mainboard.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/51973/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f58d203e969dc1a13a479d7dc63b1b162a9ae3f
Gerrit-Change-Number: 51973
Gerrit-PatchSet: 3
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Wenbin Mei.
Hello Hung-Te Lin, Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51966
to look at the new patch set (#5).
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
soc/mediatek: add new driver 'msdc' for eMMC
Add MTK host mmc driver support.
MTK host controller support eMMC5.1 spec.
BUG=b:177389446
TEST=emerge-asurada coreboot
BRANCH=asurada
Signed-off-by: Wenbin Mei <wenbin.mei(a)mediatek.com>
Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
---
M src/commonlib/include/commonlib/sd_mmc_ctrlr.h
A src/soc/mediatek/common/include/soc/msdc.h
A src/soc/mediatek/common/msdc.c
M src/soc/mediatek/mt8192/Makefile.inc
4 files changed, 685 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/51966/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Wenbin Mei <wenbin.mei(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset