coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/google/dedede/var/lantis: Configure Acoustic noise mitigation UPDs
by Karthik Ramasubramanian (Code Review) 01 Apr '21

01 Apr '21

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51762 ) Change subject: mb/google/dedede/var/lantis: Configure Acoustic noise mitigation UPDs ...................................................................... mb/google/dedede/var/lantis: Configure Acoustic noise mitigation UPDs Enable Acoustic noise mitigation for lantis and set slew rate to 1/4 which is calibrated value for the board. Other values like PreWake, Rampup and RampDown are 0 by default. BUG=b:183561593 BRANCH=dedede TEST=EE verify acoustic noise test passes. Change-Id: I5e5f24ed934910726c220678068d085b6ee2bcf6 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51762 Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/dedede/variants/lantis/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/mainboard/google/dedede/variants/lantis/overridetree.cb b/src/mainboard/google/dedede/variants/lantis/overridetree.cb index 368b1dd..b9d6f72 100644 --- a/src/mainboard/google/dedede/variants/lantis/overridetree.cb +++ b/src/mainboard/google/dedede/variants/lantis/overridetree.cb @@ -65,6 +65,12 @@ .tdp_pl2_override = 15, }" + # Enable Acoustic noise mitigation and set slew rate to 1/4 + # Rest of the parameters are 0 by default. + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate" = "SlewRateFastBy4" + register "FastPkgCRampDisable" = "1" + device domain 0 on device pci 04.0 on chip drivers/intel/dptf -- To view, visit https://review.coreboot.org/c/coreboot/+/51762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e5f24ed934910726c220678068d085b6ee2bcf6 Gerrit-Change-Number: 51762 Gerrit-PatchSet: 3 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: cpu/intel/common: use lapicid api
by Ravishankar Sarawadi (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51725 ) Change subject: cpu/intel/common: use lapicid api ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ca5b09ae67941adcc07dfafdfe4ba78b0f81009 Gerrit-Change-Number: 51725 Gerrit-PatchSet: 6 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 16:19:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/*/x86 : Support x2apic mode
by Ravishankar Sarawadi (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51723 ) Change subject: src/*/x86 : Support x2apic mode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bb729b0521fb9dc38b7981014755daeaf9ca817 Gerrit-Change-Number: 51723 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Apr 2021 16:19:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Update CpuRatio settings
by Kaiyen Chang (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Kaiyen Chang, Patrick Rudolph. Hello Kaiyen Chang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52029 to look at the new patch set (#2). Change subject: soc/intel/jasperlake: Update CpuRatio settings ...................................................................... soc/intel/jasperlake: Update CpuRatio settings An extra reset is observed on JSL platform while the flex ratio in CPU Straps is set to a non-zero value. The root cause is that the config of CpuRatio on JSL is fixed to zero in fsp_param.c. While FSP finds the value of CpuRatio from m_cfg is inconsistent with the value from CPU straps, it will invoke a system reset to apply the value from m_cfg. This change adds a mechanism to set CpuRatio to allowed maximum processor non-turbo ratio (from CPU straps) when cpu_ratio_override is not set, or overriding CpuRatio with the value of cpu_ratio_override when cpu_ratio_override is set to a non-zero value instead of just fixing CpuRatio to zero. BUG=b:181588337 BRANCH=None TEST=Boot JSL platform with a non-zero flex ratio set in CPU Straps and observe there is no extra reset in meminit while cpu_ratio_override is not set. Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 --- M src/soc/intel/jasperlake/romstage/fsp_params.c 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/52029/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Gerrit-Change-Number: 52029 Gerrit-PatchSet: 2 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Update CpuRatio settings
by Kaiyen Chang (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Kaiyen Chang. Hello Kaiyen Chang, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/52029 to review the following change. Change subject: soc/intel/jasperlake: Update CpuRatio settings ...................................................................... soc/intel/jasperlake: Update CpuRatio settings An extra reset is observed on JSL platform while the flex ratio in CPU Straps is set to a non-zero value. The root cause is that the config of CpuRatio on JSL is fixed to zero in fsp_param.c. While FSP finds the value of CpuRatio from m_cfg is inconsistent with the value from CPU straps, it will invoke a system reset to apply the value from m_cfg. This change adds a mechanism to set CpuRatio to allowed maximum processor non-turbo ratio (from CPU straps) when cpu_ratio_override is not set, or overriding CpuRatio with the value of cpu_ratio_override when cpu_ratio_override is set to a non-zero value instead of just fixing CpuRatio to zero. BUG=b:181588337 BRANCH=None TEST=Boot JSL platform and observe there is no extra reset in meminit. Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 --- M src/soc/intel/jasperlake/romstage/fsp_params.c 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/52029/1 diff --git a/src/soc/intel/jasperlake/romstage/fsp_params.c b/src/soc/intel/jasperlake/romstage/fsp_params.c index cd70807..31c9f6f 100644 --- a/src/soc/intel/jasperlake/romstage/fsp_params.c +++ b/src/soc/intel/jasperlake/romstage/fsp_params.c @@ -2,9 +2,11 @@ #include <assert.h> #include <console/console.h> +#include <cpu/x86/msr.h> #include <device/device.h> #include <fsp/util.h> #include <soc/iomap.h> +#include <soc/msr.h> #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> @@ -29,6 +31,16 @@ m_cfg->SaGv = config->SaGv; m_cfg->RMT = config->RMT; + /* CpuRatio Settings */ + if (config->cpu_ratio_override) { + m_cfg->CpuRatio = config->cpu_ratio_override; + } else { + /* Set CpuRatio to match existing MSR value */ + msr_t flex_ratio; + flex_ratio = rdmsr(MSR_FLEX_RATIO); + m_cfg->CpuRatio = (flex_ratio.lo >> 8) & 0xff; + } + /* PCIe root port configuration */ for (i = 0; i < ARRAY_SIZE(config->PcieRpEnable); i++) { if (config->PcieRpEnable[i]) @@ -52,9 +64,6 @@ /* Disable BIOS Guard */ m_cfg->BiosGuard = 0; - /* Set CPU Ratio */ - m_cfg->CpuRatio = 0; - /* Set debug interface flags */ m_cfg->PcdDebugInterfaceFlags = CONFIG(DRIVERS_UART_8250IO) ? DEBUG_INTERFACE_UART_8250IO : DEBUG_INTERFACE_LPSS_SERIAL_IO; -- To view, visit https://review.coreboot.org/c/coreboot/+/52029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b9d5620b8e394201e82185eb28b67d6702b2d5 Gerrit-Change-Number: 52029 Gerrit-PatchSet: 1 Gerrit-Owner: Kaiyen Chang <kaiyen.chang(a)intel.com> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-Attention: Kaiyen Chang <kaiyen.chang(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: security/intel/cbnt: Allow for an externally provided bg-prov bin
by Arthur Heymans (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Martin Roth, Arthur Heymans. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51982 to look at the new patch set (#4). Change subject: security/intel/cbnt: Allow for an externally provided bg-prov bin ...................................................................... security/intel/cbnt: Allow for an externally provided bg-prov bin Building the bg-prov tool requires godeps which does not work if offline. Therefor add an option to provide this binary via Kconfig. It's the responsibility of the user to use a compatible binary then. Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/cbnt/Kconfig M src/security/intel/cbnt/Makefile.inc 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/51982/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/amd/fsp/cezanne: add platform_descriptors.h
by Marshall Dawson (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Justin Frodsham, Raul Rangel, Matt Papageorge, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: vc/amd/fsp/cezanne: add platform_descriptors.h ...................................................................... Patch Set 10: (1 comment) File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/1e4d7e0a_79a51db5 PS10, Line 196: Currently unused by FSP Based on Matt's comment, I infer this should change too. -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 16:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names
by Raul Rangel (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52028 ) Change subject: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c Gerrit-Change-Number: 52028 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 01 Apr 2021 15:52:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry
by Angel Pons (Code Review) 01 Apr '21

01 Apr '21

Attention is currently required from: Nicola Corna. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52027 ) Change subject: mb/sapphire/pureplatinum/cmos.default: Remove `volume` entry ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52027/comment/a2c240c7_c0d01e68 PS1, Line 9: de50d39 commit de50d39 (mb/**/cmos.layout: Drop copy-pasted `volume` entries) -- To view, visit https://review.coreboot.org/c/coreboot/+/52027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieebafffa0d2fbf6cdd24cff4ddefe090a727cbfa Gerrit-Change-Number: 52027 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicola Corna <nicola(a)corna.info> Gerrit-Comment-Date: Thu, 01 Apr 2021 15:50:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names
by Felix Held (Code Review) 01 Apr '21

01 Apr '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52028 ) Change subject: vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names ...................................................................... vc/amd/fsp/picasso/platform_descriptors: fix typos in enum element names Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c --- M src/vendorcode/amd/fsp/picasso/platform_descriptors.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/52028/1 diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h index 81293c6..717be1f 100644 --- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h @@ -31,7 +31,7 @@ /* Upstream Auto Speed Change Allowed */ typedef enum { SPDC_DEFAULT = 0, // Enabled for Gen2 and Gen3 - SPDC_DISBLED, + SPDC_DISABLED, SPDC_ENABLED, SPDC_INVALID } dxio_upstream_auto_speed_change; @@ -105,7 +105,7 @@ EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init EDP_TO_LVDS_SW, // eDP-to-LVDS translator which requires AMD SW init AUTO_DETECT, // VBIOS auto detect connector type - UNUSED_PTYPE, // UnusedType + UNUSED_TYPE, // UnusedType MAX_CONNECTOR_TYPE // Not valid value, used to verify input } ddi_connector_type; -- To view, visit https://review.coreboot.org/c/coreboot/+/52028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cad6a6a585320b33bfab7b3950888241f7c179c Gerrit-Change-Number: 52028 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021