Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51723 )
Change subject: src/*/x86 : Support x2apic mode
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51723/comment/be0d24e7_86da3ae0
PS5, Line 7: src/*/x86 :
1. Please remove the space before the colon.
2. The prefix does *not* have to resemble the path. In this case *x86:* fits perfectly.
https://review.coreboot.org/c/coreboot/+/51723/comment/88aeef05_990f0c20
PS5, Line 9: Implement x2apic mode as existing code only supports apic mode
1. Please add dot/period to the end of sentences.
2. Please describe how you implemented the support.
https://review.coreboot.org/c/coreboot/+/51723/comment/e1b69738_7c356a39
PS5, Line 14: cat /proc/cpuinfo | grep "apicid"
On what board?
Maybe even paste the related log messages.
Patchset:
PS5:
Why are there three +2, if a 500 line change does not have a commit message consisting of one line?
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/51723/comment/efd5fe09_06427cd7
PS5, Line 50: printk(BIOS_DEBUG, " apic_id: 0x%x ", lapicid());
Why does this need to be changed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51723
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bb729b0521fb9dc38b7981014755daeaf9ca817
Gerrit-Change-Number: 51723
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 19:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )
Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Does this affect the comments on Gerrit? If so, I wouldn't want
to change it. Especially not in the case of UNNECESSARY_ELSE.
We'd be back at manually bikeshedding when the indentation level
gets too far because of nested conditions.
Could we clarify the text that it's more a suggestion, instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51551
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130598057c1800277a129ae6b927e961d6e26e42
Gerrit-Change-Number: 51551
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 19:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin, Patrick Rudolph.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52020 )
Change subject: [WIP] alderlake: enable DPTF functionality for ADL-RVP board
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/52020/comment/ac05b750_f024770d
PS1, Line 28: /* Below are ACPI IDs for Alder Lake SoC */
Need to check how we can add different new SoCs ACPI IDs like Tiger Lake, Alder Lake, etc.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I319bb0ddb9cd9bbe48c8ee09c2742a78da230b7b
Gerrit-Change-Number: 52020
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 18:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment